Merge branch 'hotfix'

Revert "feat(site_sync): return erpnext data in level"

.editorconfig

@@ -1,14 +0,0 @@
-# Root editor config file
-root = true
-
-# Common settings
-[*]
-end_of_line = lf
-insert_final_newline = true
-trim_trailing_whitespace = true
-charset = utf-8
-
-# python, js indentation settings
-[{*.py,*.js}]
-indent_style = tab
-indent_size = 4

.eslintrc

@@ -4,10 +4,6 @@
 		"node": true,
 		"es6": true
 	},
-	"parserOptions": {
-		"ecmaVersion": 9,
-		"sourceType": "module"
-	},
 	"extends": "eslint:recommended",
 	"rules": {
 		"indent": [
@@ -15,14 +11,6 @@
 			"tab",
 			{ "SwitchCase": 1 }
 		],
-		"brace-style": [
-			"error",
-			"1tbs"
-		],
-		"space-unary-ops": [
-			"error",
-			{ "words": true }
-		],
 		"linebreak-style": [
 			"error",
 			"unix"
@@ -52,17 +40,19 @@
 		"no-control-regex": [
 			"off"
 		],
-		"space-before-blocks": "warn",
-		"keyword-spacing": "warn",
-		"comma-spacing": "warn",
-		"key-spacing": "warn"
+		"spaced-comment": [
+			"warn"
+		],
+		"no-trailing-spaces": [
+			"warn"
+		]
 	},
 	"root": true,
 	"globals": {
 		"frappe": true,
-		"Vue": true,
 		"erpnext": true,
 		"hub": true,
+
 		"$": true,
 		"jQuery": true,
 		"moment": true,
@@ -92,7 +82,6 @@
 		"cur_page": true,
 		"cur_list": true,
 		"cur_tree": true,
-		"cur_pos": true,
 		"msg_dialog": true,
 		"is_null": true,
 		"in_list": true,
@@ -144,13 +133,6 @@
 		"get_server_fields": true,
 		"set_multiple": true,
 		"QUnit": true,
-		"Chart": true,
-		"Cypress": true,
-		"cy": true,
-		"it": true,
-		"context": true,
-		"before": true,
-		"beforeEach": true,
-		"onScan": true
+		"Chart": true
 	}
 }

.flake8

@@ -1,33 +0,0 @@
-[flake8]
-ignore =
-    E121,
-    E126,
-    E127,
-    E128,
-    E203,
-    E225,
-    E226,
-    E231,
-    E241,
-    E251,
-    E261,
-    E265,
-    E302,
-    E303,
-    E305,
-    E402,
-    E501,
-    E741,
-    W291,
-    W292,
-    W293,
-    W391,
-    W503,
-    W504,
-    F403,
-    B007,
-    B950,
-    W191,
-
-max-line-length = 200
-exclude=.github/helper/semgrep_rules

.git-blame-ignore-revs

@@ -1,12 +0,0 @@
-# Since version 2.23 (released in August 2019), git-blame has a feature
-# to ignore or bypass certain commits.
-#
-# This file contains a list of commits that are not likely what you
-# are looking for in a blame, such as mass reformatting or renaming.
-# You can set this file as a default ignore file for blame by running
-# the following command.
-#
-# $ git config blame.ignoreRevsFile .git-blame-ignore-revs
-
-# This commit just changes spaces to tabs for indentation in some files
-5f473611bd6ed57703716244a054d3fb5ba9cd23

.github/ISSUE_TEMPLATE/bug_report.md

@@ -1,47 +0,0 @@
----
-name: Bug report
-about: Report a bug encountered while using ERPNext
-labels: bug
----
-
-<!--
-Welcome to ERPNext issue tracker! Before creating an issue, please heed the following:
-
-1. This tracker should only be used to report bugs and request features / enhancements to ERPNext
-    - For questions and general support, checkout the manual https://erpnext.com/docs/user/manual/en or use https://discuss.erpnext.com
-    - For documentation issues, refer to https://github.com/frappe/erpnext_com
-2. Use the search function before creating a new issue. Duplicates will be closed and directed to
-   the original discussion.
-3. When making a bug report, make sure you provide all required information. The easier it is for
-   maintainers to reproduce, the faster it'll be fixed.
-4. If you think you know what the reason for the bug is, share it with us. Maybe put in a PR 😉
--->
-
-## Description of the issue
-
-## Context information (for bug reports)
-
-**Output of `bench version`**
-```
-(paste here)
-```
-
-## Steps to reproduce the issue
-
-1.
-2.
-3.
-
-### Observed result
-
-### Expected result
-
-### Stacktrace / full error message
-
-```
-(paste here)
-```
-
-## Additional information
-
-OS version / distribution, `ERPNext` install method, etc.

.github/ISSUE_TEMPLATE/config.yml

@@ -1,5 +0,0 @@
-blank_issues_enabled: false
-contact_links:
-  - name: Community Forum
-    url: https://discuss.erpnext.com/
-    about: For general QnA, discussions and community help.

.github/ISSUE_TEMPLATE/feature_request.md

@@ -1,28 +0,0 @@
----
-name: Feature request
-about: Suggest an idea to improve ERPNext
-labels: feature-request
----
-
-<!--
-Welcome to ERPNext issue tracker! Before creating an issue, please heed the following:
-
-1. This tracker should only be used to report bugs and request features / enhancements to ERPNext
-    - For questions and general support, checkout the manual https://erpnext.com/docs/user/manual/en or use https://discuss.erpnext.com
-    - For documentation issues, refer to https://github.com/frappe/erpnext_com
-2. Use the search function before creating a new issue. Duplicates will be closed and directed to
-   the original discussion.
-3. When making a feature request, make sure to be as verbose as possible. The better you convey your message, the     greater the drive to make it happen.
--->
-
-**Is your feature request related to a problem? Please describe.**
-A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
-
-**Describe the solution you'd like**
-A clear and concise description of what you want to happen.
-
-**Describe alternatives you've considered**
-A clear and concise description of any alternative solutions or features you've considered.
-
-**Additional context**
-Add any other context or screenshots about the feature request here.

.github/ISSUE_TEMPLATE/question-about-using-erpnext.md

@@ -1,17 +0,0 @@
----
-name: Question about using ERPNext
-about: This is not the appropriate channel
-labels: invalid
----
-
-Please post on our forums:
-
-for questions about using `ERPNext`: https://discuss.erpnext.com
-
-for questions about using the `Frappe Framework`: ~~https://discuss.frappe.io~~ => [stackoverflow](https://stackoverflow.com/questions/tagged/frappe) tagged under `frappe`
-
-for questions about using `bench`, probably the best place to start is the [bench repo](https://github.com/frappe/bench)
-
-For documentation issues, use the [ERPNext Documentation](https://erpnext.com/docs/) or [Frappe Framework Documentation](https://frappe.io/docs/user/en) or the [developer cheetsheet](https://github.com/frappe/frappe/wiki/Developer-Cheatsheet)
-
-> **Posts that are not bug reports or feature requests will not be addressed on this issue tracker.**

.github/PULL_REQUEST_TEMPLATE.md

@@ -1,33 +1,2 @@
-<!--
+Please read the pull request checklist to make sure your changes are merged: https://github.com/frappe/erpnext/wiki/Pull-Request-Checklist
 
-Some key notes before you open a PR:
-
- 1. Select which branch should this PR be merged in?
- 2. PR name follows [convention](http://karma-runner.github.io/4.0/dev/git-commit-msg.html)
- 3. All tests pass locally, UI and Unit tests
- 4. All business logic and validations must be on the server-side
- 5. Update necessary Documentation
- 6. Put `closes #XXXX` in your comment to auto-close the issue that your PR fixes
-
-
-Also, if you're new here
-
-- Documentation Guidelines => https://github.com/frappe/erpnext/wiki/Updating-Documentation
-
-- Contribution Guide => https://github.com/frappe/erpnext/blob/develop/.github/CONTRIBUTING.md
-
-- Pull Request Checklist => https://github.com/frappe/erpnext/wiki/Pull-Request-Checklist
-
--->
-
-> Please provide enough information so that others can review your pull request:
-
-<!-- You can skip this if you're fixing a typo or updating existing documentation -->
-
-> Explain the **details** for making this change. What existing problem does the pull request solve?
-
-<!-- Example: When "Adding a function to do X", explain why it is necessary to have a way to do X. -->
-
-> Screenshots/GIFs
-
-<!-- Add images/recordings to better visualize the change: expected/current behviour -->

.github/helper/documentation.py

@@ -1,48 +0,0 @@
-import sys
-import requests
-from urllib.parse import urlparse
-
-
-docs_repos = [
-	"frappe_docs",
-	"erpnext_documentation",
-	"erpnext_com",
-	"frappe_io",
-]
-
-
-def uri_validator(x):
-	result = urlparse(x)
-	return all([result.scheme, result.netloc, result.path])
-
-def docs_link_exists(body):
-	for line in body.splitlines():
-		for word in line.split():
-			if word.startswith('http') and uri_validator(word):
-				parsed_url = urlparse(word)
-				if parsed_url.netloc == "github.com":
-					parts = parsed_url.path.split('/')
-					if len(parts) == 5 and parts[1] == "frappe" and parts[2] in docs_repos:
-						return True
-
-
-if __name__ == "__main__":
-	pr = sys.argv[1]
-	response = requests.get("https://api.github.com/repos/frappe/erpnext/pulls/{}".format(pr))
-
-	if response.ok:
-		payload = response.json()
-		title = payload.get("title", "").lower()
-		head_sha = payload.get("head", {}).get("sha")
-		body = payload.get("body", "").lower()
-
-		if title.startswith("feat") and head_sha and "no-docs" not in body:
-			if docs_link_exists(body):
-				print("Documentation Link Found. You're Awesome! 🎉")
-
-			else:
-				print("Documentation Link Not Found! ⚠️")
-				sys.exit(1)
-
-		else:
-			print("Skipping documentation checks... 🏃")

.github/helper/install.sh

@@ -1,46 +0,0 @@
-#!/bin/bash
-
-set -e
-
-cd ~ || exit
-
-sudo apt-get install redis-server
-
-sudo apt install nodejs
-
-sudo apt install npm
-
-pip install frappe-bench
-
-git clone https://github.com/frappe/frappe --branch "${GITHUB_BASE_REF:-${GITHUB_REF##*/}}" --depth 1
-bench init --skip-assets --frappe-path ~/frappe --python "$(which python)" frappe-bench
-
-mkdir ~/frappe-bench/sites/test_site
-cp -r "${GITHUB_WORKSPACE}/.github/helper/site_config.json" ~/frappe-bench/sites/test_site/
-
-mysql --host 127.0.0.1 --port 3306 -u root -e "SET GLOBAL character_set_server = 'utf8mb4'"
-mysql --host 127.0.0.1 --port 3306 -u root -e "SET GLOBAL collation_server = 'utf8mb4_unicode_ci'"
-
-mysql --host 127.0.0.1 --port 3306 -u root -e "CREATE USER 'test_frappe'@'localhost' IDENTIFIED BY 'test_frappe'"
-mysql --host 127.0.0.1 --port 3306 -u root -e "CREATE DATABASE test_frappe"
-mysql --host 127.0.0.1 --port 3306 -u root -e "GRANT ALL PRIVILEGES ON \`test_frappe\`.* TO 'test_frappe'@'localhost'"
-
-mysql --host 127.0.0.1 --port 3306 -u root -e "UPDATE mysql.user SET Password=PASSWORD('travis') WHERE User='root'"
-mysql --host 127.0.0.1 --port 3306 -u root -e "FLUSH PRIVILEGES"
-
-wget -O /tmp/wkhtmltox.tar.xz https://github.com/frappe/wkhtmltopdf/raw/master/wkhtmltox-0.12.3_linux-generic-amd64.tar.xz
-tar -xf /tmp/wkhtmltox.tar.xz -C /tmp
-sudo mv /tmp/wkhtmltox/bin/wkhtmltopdf /usr/local/bin/wkhtmltopdf
-sudo chmod o+x /usr/local/bin/wkhtmltopdf
-sudo apt-get install libcups2-dev
-
-cd ~/frappe-bench || exit
-
-sed -i 's/watch:/# watch:/g' Procfile
-sed -i 's/schedule:/# schedule:/g' Procfile
-sed -i 's/socketio:/# socketio:/g' Procfile
-sed -i 's/redis_socketio:/# redis_socketio:/g' Procfile
-
-bench get-app erpnext "${GITHUB_WORKSPACE}"
-bench start &
-bench --site test_site reinstall --yes

.github/helper/semgrep_rules/README.md

@@ -1,38 +0,0 @@
-# Semgrep linting
-
-## What is semgrep?
-Semgrep or "semantic grep" is language agnostic static analysis tool. In simple terms semgrep is syntax-aware `grep`, so unlike regex it doesn't get confused by different ways of writing same thing or whitespaces or code split in multiple lines etc.
-
-Example:
-
-To check if a translate function is using f-string or not the regex would be `r"_\(\s*f[\"']"` while equivalent rule in semgrep would be `_(f"...")`. As semgrep knows grammer of language it takes care of unnecessary whitespace, type of quotation marks etc.
-
-You can read more such examples in `.github/helper/semgrep_rules` directory.
-
-# Why/when to use this?
-We want to maintain quality of contributions, at the same time remembering all the good practices can be pain to deal with while evaluating contributions. Using semgrep if you can translate "best practice" into a rule then it can automate the task for us.
-
-## Running locally
-
-Install semgrep using homebrew `brew install semgrep` or pip `pip install semgrep`.
-
-To run locally use following command:
-
-`semgrep --config=.github/helper/semgrep_rules [file/folder names]`
-
-## Testing
-semgrep allows testing the tests. Refer to this page: https://semgrep.dev/docs/writing-rules/testing-rules/
-
-When writing new rules you should write few positive and few negative cases as shown in the guide and current tests.
-
-To run current tests: `semgrep --test --test-ignore-todo .github/helper/semgrep_rules`
-
-
-## Reference
-
-If you are new to Semgrep read following pages to get started on writing/modifying rules:
-
-- https://semgrep.dev/docs/getting-started/
-- https://semgrep.dev/docs/writing-rules/rule-syntax
-- https://semgrep.dev/docs/writing-rules/pattern-examples/
-- https://semgrep.dev/docs/writing-rules/rule-ideas/#common-use-cases

.github/helper/semgrep_rules/frappe_correctness.py

@@ -1,64 +0,0 @@
-import frappe
-from frappe import _, flt
-
-from frappe.model.document import Document
-
-
-# ruleid: frappe-modifying-but-not-comitting
-def on_submit(self):
-	if self.value_of_goods == 0:
-		frappe.throw(_('Value of goods cannot be 0'))
-	self.status = 'Submitted'
-
-
-# ok: frappe-modifying-but-not-comitting
-def on_submit(self):
-	if self.value_of_goods == 0:
-		frappe.throw(_('Value of goods cannot be 0'))
-	self.status = 'Submitted'
-	self.db_set('status', 'Submitted')
-
-# ok: frappe-modifying-but-not-comitting
-def on_submit(self):
-	if self.value_of_goods == 0:
-		frappe.throw(_('Value of goods cannot be 0'))
-	x = "y"
-	self.status = x
-	self.db_set('status', x)
-
-
-# ok: frappe-modifying-but-not-comitting
-def on_submit(self):
-	x = "y"
-	self.status = x
-	self.save()
-
-# ruleid: frappe-modifying-but-not-comitting-other-method
-class DoctypeClass(Document):
-	def on_submit(self):
-		self.good_method()
-		self.tainted_method()
-
-	def tainted_method(self):
-		self.status = "uptate"
-
-
-# ok: frappe-modifying-but-not-comitting-other-method
-class DoctypeClass(Document):
-	def on_submit(self):
-		self.good_method()
-		self.tainted_method()
-
-	def tainted_method(self):
-		self.status = "update"
-		self.db_set("status", "update")
-
-# ok: frappe-modifying-but-not-comitting-other-method
-class DoctypeClass(Document):
-	def on_submit(self):
-		self.good_method()
-		self.tainted_method()
-		self.save()
-
-	def tainted_method(self):
-		self.status = "uptate"

.github/helper/semgrep_rules/frappe_correctness.yml

@@ -1,135 +0,0 @@
-# This file specifies rules for correctness according to how frappe doctype data model works.
-
-rules:
-- id: frappe-modifying-but-not-comitting
-  patterns:
-    - pattern: |
-        def $METHOD(self, ...):
-          ...
-          self.$ATTR = ...
-    - pattern-not: |
-        def $METHOD(self, ...):
-          ...
-          self.$ATTR = ...
-          ...
-          self.db_set(..., self.$ATTR, ...)
-    - pattern-not: |
-        def $METHOD(self, ...):
-          ...
-          self.$ATTR = $SOME_VAR
-          ...
-          self.db_set(..., $SOME_VAR, ...)
-    - pattern-not: |
-        def $METHOD(self, ...):
-          ...
-          self.$ATTR = $SOME_VAR
-          ...
-          self.save()
-    - metavariable-regex:
-        metavariable: '$ATTR'
-        # this is negative look-ahead, add more attrs to ignore like (ignore|ignore_this_too|ignore_me)
-        regex: '^(?!ignore_linked_doctypes|status_updater)(.*)$'
-    - metavariable-regex:
-        metavariable: "$METHOD"
-        regex: "(on_submit|on_cancel)"
-  message: |
-    DocType modified in self.$METHOD. Please check if modification of self.$ATTR is commited to database.
-  languages: [python]
-  severity: ERROR
-
-- id: frappe-modifying-but-not-comitting-other-method
-  patterns:
-  - pattern: |
-      class $DOCTYPE(...):
-        def $METHOD(self, ...):
-          ...
-          self.$ANOTHER_METHOD()
-          ...
-
-        def $ANOTHER_METHOD(self, ...):
-          ...
-          self.$ATTR = ...
-  - pattern-not: |
-      class $DOCTYPE(...):
-        def $METHOD(self, ...):
-          ...
-          self.$ANOTHER_METHOD()
-          ...
-
-        def $ANOTHER_METHOD(self, ...):
-          ...
-          self.$ATTR = ...
-          ...
-          self.db_set(..., self.$ATTR, ...)
-  - pattern-not: |
-      class $DOCTYPE(...):
-        def $METHOD(self, ...):
-          ...
-          self.$ANOTHER_METHOD()
-          ...
-
-        def $ANOTHER_METHOD(self, ...):
-          ...
-          self.$ATTR = $SOME_VAR
-          ...
-          self.db_set(..., $SOME_VAR, ...)
-  - pattern-not: |
-      class $DOCTYPE(...):
-        def $METHOD(self, ...):
-          ...
-          self.$ANOTHER_METHOD()
-          ...
-          self.save()
-        def $ANOTHER_METHOD(self, ...):
-          ...
-          self.$ATTR = ...
-  - metavariable-regex:
-      metavariable: "$METHOD"
-      regex: "(on_submit|on_cancel)"
-  message: |
-    self.$ANOTHER_METHOD is called from self.$METHOD, check if changes to self.$ATTR are commited to database.
-  languages: [python]
-  severity: ERROR
-
-- id: frappe-print-function-in-doctypes
-  pattern: print(...)
-  message: |
-      Did you mean to leave this print statement in? Consider using msgprint or logger instead of print statement.
-  languages: [python]
-  severity: WARNING
-  paths:
-      exclude:
-        - test_*.py
-      include:
-        - "*/**/doctype/*"
-
-- id: frappe-modifying-child-tables-while-iterating
-  pattern-either:
-    - pattern: |
-        for $ROW in self.$TABLE:
-            ...
-            self.remove(...)
-    - pattern: |
-        for $ROW in self.$TABLE:
-            ...
-            self.append(...)
-  message: |
-      Child table being modified while iterating on it.
-  languages: [python]
-  severity: ERROR
-  paths:
-      include:
-        - "*/**/doctype/*"
-
-- id: frappe-same-key-assigned-twice
-  pattern-either:
-    - pattern: |
-        {..., $X: $A, ..., $X: $B, ...}
-    - pattern: |
-        dict(..., ($X, $A), ..., ($X, $B), ...)
-    - pattern: |
-        _dict(..., ($X, $A), ..., ($X, $B), ...)
-  message: |
-      key `$X` is uselessly assigned twice. This could be a potential bug.
-  languages: [python]
-  severity: ERROR

.github/helper/semgrep_rules/security.py

@@ -1,6 +0,0 @@
-def function_name(input):
-	# ruleid: frappe-codeinjection-eval
-	eval(input)
-
-# ok: frappe-codeinjection-eval
-eval("1 + 1")

.github/helper/semgrep_rules/security.yml

@@ -1,25 +0,0 @@
-rules:
-- id: frappe-codeinjection-eval
-  patterns:
-  - pattern-not: eval("...")
-  - pattern: eval(...)
-  message: |
-    Detected the use of eval(). eval() can be dangerous if used to evaluate
-    dynamic content. Avoid it or use safe_eval().
-  languages: [python]
-  severity: ERROR
-
-- id: frappe-sqli-format-strings
-  patterns:
-    - pattern-inside: |
-        @frappe.whitelist()
-        def $FUNC(...):
-            ...
-    - pattern-either:
-        - pattern: frappe.db.sql("..." % ...)
-        - pattern: frappe.db.sql(f"...", ...)
-        - pattern: frappe.db.sql("...".format(...), ...)
-  message: |
-      Detected use of raw string formatting for SQL queries. This can lead to sql injection vulnerabilities. Refer security guidelines - https://github.com/frappe/erpnext/wiki/Code-Security-Guidelines
-  languages: [python]
-  severity: WARNING

.github/helper/semgrep_rules/translate.js

@@ -1,44 +0,0 @@
-// ruleid: frappe-translation-empty-string
-__("")
-// ruleid: frappe-translation-empty-string
-__('')
-
-// ok: frappe-translation-js-formatting
-__('Welcome {0}, get started with ERPNext in just a few clicks.', [full_name]);
-
-// ruleid: frappe-translation-js-formatting
-__(`Welcome ${full_name}, get started with ERPNext in just a few clicks.`);
-
-// ok: frappe-translation-js-formatting
-__('This is fine');
-
-
-// ok: frappe-translation-trailing-spaces
-__('This is fine');
-
-// ruleid: frappe-translation-trailing-spaces
-__(' this is not ok ');
-// ruleid: frappe-translation-trailing-spaces
-__('this is not ok ');
-// ruleid: frappe-translation-trailing-spaces
-__(' this is not ok');
-
-// ok: frappe-translation-js-splitting
-__('You have {0} subscribers in your mailing list.', [subscribers.length])
-
-// todoruleid: frappe-translation-js-splitting
-__('You have') + subscribers.length + __('subscribers in your mailing list.')
-
-// ruleid: frappe-translation-js-splitting
-__('You have' + 'subscribers in your mailing list.')
-
-// ruleid: frappe-translation-js-splitting
-__('You have {0} subscribers' +
-    'in your mailing list', [subscribers.length])
-
-// ok: frappe-translation-js-splitting
-__("Ctrl+Enter to add comment")
-
-// ruleid: frappe-translation-js-splitting
-__('You have {0} subscribers \
-    in your mailing list', [subscribers.length])

.github/helper/semgrep_rules/translate.py

@@ -1,61 +0,0 @@
-# Examples taken from https://frappeframework.com/docs/user/en/translations
-# This file is used for testing the tests.
-
-from frappe import _
-
-full_name = "Jon Doe"
-# ok: frappe-translation-python-formatting
-_('Welcome {0}, get started with ERPNext in just a few clicks.').format(full_name)
-
-# ruleid: frappe-translation-python-formatting
-_('Welcome %s, get started with ERPNext in just a few clicks.' % full_name)
-# ruleid: frappe-translation-python-formatting
-_('Welcome %(name)s, get started with ERPNext in just a few clicks.' % {'name': full_name})
-
-# ruleid: frappe-translation-python-formatting
-_('Welcome {0}, get started with ERPNext in just a few clicks.'.format(full_name))
-
-
-subscribers = ["Jon", "Doe"]
-# ok: frappe-translation-python-formatting
-_('You have {0} subscribers in your mailing list.').format(len(subscribers))
-
-# ruleid: frappe-translation-python-splitting
-_('You have') + len(subscribers) + _('subscribers in your mailing list.')
-
-# ruleid: frappe-translation-python-splitting
-_('You have {0} subscribers \
-    in your mailing list').format(len(subscribers))
-
-# ok: frappe-translation-python-splitting
-_('You have {0} subscribers') \
-    + 'in your mailing list'
-
-# ruleid: frappe-translation-trailing-spaces
-msg = _(" You have {0} pending invoice ")
-# ruleid: frappe-translation-trailing-spaces
-msg = _("You have {0} pending invoice ")
-# ruleid: frappe-translation-trailing-spaces
-msg = _(" You have {0} pending invoice")
-
-# ok: frappe-translation-trailing-spaces
-msg = ' ' + _("You have {0} pending invoices") + ' '
-
-# ruleid: frappe-translation-python-formatting
-_(f"can not format like this - {subscribers}")
-# ruleid: frappe-translation-python-splitting
-_(f"what" + f"this is also not cool")
-
-
-# ruleid: frappe-translation-empty-string
-_("")
-# ruleid: frappe-translation-empty-string
-_('')
-
-
-class Test:
-	# ok: frappe-translation-python-splitting
-	def __init__(
-			args
-			):
-		pass

.github/helper/semgrep_rules/translate.yml

@@ -1,64 +0,0 @@
-rules:
-- id: frappe-translation-empty-string
-  pattern-either:
-  - pattern: _("")
-  - pattern: __("")
-  message: |
-    Empty string is useless for translation.
-    Please refer: https://frappeframework.com/docs/user/en/translations
-  languages: [python, javascript, json]
-  severity: ERROR
-
-- id: frappe-translation-trailing-spaces
-  pattern-either:
-    - pattern: _("=~/(^[ \t]+|[ \t]+$)/")
-    - pattern: __("=~/(^[ \t]+|[ \t]+$)/")
-  message: |
-    Trailing or leading whitespace not allowed in translate strings.
-    Please refer: https://frappeframework.com/docs/user/en/translations
-  languages: [python, javascript, json]
-  severity: ERROR
-
-- id: frappe-translation-python-formatting
-  pattern-either:
-  - pattern: _("..." % ...)
-  - pattern: _("...".format(...))
-  - pattern: _(f"...")
-  message: |
-    Only positional formatters are allowed and formatting should not be done before translating.
-    Please refer: https://frappeframework.com/docs/user/en/translations
-  languages: [python]
-  severity: ERROR
-
-- id: frappe-translation-js-formatting
-  patterns:
-  - pattern: __(`...`)
-  - pattern-not: __("...")
-  message: |
-    Template strings are not allowed for text formatting.
-    Please refer: https://frappeframework.com/docs/user/en/translations
-  languages: [javascript, json]
-  severity: ERROR
-
-- id: frappe-translation-python-splitting
-  pattern-either:
-  - pattern: _(...) + _(...)
-  - pattern: _("..." + "...")
-  - pattern-regex: '[\s\.]_\([^\)]*\\\s*'    # lines broken by `\`
-  - pattern-regex: '[\s\.]_\(\s*\n'          # line breaks allowed by python for using ( )
-  message: |
-    Do not split strings inside translate function. Do not concatenate using translate functions.
-    Please refer: https://frappeframework.com/docs/user/en/translations
-  languages: [python]
-  severity: ERROR
-
-- id: frappe-translation-js-splitting
-  pattern-either:
-  - pattern-regex: '__\([^\)]*[\\]\s+'
-  - pattern: __('...' + '...', ...)
-  - pattern: __('...') + __('...')
-  message: |
-    Do not split strings inside translate function. Do not concatenate using translate functions.
-    Please refer: https://frappeframework.com/docs/user/en/translations
-  languages: [javascript, json]
-  severity: ERROR

.github/helper/semgrep_rules/ux.js

@@ -1,9 +0,0 @@
-
-// ok: frappe-missing-translate-function-js
-frappe.msgprint('{{ _("Both login and password required") }}');
-
-// ruleid: frappe-missing-translate-function-js
-frappe.msgprint('What');
-
-// ok: frappe-missing-translate-function-js
-frappe.throw('  {{ _("Both login and password required") }}.  ');

.github/helper/semgrep_rules/ux.py

@@ -1,31 +0,0 @@
-import frappe
-from frappe import msgprint, throw, _
-
-
-# ruleid: frappe-missing-translate-function-python
-throw("Error Occured")
-
-# ruleid: frappe-missing-translate-function-python
-frappe.throw("Error Occured")
-
-# ruleid: frappe-missing-translate-function-python
-frappe.msgprint("Useful message")
-
-# ruleid: frappe-missing-translate-function-python
-msgprint("Useful message")
-
-
-# ok: frappe-missing-translate-function-python
-translatedmessage = _("Hello")
-
-# ok: frappe-missing-translate-function-python
-throw(translatedmessage)
-
-# ok: frappe-missing-translate-function-python
-msgprint(translatedmessage)
-
-# ok: frappe-missing-translate-function-python
-msgprint(_("Helpful message"))
-
-# ok: frappe-missing-translate-function-python
-frappe.throw(_("Error occured"))

.github/helper/semgrep_rules/ux.yml

@@ -1,30 +0,0 @@
-rules:
-- id: frappe-missing-translate-function-python
-  pattern-either:
-  - patterns:
-      - pattern: frappe.msgprint("...", ...)
-      - pattern-not: frappe.msgprint(_("..."), ...)
-  - patterns:
-      - pattern: frappe.throw("...", ...)
-      - pattern-not: frappe.throw(_("..."), ...)
-  message: |
-      All user facing text must be wrapped in translate function. Please refer to translation documentation. https://frappeframework.com/docs/user/en/guides/basics/translations
-  languages: [python]
-  severity: ERROR
-
-- id: frappe-missing-translate-function-js
-  pattern-either:
-  - patterns:
-      - pattern: frappe.msgprint("...", ...)
-      - pattern-not: frappe.msgprint(__("..."), ...)
-      # ignore microtemplating e.g. msgprint("{{ _("server side translation") }}")
-      - pattern-not: frappe.msgprint("=~/\{\{.*\_.*\}\}/i", ...)
-  - patterns:
-      - pattern: frappe.throw("...", ...)
-      - pattern-not: frappe.throw(__("..."), ...)
-      # ignore microtemplating
-      - pattern-not: frappe.throw("=~/\{\{.*\_.*\}\}/i", ...)
-  message: |
-      All user facing text must be wrapped in translate function. Please refer to translation documentation. https://frappeframework.com/docs/user/en/guides/basics/translations
-  languages: [javascript]
-  severity: ERROR

.github/helper/site_config.json

@@ -1,16 +0,0 @@
-{
- "db_host": "127.0.0.1",
- "db_port": 3306,
- "db_name": "test_frappe",
- "db_password": "test_frappe",
- "auto_email_id": "test@example.com",
- "mail_server": "smtp.example.com",
- "mail_login": "test@example.com",
- "mail_password": "test",
- "admin_password": "admin",
- "root_login": "root",
- "root_password": "travis",
- "host_name": "http://test_site:8000",
- "install_apps": ["erpnext"],
- "throttle_user_limit": 100
-}

.github/helper/translation.py

@@ -1,60 +0,0 @@
-import re
-import sys
-
-errors_encounter = 0
-pattern = re.compile(r"_\(([\"']{,3})(?P<message>((?!\1).)*)\1(\s*,\s*context\s*=\s*([\"'])(?P<py_context>((?!\5).)*)\5)*(\s*,(\s*?.*?\n*?)*(,\s*([\"'])(?P<js_context>((?!\11).)*)\11)*)*\)")
-words_pattern = re.compile(r"_{1,2}\([\"'`]{1,3}.*?[a-zA-Z]")
-start_pattern = re.compile(r"_{1,2}\([f\"'`]{1,3}")
-f_string_pattern = re.compile(r"_\(f[\"']")
-starts_with_f_pattern = re.compile(r"_\(f")
-
-# skip first argument
-files = sys.argv[1:]
-files_to_scan = [_file for _file in files if _file.endswith(('.py', '.js'))]
-
-for _file in files_to_scan:
-	with open(_file, 'r') as f:
-		print(f'Checking: {_file}')
-		file_lines = f.readlines()
-		for line_number, line in enumerate(file_lines, 1):
-			if 'frappe-lint: disable-translate' in line:
-				continue
-
-			start_matches = start_pattern.search(line)
-			if start_matches:
-				starts_with_f = starts_with_f_pattern.search(line)
-
-				if starts_with_f:
-					has_f_string = f_string_pattern.search(line)
-					if has_f_string:
-						errors_encounter += 1
-						print(f'\nF-strings are not supported for translations at line number {line_number}\n{line.strip()[:100]}')
-						continue
-					else:
-						continue
-
-				match = pattern.search(line)
-				error_found = False
-
-				if not match and line.endswith((',\n', '[\n')):
-					# concat remaining text to validate multiline pattern
-					line = "".join(file_lines[line_number - 1:])
-					line = line[start_matches.start() + 1:]
-					match = pattern.match(line)
-
-				if not match:
-					error_found = True
-					print(f'\nTranslation syntax error at line number {line_number}\n{line.strip()[:100]}')
-
-				if not error_found and not words_pattern.search(line):
-					error_found = True
-					print(f'\nTranslation is useless because it has no words at line number {line_number}\n{line.strip()[:100]}')
-
-				if error_found:
-					errors_encounter += 1
-
-if errors_encounter > 0:
-	print('\nVisit "https://frappeframework.com/docs/user/en/translations" to learn about valid translation strings.')
-	sys.exit(1)
-else:
-	print('\nGood To Go!')

.github/workflows/backport.yml

@@ -1,16 +0,0 @@
-name: Backport
-on:
-  pull_request:
-    types:
-      - closed
-      - labeled
-
-jobs:
-  backport:
-    runs-on: ubuntu-18.04
-    name: Backport
-    steps:
-      - name: Backport
-        uses: tibdex/backport@v1
-        with:
-          github_token: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/docker-release.yml

@@ -1,14 +0,0 @@
-name: Trigger Docker build on release
-on:
-  release:
-    types: [released]
-jobs:
-  curl:
-    runs-on: ubuntu-latest
-    container:
-      image: alpine:latest
-    steps:
-    - name: curl
-      run: |
-        apk add curl bash
-        curl -s -X POST -H "Content-Type: application/json" -H "Accept: application/json" -H "Travis-API-Version: 3" -H "Authorization: token ${{ secrets.TRAVIS_CI_TOKEN }}" -d '{"request":{"branch":"master"}}' https://api.travis-ci.com/repo/frappe%2Ffrappe_docker/requests

.github/workflows/docs-checker.yml

@@ -1,24 +0,0 @@
-name: 'Documentation Required'
-on:
-  pull_request:
-    types: [ opened, synchronize, reopened, edited ]
-
-jobs:
-  build:
-    runs-on: ubuntu-latest
-
-    steps:
-      - name: 'Setup Environment'
-        uses: actions/setup-python@v2
-        with:
-          python-version: 3.6
-
-      - name: 'Clone repo'
-        uses: actions/checkout@v2
-
-      - name: Validate Docs
-        env:
-          PR_NUMBER: ${{ github.event.number }}
-        run: |
-          pip install requests --quiet
-          python $GITHUB_WORKSPACE/.github/helper/documentation.py $PR_NUMBER

.github/workflows/patch.yml

@@ -1,73 +0,0 @@
-name: Patch
-
-on: [pull_request, workflow_dispatch]
-
-jobs:
-  test:
-    runs-on: ubuntu-18.04
-
-    name: Patch Test
-
-    services:
-      mysql:
-        image: mariadb:10.3
-        env:
-          MYSQL_ALLOW_EMPTY_PASSWORD: YES
-        ports:
-          - 3306:3306
-        options: --health-cmd="mysqladmin ping" --health-interval=5s --health-timeout=2s --health-retries=3
-
-    steps:
-      - name: Clone
-        uses: actions/checkout@v2
-
-      - name: Setup Python
-        uses: actions/setup-python@v2
-        with:
-          python-version: 3.6
-
-      - name: Add to Hosts
-        run: echo "127.0.0.1 test_site" | sudo tee -a /etc/hosts
-
-      - name: Cache pip
-        uses: actions/cache@v2
-        with:
-          path: ~/.cache/pip
-          key: ${{ runner.os }}-pip-${{ hashFiles('**/requirements.txt') }}
-          restore-keys: |
-            ${{ runner.os }}-pip-
-            ${{ runner.os }}-
-
-      - name: Cache node modules
-        uses: actions/cache@v2
-        env:
-          cache-name: cache-node-modules
-        with:
-          path: ~/.npm
-          key: ${{ runner.os }}-build-${{ env.cache-name }}-${{ hashFiles('**/package-lock.json') }}
-          restore-keys: |
-            ${{ runner.os }}-build-${{ env.cache-name }}-
-            ${{ runner.os }}-build-
-            ${{ runner.os }}-
-
-      - name: Get yarn cache directory path
-        id: yarn-cache-dir-path
-        run: echo "::set-output name=dir::$(yarn cache dir)"
-
-      - uses: actions/cache@v2
-        id: yarn-cache
-        with:
-          path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
-          key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
-          restore-keys: |
-            ${{ runner.os }}-yarn-
-
-      - name: Install
-        run: bash ${GITHUB_WORKSPACE}/.github/helper/install.sh
-
-      - name: Run Patch Tests
-        run: |
-          cd ~/frappe-bench/
-          wget https://erpnext.com/files/v10-erpnext.sql.gz
-          bench --site test_site --force restore ~/frappe-bench/v10-erpnext.sql.gz
-          bench --site test_site migrate

.github/workflows/semgrep.yml

@@ -1,34 +0,0 @@
-name: Semgrep
-
-on:
-  pull_request:
-    branches:
-      - develop
-      - version-13-hotfix
-      - version-13-pre-release
-jobs:
-  semgrep:
-    name: Frappe Linter
-    runs-on: ubuntu-latest
-    steps:
-    - uses: actions/checkout@v2
-    - name: Setup python3
-      uses: actions/setup-python@v2
-      with:
-        python-version: 3.8
-
-    - name: Setup semgrep
-      run: |
-        python -m pip install -q semgrep
-        git fetch origin $GITHUB_BASE_REF:$GITHUB_BASE_REF -q
-
-    - name: Semgrep errors
-      run: |
-        files=$(git diff --name-only --diff-filter=d $GITHUB_BASE_REF)
-        [[ -d .github/helper/semgrep_rules ]] && semgrep --severity ERROR --config=.github/helper/semgrep_rules --quiet --error $files
-        semgrep --config="r/python.lang.correctness" --quiet --error $files
-
-    - name: Semgrep warnings
-      run: |
-        files=$(git diff --name-only --diff-filter=d $GITHUB_BASE_REF)
-        [[ -d .github/helper/semgrep_rules ]] && semgrep --severity WARNING --severity INFO --config=.github/helper/semgrep_rules --quiet $files

.github/workflows/server-tests.yml

@@ -1,110 +0,0 @@
-name: Server
-
-on: [pull_request, workflow_dispatch]
-
-jobs:
-  test:
-    runs-on: ubuntu-18.04
-
-    strategy:
-      fail-fast: false
-
-      matrix:
-        container: [1, 2, 3]
-
-    name: Python Unit Tests
-
-    services:
-      mysql:
-        image: mariadb:10.3
-        env:
-          MYSQL_ALLOW_EMPTY_PASSWORD: YES
-        ports:
-          - 3306:3306
-        options: --health-cmd="mysqladmin ping" --health-interval=5s --health-timeout=2s --health-retries=3
-
-    steps:
-      - name: Clone
-        uses: actions/checkout@v2
-
-      - name: Setup Python
-        uses: actions/setup-python@v2
-        with:
-          python-version: 3.7
-
-      - name: Add to Hosts
-        run: echo "127.0.0.1 test_site" | sudo tee -a /etc/hosts
-
-      - name: Cache pip
-        uses: actions/cache@v2
-        with:
-          path: ~/.cache/pip
-          key: ${{ runner.os }}-pip-${{ hashFiles('**/requirements.txt') }}
-          restore-keys: |
-            ${{ runner.os }}-pip-
-            ${{ runner.os }}-
-
-      - name: Cache node modules
-        uses: actions/cache@v2
-        env:
-          cache-name: cache-node-modules
-        with:
-          path: ~/.npm
-          key: ${{ runner.os }}-build-${{ env.cache-name }}-${{ hashFiles('**/package-lock.json') }}
-          restore-keys: |
-            ${{ runner.os }}-build-${{ env.cache-name }}-
-            ${{ runner.os }}-build-
-            ${{ runner.os }}-
-
-      - name: Get yarn cache directory path
-        id: yarn-cache-dir-path
-        run: echo "::set-output name=dir::$(yarn cache dir)"
-
-      - uses: actions/cache@v2
-        id: yarn-cache
-        with:
-          path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
-          key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
-          restore-keys: |
-            ${{ runner.os }}-yarn-
-
-      - name: Install
-        run: bash ${GITHUB_WORKSPACE}/.github/helper/install.sh
-
-      - name: Run Tests
-        run: cd ~/frappe-bench/ && bench --site test_site run-parallel-tests --app erpnext --use-orchestrator --with-coverage
-        env:
-          TYPE: server
-          CI_BUILD_ID: ${{ github.run_id }}
-          ORCHESTRATOR_URL: http://test-orchestrator.frappe.io
-
-      - name: Upload Coverage Data
-        run: |
-          cp ~/frappe-bench/sites/.coverage ${GITHUB_WORKSPACE}
-          cd ${GITHUB_WORKSPACE}
-          pip3 install coverage==5.5
-          pip3 install coveralls==3.0.1
-          coveralls
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-          COVERALLS_FLAG_NAME: run-${{ matrix.container }}
-          COVERALLS_SERVICE_NAME: ${{ github.event_name == 'pull_request' && 'github' || 'github-actions' }}
-          COVERALLS_PARALLEL: true
-
-  coveralls:
-    name: Coverage Wrap Up
-    needs: test
-    container: python:3-slim
-    runs-on: ubuntu-18.04
-    steps:
-      - name: Clone
-        uses: actions/checkout@v2
-
-      - name: Coveralls Finished
-        run: |
-          cd ${GITHUB_WORKSPACE}
-          pip3 install coverage==5.5
-          pip3 install coveralls==3.0.1
-          coveralls --finish
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/translation_linter.yml

@@ -1,22 +0,0 @@
-name: Frappe Linter
-on:
-  pull_request:
-    branches:
-      - develop
-      - version-12-hotfix
-      - version-11-hotfix
-jobs:
-  check_translation:
-    name: Translation Syntax Check
-    runs-on: ubuntu-18.04
-    steps:
-    - uses: actions/checkout@v2
-    - name: Setup python3
-      uses: actions/setup-python@v1
-      with:
-        python-version: 3.6
-    - name: Validating Translation Syntax
-      run: |
-        git fetch origin $GITHUB_BASE_REF:$GITHUB_BASE_REF -q
-        files=$(git diff --name-only --diff-filter=d $GITHUB_BASE_REF)
-        python $GITHUB_WORKSPACE/.github/helper/translation.py $files

.gitignore

@@ -12,6 +12,5 @@ erpnext/docs/current
 *.swo
 __pycache__
 *~
-.idea/
 .vscode/
-node_modules/
+node_modules/

.snyk

@@ -1,8 +0,0 @@
-# Snyk (https://snyk.io) policy file, patches or ignores known vulnerabilities.
-version: v1.14.0
-ignore: {}
-# patches apply the minimum changes required to fix a vulnerability
-patch:
-  SNYK-JS-LODASH-450202:
-    - cypress > getos > async > lodash:
-        patched: '2020-01-31T01:35:12.802Z'

.travis.yml

@@ -0,0 +1,56 @@
+language: python
+dist: trusty
+
+python:
+  - "2.7"
+
+services:
+  - mysql
+
+install:
+  # fix mongodb travis error
+  - sudo rm /etc/apt/sources.list.d/mongodb*.list
+  - pip install flake8==3.3.0
+  - flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics
+  - sudo rm /etc/apt/sources.list.d/docker.list
+  - sudo apt-get install hhvm && rm -rf /home/travis/.kiex/
+  - sudo apt-get purge -y mysql-common mysql-server mysql-client
+  - nvm install 10
+  - pip install python-coveralls
+  - wget https://raw.githubusercontent.com/frappe/bench/master/playbooks/install.py
+  - sudo python install.py --develop --user travis --without-bench-setup
+  - sudo pip install -e ~/bench
+
+  - rm $TRAVIS_BUILD_DIR/.git/shallow
+  - bash $TRAVIS_BUILD_DIR/travis/bench_init.sh
+  - cp -r $TRAVIS_BUILD_DIR/test_sites/test_site ~/frappe-bench/sites/
+
+before_script:
+  - mysql -u root -ptravis -e 'create database test_frappe'
+  - echo "USE mysql;\nCREATE USER 'test_frappe'@'localhost' IDENTIFIED BY 'test_frappe';\nFLUSH PRIVILEGES;\n" | mysql -u root -ptravis
+  - echo "USE mysql;\nGRANT ALL PRIVILEGES ON \`test_frappe\`.* TO 'test_frappe'@'localhost';\n" | mysql -u root -ptravis
+
+  - cd ~/frappe-bench
+  - bench get-app erpnext $TRAVIS_BUILD_DIR
+  - bench use test_site
+  - bench reinstall --mariadb-root-username root --mariadb-root-password travis --yes
+  - bench scheduler disable
+  - sed -i 's/9000/9001/g' sites/common_site_config.json
+  - bench start &
+  - sleep 10
+
+jobs:
+  include:
+    - stage: test
+      script:
+        - set -e
+        - bench run-tests --app erpnext --coverage
+      after_script:
+        - coveralls -b apps/erpnext -d ../../sites/.coverage
+      env: Server Side Test
+    - # stage
+      script:
+        - wget http://build.erpnext.com/20171108_190013_955977f8_database.sql.gz
+        - bench --force restore ~/frappe-bench/20171108_190013_955977f8_database.sql.gz --mariadb-root-password travis
+        - bench migrate
+      env: Patch Testing

CODEOWNERS

@@ -1,18 +0,0 @@
-# Each line is a file pattern followed by one or more owners.
-
-# These owners will be the default owners for everything in
-# the repo. Unless a later match takes precedence,
-
-manufacturing/          @rohitwaghchaure @marination
-accounts/               @deepeshgarg007 @nextchamp-saqib
-loan_management/        @deepeshgarg007 @rohitwaghchaure
-pos*                    @nextchamp-saqib @rohitwaghchaure
-assets/                 @nextchamp-saqib @deepeshgarg007
-stock/                  @marination @rohitwaghchaure
-buying/                 @marination @deepeshgarg007
-hr/                     @Anurag810 @rohitwaghchaure
-projects/               @hrwX @nextchamp-saqib
-support/                @hrwX @marination
-healthcare/             @ruchamahabal @marination
-erpnext_integrations/   @Mangesh-Khairnar @nextchamp-saqib
-requirements.txt        @gavindsouza

MANIFEST.in

@@ -0,0 +1,20 @@
+include MANIFEST.in
+include requirements.txt
+include *.json
+include *.md
+include *.py
+include *.txt
+include .travis.yml
+recursive-include erpnext *.txt
+recursive-include erpnext *.css
+recursive-include erpnext *.csv
+recursive-include erpnext *.html
+recursive-include erpnext *.ico
+recursive-include erpnext *.js
+recursive-include erpnext *.json
+recursive-include erpnext *.md
+recursive-include erpnext *.png
+recursive-include erpnext *.py
+recursive-include erpnext *.svg
+recursive-include erpnext/public *
+recursive-exclude * *.pyc

README.md

@@ -1,11 +1,11 @@
 <div align="center">
-    <img src="https://raw.githubusercontent.com/frappe/erpnext/develop/erpnext/public/images/erpnext-logo.png" height="128">
+    <img src="https://github.com/frappe/design/blob/master/logos/erpnext-logo.svg" height="128">
     <h2>ERPNext</h2>
     <p align="center">
         <p>ERP made simple</p>
     </p>
 
-[![CI](https://github.com/frappe/erpnext/actions/workflows/ci-tests.yml/badge.svg?branch=develop)](https://github.com/frappe/erpnext/actions/workflows/ci-tests.yml)
+[![Build Status](https://travis-ci.com/frappe/erpnext.png)](https://travis-ci.com/frappe/erpnext)
 [![Open Source Helpers](https://www.codetriage.com/frappe/erpnext/badges/users.svg)](https://www.codetriage.com/frappe/erpnext)
 [![Coverage Status](https://coveralls.io/repos/github/frappe/erpnext/badge.svg?branch=develop)](https://coveralls.io/github/frappe/erpnext?branch=develop)
 
@@ -13,36 +13,15 @@
 
 </div>
 
-ERPNext as a monolith includes the following areas for managing businesses:
+Includes: Accounting, Inventory, Manufacturing, CRM, Sales, Purchase, Project Management, HRMS. Requires MariaDB.
 
-1. [Accounting](https://erpnext.com/open-source-accounting)
-1. [Warehouse Management](https://erpnext.com/distribution/warehouse-management-system)
-1. [CRM](https://erpnext.com/open-source-crm)
-1. [Sales](https://erpnext.com/open-source-sales-purchase)
-1. [Purchase](https://erpnext.com/open-source-sales-purchase)
-1. [HRMS](https://erpnext.com/open-source-hrms)
-1. [Project Management](https://erpnext.com/open-source-projects)
-1. [Support](https://erpnext.com/open-source-help-desk-software)
-1. [Asset Management](https://erpnext.com/open-source-asset-management-software)
-1. [Quality Management](https://erpnext.com/docs/user/manual/en/quality-management)
-1. [Manufacturing](https://erpnext.com/open-source-manufacturing-erp-software)
-1. [Website Management](https://erpnext.com/open-source-website-builder-software)
-1. [Customize ERPNext](https://erpnext.com/docs/user/manual/en/customize-erpnext)
-1. [And More](https://erpnext.com/docs/user/manual/en/)
-
-ERPNext requires MariaDB.
-
-ERPNext is built on the [Frappe Framework](https://github.com/frappe/frappe), a full-stack web app framework built with Python & JavaScript.
+ERPNext is built on the [Frappe](https://github.com/frappe/frappe) Framework, a full-stack web app framework in Python & JavaScript.
 
 - [User Guide](https://erpnext.com/docs/user)
 - [Discussion Forum](https://discuss.erpnext.com/)
 
 ---
 
-### Containerized Installation
-
-Use docker to deploy ERPNext in production or for development of [Frappe](https://github.com/frappe/frappe) apps. See https://github.com/frappe/frappe_docker for more details.
-
 ### Full Install
 
 The Easy Way: our install script for bench will install all dependencies (e.g. MariaDB). See https://github.com/frappe/bench for more details.
@@ -70,7 +49,7 @@ The ERPNext code is licensed as GNU General Public License (v3) and the Document
 ## Contributing
 
 1. [Issue Guidelines](https://github.com/frappe/erpnext/wiki/Issue-Guidelines)
-1. [Report Security Vulnerabilities](https://erpnext.com/security)
+1. [Report Security Vulnerabilities](https://erpnext.com/report)
 1. [Pull Request Requirements](https://github.com/frappe/erpnext/wiki/Contribution-Guidelines)
 1. [Translations](https://translate.erpnext.com)
 1. [Chart of Accounts](https://charts.erpnext.com)

SECURITY.md

@@ -1,7 +0,0 @@
-# Security Policy
-
-The ERPNext team and community take security issues seriously. To report a security issue, fill out the form at [https://erpnext.com/security/report](https://erpnext.com/security/report).
-
-You can help us make ERPNext and all it's users more secure by following the [Reporting guidelines](https://erpnext.com/security).
-
-We appreciate your efforts to responsibly disclose your findings. We'll endeavor to respond quickly, and will keep you updated throughout the process.

erpnext/.stylelintrc

@@ -1,9 +0,0 @@
-{
-	"extends": ["stylelint-config-recommended"],
-	"plugins": ["stylelint-scss"],
-	"rules": {
-		"at-rule-no-unknown": null,
-		"scss/at-rule-no-unknown": true,
-		"no-descending-specificity": null
-	}
-}

erpnext/__init__.py

@@ -5,7 +5,7 @@ import frappe
 from erpnext.hooks import regional_overrides
 from frappe.utils import getdate
 
-__version__ = '13.5.1'
+__version__ = '11.1.21'
 
 def get_default_company(user=None):
 	'''Get default company for user'''
@@ -109,7 +109,7 @@ def get_region(company=None):
 	'''
 	if company or frappe.flags.company:
 		return frappe.get_cached_value('Company',
-			company or frappe.flags.company, 'country')
+			company or frappe.flags.company,  'country')
 	elif frappe.flags.country:
 		return frappe.flags.country
 	else:
@@ -132,10 +132,16 @@ def allow_regional(fn):
 
 	return caller
 
-def get_last_membership(member):
+def get_last_membership():
 	'''Returns last membership if exists'''
 	last_membership = frappe.get_all('Membership', 'name,to_date,membership_type',
-		dict(member=member, paid=1), order_by='to_date desc', limit=1)
+		dict(member=frappe.session.user, paid=1), order_by='to_date desc', limit=1)
 
-	if last_membership:
-		return last_membership[0]
+	return last_membership and last_membership[0]
+
+def is_member():
+	'''Returns true if the user is still a member'''
+	last_membership = get_last_membership()
+	if last_membership and getdate(last_membership.to_date) > getdate():
+		return True
+	return False

erpnext/accounts/accounts_dashboard/accounts/accounts.json

@@ -1,58 +0,0 @@
-{
- "cards": [
-  {
-   "card": "Total Outgoing Bills"
-  },
-  {
-   "card": "Total Incoming Bills"
-  },
-  {
-   "card": "Total Incoming Payment"
-  },
-  {
-   "card": "Total Outgoing Payment"
-  }
- ],
- "charts": [
-  {
-   "chart": "Profit and Loss",
-   "width": "Full"
-  },
-  {
-   "chart": "Incoming Bills (Purchase Invoice)",
-   "width": "Half"
-  },
-  {
-   "chart": "Outgoing Bills (Sales Invoice)",
-   "width": "Half"
-  },
-  {
-   "chart": "Accounts Receivable Ageing",
-   "width": "Half"
-  },
-  {
-   "chart": "Accounts Payable Ageing",
-   "width": "Half"
-  },
-  {
-   "chart": "Budget Variance",
-   "width": "Full"
-  },
-  {
-   "chart": "Bank Balance",
-   "width": "Full"
-  }
- ],
- "creation": "2020-07-17 11:25:34.796608",
- "dashboard_name": "Accounts",
- "docstatus": 0,
- "doctype": "Dashboard",
- "idx": 0,
- "is_default": 0,
- "is_standard": 1,
- "modified": "2020-07-22 13:07:34.540574",
- "modified_by": "Administrator",
- "module": "Accounts",
- "name": "Accounts",
- "owner": "Administrator"
-}

erpnext/accounts/custom/address.json

@@ -1,126 +0,0 @@
-{
- "custom_fields": [
-  {
-   "_assign": null,
-   "_comments": null,
-   "_liked_by": null,
-   "_user_tags": null,
-   "allow_in_quick_entry": 0,
-   "allow_on_submit": 0,
-   "bold": 0,
-   "collapsible": 0,
-   "collapsible_depends_on": null,
-   "columns": 0,
-   "creation": "2018-12-28 22:29:21.828090",
-   "default": null,
-   "depends_on": null,
-   "description": null,
-   "docstatus": 0,
-   "dt": "Address",
-   "fetch_from": null,
-   "fetch_if_empty": 0,
-   "fieldname": "tax_category",
-   "fieldtype": "Link",
-   "hidden": 0,
-   "hide_border": 0,
-   "hide_days": 0,
-   "hide_seconds": 0,
-   "idx": 15,
-   "ignore_user_permissions": 0,
-   "ignore_xss_filter": 0,
-   "in_global_search": 0,
-   "in_list_view": 0,
-   "in_preview": 0,
-   "in_standard_filter": 0,
-   "insert_after": "fax",
-   "label": "Tax Category",
-   "length": 0,
-   "mandatory_depends_on": null,
-   "modified": "2018-12-28 22:29:21.828090",
-   "modified_by": "Administrator",
-   "name": "Address-tax_category",
-   "no_copy": 0,
-   "options": "Tax Category",
-   "owner": "Administrator",
-   "parent": null,
-   "parentfield": null,
-   "parenttype": null,
-   "permlevel": 0,
-   "precision": "",
-   "print_hide": 0,
-   "print_hide_if_no_value": 0,
-   "print_width": null,
-   "read_only": 0,
-   "read_only_depends_on": null,
-   "report_hide": 0,
-   "reqd": 0,
-   "search_index": 0,
-   "translatable": 0,
-   "unique": 0,
-   "width": null
-  },
-  {
-   "_assign": null,
-   "_comments": null,
-   "_liked_by": null,
-   "_user_tags": null,
-   "allow_in_quick_entry": 0,
-   "allow_on_submit": 0,
-   "bold": 0,
-   "collapsible": 0,
-   "collapsible_depends_on": null,
-   "columns": 0,
-   "creation": "2020-10-14 17:41:40.878179",
-   "default": "0",
-   "depends_on": null,
-   "description": null,
-   "docstatus": 0,
-   "dt": "Address",
-   "fetch_from": null,
-   "fetch_if_empty": 0,
-   "fieldname": "is_your_company_address",
-   "fieldtype": "Check",
-   "hidden": 0,
-   "hide_border": 0,
-   "hide_days": 0,
-   "hide_seconds": 0,
-   "idx": 20,
-   "ignore_user_permissions": 0,
-   "ignore_xss_filter": 0,
-   "in_global_search": 0,
-   "in_list_view": 0,
-   "in_preview": 0,
-   "in_standard_filter": 0,
-   "insert_after": "linked_with",
-   "label": "Is Your Company Address",
-   "length": 0,
-   "mandatory_depends_on": null,
-   "modified": "2020-10-14 17:41:40.878179",
-   "modified_by": "Administrator",
-   "name": "Address-is_your_company_address",
-   "no_copy": 0,
-   "options": null,
-   "owner": "Administrator",
-   "parent": null,
-   "parentfield": null,
-   "parenttype": null,
-   "permlevel": 0,
-   "precision": "",
-   "print_hide": 0,
-   "print_hide_if_no_value": 0,
-   "print_width": null,
-   "read_only": 0,
-   "read_only_depends_on": null,
-   "report_hide": 0,
-   "reqd": 0,
-   "search_index": 0,
-   "translatable": 0,
-   "unique": 0,
-   "width": null
-  }
- ],
- "custom_perms": [],
- "doctype": "Address",
- "property_setters": [],
- "sync_on_migrate": 1
-}

erpnext/accounts/custom/address.py

@@ -1,42 +0,0 @@
-import frappe
-from frappe import _
-from frappe.contacts.doctype.address.address import Address
-from frappe.contacts.doctype.address.address import get_address_templates
-
-class ERPNextAddress(Address):
-	def validate(self):
-		self.validate_reference()
-		super(ERPNextAddress, self).validate()
-
-	def link_address(self):
-		"""Link address based on owner"""
-		if self.is_your_company_address:
-			return
-
-		return super(ERPNextAddress, self).link_address()
-
-	def validate_reference(self):
-		if self.is_your_company_address and not [
-			row for row in self.links if row.link_doctype == "Company"
-		]:
-			frappe.throw(_("Address needs to be linked to a Company. Please add a row for Company in the Links table."),
-				title=_("Company Not Linked"))
-
-@frappe.whitelist()
-def get_shipping_address(company, address = None):
-	filters = [
-		["Dynamic Link", "link_doctype", "=", "Company"],
-		["Dynamic Link", "link_name", "=", company],
-		["Address", "is_your_company_address", "=", 1]
-	]
-	fields = ["*"]
-	if address and frappe.db.get_value('Dynamic Link',
-		{'parent': address, 'link_name': company}):
-		filters.append(["Address", "name", "=", address])
-
-	address = frappe.get_all("Address", filters=filters, fields=fields) or {}
-
-	if address:
-		address_as_dict = address[0]
-		name, address_template = get_address_templates(address_as_dict)
-		return address_as_dict.get("name"), frappe.render_template(address_template, address_as_dict)

erpnext/accounts/dashboard_chart/accounts_payable_ageing/accounts_payable_ageing.json

@@ -1,23 +0,0 @@
-{
- "chart_name": "Accounts Payable Ageing",
- "chart_type": "Report",
- "creation": "2020-07-17 11:25:34.564015",
- "docstatus": 0,
- "doctype": "Dashboard Chart",
- "dynamic_filters_json": "{\"company\":\"frappe.defaults.get_user_default(\\\"Company\\\")\",\"report_date\":\"frappe.datetime.now_date()\"}",
- "filters_json": "{\"ageing_based_on\":\"Due Date\",\"range1\":30,\"range2\":60,\"range3\":90,\"range4\":120,\"group_by_party\":0,\"based_on_payment_terms\":0}",
- "idx": 0,
- "is_public": 1,
- "is_standard": 1,
- "modified": "2020-07-22 12:29:33.584419",
- "modified_by": "Administrator",
- "module": "Accounts",
- "name": "Accounts Payable Ageing",
- "number_of_groups": 0,
- "owner": "Administrator",
- "report_name": "Accounts Payable",
- "timeseries": 0,
- "type": "Donut",
- "use_report_chart": 1,
- "y_axis": []
-}

erpnext/accounts/dashboard_chart/accounts_receivable_ageing/accounts_receivable_ageing.json

@@ -1,23 +0,0 @@
-{
- "chart_name": "Accounts Receivable Ageing",
- "chart_type": "Report",
- "creation": "2020-07-17 11:25:34.535388",
- "docstatus": 0,
- "doctype": "Dashboard Chart",
- "dynamic_filters_json": "{\"company\":\"frappe.defaults.get_user_default(\\\"Company\\\")\",\"report_date\":\"frappe.datetime.now_date()\"}",
- "filters_json": "{\"ageing_based_on\":\"Due Date\",\"range1\":30,\"range2\":60,\"range3\":90,\"range4\":120,\"group_by_party\":0,\"based_on_payment_terms\":0,\"show_future_payments\":0,\"show_delivery_notes\":0,\"show_sales_person\":0}",
- "idx": 0,
- "is_public": 1,
- "is_standard": 1,
- "modified": "2020-07-22 12:28:42.743551",
- "modified_by": "Administrator",
- "module": "Accounts",
- "name": "Accounts Receivable Ageing",
- "number_of_groups": 0,
- "owner": "Administrator",
- "report_name": "Accounts Receivable",
- "timeseries": 0,
- "type": "Donut",
- "use_report_chart": 1,
- "y_axis": []
-}

erpnext/accounts/dashboard_chart/bank_balance/bank_balance.json

@@ -1,26 +0,0 @@
-{
- "chart_name": "Bank Balance",
- "chart_type": "Custom",
- "creation": "2020-07-17 11:25:34.620221",
- "docstatus": 0,
- "doctype": "Dashboard Chart",
- "dynamic_filters_json": "{\"company\":\"frappe.defaults.get_user_default(\\\"Company\\\")\",\"account\":\"locals[\\\":Company\\\"][frappe.defaults.get_user_default(\\\"Company\\\")][\\\"default_bank_account\\\"]\"}",
- "filters_json": "{}",
- "idx": 0,
- "is_public": 1,
- "is_standard": 1,
- "last_synced_on": "2020-07-22 12:19:59.879476",
- "modified": "2020-07-22 12:21:48.780513",
- "modified_by": "Administrator",
- "module": "Accounts",
- "name": "Bank Balance",
- "number_of_groups": 0,
- "owner": "Administrator",
- "source": "Account Balance Timeline",
- "time_interval": "Quarterly",
- "timeseries": 0,
- "timespan": "Last Year",
- "type": "Line",
- "use_report_chart": 0,
- "y_axis": []
-}

erpnext/accounts/dashboard_chart/budget_variance/budget_variance.json

@@ -1,23 +0,0 @@
-{
- "chart_name": "Budget Variance",
- "chart_type": "Report",
- "creation": "2020-07-17 11:25:34.593061",
- "docstatus": 0,
- "doctype": "Dashboard Chart",
- "dynamic_filters_json": "{\"company\":\"frappe.defaults.get_user_default(\\\"Company\\\")\",\"from_fiscal_year\":\"frappe.sys_defaults.fiscal_year\",\"to_fiscal_year\":\"frappe.sys_defaults.fiscal_year\"}",
- "filters_json": "{\"period\":\"Monthly\",\"budget_against\":\"Cost Center\",\"show_cumulative\":0}",
- "idx": 0,
- "is_public": 1,
- "is_standard": 1,
- "modified": "2020-07-22 12:24:49.144210",
- "modified_by": "Administrator",
- "module": "Accounts",
- "name": "Budget Variance",
- "number_of_groups": 0,
- "owner": "Administrator",
- "report_name": "Budget Variance Report",
- "timeseries": 0,
- "type": "Bar",
- "use_report_chart": 1,
- "y_axis": []
-}

erpnext/accounts/dashboard_chart/incoming_bills_(purchase_invoice)/incoming_bills_(purchase_invoice).json

@@ -1,29 +0,0 @@
-{
- "based_on": "posting_date",
- "chart_name": "Incoming Bills (Purchase Invoice)",
- "chart_type": "Sum",
- "color": "#a83333",
- "creation": "2020-07-17 11:25:34.479703",
- "docstatus": 0,
- "doctype": "Dashboard Chart",
- "document_type": "Purchase Invoice",
- "dynamic_filters_json": "",
- "filters_json": "[[\"Purchase Invoice\",\"docstatus\",\"=\",1]]",
- "idx": 0,
- "is_public": 1,
- "is_standard": 1,
- "last_synced_on": "2020-07-21 17:37:30.727306",
- "modified": "2020-07-21 17:51:07.374917",
- "modified_by": "Administrator",
- "module": "Accounts",
- "name": "Incoming Bills (Purchase Invoice)",
- "number_of_groups": 0,
- "owner": "Administrator",
- "time_interval": "Monthly",
- "timeseries": 1,
- "timespan": "Last Year",
- "type": "Bar",
- "use_report_chart": 0,
- "value_based_on": "base_net_total",
- "y_axis": []
-}

erpnext/accounts/dashboard_chart/outgoing_bills_(sales_invoice)/outgoing_bills_(sales_invoice).json

@@ -1,28 +0,0 @@
-{
- "based_on": "posting_date",
- "chart_name": "Outgoing Bills (Sales Invoice)",
- "chart_type": "Sum",
- "color": "#7b933d",
- "creation": "2020-07-17 11:25:34.507547",
- "docstatus": 0,
- "doctype": "Dashboard Chart",
- "document_type": "Sales Invoice",
- "filters_json": "[[\"Sales Invoice\",\"docstatus\",\"=\",1]]",
- "idx": 0,
- "is_public": 1,
- "is_standard": 1,
- "last_synced_on": "2020-07-21 17:37:31.574666",
- "modified": "2020-07-21 17:52:03.970530",
- "modified_by": "Administrator",
- "module": "Accounts",
- "name": "Outgoing Bills (Sales Invoice)",
- "number_of_groups": 0,
- "owner": "Administrator",
- "time_interval": "Monthly",
- "timeseries": 1,
- "timespan": "Last Year",
- "type": "Bar",
- "use_report_chart": 0,
- "value_based_on": "base_net_total",
- "y_axis": []
-}

erpnext/accounts/dashboard_chart/profit_and_loss/profit_and_loss.json

@@ -1,23 +0,0 @@
-{
- "chart_name": "Profit and Loss",
- "chart_type": "Report",
- "creation": "2020-07-17 11:25:34.448572",
- "docstatus": 0,
- "doctype": "Dashboard Chart",
- "dynamic_filters_json": "{\"company\":\"frappe.defaults.get_user_default(\\\"Company\\\")\",\"from_fiscal_year\":\"frappe.sys_defaults.fiscal_year\",\"to_fiscal_year\":\"frappe.sys_defaults.fiscal_year\"}",
- "filters_json": "{\"filter_based_on\":\"Fiscal Year\",\"period_start_date\":\"2020-04-01\",\"period_end_date\":\"2021-03-31\",\"periodicity\":\"Yearly\",\"include_default_book_entries\":1}",
- "idx": 0,
- "is_public": 1,
- "is_standard": 1,
- "modified": "2020-07-22 12:33:48.888943",
- "modified_by": "Administrator",
- "module": "Accounts",
- "name": "Profit and Loss",
- "number_of_groups": 0,
- "owner": "Administrator",
- "report_name": "Profit and Loss Statement",
- "timeseries": 0,
- "type": "Bar",
- "use_report_chart": 1,
- "y_axis": []
-}

erpnext/accounts/dashboard_chart_source/account_balance_timeline/account_balance_timeline.js

@@ -1,22 +0,0 @@
-frappe.provide('frappe.dashboards.chart_sources');
-
-frappe.dashboards.chart_sources["Account Balance Timeline"] = {
-	method: "erpnext.accounts.dashboard_chart_source.account_balance_timeline.account_balance_timeline.get",
-	filters: [
-		{
-			fieldname: "company",
-			label: __("Company"),
-			fieldtype: "Link",
-			options: "Company",
-			default: frappe.defaults.get_user_default("Company"),
-			reqd: 1
-		},
-		{
-			fieldname: "account",
-			label: __("Account"),
-			fieldtype: "Link",
-			options: "Account",
-			reqd: 1
-		},
-	]
-};

erpnext/accounts/dashboard_chart_source/account_balance_timeline/account_balance_timeline.json

@@ -1,13 +0,0 @@
-{
- "creation": "2019-02-06 07:57:10.377718",
- "docstatus": 0,
- "doctype": "Dashboard Chart Source",
- "idx": 0,
- "modified": "2019-04-09 18:30:49.943174",
- "modified_by": "Administrator",
- "module": "Accounts",
- "name": "Account Balance Timeline",
- "owner": "Administrator",
- "source_name": "Account Balance Timeline",
- "timeseries": 1
-}

erpnext/accounts/dashboard_chart_source/account_balance_timeline/account_balance_timeline.py

@@ -1,121 +0,0 @@
-# Copyright (c) 2015, Frappe Technologies Pvt. Ltd. and Contributors
-# License: GNU General Public License v3. See license.txt
-
-from __future__ import unicode_literals
-import frappe, json
-from frappe import _
-from frappe.utils import add_to_date, date_diff, getdate, nowdate, get_last_day, formatdate, get_link_to_form
-from erpnext.accounts.report.general_ledger.general_ledger import execute
-from frappe.utils.dashboard import cache_source
-from frappe.utils.dateutils import get_from_date_from_timespan, get_period_ending
-from frappe.utils.nestedset import get_descendants_of
-
-@frappe.whitelist()
-@cache_source
-def get(chart_name = None, chart = None, no_cache = None, filters = None, from_date = None,
-	to_date = None, timespan = None, time_interval = None, heatmap_year = None):
-	if chart_name:
-		chart = frappe.get_doc('Dashboard Chart', chart_name)
-	else:
-		chart = frappe._dict(frappe.parse_json(chart))
-	timespan = chart.timespan
-
-	if chart.timespan == 'Select Date Range':
-		from_date = chart.from_date
-		to_date = chart.to_date
-
-	timegrain = chart.time_interval
-	filters = frappe.parse_json(filters) or frappe.parse_json(chart.filters_json)
-
-	account = filters.get("account")
-	company = filters.get("company")
-
-	if not account and chart_name:
-		frappe.throw(_("Account is not set for the dashboard chart {0}")
-			.format(get_link_to_form("Dashboard Chart", chart_name)))
-
-	if not frappe.db.exists("Account", account) and chart_name:
-		frappe.throw(_("Account {0} does not exists in the dashboard chart {1}")
-			.format(account, get_link_to_form("Dashboard Chart", chart_name)))
-
-	if not to_date:
-		to_date = nowdate()
-	if not from_date:
-		if timegrain in ('Monthly', 'Quarterly'):
-			from_date = get_from_date_from_timespan(to_date, timespan)
-
-	# fetch dates to plot
-	dates = get_dates_from_timegrain(from_date, to_date, timegrain)
-
-	# get all the entries for this account and its descendants
-	gl_entries = get_gl_entries(account, get_period_ending(to_date, timegrain))
-
-	# compile balance values
-	result = build_result(account, dates, gl_entries)
-
-	return {
-		"labels": [formatdate(r[0].strftime('%Y-%m-%d')) for r in result],
-		"datasets": [{
-			"name": account,
-			"values": [r[1] for r in result]
-		}]
-	}
-
-def build_result(account, dates, gl_entries):
-	result = [[getdate(date), 0.0] for date in dates]
-	root_type = frappe.db.get_value('Account', account, 'root_type')
-
-	# start with the first date
-	date_index = 0
-
-	# get balances in debit
-	for entry in gl_entries:
-
-		# entry date is after the current pointer, so move the pointer forward
-		while getdate(entry.posting_date) > result[date_index][0]:
-			date_index += 1
-
-		result[date_index][1] += entry.debit - entry.credit
-
-	# if account type is credit, switch balances
-	if root_type not in ('Asset', 'Expense'):
-		for r in result:
-			r[1] = -1 * r[1]
-
-	# for balance sheet accounts, the totals are cumulative
-	if root_type in ('Asset', 'Liability', 'Equity'):
-		for i, r in enumerate(result):
-			if i > 0:
-				r[1] = r[1] + result[i-1][1]
-
-	return result
-
-def get_gl_entries(account, to_date):
-	child_accounts = get_descendants_of('Account', account, ignore_permissions=True)
-	child_accounts.append(account)
-
-	return frappe.db.get_all('GL Entry',
-		fields = ['posting_date', 'debit', 'credit'],
-		filters = [
-			dict(posting_date = ('<', to_date)),
-			dict(account = ('in', child_accounts)),
-			dict(voucher_type = ('!=', 'Period Closing Voucher'))
-		],
-		order_by = 'posting_date asc')
-
-def get_dates_from_timegrain(from_date, to_date, timegrain):
-	days = months = years = 0
-	if "Daily" == timegrain:
-		days = 1
-	elif "Weekly" == timegrain:
-		days = 7
-	elif "Monthly" == timegrain:
-		months = 1
-	elif "Quarterly" == timegrain:
-		months = 3
-
-	dates = [get_period_ending(from_date, timegrain)]
-	while getdate(dates[-1]) < getdate(to_date):
-		date = get_period_ending(add_to_date(dates[-1], years=years, months=months, days=days), timegrain)
-		dates.append(date)
-	return dates

erpnext/accounts/deferred_revenue.py

@@ -2,11 +2,9 @@ from __future__ import unicode_literals
 
 import frappe
 from frappe import _
-from frappe.utils import date_diff, add_months, today, getdate, add_days, flt, get_last_day, get_first_day, cint, get_link_to_form, rounded
+from frappe.utils import date_diff, add_months, today, getdate, add_days, flt, get_last_day
 from erpnext.accounts.utils import get_account_currency
 from frappe.email import sendmail_to_system_managers
-from frappe.utils.background_jobs import enqueue
-from erpnext.accounts.doctype.accounting_dimension.accounting_dimension import get_accounting_dimensions
 
 def validate_service_stop_date(doc):
 	''' Validates service_stop_date for Purchase Invoice and Sales Invoice '''
@@ -31,23 +29,11 @@ def validate_service_stop_date(doc):
 			if date_diff(item.service_stop_date, item.service_end_date) > 0:
 				frappe.throw(_("Service Stop Date cannot be after Service End Date"))
 
-		if old_stop_dates and old_stop_dates.get(item.name) and item.service_stop_date!=old_stop_dates.get(item.name):
-			frappe.throw(_("Cannot change Service Stop Date for item in row {0}").format(item.idx))
+		if old_stop_dates and old_stop_dates.get(item.name) and item.service_stop_date!=old_stop_dates[item.name]:
+			frappe.throw(_("Cannot change Service Stop Date for item in row {0}".format(item.idx)))
 
-def build_conditions(process_type, account, company):
-	conditions=''
-	deferred_account = "item.deferred_revenue_account" if process_type=="Income" else "item.deferred_expense_account"
-
-	if account:
-		conditions += "AND %s='%s'"%(deferred_account, account)
-	elif company:
-		conditions += f"AND p.company = {frappe.db.escape(company)}"
-
-	return conditions
-
-def convert_deferred_expense_to_expense(deferred_process, start_date=None, end_date=None, conditions=''):
+def convert_deferred_expense_to_expense(start_date=None, end_date=None):
 	# book the expense/income on the last day, but it will be trigger on the 1st of month at 12:00 AM
-
 	if not start_date:
 		start_date = add_months(today(), -1)
 	if not end_date:
@@ -55,25 +41,18 @@ def convert_deferred_expense_to_expense(deferred_process, start_date=None, end_d
 
 	# check for the purchase invoice for which GL entries has to be done
 	invoices = frappe.db.sql_list('''
-		select distinct item.parent
-		from `tabPurchase Invoice Item` item, `tabPurchase Invoice` p
-		where item.service_start_date<=%s and item.service_end_date>=%s
-		and item.enable_deferred_expense = 1 and item.parent=p.name
-		and item.docstatus = 1 and ifnull(item.amount, 0) > 0
-		{0}
-	'''.format(conditions), (end_date, start_date)) #nosec
+		select distinct parent from `tabPurchase Invoice Item`
+		where service_start_date<=%s and service_end_date>=%s
+		and enable_deferred_expense = 1 and docstatus = 1 and ifnull(amount, 0) > 0
+	''', (end_date, start_date))
 
 	# For each invoice, book deferred expense
 	for invoice in invoices:
 		doc = frappe.get_doc("Purchase Invoice", invoice)
-		book_deferred_income_or_expense(doc, deferred_process, end_date)
+		book_deferred_income_or_expense(doc, end_date)
 
-	if frappe.flags.deferred_accounting_error:
-		send_mail(deferred_process)
-
-def convert_deferred_revenue_to_income(deferred_process, start_date=None, end_date=None, conditions=''):
+def convert_deferred_revenue_to_income(start_date=None, end_date=None):
 	# book the expense/income on the last day, but it will be trigger on the 1st of month at 12:00 AM
-
 	if not start_date:
 		start_date = add_months(today(), -1)
 	if not end_date:
@@ -81,20 +60,14 @@ def convert_deferred_revenue_to_income(deferred_process, start_date=None, end_da
 
 	# check for the sales invoice for which GL entries has to be done
 	invoices = frappe.db.sql_list('''
-		select distinct item.parent
-		from `tabSales Invoice Item` item, `tabSales Invoice` p
-		where item.service_start_date<=%s and item.service_end_date>=%s
-		and item.enable_deferred_revenue = 1 and item.parent=p.name
-		and item.docstatus = 1 and ifnull(item.amount, 0) > 0
-		{0}
-	'''.format(conditions), (end_date, start_date)) #nosec
+		select distinct parent from `tabSales Invoice Item`
+		where service_start_date<=%s and service_end_date>=%s
+		and enable_deferred_revenue = 1 and docstatus = 1 and ifnull(amount, 0) > 0
+	''', (end_date, start_date))
 
 	for invoice in invoices:
 		doc = frappe.get_doc("Sales Invoice", invoice)
-		book_deferred_income_or_expense(doc, deferred_process, end_date)
-
-	if frappe.flags.deferred_accounting_error:
-		send_mail(deferred_process)
+		book_deferred_income_or_expense(doc, end_date)
 
 def get_booking_dates(doc, item, posting_date=None):
 	if not posting_date:
@@ -110,18 +83,6 @@ def get_booking_dates(doc, item, posting_date=None):
 		order by posting_date desc limit 1
 	''', (doc.company, item.get(deferred_account), doc.doctype, doc.name, item.name), as_dict=True)
 
-	prev_gl_via_je = frappe.db.sql('''
-		SELECT p.name, p.posting_date FROM `tabJournal Entry` p, `tabJournal Entry Account` c
-		WHERE p.name = c.parent and p.company=%s and c.account=%s
-		and c.reference_type=%s and c.reference_name=%s
-		and c.reference_detail_no=%s and c.docstatus < 2 order by posting_date desc limit 1
-	''', (doc.company, item.get(deferred_account), doc.doctype, doc.name, item.name), as_dict=True)
-
-	if prev_gl_via_je:
-		if (not prev_gl_entry) or (prev_gl_entry and
-			prev_gl_entry[0].posting_date < prev_gl_via_je[0].posting_date):
-			prev_gl_entry = prev_gl_via_je
-
 	if prev_gl_entry:
 		start_date = getdate(add_days(prev_gl_entry[0].posting_date, 1))
 	else:
@@ -143,48 +104,14 @@ def get_booking_dates(doc, item, posting_date=None):
 	else:
 		return None, None, None
 
-def calculate_monthly_amount(doc, item, last_gl_entry, start_date, end_date, total_days, total_booking_days, account_currency):
-	amount, base_amount = 0, 0
-
-	if not last_gl_entry:
-		total_months = (item.service_end_date.year - item.service_start_date.year) * 12 + \
-			(item.service_end_date.month - item.service_start_date.month) + 1
-
-		prorate_factor = flt(date_diff(item.service_end_date, item.service_start_date)) \
-			/ flt(date_diff(get_last_day(item.service_end_date), get_first_day(item.service_start_date)))
-
-		actual_months = rounded(total_months * prorate_factor, 1)
-
-		already_booked_amount, already_booked_amount_in_account_currency = get_already_booked_amount(doc, item)
-		base_amount = flt(item.base_net_amount / actual_months, item.precision("base_net_amount"))
-
-		if base_amount + already_booked_amount > item.base_net_amount:
-			base_amount = item.base_net_amount - already_booked_amount
-
-		if account_currency==doc.company_currency:
-			amount = base_amount
-		else:
-			amount = flt(item.net_amount/actual_months, item.precision("net_amount"))
-			if amount + already_booked_amount_in_account_currency > item.net_amount:
-				amount = item.net_amount - already_booked_amount_in_account_currency
-
-		if not (get_first_day(start_date) == start_date and get_last_day(end_date) == end_date):
-			partial_month = flt(date_diff(end_date, start_date)) \
-				/ flt(date_diff(get_last_day(end_date), get_first_day(start_date)))
-
-			base_amount = rounded(partial_month, 1) * base_amount
-			amount = rounded(partial_month, 1) * amount
-	else:
-		already_booked_amount, already_booked_amount_in_account_currency = get_already_booked_amount(doc, item)
-		base_amount = flt(item.base_net_amount - already_booked_amount, item.precision("base_net_amount"))
-		if account_currency==doc.company_currency:
-			amount = base_amount
-		else:
-			amount = flt(item.net_amount - already_booked_amount_in_account_currency, item.precision("net_amount"))
-
-	return amount, base_amount
-
 def calculate_amount(doc, item, last_gl_entry, total_days, total_booking_days, account_currency):
+	if doc.doctype == "Sales Invoice":
+		total_credit_debit, total_credit_debit_currency = "debit", "debit_in_account_currency"
+		deferred_account = "deferred_revenue_account"
+	else:
+		total_credit_debit, total_credit_debit_currency = "credit", "credit_in_account_currency"
+		deferred_account = "deferred_expense_account"
+
 	amount, base_amount = 0, 0
 	if not last_gl_entry:
 		base_amount = flt(item.base_net_amount*total_booking_days/flt(total_days), item.precision("base_net_amount"))
@@ -193,55 +120,27 @@ def calculate_amount(doc, item, last_gl_entry, total_days, total_booking_days, a
 		else:
 			amount = flt(item.net_amount*total_booking_days/flt(total_days), item.precision("net_amount"))
 	else:
-		already_booked_amount, already_booked_amount_in_account_currency = get_already_booked_amount(doc, item)
-
+		gl_entries_details = frappe.db.sql('''
+			select sum({0}) as total_credit, sum({1}) as total_credit_in_account_currency, voucher_detail_no
+			from `tabGL Entry` where company=%s and account=%s and voucher_type=%s and voucher_no=%s and voucher_detail_no=%s
+			group by voucher_detail_no
+		'''.format(total_credit_debit, total_credit_debit_currency),
+			(doc.company, item.get(deferred_account), doc.doctype, doc.name, item.name), as_dict=True)
+		already_booked_amount = gl_entries_details[0].total_credit if gl_entries_details else 0
 		base_amount = flt(item.base_net_amount - already_booked_amount, item.precision("base_net_amount"))
 		if account_currency==doc.company_currency:
 			amount = base_amount
 		else:
+			already_booked_amount_in_account_currency = gl_entries_details[0].total_credit_in_account_currency if gl_entries_details else 0
 			amount = flt(item.net_amount - already_booked_amount_in_account_currency, item.precision("net_amount"))
 
 	return amount, base_amount
 
-def get_already_booked_amount(doc, item):
-	if doc.doctype == "Sales Invoice":
-		total_credit_debit, total_credit_debit_currency = "debit", "debit_in_account_currency"
-		deferred_account = "deferred_revenue_account"
-	else:
-		total_credit_debit, total_credit_debit_currency = "credit", "credit_in_account_currency"
-		deferred_account = "deferred_expense_account"
-
-	gl_entries_details = frappe.db.sql('''
-		select sum({0}) as total_credit, sum({1}) as total_credit_in_account_currency, voucher_detail_no
-		from `tabGL Entry` where company=%s and account=%s and voucher_type=%s and voucher_no=%s and voucher_detail_no=%s
-		group by voucher_detail_no
-	'''.format(total_credit_debit, total_credit_debit_currency),
-		(doc.company, item.get(deferred_account), doc.doctype, doc.name, item.name), as_dict=True)
-
-	journal_entry_details = frappe.db.sql('''
-		SELECT sum(c.{0}) as total_credit, sum(c.{1}) as total_credit_in_account_currency, reference_detail_no
-		FROM `tabJournal Entry` p , `tabJournal Entry Account` c WHERE p.name = c.parent and
-		p.company = %s and c.account=%s and c.reference_type=%s and c.reference_name=%s and c.reference_detail_no=%s
-		and p.docstatus < 2 group by reference_detail_no
-	'''.format(total_credit_debit, total_credit_debit_currency),
-		(doc.company, item.get(deferred_account), doc.doctype, doc.name, item.name), as_dict=True)
-
-	already_booked_amount = gl_entries_details[0].total_credit if gl_entries_details else 0
-	already_booked_amount += journal_entry_details[0].total_credit if journal_entry_details else 0
-
-	if doc.currency == doc.company_currency:
-		already_booked_amount_in_account_currency = already_booked_amount
-	else:
-		already_booked_amount_in_account_currency = gl_entries_details[0].total_credit_in_account_currency if gl_entries_details else 0
-		already_booked_amount_in_account_currency += journal_entry_details[0].total_credit_in_account_currency if journal_entry_details else 0
-
-	return already_booked_amount, already_booked_amount_in_account_currency
-
-def book_deferred_income_or_expense(doc, deferred_process, posting_date=None):
+def book_deferred_income_or_expense(doc, posting_date=None):
 	enable_check = "enable_deferred_revenue" \
 		if doc.doctype=="Sales Invoice" else "enable_deferred_expense"
 
-	def _book_deferred_revenue_or_expense(item, via_journal_entry, submit_journal_entry, book_deferred_entries_based_on):
+	def _book_deferred_revenue_or_expense(item):
 		start_date, end_date, last_gl_entry = get_booking_dates(doc, item, posting_date=posting_date)
 		if not (start_date and end_date): return
 
@@ -256,67 +155,25 @@ def book_deferred_income_or_expense(doc, deferred_process, posting_date=None):
 		total_days = date_diff(item.service_end_date, item.service_start_date) + 1
 		total_booking_days = date_diff(end_date, start_date) + 1
 
-		if book_deferred_entries_based_on == 'Months':
-			amount, base_amount = calculate_monthly_amount(doc, item, last_gl_entry,
-				start_date, end_date, total_days, total_booking_days, account_currency)
-		else:
-			amount, base_amount = calculate_amount(doc, item, last_gl_entry,
-				total_days, total_booking_days, account_currency)
+		amount, base_amount = calculate_amount(doc, item, last_gl_entry,
+			total_days, total_booking_days, account_currency)
 
-		if via_journal_entry:
-			book_revenue_via_journal_entry(doc, credit_account, debit_account, against, amount,
-				base_amount, end_date, project, account_currency, item.cost_center, item, deferred_process, submit_journal_entry)
-		else:
-			make_gl_entries(doc, credit_account, debit_account, against,
-				amount, base_amount, end_date, project, account_currency, item.cost_center, item, deferred_process)
-
-		# Returned in case of any errors because it tries to submit the same record again and again in case of errors
-		if frappe.flags.deferred_accounting_error:
-			return
+		make_gl_entries(doc, credit_account, debit_account, against,
+			amount, base_amount, end_date, project, account_currency, item.cost_center, item.name)
 
 		if getdate(end_date) < getdate(posting_date) and not last_gl_entry:
-			_book_deferred_revenue_or_expense(item, via_journal_entry, submit_journal_entry, book_deferred_entries_based_on)
+			_book_deferred_revenue_or_expense(item)
 
-	via_journal_entry = cint(frappe.db.get_singles_value('Accounts Settings', 'book_deferred_entries_via_journal_entry'))
-	submit_journal_entry = cint(frappe.db.get_singles_value('Accounts Settings', 'submit_journal_entries'))
-	book_deferred_entries_based_on = frappe.db.get_singles_value('Accounts Settings', 'book_deferred_entries_based_on')
 
 	for item in doc.get('items'):
 		if item.get(enable_check):
-			_book_deferred_revenue_or_expense(item, via_journal_entry, submit_journal_entry, book_deferred_entries_based_on)
-
-def process_deferred_accounting(posting_date=None):
-	''' Converts deferred income/expense into income/expense
-		Executed via background jobs on every month end '''
-
-	if not posting_date:
-		posting_date = today()
-
-	if not cint(frappe.db.get_singles_value('Accounts Settings', 'automatically_process_deferred_accounting_entry')):
-		return
-
-	start_date = add_months(today(), -1)
-	end_date = add_days(today(), -1)
-
-	for record_type in ('Income', 'Expense'):
-		doc = frappe.get_doc(dict(
-			doctype='Process Deferred Accounting',
-			posting_date=posting_date,
-			start_date=start_date,
-			end_date=end_date,
-			type=record_type
-		))
-
-		doc.insert()
-		doc.submit()
+			_book_deferred_revenue_or_expense(item)
 
 def make_gl_entries(doc, credit_account, debit_account, against,
-	amount, base_amount, posting_date, project, account_currency, cost_center, item, deferred_process=None):
+	amount, base_amount, posting_date, project, account_currency, cost_center, voucher_detail_no):
 	# GL Entry for crediting the amount in the deferred expense
 	from erpnext.accounts.general_ledger import make_gl_entries
 
-	if amount == 0: return
-
 	gl_entries = []
 	gl_entries.append(
 		doc.get_gl_dict({
@@ -325,12 +182,10 @@ def make_gl_entries(doc, credit_account, debit_account, against,
 			"credit": base_amount,
 			"credit_in_account_currency": amount,
 			"cost_center": cost_center,
-			"voucher_detail_no": item.name,
+			"voucher_detail_no": voucher_detail_no,
 			'posting_date': posting_date,
-			'project': project,
-			'against_voucher_type': 'Process Deferred Accounting',
-			'against_voucher': deferred_process
-		}, account_currency, item=item)
+			'project': project
+		}, account_currency)
 	)
 	# GL Entry to debit the amount from the expense
 	gl_entries.append(
@@ -340,12 +195,10 @@ def make_gl_entries(doc, credit_account, debit_account, against,
 			"debit": base_amount,
 			"debit_in_account_currency": amount,
 			"cost_center": cost_center,
-			"voucher_detail_no": item.name,
+			"voucher_detail_no": voucher_detail_no,
 			'posting_date': posting_date,
-			'project': project,
-			'against_voucher_type': 'Process Deferred Accounting',
-			'against_voucher': deferred_process
-		}, account_currency, item=item)
+			'project': project
+		}, account_currency)
 	)
 
 	if gl_entries:
@@ -354,94 +207,7 @@ def make_gl_entries(doc, credit_account, debit_account, against,
 			frappe.db.commit()
 		except:
 			frappe.db.rollback()
+			title = _("Error while processing deferred accounting for {0}").format(doc.name)
 			traceback = frappe.get_traceback()
-			frappe.log_error(message=traceback)
-
-			frappe.flags.deferred_accounting_error = True
-
-def send_mail(deferred_process):
-	title = _("Error while processing deferred accounting for {0}").format(deferred_process)
-	link = get_link_to_form('Process Deferred Accounting', deferred_process)
-	content = _("Deferred accounting failed for some invoices:") + "\n"
-	content += _("Please check Process Deferred Accounting {0} and submit manually after resolving errors.").format(link)
-	sendmail_to_system_managers(title, content)
-
-def book_revenue_via_journal_entry(doc, credit_account, debit_account, against,
-	amount, base_amount, posting_date, project, account_currency, cost_center, item,
-	deferred_process=None, submit='No'):
-
-	if amount == 0: return
-
-	journal_entry = frappe.new_doc('Journal Entry')
-	journal_entry.posting_date = posting_date
-	journal_entry.company = doc.company
-	journal_entry.voucher_type = 'Deferred Revenue' if doc.doctype == 'Sales Invoice' \
-		else 'Deferred Expense'
-
-	debit_entry = {
-		'account': credit_account,
-		'credit': base_amount,
-		'credit_in_account_currency': amount,
-		'party_type': 'Customer' if doc.doctype == 'Sales Invoice' else 'Supplier',
-		'party': against,
-		'account_currency': account_currency,
-		'reference_name': doc.name,
-		'reference_type': doc.doctype,
-		'reference_detail_no': item.name,
-		'cost_center': cost_center,
-		'project': project,
-	}
-
-	credit_entry = {
-		'account': debit_account,
-		'debit': base_amount,
-		'debit_in_account_currency': amount,
-		'party_type': 'Customer' if doc.doctype == 'Sales Invoice' else 'Supplier',
-		'party': against,
-		'account_currency': account_currency,
-		'reference_name': doc.name,
-		'reference_type': doc.doctype,
-		'reference_detail_no': item.name,
-		'cost_center': cost_center,
-		'project': project,
-	}
-
-	for dimension in get_accounting_dimensions():
-		debit_entry.update({
-			dimension: item.get(dimension)
-		})
-
-		credit_entry.update({
-			dimension: item.get(dimension)
-		})
-
-	journal_entry.append('accounts', debit_entry)
-	journal_entry.append('accounts', credit_entry)
-
-	try:
-		journal_entry.save()
-
-		if submit:
-			journal_entry.submit()
-	except:
-		frappe.db.rollback()
-		traceback = frappe.get_traceback()
-		frappe.log_error(message=traceback)
-
-		frappe.flags.deferred_accounting_error = True
-
-def get_deferred_booking_accounts(doctype, voucher_detail_no, dr_or_cr):
-
-	if doctype == 'Sales Invoice':
-		credit_account, debit_account = frappe.db.get_value('Sales Invoice Item', {'name': voucher_detail_no},
-			['income_account', 'deferred_revenue_account'])
-	else:
-		credit_account, debit_account = frappe.db.get_value('Purchase Invoice Item', {'name': voucher_detail_no},
-			['deferred_expense_account', 'expense_account'])
-
-	if dr_or_cr == 'Debit':
-		return debit_account
-	else:
-		return credit_account
-
-
+			frappe.log_error(message=traceback , title=title)
+			sendmail_to_system_managers(title, traceback)

erpnext/accounts/doctype/account/account.js

@@ -42,14 +42,15 @@ frappe.ui.form.on('Account', {
 				// show / hide convert buttons
 				frm.trigger('add_toolbar_buttons');
 			}
-			if (frm.has_perm('write')) {
-				frm.add_custom_button(__('Update Account Name / Number'), function () {
-					frm.trigger("update_account_number");
-				});
-				frm.add_custom_button(__('Merge Account'), function () {
-					frm.trigger("merge_account");
-				});
-			}
+			frm.add_custom_button(__('Update Account Name / Number'), function () {
+				frm.trigger("update_account_number");
+			});
+		}
+
+		if(!frm.doc.__islocal) {
+			frm.add_custom_button(__('Merge Account'), function () {
+				frm.trigger("merge_account");
+			});
 		}
 	},
 	account_type: function (frm) {

erpnext/accounts/doctype/account/account.py

@@ -13,7 +13,7 @@ class BalanceMismatchError(frappe.ValidationError): pass
 class Account(NestedSet):
 	nsm_parent_field = 'parent_account'
 	def on_update(self):
-		if frappe.local.flags.ignore_update_nsm:
+		if frappe.local.flags.ignore_on_update:
 			return
 		else:
 			super(Account, self).on_update()
@@ -89,38 +89,39 @@ class Account(NestedSet):
 				throw(_("Root cannot be edited."), RootNotEditable)
 
 		if not self.parent_account and not self.is_group:
-			frappe.throw(_("The root account {0} must be a group").format(frappe.bold(self.name)))
+			frappe.throw(_("Root Account must be a group"))
 
 	def validate_root_company_and_sync_account_to_children(self):
 		# ignore validation while creating new compnay or while syncing to child companies
 		if frappe.local.flags.ignore_root_company_validation or self.flags.ignore_root_company_validation:
 			return
+
 		ancestors = get_root_company(self.company)
 		if ancestors:
 			if frappe.get_value("Company", self.company, "allow_account_creation_against_child_company"):
 				return
-			if not frappe.db.get_value("Account",
-				{'account_name': self.account_name, 'company': ancestors[0]}, 'name'):
-				frappe.throw(_("Please add the account to root level Company - {}").format(ancestors[0]))
-		elif self.parent_account:
+			frappe.throw(_("Please add the account to root level Company - %s" % ancestors[0]))
+		else:
 			descendants = get_descendants_of('Company', self.company)
 			if not descendants: return
-			parent_acc_name_map = {}
-			parent_acc_name, parent_acc_number = frappe.db.get_value('Account', self.parent_account, \
-				["account_name", "account_number"])
-			filters = {
-				"company": ["in", descendants],
-				"account_name": parent_acc_name,
-			}
-			if parent_acc_number:
-				filters["account_number"] = parent_acc_number
 
-			for d in frappe.db.get_values('Account', filters=filters, fieldname=["company", "name"], as_dict=True):
-				parent_acc_name_map[d["company"]] = d["name"]
+			acc_name_map = {}
+			acc_name = frappe.db.get_value('Account', self.parent_account, "account_name")
+			for d in frappe.db.get_values('Account',
+				{"company": ["in", descendants], "account_name": acc_name},
+				["company", "name"], as_dict=True):
+				acc_name_map[d["company"]] = d["name"]
 
-			if not parent_acc_name_map: return
+			if not acc_name_map: return
 
-			self.create_account_for_child_company(parent_acc_name_map, descendants, parent_acc_name)
+			for company in descendants:
+				doc = frappe.copy_doc(self)
+				doc.flags.ignore_root_company_validation = True
+				doc.update({"company": company, "account_currency": None,
+					"parent": acc_name_map[company], "parent_account": acc_name_map[company]})
+				doc.save()
+				frappe.msgprint(_("Account {0} is added in the child company {1}")
+					.format(doc.name, company))
 
 	def validate_group_or_ledger(self):
 		if self.get("__islocal"):
@@ -162,59 +163,6 @@ class Account(NestedSet):
 			if frappe.db.get_value("GL Entry", {"account": self.name}):
 				frappe.throw(_("Currency can not be changed after making entries using some other currency"))
 
-	def create_account_for_child_company(self, parent_acc_name_map, descendants, parent_acc_name):
-		for company in descendants:
-			company_bold = frappe.bold(company)
-			parent_acc_name_bold = frappe.bold(parent_acc_name)
-			if not parent_acc_name_map.get(company):
-				frappe.throw(_("While creating account for Child Company {0}, parent account {1} not found. Please create the parent account in corresponding COA")
-					.format(company_bold, parent_acc_name_bold), title=_("Account Not Found"))
-
-			# validate if parent of child company account to be added is a group
-			if (frappe.db.get_value("Account", self.parent_account, "is_group")
-				and not frappe.db.get_value("Account", parent_acc_name_map[company], "is_group")):
-				msg = _("While creating account for Child Company {0}, parent account {1} found as a ledger account.").format(company_bold, parent_acc_name_bold)
-				msg += "<br><br>"
-				msg += _("Please convert the parent account in corresponding child company to a group account.")
-				frappe.throw(msg, title=_("Invalid Parent Account"))
-
-			filters = {
-				"account_name": self.account_name,
-				"company": company
-			}
-
-			if self.account_number:
-				filters["account_number"] = self.account_number
-
-			child_account = frappe.db.get_value("Account", filters, 'name')
-			if not child_account:
-				doc = frappe.copy_doc(self)
-				doc.flags.ignore_root_company_validation = True
-				doc.update({
-					"company": company,
-					# parent account's currency should be passed down to child account's curreny
-					# if it is None, it picks it up from default company currency, which might be unintended
-					"account_currency": self.account_currency,
-					"parent_account": parent_acc_name_map[company]
-				})
-
-				doc.save()
-				frappe.msgprint(_("Account {0} is added in the child company {1}")
-					.format(doc.name, company))
-			elif child_account:
-				# update the parent company's value in child companies
-				doc = frappe.get_doc("Account", child_account)
-				parent_value_changed = False
-				for field in ['account_type', 'account_currency',
-					'freeze_account', 'balance_must_be']:
-					if doc.get(field) != self.get(field):
-						parent_value_changed = True
-						doc.set(field, self.get(field))
-
-				if parent_value_changed:
-					doc.save()
-
-	@frappe.whitelist()
 	def convert_group_to_ledger(self):
 		if self.check_if_child_exists():
 			throw(_("Account with child nodes cannot be converted to ledger"))
@@ -225,7 +173,6 @@ class Account(NestedSet):
 			self.save()
 			return 1
 
-	@frappe.whitelist()
 	def convert_ledger_to_group(self):
 		if self.check_gle_exists():
 			throw(_("Account with existing transaction can not be converted to group."))
@@ -258,8 +205,6 @@ class Account(NestedSet):
 
 		super(Account, self).on_trash(True)
 
-@frappe.whitelist()
-@frappe.validate_and_sanitize_search_inputs
 def get_parent_account(doctype, txt, searchfield, start, page_len, filters):
 	return frappe.db.sql("""select name from tabAccount
 		where is_group = 1 and docstatus != 2 and company = %s
@@ -303,31 +248,10 @@ def validate_account_number(name, account_number, company):
 				.format(account_number, account_with_same_number))
 
 @frappe.whitelist()
-def update_account_number(name, account_name, account_number=None, from_descendant=False):
+def update_account_number(name, account_name, account_number=None):
+
 	account = frappe.db.get_value("Account", name, "company", as_dict=True)
 	if not account: return
-
-	old_acc_name, old_acc_number = frappe.db.get_value('Account', name, \
-				["account_name", "account_number"])
-
-	# check if account exists in parent company
-	ancestors = get_ancestors_of("Company", account.company)
-	allow_independent_account_creation = frappe.get_value("Company", account.company, "allow_account_creation_against_child_company")
-
-	if ancestors and not allow_independent_account_creation:
-		for ancestor in ancestors:
-			if frappe.db.get_value("Account", {'account_name': old_acc_name, 'company': ancestor}, 'name'):
-				# same account in parent company exists
-				allow_child_account_creation = _("Allow Account Creation Against Child Company")
-
-				message = _("Account {0} exists in parent company {1}.").format(frappe.bold(old_acc_name), frappe.bold(ancestor))
-				message += "<br>"
-				message += _("Renaming it is only allowed via parent company {0}, to avoid mismatch.").format(frappe.bold(ancestor))
-				message += "<br><br>"
-				message += _("To overrule this, enable '{0}' in company {1}").format(allow_child_account_creation, frappe.bold(account.company))
-
-				frappe.throw(message, title=_("Rename Not Allowed"))
-
 	validate_account_number(name, account_number, account.company)
 	if account_number:
 		frappe.db.set_value("Account", name, "account_number", account_number.strip())
@@ -335,15 +259,9 @@ def update_account_number(name, account_name, account_number=None, from_descenda
 		frappe.db.set_value("Account", name, "account_number", "")
 	frappe.db.set_value("Account", name, "account_name", account_name.strip())
 
-	if not from_descendant:
-		# Update and rename in child company accounts as well
-		descendants = get_descendants_of('Company', account.company)
-		if descendants:
-			sync_update_account_number_in_child(descendants, old_acc_name, account_name, account_number, old_acc_number)
-
 	new_name = get_account_autoname(account_number, account_name, account.company)
 	if name != new_name:
-		frappe.rename_doc("Account", name, new_name, force=1)
+		frappe.rename_doc("Account", name, new_name, ignore_permissions=1)
 		return new_name
 
 @frappe.whitelist()
@@ -362,7 +280,7 @@ def merge_account(old, new, is_group, root_type, company):
 		frappe.db.set_value("Account", new, "parent_account",
 			frappe.db.get_value("Account", old, "parent_account"))
 
-	frappe.rename_doc("Account", old, new, merge=1, force=1)
+	frappe.rename_doc("Account", old, new, merge=1, ignore_permissions=1)
 
 	return new
 
@@ -371,14 +289,3 @@ def get_root_company(company):
 	# return the topmost company in the hierarchy
 	ancestors = get_ancestors_of('Company', company, "lft asc")
 	return [ancestors[0]] if ancestors else []
-
-def sync_update_account_number_in_child(descendants, old_acc_name, account_name, account_number=None, old_acc_number=None):
-	filters = {
-		"company": ["in", descendants],
-		"account_name": old_acc_name,
-	}
-	if old_acc_number:
-		filters["account_number"] = old_acc_number
-
-	for d in frappe.db.get_values('Account', filters=filters, fieldname=["company", "name"], as_dict=True):
-			update_account_number(d["name"], account_name, account_number, from_descendant=True)

erpnext/accounts/doctype/account/account_tree.js

@@ -1,8 +1,8 @@
 frappe.provide("frappe.treeview_settings")
 
 frappe.treeview_settings["Account"] = {
-	breadcrumb: "Accounts",
-	title: __("Chart of Accounts"),
+	breadcrumbs: "Accounts",
+	title: __("Chart Of Accounts"),
 	get_tree_root: false,
 	filters: [
 		{
@@ -14,9 +14,6 @@ frappe.treeview_settings["Account"] = {
 			on_change: function() {
 				var me = frappe.treeview_settings['Account'].treeview;
 				var company = me.page.fields_dict.company.get_value();
-				if (!company) {
-					frappe.throw(__("Please set a Company"));
-				}
 				frappe.call({
 					method: "erpnext.accounts.doctype.account.account.get_root_company",
 					args: {
@@ -93,13 +90,13 @@ frappe.treeview_settings["Account"] = {
 			frappe.set_route('List', 'Period Closing Voucher', {company: get_company()});
 		}, __('View'));
 
-
+		// make
 		treeview.page.add_inner_button(__("Journal Entry"), function() {
 			frappe.new_doc('Journal Entry', {company: get_company()});
-		}, __('Create'));
-		treeview.page.add_inner_button(__("Company"), function() {
+		}, __('Make'));
+		treeview.page.add_inner_button(__("New Company"), function() {
 			frappe.new_doc('Company');
-		}, __('Create'));
+		}, __('Make'));
 
 		// financial statements
 		for (let report of ['Trial Balance', 'General Ledger', 'Balance Sheet',
@@ -120,17 +117,13 @@ frappe.treeview_settings["Account"] = {
 			} else {
 				treeview.new_node();
 			}
-		}, "add");
+		}, "octicon octicon-plus");
 	},
 	onrender: function(node) {
-		if (frappe.boot.user.can_read.indexOf("GL Entry") !== -1) {
-
-			// show Dr if positive since balance is calculated as debit - credit else show Cr
-			let balance = node.data.balance_in_account_currency || node.data.balance;
-			let dr_or_cr = balance > 0 ? "Dr": "Cr";
-
+		if(frappe.boot.user.can_read.indexOf("GL Entry") !== -1){
+			var dr_or_cr = node.data.balance < 0 ? "Cr" : "Dr";
 			if (node.data && node.data.balance!==undefined) {
-				$('<span class="balance-area pull-right">'
+				$('<span class="balance-area pull-right text-muted small">'
 					+ (node.data.balance_in_account_currency ?
 						(format_currency(Math.abs(node.data.balance_in_account_currency),
 							node.data.account_currency) + " / ") : "")

erpnext/accounts/doctype/account/chart_of_accounts/chart_of_accounts.py

@@ -9,8 +9,8 @@ from unidecode import unidecode
 from six import iteritems
 from frappe.utils.nestedset import rebuild_tree
 
-def create_charts(company, chart_template=None, existing_company=None, custom_chart=None):
-	chart = custom_chart or get_chart(chart_template, existing_company)
+def create_charts(company, chart_template=None, existing_company=None):
+	chart = get_chart(chart_template, existing_company)
 	if chart:
 		accounts = []
 
@@ -40,7 +40,7 @@ def create_charts(company, chart_template=None, existing_company=None, custom_ch
 						"report_type": report_type,
 						"account_number": account_number,
 						"account_type": child.get("account_type"),
-						"account_currency": child.get('account_currency') or frappe.db.get_value('Company',  company,  "default_currency"),
+						"account_currency": frappe.db.get_value('Company',  company,  "default_currency"),
 						"tax_rate": child.get("tax_rate")
 					})
 
@@ -57,10 +57,10 @@ def create_charts(company, chart_template=None, existing_company=None, custom_ch
 
 		# Rebuild NestedSet HSM tree for Account Doctype
 		# after all accounts are already inserted.
-		frappe.local.flags.ignore_update_nsm = True
+		frappe.local.flags.ignore_on_update = True
 		_import_accounts(chart, None, None, root_account=True)
 		rebuild_tree("Account", "parent_account")
-		frappe.local.flags.ignore_update_nsm = False
+		frappe.local.flags.ignore_on_update = False
 
 def add_suffix_if_duplicate(account_name, account_number, accounts):
 	if account_number:
@@ -207,9 +207,9 @@ def validate_bank_account(coa, bank_account):
 	return (bank_account in accounts)
 
 @frappe.whitelist()
-def build_tree_from_json(chart_template, chart_data=None):
+def build_tree_from_json(chart_template):
 	''' get chart template from its folder and parse the json to be rendered as tree '''
-	chart = chart_data or get_chart(chart_template)
+	chart = get_chart(chart_template)
 
 	# if no template selected, return as it is
 	if not chart:
@@ -225,7 +225,7 @@ def build_tree_from_json(chart_template, chart_data=None):
 
 			account['parent_account'] = parent
 			account['expandable'] = True if identify_is_group(child) else False
-			account['value'] = (cstr(child.get('account_number')).strip() + ' - ' + account_name) \
+			account['value'] = (child.get('account_number') + ' - ' + account_name) \
 				if child.get('account_number') else account_name
 			accounts.append(account)
 			_import_accounts(child, account['value'])

erpnext/accounts/doctype/account/chart_of_accounts/verified/ae_uae_chart_template_standard.json

@@ -1,466 +1,465 @@
 {
-    "country_code": "ae",
-    "name": "U.A.E - Chart of Accounts",
+    "country_code": "ae", 
+    "name": "U.A.E - Chart of Accounts", 
     "tree": {
         "Assets": {
             "Current Assets": {
                 "Accounts Receivable": {
                     "Corporate Credit Cards": {
                         "account_type": "Receivable"
-                    },
+                    }, 
                     "Other Receivable": {
                         "Accrued Rebates Due from Suppliers": {
                             "account_type": "Receivable"
-                        },
-                        "Accrued Income from Suppliers": {
+                        }, 
+                        "Accured Income from Suppliers": {
                             "account_type": "Receivable"
-                        },
+                        }, 
                         "Other Debtors": {
                             "account_type": "Receivable"
-                        },
+                        }, 
                         "account_type": "Receivable"
-                    },
+                    }, 
                     "Post Dated Cheques Received": {
                         "account_type": "Receivable"
-                    },
+                    }, 
                     "Staff Receivable": {
                         "account_type": "Receivable"
-                    },
+                    }, 
                     "Trade Receivable": {
                         "account_type": "Receivable"
-                    },
+                    }, 
                     "Trade in Opening Fees": {
                         "account_type": "Receivable"
-                    },
+                    }, 
                     "account_type": "Receivable"
-                },
+                }, 
                 "Cash in Hand & Banks": {
                     "Banks": {
-                        "Bank Margin On LC & LG": {},
-                        "Banks Blocked Deposits": {},
-                        "Banks Call Deposit Accounts": {},
+                        "Bank Margin On LC & LG": {}, 
+                        "Banks Blocked Deposits": {}, 
+                        "Banks Call Deposit Accounts": {}, 
                         "Banks Current Accounts": {
                             "account_type": "Bank"
-                        },
+                        }, 
                         "account_type": "Bank"
-                    },
+                    }, 
                     "Cash in Hand": {
                         "Cash in Safe": {
                             "Main Safe": {
                                 "account_type": "Cash"
-                            },
+                            }, 
                             "Main Safe - Foreign Currency": {
                                 "account_type": "Cash"
                             }
-                        },
+                        }, 
                         "Petty Cash": {
-                            "Petty Cash - Administration": {
+                            "Petty Cash - Admininistration": {
                                 "account_type": "Cash"
-                            },
+                            }, 
                             "Petty Cash - Others": {
                                 "account_type": "Cash"
                             }
-                        },
+                        }, 
                         "account_type": "Cash"
-                    },
+                    }, 
                     "Cash in Transit": {
                         "Credit Cards": {
                             "Gateway Credit Cards": {
                                 "account_type": "Bank"
-                            },
+                            }, 
                             "Manual Visa & Master Cards": {
                                 "account_type": "Bank"
-                            },
+                            }, 
                             "PayPal Account": {
                                 "account_type": "Bank"
-                            },
+                            }, 
                             "Visa & Master Credit Cards": {
                                 "account_type": "Bank"
                             }
                         }
                     }
-                },
+                }, 
                 "Inventory": {
                     "Consigned Stock": {
-                        "Handling Difference in Inventory": {},
-                        "Items Delivered to Customs on temporary Base": {}
-                    },
+                        "Handling Difference in Inventory": {
+                            "account_type": "Stock Adjustment"
+                        }, 
+                        "Items Delivered to Customs on temprary Base": {}
+                    }, 
                     "Stock in Hand": {
                         "account_type": "Stock"
                     }
-                },
-                "Preliminary and Preoperating Expenses": {
+                }, 
+                "Perliminary and Preoperating Expenses": {
                     "Preoperating Expenses": {}
-                },
+                }, 
                 "Prepayments & Deposits": {
                     "Deposits": {
-                        "Deposit - Office Rent": {},
-                        "Deposit Others": {},
-                        "Deposit to Immigration (Visa)": {},
+                        "Deposit - Office Rent": {}, 
+                        "Deposit Others": {}, 
+                        "Deposit to Immigration (Visa)": {}, 
                         "Deposits - Customs": {}
-                    },
+                    }, 
                     "Prepaid Taxes": {
-                        "Sales Taxes Receivables": {},
+                        "Sales Taxes Receivables": {}, 
                         "Withholding Tax Receivables": {}
-                    },
+                    }, 
                     "Prepayments": {
-                        "Other Prepayments": {},
-                        "PrePaid Advertisement Expenses": {},
-                        "Prepaid Bank Guarantee": {},
-                        "Prepaid Consultancy Fees": {},
-                        "Prepaid Employees Housing": {},
-                        "Prepaid Finance charge for Loans": {},
-                        "Prepaid Legal Fees": {},
-                        "Prepaid License Fees": {},
-                        "Prepaid Life Insurance": {},
-                        "Prepaid Maintenance": {},
-                        "Prepaid Medical Insurance": {},
-                        "Prepaid Office Rent": {},
-                        "Prepaid Other Insurance": {},
-                        "Prepaid Schooling Fees": {},
-                        "Prepaid Site Hosting Fees": {},
+                        "Other Prepayments": {}, 
+                        "PrePaid Advertisement Expenses": {}, 
+                        "Prepaid Bank Guarantee": {}, 
+                        "Prepaid Consultancy Fees": {}, 
+                        "Prepaid Employees Housing": {}, 
+                        "Prepaid Finance charge for Loans": {}, 
+                        "Prepaid Legal Fees": {}, 
+                        "Prepaid License Fees": {}, 
+                        "Prepaid Life Insurance": {}, 
+                        "Prepaid Maintenance": {}, 
+                        "Prepaid Medical Insurance": {}, 
+                        "Prepaid Office Rent": {}, 
+                        "Prepaid Other Insurance": {}, 
+                        "Prepaid Schooling Fees": {}, 
+                        "Prepaid Site Hosting Fees": {}, 
                         "Prepaid Sponsorship Fees": {}
                     }
                 }
-            },
+            }, 
             "Long Term Assets": {
                 "Fixed Assets": {
                     "Accumulated Depreciation": {
                         "Acc. Depreciation of Motor Vehicles": {
                             "account_type": "Accumulated Depreciation"
-                        },
+                        }, 
                         "Acc. Deprn.Computer Hardware & Software": {
                             "account_type": "Accumulated Depreciation"
-                        },
+                        }, 
                         "Acc.Deprn.of Furniture & Office Equipment": {
                             "account_type": "Accumulated Depreciation"
-                        },
+                        }, 
                         "Amortisation on Leasehold Improvement": {
                             "account_type": "Accumulated Depreciation"
-                        },
+                        }, 
                         "account_type": "Accumulated Depreciation"
-                    },
+                    }, 
                     "Fixed Assets (Cost Price)": {
                         "Computer Hardware & Software": {
                             "account_type": "Fixed Asset"
-                        },
+                        }, 
                         "Furniture and Equipment": {
                             "account_type": "Fixed Asset"
-                        },
-                        "Leasehold Improvement": {},
-                        "Motor Vehicles": {
+                        }, 
+                        "Leasehold Improvement": {}, 
+                        "Motor Vehicules": {
                             "account_type": "Fixed Asset"
-                        },
-                        "Work In Progress": {},
+                        }, 
+                        "Work In Progrees": {}, 
                         "account_type": "Fixed Asset"
                     }
-                },
+                }, 
                 "Intangible Assets": {
-                    "Computer Card Renewal": {},
-                    "Disposal of Outlets": {},
+                    "Computer Card Renewal": {}, 
+                    "Dispoal of Outlets": {}, 
                     "Registration of Trademarks": {}
-                },
-                "Intercompany Accounts": {},
+                }, 
+                "Intercompany Accounts": {}, 
                 "Investments": {
                     "Investments in Subsidiaries": {}
                 }
-            },
+            }, 
             "root_type": "Asset"
-        },
+        }, 
         "Closing And Temporary Accounts": {
             "Closing Accounts": {
                 "Closing Account": {}
-            },
+            }, 
             "root_type": "Liability"
-        },
+        }, 
         "Expenses": {
             "Commercial Expenses": {
-                "Consultancy Fees": {},
+                "Consultancy Fees": {}, 
                 "Provision for Doubtful Debts": {}
-            },
+            }, 
             "Cost of Sale": {
                 "Cost Of Goods Sold": {
-                    "Cost Of Goods Sold I/C Sales": {},
+                    "Cost Of Goods Sold I/C Sales": {}, 
                     "Cost of Goods Sold in Trading": {
                         "account_type": "Cost of Goods Sold"
-                    },
+                    }, 
                     "account_type": "Cost of Goods Sold"
-                },
+                }, 
                 "Expenses Included In Valuation": {
                     "account_type": "Expenses Included In Valuation"
-                },
-                "Stock Adjustment": {
-                    "account_type": "Stock Adjustment"
                 }
-            },
+            }, 
             "Depreciation": {
                 "Depreciation & Amortization": {
-                    "Amortization on Leasehold Improvement": {},
+                    "Amortization on Leasehold Improvement": {}, 
                     "Depreciation Of Computer Hard & Soft": {
                         "account_type": "Depreciation"
-                    },
+                    }, 
                     "Depreciation Of Furniture & Office Equipment\n\t\t\t": {
                         "account_type": "Depreciation"
-                    },
+                    }, 
                     "Depreciation Of Motor Vehicles": {
                         "account_type": "Depreciation"
                     }
                 }
-            },
+            }, 
             "Direct Expenses": {
                 "Financial Charges": {
-                    "Air Miles Card Charges": {},
-                    "Amex Credit Cards Charges": {},
-                    "Bank Finance & Loan Charges": {},
-                    "Credit Card Charges": {},
-                    "Credit Card Swipe Charges": {},
+                    "Air Miles Card Charges": {}, 
+                    "Amex Credit Cards Charges": {}, 
+                    "Bank Finance & Loan Charges": {}, 
+                    "Credit Card Charges": {}, 
+                    "Credit Card Swipe Charges": {}, 
                     "PayPal Charges": {}
                 }
-            },
+            }, 
             "MISC Charges": {
                 "Other Charges": {
-                    "Capital Loss": {
-                        "Disposal of Business Branch": {},
-                        "Loss On Fixed Assets Disposal": {},
+                    "Captial Loss": {
+                        "Disposal of Business Branch": {}, 
+                        "Loss On Fixed Assets Disposal": {}, 
                         "Loss on Difference on Exchange": {}
-                    },
+                    }, 
                     "Other Non Operating Exp": {
                         "Other Non Operating Expenses": {}
-                    },
+                    }, 
                     "Previous Year Adjustments": {
                         "Previous Year Adjustments Account": {}
-                    },
+                    }, 
                     "Royalty Fees": {
                         "Royalty to Parent Co.": {}
-                    },
+                    }, 
                     "Tax / Zakat Expenses": {
                         "Income Tax": {
                             "account_type": "Tax"
-                        },
-                        "Zakat": {},
+                        }, 
+                        "Zakat": {}, 
                         "account_type": "Tax"
                     }
                 }
-            },
+            }, 
             "Share Resources": {
                 "Share Resource Expenses Account": {}
-            },
+            }, 
             "Store Operating Expenses": {
                 "Selling, General & Admin Expenses": {
                     "Advertising Expenses": {
                         "Other - Advertising Expenses": {}
-                    },
+                    }, 
                     "Bank & Finance Charges": {
                         "Other Bank Charges": {}
-                    },
+                    }, 
                     "Communications": {
-                        "Courier": {},
-                        "Others - Communication": {},
-                        "Telephone": {},
+                        "Courrier": {}, 
+                        "Others - Communication": {}, 
+                        "Telephone": {}, 
                         "Web Site Hosting Fees": {}
-                    },
+                    }, 
                     "Office & Various Expenses": {
-                        "Cleaning": {},
-                        "Conveyance Expenses": {},
-                        "Gifts & Donations": {},
-                        "Insurance": {},
-                        "Kitchen and Buffet Expenses": {},
-                        "Maintenance": {},
-                        "Others - Office Various Expenses": {},
-                        "Security & Guard": {},
-                        "Stationary From Suppliers": {},
-                        "Stationary Out Of Stock": {},
-                        "Subscriptions": {},
-                        "Training": {},
+                        "Cleaning": {}, 
+                        "Convoyance Expenses": {}, 
+                        "Gifts & Donations": {}, 
+                        "Insurance": {}, 
+                        "Kitchen and Buffet Expenses": {}, 
+                        "Maintenance": {}, 
+                        "Others - Office Various Expenses": {}, 
+                        "Security & Guard": {}, 
+                        "Stationary From Suppliers": {}, 
+                        "Stationary Out Of Stock": {}, 
+                        "Subscriptions": {}, 
+                        "Training": {}, 
                         "Vehicle Expenses": {}
-                    },
+                    }, 
                     "Personnel Cost": {
-                        "Basic Salary": {},
-                        "End Of Service Indemnity": {},
-                        "Housing Allowance": {},
-                        "Leave Salary": {},
-                        "Leave Ticket": {},
-                        "Life Insurance": {},
-                        "Medical Insurance": {},
-                        "Personnel Cost Others": {},
-                        "Sales Commission": {},
-                        "Staff School Allowances": {},
-                        "Transportation Allowance": {},
-                        "Uniform": {},
+                        "Basic Salary": {}, 
+                        "End Of Service Indemnity": {}, 
+                        "Housing Allowance": {}, 
+                        "Leave Salary": {}, 
+                        "Leave Ticket": {}, 
+                        "Life Insurance": {}, 
+                        "Medical Insurance": {}, 
+                        "Personnel Cost Others": {}, 
+                        "Sales Commission": {}, 
+                        "Staff School Allowances": {}, 
+                        "Transportation Allowance": {}, 
+                        "Uniform": {}, 
                         "Visa Expenses": {}
-                    },
+                    }, 
                     "Professional & Legal Fees": {
-                        "Audit Fees": {},
-                        "Legal fees": {},
-                        "Others - Professional Fees": {},
-                        "Sponsorship Fees": {},
+                        "Audit Fees": {}, 
+                        "Legal fees": {}, 
+                        "Others - Professional Fees": {}, 
+                        "Sponsorship Fees": {}, 
                         "Trade License Fees": {}
-                    },
+                    }, 
                     "Provision & Write Off": {
-                        "Amortisation of Preoperating Expenses": {},
-                        "Cash Shortage": {},
-                        "Others - Provision & Write off": {},
-                        "Write Off Inventory": {},
+                        "Amortisation of Preoperating Expenses": {}, 
+                        "Cash Shortage": {}, 
+                        "Others - Provision & Write off": {}, 
+                        "Write Off Inventory": {}, 
                         "Write Off Receivables & Payables": {}
-                    },
+                    }, 
                     "Rent Expenses": {
-                        "Office Rent": {},
+                        "Office Rent": {}, 
                         "Warehouse Rent": {}
-                    },
+                    }, 
                     "Travel Expenses": {
-                        "Air tickets": {},
-                        "Hotel": {},
-                        "Meals": {},
-                        "Others": {},
+                        "Air tickets": {}, 
+                        "Hotel": {}, 
+                        "Meals": {}, 
+                        "Others": {}, 
                         "Per Diem": {}
-                    },
+                    }, 
                     "Utilities": {
-                        "Other Utility Cahrges": {},
+                        "Other Utility Cahrges": {}, 
                         "Water & Electricity": {}
                     }
                 }
-            },
+            }, 
             "root_type": "Expense"
-        },
+        }, 
         "Liabilities": {
             "Current Liabilities": {
                 "Accounts Payable": {
                     "Payables": {
-                        "Advance Payable to Suppliers": {
+                        "Advance Paybale to Suppliers": {
                             "account_type": "Payable"
-                        },
+                        }, 
                         "Consigned Payable": {
                             "account_type": "Payable"
-                        },
+                        }, 
                         "Other Payable": {
                             "account_type": "Payable"
-                        },
+                        }, 
                         "Post Dated Cheques Paid": {
                             "account_type": "Payable"
-                        },
-                        "Staff Payable": {},
+                        }, 
+                        "Staff Payable": {}, 
                         "Suppliers Price Protection": {
                             "account_type": "Payable"
-                        },
+                        }, 
                         "Trade Payable": {
                             "account_type": "Payable"
-                        },
+                        }, 
                         "account_type": "Payable"
                     }
-                },
+                }, 
                 "Accruals & Provisions": {
                     "Accruals": {
                         "Accrued Personnel Cost": {
-                            "Accrued - Commissions": {},
-                            "Accrued - Leave Salary": {},
-                            "Accrued - Leave Tickets": {},
-                            "Accrued - Salaries": {},
-                            "Accrued Other Personnel Cost": {},
-                            "Accrued Salaries Increment": {},
+                            "Accrued - Commissions": {}, 
+                            "Accrued - Leave Salary": {}, 
+                            "Accrued - Leave Tickets": {}, 
+                            "Accrued - Salaries": {}, 
+                            "Accrued Other Personnel Cost": {}, 
+                            "Accrued Salaries Increment": {}, 
                             "Accrued-Staff Bonus": {}
                         }
-                    },
+                    }, 
                     "Accrued Expenses": {
                         "Accrued Other Expenses": {
-                            "Accrued - Audit Fees": {},
-                            "Accrued - Office Rent": {},
-                            "Accrued - Sponsorship": {},
-                            "Accrued - Telephone": {},
-                            "Accrued - Utilities": {},
+                            "Accrued - Audit Fees": {}, 
+                            "Accrued - Office Rent": {}, 
+                            "Accrued - Sponsorship": {}, 
+                            "Accrued - Telephone": {}, 
+                            "Accrued - Utilities": {}, 
                             "Accrued Others": {}
                         }
-                    },
+                    }, 
                     "Other Current Liabilities": {
-                        "Accrued Dubai Customs": {},
-                        "Deferred income": {},
+                        "Accrued Dubai Customs": {}, 
+                        "Deferred income": {}, 
                         "Shipping & Handling": {}
-                    },
+                    }, 
                     "Provisions": {
                         "Tax Payables": {
-                            "Income Tax Payable": {},
-                            "Sales Tax Payable": {},
+                            "Income Tax Payable": {}, 
+                            "Sales Tax Payable": {}, 
                             "Withholding Tax Payable": {}
                         }
-                    },
+                    }, 
                     "Short Term Loan": {}
-                },
+                }, 
                 "Duties and Taxes": {
-                    "account_type": "Tax",
+                    "account_type": "Tax", 
                     "is_group": 1
-                },
+                }, 
                 "Reservations & Credit Notes": {
                     "Credit Notes": {
-                        "Credit Notes to Customers": {},
+                        "Credit Notes to Customers": {}, 
                         "Reservations": {}
                     }
-                },
+                }, 
                 "Stock Liabilities": {
                     "Stock Received But Not Billed": {
                         "account_type": "Stock Received But Not Billed"
                     }
-                },
+                }, 
                 "Unearned Income": {}
-            },
+            }, 
             "Long Term Liabilities": {
                 "Long Term Loans & Provisions": {}
-            },
+            }, 
             "root_type": "Liability"
-        },
+        }, 
         "Revenue": {
             "Direct Revenue": {
                 "Other Direct Revenue": {
                     "Other Revenue - Operating": {
-                        "Advertising Income": {},
-                        "Branding Income": {},
-                        "Early Setmt Margin from Suppliers": {},
-                        "Marketing Rebate from Suppliers": {},
-                        "Rebate from Suppliers": {},
-                        "Service Income": {},
+                        "Advertising Income": {}, 
+                        "Branding Income": {}, 
+                        "Early Setmt Margin from Suppliers": {}, 
+                        "Marketing Rebate from Suppliers": {}, 
+                        "Rebate from Suppliers": {}, 
+                        "Service Income": {}, 
                         "Space Rental Income": {}
                     }
                 }
-            },
+            }, 
             "Indirect Revenue": {
                 "Other Indirect Revenue": {
-                    "Capital Gain": {},
-                    "Excess In Till": {},
-                    "Gain On Difference Of Exchange": {},
-                    "Management Consultancy Fees": {},
+                    "Capital Gain": {}, 
+                    "Excess In Till": {}, 
+                    "Gain On Difference Of Exchange": {}, 
+                    "Management Consultancy Fees": {}, 
                     "Other Income": {}
-                },
+                }, 
                 "Other Revenue - Non Operating": {
-                    "Interest Revenue": {},
-                    "Interest from FD": {},
-                    "Products Listing Fees from Suppliers": {},
+                    "Interest Revenue": {}, 
+                    "Interest from FD": {}, 
+                    "Products Listing Fees from Suppliers": {}, 
                     "Trade Opening Fees from suppliers": {}
                 }
-            },
+            }, 
             "Sales": {
                 "Sales from Other Regions": {
                     "Sales from Other Region": {}
-                },
+                }, 
                 "Sales of same region": {
-                    "Management Consultancy Fees 1": {},
-                    "Sales Account": {},
+                    "Management Consultancy Fees 1": {}, 
+                    "Sales Account": {}, 
                     "Sales of I/C": {}
                 }
-            },
+            }, 
             "root_type": "Income"
-        },
+        }, 
         "Share Holder Equity": {
             "Capital": {
-                "Contributed Capital": {},
-                "Share Capital": {},
-                "Shareholders Current A/c": {},
-                "Sub Ordinated Loan": {},
+                "Contributed Capital": {}, 
+                "Share Capital": {}, 
+                "Shareholders Current A/c": {}, 
+                "Sub Ordinated Loan": {}, 
                 "Treasury Stocks": {}
-            },
+            }, 
             "Retained Earnings": {
-                "Current Year Results": {},
-                "Dividends Paid": {},
+                "Current Year Results": {}, 
+                "Dividends Paid": {}, 
                 "Previous Years Results": {}
-            },
-            "account_type": "Equity",
+            }, 
+            "account_type": "Equity", 
             "root_type": "Equity"
         }
     }

erpnext/accounts/doctype/account/chart_of_accounts/verified/de_kontenplan_SKR03_gnucash.json

@@ -1,531 +0,0 @@
-{
-    "country_code": "de",
-    "name": "SKR03 mit Kontonummern",
-    "tree": {
-        "Aktiva": {
-            "is_group": 1,
-			"root_type": "Asset",
-            "A - Anlagevermögen": {
-                "is_group": 1,
-                "EDV-Software": {
-                    "account_number": "0027",
-                    "account_type": "Fixed Asset"
-                },
-                "Gesch\u00e4ftsausstattung": {
-                    "account_number": "0410",
-                    "account_type": "Fixed Asset"
-                },
-                "B\u00fcroeinrichtung": {
-                    "account_number": "0420",
-                    "account_type": "Fixed Asset"
-                },
-                "Darlehen": {
-                    "account_number": "0565"
-                },
-                "Maschinen": {
-                    "account_number": "0210",
-                    "account_type": "Fixed Asset"
-                },
-                "Betriebsausstattung": {
-                    "account_number": "0400",
-                    "account_type": "Fixed Asset"
-                },
-                "Ladeneinrichtung": {
-                    "account_number": "0430",
-                    "account_type": "Fixed Asset"
-				},
-				"Accumulated Depreciation": {
-					"account_type": "Accumulated Depreciation"
-				}
-			},
-			"B - Umlaufvermögen": {
-				"is_group": 1,
-				"I. Vorräte": {
-					"is_group": 1,
-					"Roh-, Hilfs- und Betriebsstoffe (Bestand)": {
-						"account_number": "3970",
-						"account_type": "Stock"
-					},
-					"Waren (Bestand)": {
-						"account_number": "3980",
-						"account_type": "Stock"
-					}
-				},
-				"II. Forderungen und sonstige Vermögensgegenstände": {
-					"is_group": 1,
-					"Ford. a. Lieferungen und Leistungen": {
-						"account_number": "1400",
-						"account_type": "Receivable"
-					},
-					"Durchlaufende Posten": {
-						"account_number": "1590"
-					},
-					"Gewinnermittlung \u00a74/3 nicht Ergebniswirksam": {
-						"account_number": "1371"
-					},
-					"Abziehbare Vorsteuer": {
-						"account_type": "Tax",
-						"is_group": 1,
-						"Abziehbare Vorsteuer 7%": {
-							"account_number": "1571"
-						},
-						"Abziehbare Vorsteuer 19%": {
-							"account_number": "1576"
-						},
-						"Abziehbare Vorsteuer nach \u00a713b UStG 19%": {
-							"account_number": "1577"
-						},
-						"Leistungen \u00a713b UStG 19% Vorsteuer, 19% Umsatzsteuer": {
-							"account_number": "3120"
-						}
-					}
-				},
-				"III. Wertpapiere": {
-					"is_group": 1
-				},
-				"IV. Kassenbestand, Bundesbankguthaben, Guthaben bei Kreditinstituten und Schecks.": {
-					"is_group": 1,
-					"Kasse": {
-						"account_type": "Cash",
-						"is_group": 1,
-						"Kasse": {
-							"is_group": 1,
-							"account_number": "1000",
-							"account_type": "Cash"
-						}
-					},
-					"Bank": {
-						"is_group": 1,
-						"account_type": "Bank",
-						"Postbank": {
-							"account_number": "1100",
-							"account_type": "Bank"
-						},
-						"Bankkonto": {
-							"account_number": "1200",
-							"account_type": "Bank"
-						}
-					}
-				}
-			},
-			"C - Rechnungsabgrenzungsposten": {
-				"is_group": 1,
-				"Aktive Rechnungsabgrenzung": {
-                    "account_number": "0980"
-				}
-			},
-			"D - Aktive latente Steuern": {
-				"is_group": 1,
-				"Aktive latente Steuern": {
-                    "account_number": "0983"
-				}
-			},
-			"E - Aktiver Unterschiedsbetrag aus der Vermögensverrechnung": {
-				"is_group": 1
-			}
-        },
-        "Passiva": {
-            "is_group": 1,
-			"root_type": "Liability",
-			"A. Eigenkapital": {
-				"is_group": 1,
-				"I. Gezeichnetes Kapital": {
-					"is_group": 1
-				},
-				"II. Kapitalrücklage": {
-					"is_group": 1
-				},
-				"III. Gewinnrücklagen": {
-					"is_group": 1
-				},
-				"IV. Gewinnvortrag/Verlustvortrag": {
-					"is_group": 1
-				},
-				"V. Jahresüberschuß/Jahresfehlbetrag": {
-					"is_group": 1
-				}
-			},
-			"B. Rückstellungen": {
-				"is_group": 1,
-				"I. Rückstellungen für Pensionen und ähnliche Verpflichtungen": {
-					"is_group": 1
-				},
-				"II. Steuerrückstellungen": {
-					"is_group": 1
-				},
-				"III. sonstige Rückstellungen": {
-					"is_group": 1
-				}
-			},
-			"C. Verbindlichkeiten": {
-				"is_group": 1,
-				"I. Anleihen": {
-					"is_group": 1
-				},
-				"II. Verbindlichkeiten gegenüber Kreditinstituten": {
-					"is_group": 1
-				},
-				"III. Erhaltene Anzahlungen auf Bestellungen": {
-					"is_group": 1
-				},
-				"IV. Verbindlichkeiten aus Lieferungen und Leistungen": {
-					"is_group": 1,
-					"Verbindlichkeiten aus Lieferungen u. Leistungen": {
-						"account_number": "1600",
-						"account_type": "Payable"
-					}
-				},
-				"V. Verbindlichkeiten aus der Annahme gezogener Wechsel und der Ausstellung eigener Wechsel": {
-					"is_group": 1
-				},
-				"VI. Verbindlichkeiten gegenüber verbundenen Unternehmen": {
-					"is_group": 1
-				},
-				"VII. Verbindlichkeiten gegenüber Unternehmen, mit denen ein Beteiligungsverhältnis besteht": {
-					"is_group": 1
-				},
-				"VIII. sonstige Verbindlichkeiten": {
-					"is_group": 1,
-					"Sonstige Verbindlichkeiten": {
-						"account_number": "1700",
-						"account_type": "Asset Received But Not Billed"
-					},
-					"Sonstige Verbindlichkeiten (1 bis 5 Jahre)": {
-						"account_number": "1702",
-						"account_type": "Stock Received But Not Billed"
-					},
-					"Verbindlichkeiten aus Lohn und Gehalt": {
-						"account_number": "1740",
-						"account_type": "Payable"
-					},
-					"Umsatzsteuer": {
-						"is_group": 1,
-						"account_type": "Tax",
-						"Umsatzsteuer 7%": {
-							"account_number": "1771"
-						},
-						"Umsatzsteuer 19%": {
-							"account_number": "1776"
-						},
-						"Umsatzsteuer-Vorauszahlung": {
-							"account_number": "1780"
-						},
-						"Umsatzsteuer-Vorauszahlung 1/11": {
-							"account_number": "1781"
-						},
-						"Umsatzsteuer \u00a7 13b UStG 19%": {
-							"account_number": "1787"
-						},
-						"Umsatzsteuer Vorjahr": {
-							"account_number": "1790"
-						},
-						"Umsatzsteuer fr\u00fchere Jahre": {
-							"account_number": "1791"
-						}
-					}
-				}
-			},
-			"D. Rechnungsabgrenzungsposten": {
-				"is_group": 1,
-				"Passive Rechnungsabgrenzung": {
-					"account_number": "0990"
-				}
-			},
-			"E. Passive latente Steuern": {
-				"is_group": 1
-			}
-        },
-        "Erl\u00f6se u. Ertr\u00e4ge 2/8": {
-            "is_group": 1,
-            "root_type": "Income",
-            "Erl\u00f6skonten 8": {
-				"is_group": 1,
-				"Erl\u00f6se": {
-                    "account_number": "8200",
-                    "account_type": "Income Account"
-                },
-                "Erl\u00f6se USt. 19%": {
-                    "account_number": "8400",
-                    "account_type": "Income Account"
-                },
-                "Erl\u00f6se USt. 7%": {
-                    "account_number": "8300",
-                    "account_type": "Income Account"
-                }
-            },
-            "Ertragskonten 2": {
-                "is_group": 1,
-                "sonstige Zinsen und \u00e4hnliche Ertr\u00e4ge": {
-                    "account_number": "2650",
-                    "account_type": "Income Account"
-                },
-                "Au\u00dferordentliche Ertr\u00e4ge": {
-                    "account_number": "2500",
-                    "account_type": "Income Account"
-                },
-                "Sonstige Ertr\u00e4ge": {
-                    "account_number": "2700",
-                    "account_type": "Income Account"
-                }
-            }
-        },
-        "Aufwendungen 2/4": {
-            "is_group": 1,
-			"root_type": "Expense",
-			"Wareneingang": {
-				"account_number": "3200"
-			},
-			"Bezugsnebenkosten": {
-				"account_number": "3800",
-				"account_type": "Expenses Included In Asset Valuation"
-			},
-			"Herstellungskosten": {
-				"account_number": "4996",
-				"account_type": "Cost of Goods Sold"
-			},
-			"Verluste aus dem Abgang von Gegenständen des Anlagevermögens": {
-				"account_number": "2320",
-				"account_type": "Stock Adjustment"
-			},
-			"Verwaltungskosten": {
-				"account_number": "4997",
-				"account_type": "Expenses Included In Valuation"
-			},
-			"Vertriebskosten": {
-				"account_number": "4998",
-				"account_type": "Expenses Included In Valuation"
-			},
-			"Gegenkonto 4996-4998": {
-				"account_number": "4999"
-			},
-            "Abschreibungen": {
-                "is_group": 1,
-				"Abschreibungen auf Sachanlagen (ohne AfA auf Kfz und Gebäude)": {
-                    "account_number": "4830",
-                    "account_type": "Accumulated Depreciation"
-				},
-				"Abschreibungen auf Gebäude": {
-                    "account_number": "4831",
-                    "account_type": "Depreciation"
-				},
-				"Abschreibungen auf Kfz": {
-                    "account_number": "4832",
-                    "account_type": "Depreciation"
-				},
-				"Sofortabschreibung GWG": {
-                    "account_number": "4855",
-                    "account_type": "Expense Account"
-				}
-            },
-            "Kfz-Kosten": {
-                "is_group": 1,
-                "Kfz-Steuer": {
-                    "account_number": "4510",
-                    "account_type": "Expense Account"
-                },
-                "Kfz-Versicherungen": {
-                    "account_number": "4520",
-                    "account_type": "Expense Account"
-                },
-                "laufende Kfz-Betriebskosten": {
-                    "account_number": "4530",
-                    "account_type": "Expense Account"
-                },
-                "Kfz-Reparaturen": {
-                    "account_number": "4540",
-                    "account_type": "Expense Account"
-                },
-                "Fremdfahrzeuge": {
-                    "account_number": "4570",
-                    "account_type": "Expense Account"
-                },
-                "sonstige Kfz-Kosten": {
-                    "account_number": "4580",
-                    "account_type": "Expense Account"
-                }
-            },
-            "Personalkosten": {
-                "is_group": 1,
-                "Geh\u00e4lter": {
-                    "account_number": "4120",
-                    "account_type": "Expense Account"
-                },
-                "gesetzliche soziale Aufwendungen": {
-                    "account_number": "4130",
-                    "account_type": "Expense Account"
-                },
-                "Aufwendungen f\u00fcr Altersvorsorge": {
-                    "account_number": "4165",
-                    "account_type": "Expense Account"
-                },
-                "Verm\u00f6genswirksame Leistungen": {
-                    "account_number": "4170",
-                    "account_type": "Expense Account"
-                },
-                "Aushilfsl\u00f6hne": {
-                    "account_number": "4190",
-                    "account_type": "Expense Account"
-                }
-            },
-            "Raumkosten": {
-                "is_group": 1,
-                "Miete und Nebenkosten": {
-                    "account_number": "4210",
-                    "account_type": "Expense Account"
-                },
-                "Gas, Wasser, Strom (Verwaltung, Vertrieb)": {
-                    "account_number": "4240",
-                    "account_type": "Expense Account"
-                },
-                "Reinigung": {
-                    "account_number": "4250",
-                    "account_type": "Expense Account"
-                }
-            },
-            "Reparatur/Instandhaltung": {
-                "is_group": 1,
-                "Reparatur u. Instandh. von Anlagen/Maschinen u. Betriebs- u. Gesch\u00e4ftsausst.": {
-                    "account_number": "4805",
-                    "account_type": "Expense Account"
-                }
-            },
-            "Versicherungsbeitr\u00e4ge": {
-                "is_group": 1,
-                "Versicherungen": {
-                    "account_number": "4360",
-                    "account_type": "Expense Account"
-                },
-                "Beitr\u00e4ge": {
-                    "account_number": "4380",
-                    "account_type": "Expense Account"
-                },
-                "sonstige Ausgaben": {
-                    "account_number": "4390",
-                    "account_type": "Expense Account"
-                },
-                "steuerlich abzugsf\u00e4hige Versp\u00e4tungszuschl\u00e4ge und Zwangsgelder": {
-                    "account_number": "4396",
-                    "account_type": "Expense Account"
-                }
-            },
-            "Werbe-/Reisekosten": {
-                "is_group": 1,
-                "Werbekosten": {
-                    "account_number": "4610",
-                    "account_type": "Expense Account"
-                },
-                "Aufmerksamkeiten": {
-                    "account_number": "4653",
-                    "account_type": "Expense Account"
-                },
-                "nicht abzugsf\u00e4hige Betriebsausg. aus Werbe-, Repr\u00e4s.- u. Reisekosten": {
-                    "account_number": "4665",
-                    "account_type": "Expense Account"
-                },
-                "Reisekosten Unternehmer": {
-                    "account_number": "4670",
-                    "account_type": "Expense Account"
-                }
-            },
-            "verschiedene Kosten": {
-                "is_group": 1,
-                "Porto": {
-                    "account_number": "4910",
-                    "account_type": "Expense Account"
-                },
-                "Telekom": {
-                    "account_number": "4920",
-                    "account_type": "Expense Account"
-                },
-                "Mobilfunk D2": {
-                    "account_number": "4921",
-                    "account_type": "Expense Account"
-                },
-                "Internet": {
-                    "account_number": "4922",
-                    "account_type": "Expense Account"
-                },
-                "B\u00fcrobedarf": {
-                    "account_number": "4930",
-                    "account_type": "Expense Account"
-                },
-                "Zeitschriften, B\u00fccher": {
-                    "account_number": "4940",
-                    "account_type": "Expense Account"
-                },
-                "Fortbildungskosten": {
-                    "account_number": "4945",
-                    "account_type": "Expense Account"
-                },
-                "Buchf\u00fchrungskosten": {
-                    "account_number": "4955",
-                    "account_type": "Expense Account"
-                },
-                "Abschlu\u00df- u. Pr\u00fcfungskosten": {
-                    "account_number": "4957",
-                    "account_type": "Expense Account"
-                },
-                "Nebenkosten des Geldverkehrs": {
-                    "account_number": "4970",
-                    "account_type": "Expense Account"
-                },
-                "Werkzeuge und Kleinger\u00e4te": {
-                    "account_number": "4985",
-                    "account_type": "Expense Account"
-                }
-            },
-            "Zinsaufwendungen": {
-                "is_group": 1,
-                "Zinsaufwendungen f\u00fcr kurzfristige Verbindlichkeiten": {
-                    "account_number": "2110",
-                    "account_type": "Expense Account"
-                },
-                "Zinsaufwendungen f\u00fcr KFZ Finanzierung": {
-                    "account_number": "2121",
-                    "account_type": "Expense Account"
-                }
-            }
-        },
-        "Anfangsbestand 9": {
-            "is_group": 1,
-            "root_type": "Equity",
-            "Saldenvortragskonten": {
-                "is_group": 1,
-                "Saldenvortrag Sachkonten": {
-                    "account_number": "9000"
-                },
-                "Saldenvortr\u00e4ge Debitoren": {
-                    "account_number": "9008"
-                },
-                "Saldenvortr\u00e4ge Kreditoren": {
-                    "account_number": "9009"
-                }
-            }
-        },
-        "Privatkonten 1": {
-            "is_group": 1,
-            "root_type": "Equity",
-            "Privatentnahmen/-einlagen": {
-                "is_group": 1,
-                "Privatentnahme allgemein": {
-                    "account_number": "1800"
-                },
-                "Privatsteuern": {
-                    "account_number": "1810"
-                },
-                "Sonderausgaben beschr\u00e4nkt abzugsf\u00e4hig": {
-                    "account_number": "1820"
-                },
-                "Sonderausgaben unbeschr\u00e4nkt abzugsf\u00e4hig": {
-                    "account_number": "1830"
-                },
-                "Au\u00dfergew\u00f6hnliche Belastungen": {
-                    "account_number": "1850"
-                },
-                "Privateinlagen": {
-                    "account_number": "1890"
-                }
-            }
-        }
-    }
-}

erpnext/accounts/doctype/account/chart_of_accounts/verified/de_kontenplan_SKR04.json

@@ -1,6 +1,6 @@
 {
     "country_code": "de", 
-    "name": "SKR04 ohne Kontonummern", 
+    "name": "Germany - Kontenplan SKR04", 
     "tree": {
         "Bilanz - Aktiva": {
             "Anlageverm\u00f6gen": {
@@ -292,21 +292,18 @@
                         "Umsatzsteuerforderungen fr\u00fchere Jahre": {}
                     }, 
                     "Sonstige Verm\u00f6gensgegenst\u00e4nde oder sonstige Verbindlichkeiten": {
-                        "Abziehbare Vorsteuer": {
-                            "account_type": "Tax",
-                            "is_group": 1,
-                            "Abziehbare Vorsteuer 16%": {},
-                            "Abziehbare Vorsteuer 19%": {},
-                            "Abziehbare Vorsteuer 7%": {},
-                            "Abziehbare Vorsteuer aus der Auslagerung von Gegenst\u00e4nden aus einem Unsatzsteuerlager": {},
-                            "Abziehbare Vorsteuer aus innergemeinschaftlichem Erwerb": {},
-                            "Abziehbare Vorsteuer aus innergemeinschaftlichem Erwerb 16%": {},
-                            "Abziehbare Vorsteuer aus innergemeinschaftlichem Erwerb 19%": {},
-                            "Abziehbare Vorsteuer aus innergemeinschaftlichem Erwerb von Neufahrzeugen von Lieferanten ohne Ust-Identifikationsnummer": {},
-                            "Abziehbare Vorsteuer nach \u00a7 13b UStG ": {},
-                            "Abziehbare Vorsteuer nach \u00a7 13b UStG 16%": {},
-                            "Abziehbare Vorsteuer nach \u00a7 13b UStG 19%": {}
-                        },
+                        "Abziehbare Vorsteuer": {}, 
+                        "Abziehbare Vorsteuer 16%": {}, 
+                        "Abziehbare Vorsteuer 19%": {}, 
+                        "Abziehbare Vorsteuer 7%": {}, 
+                        "Abziehbare Vorsteuer aus der Auslagerung von Gegenst\u00e4nden aus einem Unsatzsteuerlager": {}, 
+                        "Abziehbare Vorsteuer aus innergemeinschaftlichem Erwerb": {}, 
+                        "Abziehbare Vorsteuer aus innergemeinschaftlichem Erwerb 16%": {}, 
+                        "Abziehbare Vorsteuer aus innergemeinschaftlichem Erwerb 19%": {}, 
+                        "Abziehbare Vorsteuer aus innergemeinschaftlichem Erwerb von Neufahrzeugen von Lieferanten ohne Ust-Identifikationsnummer": {}, 
+                        "Abziehbare Vorsteuer nach \u00a7 13b UStG ": {}, 
+                        "Abziehbare Vorsteuer nach \u00a7 13b UStG 16%": {}, 
+                        "Abziehbare Vorsteuer nach \u00a7 13b UStG 19%": {}, 
                         "Aufl\u00f6sung Vorsteuer aus Vorjahr \u00a7 4/3 EStG": {}, 
                         "Aufzuteilende Vorsteuer": {}, 
                         "Aufzuteilende Vorsteuer 16%": {}, 
@@ -676,26 +673,23 @@
                         "Sonstige Verrechnungskonten (Interimskonto)": {
                             "account_type": "Stock Received But Not Billed"
                         }, 
-                        "Umsatzsteuer": {
-                            "account_type": "Tax",
-                            "is_group": 1,
-                            "Umsatzsteuer 16%": {},
-                            "Umsatzsteuer 19%": {},
-                            "Umsatzsteuer 7%": {},
-                            "Umsatzsteuer Vorjahr": {},
-                            "Umsatzsteuer aus der Auslagerung von Gegenst\u00e4nden aus einem Umsatzsteuerlager": {},
-                            "Umsatzsteuer aus im Inland steuerpflichtigen EG-Lieferungen": {},
-                            "Umsatzsteuer aus im Inland steuerpflichtigen EG-Lieferungen 19%": {},
-                            "Umsatzsteuer aus innergemeinschaftlichem Erwerb ": {},
-                            "Umsatzsteuer aus innergemeinschaftlichem Erwerb 16%": {},
-                            "Umsatzsteuer aus innergemeinschaftlichem Erwerb 19%": {},
-                            "Umsatzsteuer aus innergemeinschaftlichem Erwerb ohne Vorsteuerabzug": {},
-                            "Umsatzsteuer fr\u00fchere Jahre": {},
-                            "Umsatzsteuer laufendes Jahr": {},
-                            "Umsatzsteuer nach \u00a713b UStG": {},
-                            "Umsatzsteuer nach \u00a713b UStG 16%": {},
-                            "Umsatzsteuer nach \u00a713b UStG 19%": {}
-                        },
+                        "Umsatzsteuer": {}, 
+                        "Umsatzsteuer 16%": {}, 
+                        "Umsatzsteuer 19%": {}, 
+                        "Umsatzsteuer 7%": {}, 
+                        "Umsatzsteuer Vorjahr": {}, 
+                        "Umsatzsteuer aus der Auslagerung von Gegenst\u00e4nden aus einem Umsatzsteuerlager": {}, 
+                        "Umsatzsteuer aus im Inland steuerpflichtigen EG-Lieferungen": {}, 
+                        "Umsatzsteuer aus im Inland steuerpflichtigen EG-Lieferungen 19%": {}, 
+                        "Umsatzsteuer aus innergemeinschaftlichem Erwerb ": {}, 
+                        "Umsatzsteuer aus innergemeinschaftlichem Erwerb 16%": {}, 
+                        "Umsatzsteuer aus innergemeinschaftlichem Erwerb 19%": {}, 
+                        "Umsatzsteuer aus innergemeinschaftlichem Erwerb ohne Vorsteuerabzug": {}, 
+                        "Umsatzsteuer fr\u00fchere Jahre": {}, 
+                        "Umsatzsteuer laufendes Jahr": {}, 
+                        "Umsatzsteuer nach \u00a713b UStG": {}, 
+                        "Umsatzsteuer nach \u00a713b UStG 16%": {}, 
+                        "Umsatzsteuer nach \u00a713b UStG 19%": {}, 
                         "Umsatzsteuer- Vorauszahlungen": {}, 
                         "Umsatzsteuer- Vorauszahlungen 1/11": {}, 
                         "Verbindlichkeiten aus Lohn- und Kirchensteuer": {}
@@ -1389,7 +1383,8 @@
                     "Sonstige Zinsen und \u00e4hnliche Ertr\u00e4ge 1": {
                         "Diskontertr\u00e4ge": {}, 
                         "Diskontertr\u00e4ge aus verbundenen Unternehmen": {}, 
-                        "Laufende Ertr\u00e4ge aus Anteilen an Kapitalgesellschaften 100% / 50% steuerfrei": {},
+                        "Laufende Ertr\u00e4ge aus Anteilen an Kapitalgesellschaften 100% / 50% steuerfrei": {}, 
+                        "Laufende Ertr\u00e4ge aus Anteilen an Kapitalgesellschaften 100% / 50% steuerfrei": {}, 
                         "Sonstige Zinsen und \u00e4hnliche Ertr\u00e4ge 2": {}, 
                         "Sonstige Zinsen und \u00e4hnliche Ertr\u00e4ge aus verbundenen Unternehmen": {}, 
                         "Sonstige Zinsertr\u00e4ge": {}, 
@@ -1708,4 +1703,4 @@
             "root_type": "Asset"
         }
     }
-}
+}

erpnext/accounts/doctype/account/chart_of_accounts/verified/el_salvador_standard.json

@@ -1,809 +0,0 @@
-{
-    "country_code": "sv",
-    "name": "El Salvador Standard",
-    "tree": {
-        "100000 - ACTIVOS - xmC": {
-            "11000000 - ACTIVOS CORRIENTES - xmC": {
-                "11010000 - EFECTIVO Y EQUIVALENTES AL EFECTIVO - xmC": {
-                    "11010100 - Caja general - xmC": {
-                        "account_number": "11010100",
-                        "account_type": "Cash"
-                    },
-                    "Caja chica": {
-                        "account_number": "11010200",
-                        "account_type": "Cash",
-                        "is_group": 1
-                    },
-                    "Efectivo en bancos": {
-                        "account_number": "11010300",
-                        "account_type": "Bank",
-                        "is_group": 1
-                    },
-                    "account_number": "11010000",
-                    "account_type": "Cash"
-                },
-                "CUENTAS POR COBRAR ARRENDAMIENTOS FINANCIEROS": {
-                    "Arrendamientos financieros por cobrar": {
-                        "account_number": "11040100",
-                        "is_group": 1
-                    },
-                    "Estimaci\u00f3n para cuentas de cobro dudoso (CR)": {
-                        "account_number": "11040200",
-                        "is_group": 1
-                    },
-                    "account_number": "11040000"
-                },
-                "DEUDORES COMERCIALES Y OTRAS CUENTAS POR COBRAR": {
-                    "11030100 - Deudores comerciales - xmC": {
-                        "account_number": "11030100",
-                        "account_type": "Receivable"
-                    },
-                    "Estimaci\u00f3n para cuentas de cobro dudoso (CR)": {
-                        "account_number": "11030200",
-                        "account_type": "Receivable",
-                        "is_group": 1
-                    },
-                    "Otras cuentas por cobrar no comerciales": {
-                        "account_number": "11030300",
-                        "account_type": "Receivable",
-                        "is_group": 1
-                    },
-                    "account_number": "11030000",
-                    "account_type": "Receivable"
-                },
-                "GASTOS PAGADOS POR ANTICIPADO": {
-                    "Adelantos a empleados": {
-                        "account_number": "110904",
-                        "account_type": "Temporary",
-                        "is_group": 1
-                    },
-                    "Papeler\u00eda y \u00fatiles en existencia": {
-                        "account_number": "11090300",
-                        "account_type": "Temporary",
-                        "is_group": 1
-                    },
-                    "Primas de seguros aun no vendidas": {
-                        "account_number": "11090100",
-                        "account_type": "Temporary",
-                        "is_group": 1
-                    },
-                    "Rentas aun no corridas por los inmuebles": {
-                        "account_number": "11090200",
-                        "account_type": "Temporary",
-                        "is_group": 1
-                    },
-                    "account_number": "11090000",
-                    "account_type": "Temporary"
-                },
-                "INVENTARIOS": {
-                    "11050100 - Inventarios en bodega al costo - xmC": {
-                        "account_number": "11050100",
-                        "account_type": "Stock"
-                    },
-                    "11050300 - Pedidos en transito - xmC": {
-                        "account_number": "11050300",
-                        "account_type": "Stock Received But Not Billed"
-                    },
-                    "Estimaci\u00f3n para obsolescencia de inventarios o de lento movimiento (CR)": {
-                        "account_number": "11050200",
-                        "account_type": "Stock",
-                        "is_group": 1
-                    },
-                    "Mercader\u00edas en consignaci\u00f3n": {
-                        "account_number": "11050400",
-                        "account_type": "Stock",
-                        "is_group": 1
-                    },
-                    "account_number": "11050000",
-                    "account_type": "Stock"
-                },
-                "INVERSIONES TEMPORALES": {
-                    "Acciones": {
-                        "account_number": "11020100",
-                        "account_type": "Temporary",
-                        "is_group": 1
-                    },
-                    "Bonos": {
-                        "account_number": "11020200",
-                        "account_type": "Temporary",
-                        "is_group": 1
-                    },
-                    "C\u00e9dulas hipotecarias": {
-                        "account_number": "11020300",
-                        "account_type": "Temporary",
-                        "is_group": 1
-                    },
-                    "account_number": "11020000",
-                    "account_type": "Temporary"
-                },
-                "IVA CREDITO FISCAL": {
-                    "IVA compras locales": {
-                        "account_number": "11060100",
-                        "account_type": "Tax",
-                        "is_group": 1,
-                        "tax_rate": 13.0
-                    },
-                    "IVA importaciones": {
-                        "account_number": "11060200",
-                        "account_type": "Tax",
-                        "is_group": 1,
-                        "tax_rate": 13.0
-                    },
-                    "account_number": "11060000",
-                    "account_type": "Tax",
-                    "tax_rate": 13.0
-                },
-                "IVA PERCIBIDO": {
-                    "account_number": "IVA PERCIBIDO",
-                    "account_type": "Tax",
-                    "is_group": 1,
-                    "tax_rate": 1.0
-                },
-                "IVA RETENIDO": {
-                    "account_number": "11070000",
-                    "account_type": "Tax",
-                    "is_group": 1,
-                    "tax_rate": 1.0
-                },
-                "account_number": "11000000"
-            },
-            "12000000 - ACTIVOS NO CORRIENTES - xmC": {
-                "ACTIVOS INTANGIBLES": {
-                    "Concesiones y franquicias": {
-                        "account_number": "12080300",
-                        "account_type": "Fixed Asset",
-                        "is_group": 1
-                    },
-                    "Derechos de llave": {
-                        "account_number": "12080100",
-                        "account_type": "Fixed Asset",
-                        "is_group": 1
-                    },
-                    "Patentes y marcas de fabrica": {
-                        "account_number": "12080200",
-                        "account_type": "Fixed Asset",
-                        "is_group": 1
-                    },
-                    "Software": {
-                        "account_number": "12080400",
-                        "account_type": "Fixed Asset",
-                        "is_group": 1
-                    },
-                    "account_number": "12080000",
-                    "account_type": "Fixed Asset"
-                },
-                "CUENTAS POR COBRAR ARRENDAMIENTOS FINANCIEROS A LARGO PLAZO": {
-                    "Arrendamientos financieros por cobrar a largo plazo": {
-                        "account_number": "12060100",
-                        "account_type": "Receivable",
-                        "is_group": 1
-                    },
-                    "Estimaci\u00f3n para cuentas de cobro dudoso a largo plazo (CR)": {
-                        "account_number": "12060200",
-                        "account_type": "Receivable",
-                        "is_group": 1
-                    },
-                    "account_number": "12060000",
-                    "account_type": "Receivable"
-                },
-                "DEPRECIACION ACUMULUDA (CR)": {
-                    "12030100 - Deprec. acumulada de propiedades, planta y equipo propio al costo - xmC": {
-                        "account_number": "12030100",
-                        "account_type": "Accumulated Depreciation"
-                    },
-                    "Deprec. acumulada de prop., planta y equipo bajo arrend. Financiero": {
-                        "account_number": "12030200",
-                        "account_type": "Accumulated Depreciation",
-                        "is_group": 1
-                    },
-                    "Deprec. acumulada de revaluaos de propiedades, planta y equipo": {
-                        "account_number": "12030300",
-                        "account_type": "Accumulated Depreciation",
-                        "is_group": 1
-                    },
-                    "account_number": "12030000",
-                    "account_type": "Accumulated Depreciation"
-                },
-                "DEUDORES COMERCIALES Y OTRAS CUENTAS POR COBRAR A LARGO PLAZO": {
-                    "12050100 - Deudores comerciales a largo plazo - xmC": {
-                        "account_number": "12050100",
-                        "account_type": "Receivable",
-                        "is_group": 1
-                    },
-                    "Cuentas por cobrar no comerciales a largo plazo": {
-                        "account_number": "12050300",
-                        "account_type": "Receivable",
-                        "is_group": 1
-                    },
-                    "Estimaci\u00f3n para cuentas de cobro dudoso a largo plazo (CR)": {
-                        "account_number": "12050200",
-                        "account_type": "Receivable",
-                        "is_group": 1
-                    },
-                    "account_number": "12050000",
-                    "account_type": "Receivable"
-                },
-                "IMPUESTO SOBRE LA RENTA DIFERIDO-ACTIVO": {
-                    "12070200 - Pago anticipados de impuestos sobre la renta - xmC": {
-                        "account_number": "12070200",
-                        "account_type": "Temporary",
-                        "is_group": 1
-                    },
-                    "Cr\u00e9dito impuestos sobre la renta de a\u00f1os anteriores": {
-                        "account_number": "12070100",
-                        "account_type": "Tax",
-                        "is_group": 1
-                    },
-                    "account_number": "12070000",
-                    "account_type": "Tax"
-                },
-                "INVERSIONES PERMANENTES": {
-                    "Inversiones en asociadas": {
-                        "account_number": "12040200",
-                        "account_type": "Fixed Asset",
-                        "is_group": 1
-                    },
-                    "Inversiones en negocios conjuntos": {
-                        "account_number": "12040300",
-                        "account_type": "Fixed Asset",
-                        "is_group": 1
-                    },
-                    "Inversiones en subsidiarias": {
-                        "account_number": "12040100",
-                        "account_type": "Fixed Asset",
-                        "is_group": 1
-                    },
-                    "account_number": "12040000",
-                    "account_type": "Fixed Asset"
-                },
-                "PROPIEDADES, PLANTA Y EQUIPO": {
-                    "12010300 - Maquinarias y equipos - xmC": {
-                        "account_number": "12010300",
-                        "account_type": "Fixed Asset"
-                    },
-                    "Edificios": {
-                        "account_number": "12010200",
-                        "account_type": "Fixed Asset",
-                        "is_group": 1
-                    },
-                    "Mobiliario y equipo": {
-                        "account_number": "12010400",
-                        "account_type": "Fixed Asset",
-                        "is_group": 1
-                    },
-                    "Terrenos": {
-                        "account_number": "12010100",
-                        "account_type": "Fixed Asset",
-                        "is_group": 1
-                    },
-                    "Veh\u00edculos": {
-                        "account_number": "12010500",
-                        "account_type": "Fixed Asset",
-                        "is_group": 1
-                    },
-                    "account_number": "12010000",
-                    "account_type": "Fixed Asset"
-                },
-                "REVALUACIONES DE PROPIEDADES, PLANTA Y EQUIPO": {
-                    "Revaluaci\u00f3n de edificios": {
-                        "account_number": "12020200",
-                        "account_type": "Fixed Asset",
-                        "is_group": 1
-                    },
-                    "Revaluaci\u00f3n de maquinarias y equipo": {
-                        "account_number": "12020300",
-                        "account_type": "Fixed Asset",
-                        "is_group": 1
-                    },
-                    "Revaluaci\u00f3n de mobiliario y equipo": {
-                        "account_number": "12020400",
-                        "account_type": "Fixed Asset",
-                        "is_group": 1
-                    },
-                    "Revaluaci\u00f3n de terrenos": {
-                        "account_number": "12020100",
-                        "account_type": "Fixed Asset",
-                        "is_group": 1
-                    },
-                    "Revaluaci\u00f3n de veh\u00edculos": {
-                        "account_number": "12020500",
-                        "account_type": "Fixed Asset",
-                        "is_group": 1
-                    },
-                    "account_number": "12020000",
-                    "account_type": "Fixed Asset"
-                },
-                "account_number": "12000000",
-                "account_type": "Fixed Asset"
-            },
-            "account_number": "100000",
-            "root_type": "Asset"
-        },
-        "20000000 - PASIVOS - xmC": {
-            "PASIVOS CORRIENTES": {
-                "ACREEDORES COMERCIALES Y OTRAS CUENTAS POR PAGAR": {
-                    "21020100 - Cuentas por pagar comerciales - xmC": {
-                        "account_number": "21020100",
-                        "account_type": "Payable"
-                    },
-                    "Documentos por pagar comerciales": {
-                        "account_number": "21020200",
-                        "account_type": "Payable",
-                        "is_group": 1
-                    },
-                    "account_number": "21020000",
-                    "account_type": "Payable"
-                },
-                "BENEFICIOS A EMPLEADOS POR PAGAR": {
-                    "Beneficios a corto plazo por pagar": {
-                        "account_number": "21050100",
-                        "account_type": "Payable",
-                        "is_group": 1
-                    },
-                    "Beneficios post empleo por pagar": {
-                        "account_number": "21050200",
-                        "account_type": "Payable",
-                        "is_group": 1
-                    },
-                    "account_number": "21050000",
-                    "account_type": "Payable"
-                },
-                "DIVIDENDOS POR PAGAR": {
-                    "account_number": "21080000",
-                    "account_type": "Payable",
-                    "is_group": 1
-                },
-                "IMPUESTO SOBRE LA RENTA CORRIENTE POR PAGAR": {
-                    "account_number": "21070000",
-                    "account_type": "Tax",
-                    "is_group": 1
-                },
-                "IVA DEBITOS FISCALES": {
-                    "Por ventas a consumidores": {
-                        "account_number": "21060200",
-                        "account_type": "Tax",
-                        "is_group": 1
-                    },
-                    "Por ventas a contribuyentes": {
-                        "account_number": "21060100",
-                        "account_type": "Tax",
-                        "is_group": 1
-                    },
-                    "account_number": "21060000",
-                    "account_type": "Tax"
-                },
-                "OBLIGACIONES BAJO ARRENDAMIENTOS FINANCIEROS PORCION CORRIENTE": {
-                    "Contratos bajo arrendamientos financieros": {
-                        "account_number": "21030100",
-                        "account_type": "Payable",
-                        "is_group": 1
-                    },
-                    "account_number": "21030000",
-                    "account_type": "Payable"
-                },
-                "OTROS ACREEDORES, RETENCIONES Y DESCUENTOS": {
-                    "Cuentas por pagar a accionistas": {
-                        "account_number": "21040400",
-                        "account_type": "Payable",
-                        "is_group": 1
-                    },
-                    "Descuentos": {
-                        "account_number": "21040300",
-                        "account_type": "Payable",
-                        "is_group": 1
-                    },
-                    "Otros acreedores": {
-                        "account_number": "21040100",
-                        "account_type": "Payable",
-                        "is_group": 1
-                    },
-                    "Retenciones": {
-                        "account_number": "21040200",
-                        "account_type": "Payable",
-                        "is_group": 1
-                    },
-                    "account_number": "21040000",
-                    "account_type": "Payable"
-                },
-                "PRESTAMOS Y SOBREGIROS BANCARIOS": {
-                    "Porci\u00f3n corriente de prestamos bancarios a largo plazo": {
-                        "account_number": "21010300",
-                        "is_group": 1
-                    },
-                    "Prestamos bancarios a corto plazo": {
-                        "account_number": "21010100",
-                        "is_group": 1
-                    },
-                    "Sobregiros bancarios": {
-                        "account_number": "21010200",
-                        "is_group": 1
-                    },
-                    "account_number": "21010000"
-                },
-                "account_number": "21000000"
-            },
-            "PASIVOS NO CORRIENTES": {
-                "ANTICIPOS Y GARANTIAS DE CLIENTES": {
-                    "Anticipos de clientes": {
-                        "account_number": "22040100",
-                        "account_type": "Temporary",
-                        "is_group": 1
-                    },
-                    "Garant\u00edas de clientes": {
-                        "account_number": "22040200",
-                        "account_type": "Temporary",
-                        "is_group": 1
-                    },
-                    "account_number": "22040000",
-                    "account_type": "Temporary"
-                },
-                "INTERES MINOTARIO": {
-                    "Inter\u00e9s de accionista minotarios": {
-                        "account_number": "22050100",
-                        "is_group": 1
-                    },
-                    "account_number": "22050000"
-                },
-                "OBLIGACIONES BAJO ARRENDAMIENTOS FINANCIEROS A LARGO PLAZO": {
-                    "Contratos bajo arrendamientos financieros": {
-                        "account_number": "22030100",
-                        "is_group": 1
-                    },
-                    "account_number": "22030000"
-                },
-                "OTROS PRESTAMOS A LARGO PLAZO": {
-                    "account_number": "22020000",
-                    "is_group": 1
-                },
-                "PRESTAMOS BANCARIOS A LARGO PLAZO": {
-                    "account_number": "22010000",
-                    "is_group": 1
-                },
-                "account_number": "22000000"
-            },
-            "PROVISIONES": {
-                "IMPUESTOS SOBRE LA RENTA COMPLEMENTARIO": {
-                    "Ejercicios anteriores": {
-                        "account_number": "23010100",
-                        "account_type": "Tax",
-                        "is_group": 1
-                    },
-                    "account_number": "23010000",
-                    "account_type": "Tax"
-                },
-                "PROVISION PARA OBLIGACIONES LABORALES": {
-                    "Indemnizaci\u00f3n": {
-                        "account_number": "23020100",
-                        "is_group": 1
-                    },
-                    "account_number": "23020000"
-                },
-                "account_number": "23000000"
-            },
-            "account_number": "20000000",
-            "root_type": "Liability"
-        },
-        "30000000 - PATRIMONIO - xmC": {
-            "CAPITAL, RESERVAS Y RESULTADOS": {
-                "CAPITAL SOCIAL": {
-                    "Capital Social M\u00ednimo": {
-                        "Capital Social M\u00ednimo NO Pagado": {
-                            "account_number": "31010102",
-                            "account_type": "Equity",
-                            "is_group": 1
-                        },
-                        "Capital Social M\u00ednimo Suscrito": {
-                            "account_number": "31010101",
-                            "account_type": "Equity",
-                            "is_group": 1
-                        },
-                        "account_number": "31010100",
-                        "account_type": "Equity"
-                    },
-                    "Capital Social Variable": {
-                        "Capital Social Variable NO Pagado": {
-                            "account_number": "31010202",
-                            "account_type": "Equity",
-                            "is_group": 1
-                        },
-                        "Capital Social Variable Suscrito": {
-                            "account_number": "31010201",
-                            "account_type": "Equity",
-                            "is_group": 1
-                        },
-                        "account_number": "31010200",
-                        "account_type": "Equity"
-                    },
-                    "account_number": "31010000",
-                    "account_type": "Equity"
-                },
-                "DIVIDENDOS PAGADOS": {
-                    "account_number": "31060000",
-                    "account_type": "Equity",
-                    "is_group": 1
-                },
-                "GANANCIAS NO DISTRIBUIDAS": {
-                    "De ejercicios anteriores": {
-                        "account_number": "31020100",
-                        "account_type": "Equity",
-                        "is_group": 1
-                    },
-                    "Del presente ejercicio": {
-                        "account_number": "31020200",
-                        "account_type": "Equity",
-                        "is_group": 1
-                    },
-                    "account_number": "31020000",
-                    "account_type": "Equity"
-                },
-                "GANANCIAS RESTRINGIDAS": {
-                    "Reserva legal": {
-                        "account_number": "31030100",
-                        "account_type": "Equity",
-                        "is_group": 1
-                    },
-                    "account_number": "31030000",
-                    "account_type": "Equity"
-                },
-                "PERDIDAS ACUMULADAS (CR)": {
-                    "De ejercicios anteriores": {
-                        "account_number": "31050100",
-                        "account_type": "Equity",
-                        "is_group": 1
-                    },
-                    "Del presente ejercicio": {
-                        "account_number": "31050200",
-                        "account_type": "Equity",
-                        "is_group": 1
-                    },
-                    "account_number": "31050000",
-                    "account_type": "Equity"
-                },
-                "SUPERAVIT POR REVALUACIONES": {
-                    "Super\u00e1vit por revaluaci\u00f3n de activos": {
-                        "account_number": "31040100",
-                        "account_type": "Equity",
-                        "is_group": 1
-                    },
-                    "account_number": "31040000",
-                    "account_type": "Equity"
-                },
-                "account_number": "31000000",
-                "account_type": "Equity"
-            },
-            "account_number": "30000000",
-            "root_type": "Equity"
-        },
-        "40000000 - CUENTAS DE RESULTADO DEUDORAS - xmC": {
-            "COSTOS Y GASTOS DE OPERACI\u00d3N": {
-                "41010000 - COSTO DE LAS VENTAS - xmC": {
-                    "account_number": "41010000",
-                    "account_type": "Cost of Goods Sold"
-                },
-                "GASTOS DE DEPARTAMENTO DE OPERACIONES": {
-                    "41020600 - Depreciaciones y amortizaciones - xmC": {
-                        "account_number": "41020600",
-                        "account_type": "Depreciation"
-                    },
-                    "41020900 - Redondeos - xmC": {
-                        "account_number": "41020900",
-                        "account_type": "Round Off"
-                    },
-                    "Gastos operativos": {
-                        "account_number": "41020700",
-                        "account_type": "Chargeable",
-                        "is_group": 1
-                    },
-                    "Mantenimientos": {
-                        "account_number": "41020400",
-                        "account_type": "Chargeable",
-                        "is_group": 1
-                    },
-                    "Materiales y suministros": {
-                        "Ajustes de Inventario": {
-                            "account_number": "41020201",
-                            "account_type": "Stock Adjustment"
-                        },
-                        "account_number": "41020200",
-                        "account_type": "Chargeable"
-                    },
-                    "Seguros": {
-                        "account_number": "41020500",
-                        "account_type": "Chargeable",
-                        "is_group": 1
-                    },
-                    "Servicios b\u00e1sicos": {
-                        "account_number": "41020300",
-                        "account_type": "Chargeable",
-                        "is_group": 1
-                    },
-                    "Servicios y honorarios profesionales": {
-                        "account_number": "41020800",
-                        "account_type": "Chargeable",
-                        "is_group": 1
-                    },
-                    "Sueldos y prestaciones laborales": {
-                        "account_number": "41020100",
-                        "account_type": "Chargeable",
-                        "is_group": 1
-                    },
-                    "account_number": "41020000",
-                    "account_type": "Expense Account"
-                },
-                "GASTOS DE VENTAS Y DISTRIBUCION": {
-                    "Depreciaciones y amortizaciones": {
-                        "account_number": "41030600",
-                        "account_type": "Chargeable",
-                        "is_group": 1
-                    },
-                    "Gastos operativos": {
-                        "account_number": "41030700",
-                        "account_type": "Chargeable",
-                        "is_group": 1
-                    },
-                    "Mantenimientos": {
-                        "account_number": "41030400",
-                        "account_type": "Chargeable",
-                        "is_group": 1
-                    },
-                    "Materiales y suministros": {
-                        "account_number": "41030200",
-                        "account_type": "Chargeable",
-                        "is_group": 1
-                    },
-                    "Seguros": {
-                        "account_number": "41030500",
-                        "account_type": "Chargeable",
-                        "is_group": 1
-                    },
-                    "Servicios b\u00e1sicos": {
-                        "account_number": "41030300",
-                        "account_type": "Chargeable",
-                        "is_group": 1
-                    },
-                    "Servicios y honorarios profesionales": {
-                        "account_number": "41030800",
-                        "account_type": "Chargeable",
-                        "is_group": 1
-                    },
-                    "Sueldos y prestaciones laborales": {
-                        "account_number": "41030100",
-                        "account_type": "Chargeable",
-                        "is_group": 1
-                    },
-                    "account_number": "41030000",
-                    "account_type": "Expense Account"
-                },
-                "account_number": "41000000",
-                "account_type": "Expense Account"
-            },
-            "GASTOS DE IMPUESTO SOBRE LA RENTA": {
-                "GASTOS DE IMPUESTO SOBRE LA RENTA CORRIENTE": {
-                    "account_number": "43010000",
-                    "account_type": "Expense Account",
-                    "is_group": 1
-                },
-                "account_number": "43000000",
-                "account_type": "Expense Account"
-            },
-            "GASTOS DE NO OPERACI\u00d3N": {
-                "42020000 - GASTOS NO DEDUCIBLES - xmC": {
-                    "Garant\u00eda por venta de productos": {
-                        "account_number": "42020200",
-                        "account_type": "Expense Account",
-                        "is_group": 1
-                    },
-                    "Impuesto sobre la renta complementario": {
-                        "account_number": "42020100",
-                        "account_type": "Tax",
-                        "is_group": 1
-                    },
-                    "account_number": "42020000",
-                    "account_type": "Expense Account"
-                },
-                "GASTOS FINANCIEROS": {
-                    "42010100 - Intereses - xmC": {
-                        "account_number": "42010100",
-                        "account_type": "Expense Account",
-                        "is_group": 1
-                    },
-                    "42010300 - Diferenciales cambiarios - xmC": {
-                        "account_number": "42010300",
-                        "account_type": "Expense Account",
-                        "is_group": 1
-                    },
-                    "Comisiones bancarias": {
-                        "account_number": "42010200",
-                        "account_type": "Expense Account",
-                        "is_group": 1
-                    },
-                    "account_number": "42010000",
-                    "account_type": "Expense Account"
-                },
-                "account_number": "42000000",
-                "account_type": "Expense Account"
-            },
-            "account_number": "40000000",
-            "root_type": "Expense"
-        },
-        "50000000 - CUENTAS DE RESULTADO ACREEDORAS - xmC": {
-            "INGRESOS DE NO OPERACI\u00d3N": {
-                "DIVIDENDOS GANADOS": {
-                    "Dividendos devengados por inversiones": {
-                        "account_number": "52020100",
-                        "account_type": "Income Account",
-                        "is_group": 1
-                    },
-                    "account_number": "52020000",
-                    "account_type": "Income Account"
-                },
-                "INGRESOS FINANCIEROS": {
-                    "Comisiones": {
-                        "account_number": "52010200",
-                        "account_type": "Income Account",
-                        "is_group": 1
-                    },
-                    "Diferenciales cambiarios": {
-                        "account_number": "52010300",
-                        "account_type": "Income Account",
-                        "is_group": 1
-                    },
-                    "Intereses": {
-                        "account_number": "52010100",
-                        "account_type": "Income Account",
-                        "is_group": 1
-                    },
-                    "account_number": "52010000",
-                    "account_type": "Income Account"
-                },
-                "OTROS INGRESOS": {
-                    "Ingresos por activos dados en arrendamientos financieros": {
-                        "account_number": "52030200",
-                        "account_type": "Income Account",
-                        "is_group": 1
-                    },
-                    "Ingresos por conversi\u00f3n": {
-                        "account_number": "52030100",
-                        "account_type": "Income Account",
-                        "is_group": 1
-                    },
-                    "Reintegros de seguros": {
-                        "account_number": "52030300",
-                        "account_type": "Income Account",
-                        "is_group": 1
-                    },
-                    "account_number": "52030000",
-                    "account_type": "Income Account"
-                },
-                "account_number": "52000000",
-                "account_type": "Income Account"
-            },
-            "INGRESOS POR OPERACIONES CONTINUAS": {
-                "51010000 - VENTAS DE BIENES - xmC": {
-                    "account_number": "51010000",
-                    "account_type": "Income Account"
-                },
-                "VENTAS DE SERVICIOS": {
-                    "account_number": "51020000",
-                    "account_type": "Income Account",
-                    "is_group": 1
-                },
-                "account_number": "51000000",
-                "account_type": "Income Account"
-            },
-            "account_number": "50000000",
-            "root_type": "Income"
-        },
-        "60000000 - CUENTA LIQUIDADORA DE RESULTADOS - xmC": {
-            "CUENTA DE CIERRE": {
-                "PERDIDAS Y GANANCIAS": {
-                    "account_number": "61010000",
-                    "is_group": 1
-                },
-                "account_number": "61000000"
-            },
-            "account_number": "60000000",
-            "root_type": "Income"
-        }
-    }
-}

erpnext/accounts/doctype/account/chart_of_accounts/verified/id_chart_of_accounts.json

@@ -38,24 +38,24 @@
                 "Kas": {
                     "Kas Mata Uang Lain": {
                         "Kas USD": {
-                            "account_number": "1112.001", 
+                            "account_number": "1112.0010", 
                             "account_type": "Cash"
                         }, 
                         "account_number": "1112.000"
                     }, 
                     "Kas Rupiah": {
                         "Kas Besar": {
-                            "account_number": "1111.002", 
+                            "account_number": "1111.0020", 
                             "account_type": "Cash"
                         }, 
                         "Kas Kecil": {
-                            "account_number": "1111.001", 
+                            "account_number": "1111.0010", 
                             "account_type": "Cash"
                         }, 
                         "account_number": "1111.000", 
                         "account_type": "Cash"
                     }, 
-                    "account_number": "1110.000"
+                    "account_number": "1110.0000"
                 }, 
                 "Pendapatan Yang Akan di Terima": {
                     "Pendapatan Yang di Terima": {
@@ -98,7 +98,7 @@
                     }, 
                     "account_number": "1130.000"
                 }, 
-                "account_number": "1100.000"
+                "account_number": "1100.0000"
             }, 
             "Aktiva Tetap": {
                 "Aktiva": {
@@ -121,20 +121,20 @@
                 "Investasi": {
                     "Investasi": {
                         "Deposito": {
-                            "account_number": "1231.300", 
+                            "account_number": "1231.003", 
                             "is_group": 1
                         }, 
-                        "Investasi Saham": {
+                        "Investai Saham": {
                             "Investasi Saham": {
-                                "account_number": "1231.101"
+                                "account_number": "1231.0011"
                             }, 
-                            "account_number": "1231.100"
+                            "account_number": "1231.001"
                         }, 
                         "Investasi Perumahan": {
                             "Investasi Perumahan": {
-                                "account_number": "1231.201"
+                                "account_number": "1231.0021"
                             }, 
-                            "account_number": "1231.200"
+                            "account_number": "1231.002"
                         }, 
                         "account_number": "1231.000"
                     }, 
@@ -142,7 +142,7 @@
                 }, 
                 "account_number": "1200.000"
             }, 
-            "account_number": "1000.000", 
+            "account_number": "1000.0000", 
             "root_type": "Asset"
         }, 
         "Beban": {
@@ -684,4 +684,4 @@
             "root_type": "Income"
         }
     }
-}
+}

erpnext/accounts/doctype/account/chart_of_accounts/verified/standard_chart_of_accounts_with_account_number.py

@@ -245,9 +245,6 @@ def get():
                     "account_number": "2200"
                 },
                 _("Duties and Taxes"): {
-                    _("TDS Payable"): {
-                        "account_number": "2310"
-                    },
                     "account_type": "Tax",
                     "is_group": 1,
                     "account_number": "2300"

erpnext/accounts/doctype/account/test_account.py

@@ -5,7 +5,8 @@ from __future__ import unicode_literals
 import unittest
 import frappe
 from erpnext.stock import get_warehouse_account, get_company_default_inventory_account
-from erpnext.accounts.doctype.account.account import update_account_number, merge_account
+from erpnext.accounts.doctype.account.account import update_account_number
+from erpnext.accounts.doctype.account.account import merge_account
 
 class TestAccount(unittest.TestCase):
 	def test_rename_account(self):
@@ -68,7 +69,6 @@ class TestAccount(unittest.TestCase):
 			acc.account_name = "Accumulated Depreciation"
 			acc.parent_account = "Fixed Assets - _TC"
 			acc.company = "_Test Company"
-			acc.account_type = "Accumulated Depreciation"
 			acc.insert()
 
 		doc = frappe.get_doc("Account", "Securities and Deposits - _TC")
@@ -98,8 +98,7 @@ class TestAccount(unittest.TestCase):
 			"Softwares - _TC", doc.is_group, doc.root_type, doc.company)
 
 	def test_account_sync(self):
-		frappe.local.flags.pop("ignore_root_company_validation", None)
-
+		del frappe.local.flags["ignore_root_company_validation"]
 		acc = frappe.new_doc("Account")
 		acc.account_name = "Test Sync Account"
 		acc.parent_account = "Temporary Accounts - _TC3"
@@ -111,68 +110,7 @@ class TestAccount(unittest.TestCase):
 		self.assertEqual(acc_tc_4, "Test Sync Account - _TC4")
 		self.assertEqual(acc_tc_5, "Test Sync Account - _TC5")
 
-	def test_add_account_to_a_group(self):
-		frappe.db.set_value("Account", "Office Rent - _TC3", "is_group", 1)
-
-		acc = frappe.new_doc("Account")
-		acc.account_name = "Test Group Account"
-		acc.parent_account = "Office Rent - _TC3"
-		acc.company = "_Test Company 3"
-		self.assertRaises(frappe.ValidationError, acc.insert)
-
-		frappe.db.set_value("Account", "Office Rent - _TC3", "is_group", 0)
-
-	def test_account_rename_sync(self):
-		frappe.local.flags.pop("ignore_root_company_validation", None)
-
-		acc = frappe.new_doc("Account")
-		acc.account_name = "Test Rename Account"
-		acc.parent_account = "Temporary Accounts - _TC3"
-		acc.company = "_Test Company 3"
-		acc.insert()
-
-		# Rename account in parent company
-		update_account_number(acc.name, "Test Rename Sync Account", "1234")
-
-		# Check if renamed in children
-		self.assertTrue(frappe.db.exists("Account", {'account_name': "Test Rename Sync Account", "company": "_Test Company 4", "account_number": "1234"}))
-		self.assertTrue(frappe.db.exists("Account", {'account_name': "Test Rename Sync Account", "company": "_Test Company 5", "account_number": "1234"}))
-
-		frappe.delete_doc("Account", "1234 - Test Rename Sync Account - _TC3")
-		frappe.delete_doc("Account", "1234 - Test Rename Sync Account - _TC4")
-		frappe.delete_doc("Account", "1234 - Test Rename Sync Account - _TC5")
-
-	def test_child_company_account_rename_sync(self):
-		frappe.local.flags.pop("ignore_root_company_validation", None)
-
-		acc = frappe.new_doc("Account")
-		acc.account_name = "Test Group Account"
-		acc.parent_account = "Temporary Accounts - _TC3"
-		acc.is_group = 1
-		acc.company = "_Test Company 3"
-		acc.insert()
-
-		self.assertTrue(frappe.db.exists("Account", {'account_name': "Test Group Account", "company": "_Test Company 4"}))
-		self.assertTrue(frappe.db.exists("Account", {'account_name': "Test Group Account", "company": "_Test Company 5"}))
-
-		# Try renaming child company account
-		acc_tc_5 = frappe.db.get_value('Account', {'account_name': "Test Group Account", "company": "_Test Company 5"})
-		self.assertRaises(frappe.ValidationError, update_account_number, acc_tc_5, "Test Modified Account")
-
-		# Rename child company account with allow_account_creation_against_child_company enabled
-		frappe.db.set_value("Company", "_Test Company 5", "allow_account_creation_against_child_company", 1)
-
-		update_account_number(acc_tc_5, "Test Modified Account")
-		self.assertTrue(frappe.db.exists("Account", {'name': "Test Modified Account - _TC5", "company": "_Test Company 5"}))
-
-		frappe.db.set_value("Company", "_Test Company 5", "allow_account_creation_against_child_company", 0)
-
-		to_delete = ["Test Group Account - _TC3", "Test Group Account - _TC4", "Test Modified Account - _TC5"]
-		for doc in to_delete:
-			frappe.delete_doc("Account", doc)
-
-
-def _make_test_records(verbose=None):
+def _make_test_records(verbose):
 	from frappe.test_runner import make_test_objects
 
 	accounts = [
@@ -204,14 +142,12 @@ def _make_test_records(verbose=None):
 		["_Test Write Off", "Indirect Expenses", 0, None, None],
 		["_Test Exchange Gain/Loss", "Indirect Expenses", 0, None, None],
 
-		["_Test Account Sales", "Direct Income", 0, None, None],
-
 		# related to Account Inventory Integration
 		["_Test Account Stock In Hand", "Current Assets", 0, None, None],
 
 		# fixed asset depreciation
 		["_Test Fixed Asset", "Current Assets", 0, "Fixed Asset", None],
-		["_Test Accumulated Depreciations", "Current Assets", 0, "Accumulated Depreciation", None],
+		["_Test Accumulated Depreciations", "Current Assets", 0, None, None],
 		["_Test Depreciations", "Expenses", 0, None, None],
 		["_Test Gain/Loss on Asset Disposal", "Expenses", 0, None, None],
 
@@ -222,7 +158,7 @@ def _make_test_records(verbose=None):
 		["_Test Payable USD", "Current Liabilities", 0, "Payable", "USD"]
 	]
 
-	for company, abbr in [["_Test Company", "_TC"], ["_Test Company 1", "_TC1"], ["_Test Company with perpetual inventory", "TCP1"]]:
+	for company, abbr in [["_Test Company", "_TC"], ["_Test Company 1", "_TC1"]]:
 		test_objects = make_test_objects("Account", [{
 				"doctype": "Account",
 				"account_name": account_name,
@@ -254,8 +190,7 @@ def create_account(**kwargs):
 			account_name = kwargs.get('account_name'),
 			account_type = kwargs.get('account_type'),
 			parent_account = kwargs.get('parent_account'),
-			company = kwargs.get('company'),
-			account_currency = kwargs.get('account_currency')
+			company = kwargs.get('company')
 		))
 
 		account.save()

erpnext/accounts/doctype/account_subtype/account_subtype.js

@@ -0,0 +1,8 @@
+// Copyright (c) 2018, Frappe Technologies Pvt. Ltd. and contributors
+// For license information, please see license.txt
+
+frappe.ui.form.on('Account Subtype', {
+	refresh: function() {
+
+	}
+});

erpnext/accounts/doctype/account_subtype/account_subtype.json

@@ -0,0 +1,134 @@
+{
+ "allow_copy": 0, 
+ "allow_events_in_timeline": 0, 
+ "allow_guest_to_view": 0, 
+ "allow_import": 1, 
+ "allow_rename": 1, 
+ "autoname": "field:account_subtype", 
+ "beta": 0, 
+ "creation": "2018-10-25 15:46:08.054586", 
+ "custom": 0, 
+ "docstatus": 0, 
+ "doctype": "DocType", 
+ "document_type": "", 
+ "editable_grid": 1, 
+ "engine": "InnoDB", 
+ "fields": [
+  {
+   "allow_bulk_edit": 0, 
+   "allow_in_quick_entry": 0, 
+   "allow_on_submit": 0, 
+   "bold": 0, 
+   "collapsible": 0, 
+   "columns": 0, 
+   "fieldname": "account_subtype", 
+   "fieldtype": "Data", 
+   "hidden": 0, 
+   "ignore_user_permissions": 0, 
+   "ignore_xss_filter": 0, 
+   "in_filter": 0, 
+   "in_global_search": 0, 
+   "in_list_view": 0, 
+   "in_standard_filter": 0, 
+   "label": "Account Subtype", 
+   "length": 0, 
+   "no_copy": 0, 
+   "permlevel": 0, 
+   "precision": "", 
+   "print_hide": 0, 
+   "print_hide_if_no_value": 0, 
+   "read_only": 0, 
+   "remember_last_selected_value": 0, 
+   "report_hide": 0, 
+   "reqd": 0, 
+   "search_index": 0, 
+   "set_only_once": 0, 
+   "translatable": 0, 
+   "unique": 1
+  }
+ ], 
+ "has_web_view": 0, 
+ "hide_heading": 0, 
+ "hide_toolbar": 0, 
+ "idx": 0, 
+ "image_view": 0, 
+ "in_create": 0, 
+ "is_submittable": 0, 
+ "issingle": 0, 
+ "istable": 0, 
+ "max_attachments": 0, 
+ "modified": "2018-10-25 15:47:03.841390", 
+ "modified_by": "Administrator", 
+ "module": "Accounts", 
+ "name": "Account Subtype", 
+ "name_case": "", 
+ "owner": "Administrator", 
+ "permissions": [
+  {
+   "amend": 0, 
+   "cancel": 0, 
+   "create": 1, 
+   "delete": 1, 
+   "email": 1, 
+   "export": 1, 
+   "if_owner": 0, 
+   "import": 0, 
+   "permlevel": 0, 
+   "print": 1, 
+   "read": 1, 
+   "report": 1, 
+   "role": "System Manager", 
+   "set_user_permissions": 0, 
+   "share": 1, 
+   "submit": 0, 
+   "write": 1
+  }, 
+  {
+   "amend": 0, 
+   "cancel": 0, 
+   "create": 1, 
+   "delete": 1, 
+   "email": 1, 
+   "export": 1, 
+   "if_owner": 0, 
+   "import": 0, 
+   "permlevel": 0, 
+   "print": 1, 
+   "read": 1, 
+   "report": 1, 
+   "role": "Accounts Manager", 
+   "set_user_permissions": 0, 
+   "share": 1, 
+   "submit": 0, 
+   "write": 1
+  }, 
+  {
+   "amend": 0, 
+   "cancel": 0, 
+   "create": 1, 
+   "delete": 1, 
+   "email": 1, 
+   "export": 1, 
+   "if_owner": 0, 
+   "import": 0, 
+   "permlevel": 0, 
+   "print": 1, 
+   "read": 1, 
+   "report": 1, 
+   "role": "Accounts User", 
+   "set_user_permissions": 0, 
+   "share": 1, 
+   "submit": 0, 
+   "write": 1
+  }
+ ], 
+ "quick_entry": 1, 
+ "read_only": 0, 
+ "read_only_onload": 0, 
+ "show_name_in_global_search": 0, 
+ "sort_field": "modified", 
+ "sort_order": "DESC", 
+ "track_changes": 0, 
+ "track_seen": 0, 
+ "track_views": 0
+}

erpnext/accounts/doctype/account_subtype/account_subtype.py

@@ -0,0 +1,9 @@
+# -*- coding: utf-8 -*-
+# Copyright (c) 2018, Frappe Technologies Pvt. Ltd. and contributors
+# For license information, please see license.txt
+
+from __future__ import unicode_literals
+from frappe.model.document import Document
+
+class AccountSubtype(Document):
+	pass

erpnext/accounts/doctype/account_subtype/test_account_subtype.js

@@ -0,0 +1,23 @@
+/* eslint-disable */
+// rename this file from _test_[name] to test_[name] to activate
+// and remove above this line
+
+QUnit.test("test: Account Subtype", function (assert) {
+	let done = assert.async();
+
+	// number of asserts
+	assert.expect(1);
+
+	frappe.run_serially([
+		// insert a new Account Subtype
+		() => frappe.tests.make('Account Subtype', [
+			// values to be set
+			{key: 'value'}
+		]),
+		() => {
+			assert.equal(cur_frm.doc.key, 'value');
+		},
+		() => done()
+	]);
+
+});

erpnext/accounts/doctype/account_subtype/test_account_subtype.py

@@ -0,0 +1,9 @@
+# -*- coding: utf-8 -*-
+# Copyright (c) 2018, Frappe Technologies Pvt. Ltd. and Contributors
+# See license.txt
+from __future__ import unicode_literals
+
+import unittest
+
+class TestAccountSubtype(unittest.TestCase):
+	pass

erpnext/accounts/doctype/account_type/account_type.js

@@ -0,0 +1,8 @@
+// Copyright (c) 2018, Frappe Technologies Pvt. Ltd. and contributors
+// For license information, please see license.txt
+
+frappe.ui.form.on('Account Type', {
+	refresh: function() {
+
+	}
+});

erpnext/accounts/doctype/account_type/account_type.json

@@ -0,0 +1,134 @@
+{
+ "allow_copy": 0, 
+ "allow_events_in_timeline": 0, 
+ "allow_guest_to_view": 0, 
+ "allow_import": 1, 
+ "allow_rename": 1, 
+ "autoname": "field:account_type", 
+ "beta": 0, 
+ "creation": "2018-10-25 15:45:45.789963", 
+ "custom": 0, 
+ "docstatus": 0, 
+ "doctype": "DocType", 
+ "document_type": "", 
+ "editable_grid": 1, 
+ "engine": "InnoDB", 
+ "fields": [
+  {
+   "allow_bulk_edit": 0, 
+   "allow_in_quick_entry": 0, 
+   "allow_on_submit": 0, 
+   "bold": 0, 
+   "collapsible": 0, 
+   "columns": 0, 
+   "fieldname": "account_type", 
+   "fieldtype": "Data", 
+   "hidden": 0, 
+   "ignore_user_permissions": 0, 
+   "ignore_xss_filter": 0, 
+   "in_filter": 0, 
+   "in_global_search": 0, 
+   "in_list_view": 0, 
+   "in_standard_filter": 0, 
+   "label": "Account Type", 
+   "length": 0, 
+   "no_copy": 0, 
+   "permlevel": 0, 
+   "precision": "", 
+   "print_hide": 0, 
+   "print_hide_if_no_value": 0, 
+   "read_only": 0, 
+   "remember_last_selected_value": 0, 
+   "report_hide": 0, 
+   "reqd": 0, 
+   "search_index": 0, 
+   "set_only_once": 0, 
+   "translatable": 0, 
+   "unique": 1
+  }
+ ], 
+ "has_web_view": 0, 
+ "hide_heading": 0, 
+ "hide_toolbar": 0, 
+ "idx": 0, 
+ "image_view": 0, 
+ "in_create": 0, 
+ "is_submittable": 0, 
+ "issingle": 0, 
+ "istable": 0, 
+ "max_attachments": 0, 
+ "modified": "2018-10-25 15:46:51.042604", 
+ "modified_by": "Administrator", 
+ "module": "Accounts", 
+ "name": "Account Type", 
+ "name_case": "", 
+ "owner": "Administrator", 
+ "permissions": [
+  {
+   "amend": 0, 
+   "cancel": 0, 
+   "create": 1, 
+   "delete": 1, 
+   "email": 1, 
+   "export": 1, 
+   "if_owner": 0, 
+   "import": 0, 
+   "permlevel": 0, 
+   "print": 1, 
+   "read": 1, 
+   "report": 1, 
+   "role": "System Manager", 
+   "set_user_permissions": 0, 
+   "share": 1, 
+   "submit": 0, 
+   "write": 1
+  }, 
+  {
+   "amend": 0, 
+   "cancel": 0, 
+   "create": 1, 
+   "delete": 1, 
+   "email": 1, 
+   "export": 1, 
+   "if_owner": 0, 
+   "import": 0, 
+   "permlevel": 0, 
+   "print": 1, 
+   "read": 1, 
+   "report": 1, 
+   "role": "Accounts Manager", 
+   "set_user_permissions": 0, 
+   "share": 1, 
+   "submit": 0, 
+   "write": 1
+  }, 
+  {
+   "amend": 0, 
+   "cancel": 0, 
+   "create": 1, 
+   "delete": 1, 
+   "email": 1, 
+   "export": 1, 
+   "if_owner": 0, 
+   "import": 0, 
+   "permlevel": 0, 
+   "print": 1, 
+   "read": 1, 
+   "report": 1, 
+   "role": "Accounts User", 
+   "set_user_permissions": 0, 
+   "share": 1, 
+   "submit": 0, 
+   "write": 1
+  }
+ ], 
+ "quick_entry": 1, 
+ "read_only": 0, 
+ "read_only_onload": 0, 
+ "show_name_in_global_search": 0, 
+ "sort_field": "modified", 
+ "sort_order": "DESC", 
+ "track_changes": 0, 
+ "track_seen": 0, 
+ "track_views": 0
+}

erpnext/accounts/doctype/account_type/account_type.py

@@ -0,0 +1,9 @@
+# -*- coding: utf-8 -*-
+# Copyright (c) 2018, Frappe Technologies Pvt. Ltd. and contributors
+# For license information, please see license.txt
+
+from __future__ import unicode_literals
+from frappe.model.document import Document
+
+class AccountType(Document):
+	pass

erpnext/accounts/doctype/account_type/test_account_type.js

@@ -0,0 +1,23 @@
+/* eslint-disable */
+// rename this file from _test_[name] to test_[name] to activate
+// and remove above this line
+
+QUnit.test("test: Account Type", function (assert) {
+	let done = assert.async();
+
+	// number of asserts
+	assert.expect(1);
+
+	frappe.run_serially([
+		// insert a new Account Type
+		() => frappe.tests.make('Account Type', [
+			// values to be set
+			{key: 'value'}
+		]),
+		() => {
+			assert.equal(cur_frm.doc.key, 'value');
+		},
+		() => done()
+	]);
+
+});

erpnext/accounts/doctype/account_type/test_account_type.py

@@ -0,0 +1,9 @@
+# -*- coding: utf-8 -*-
+# Copyright (c) 2018, Frappe Technologies Pvt. Ltd. and Contributors
+# See license.txt
+from __future__ import unicode_literals
+
+import unittest
+
+class TestAccountType(unittest.TestCase):
+	pass

erpnext/accounts/doctype/accounting_dimension/accounting_dimension.js

@@ -1,63 +0,0 @@
-// Copyright (c) 2019, Frappe Technologies Pvt. Ltd. and contributors
-// For license information, please see license.txt
-
-frappe.ui.form.on('Accounting Dimension', {
-	refresh: function(frm) {
-		frm.set_query('document_type', () => {
-			let invalid_doctypes = frappe.model.core_doctypes_list;
-			invalid_doctypes.push('Accounting Dimension', 'Project',
-				'Cost Center', 'Accounting Dimension Detail', 'Company');
-
-			return {
-				filters: {
-					name: ['not in', invalid_doctypes]
-				}
-			};
-		});
-
-		if (!frm.is_new()) {
-			frm.add_custom_button(__('Show {0}', [frm.doc.document_type]), function () {
-				frappe.set_route("List", frm.doc.document_type);
-			});
-
-			let button = frm.doc.disabled ? "Enable" : "Disable";
-
-			frm.add_custom_button(__(button), function() {
-
-				frm.set_value('disabled', 1 - frm.doc.disabled);
-
-				frappe.call({
-					method: "erpnext.accounts.doctype.accounting_dimension.accounting_dimension.disable_dimension",
-					args: {
-						doc: frm.doc
-					},
-					freeze: true,
-					callback: function(r) {
-						let message = frm.doc.disabled ? "Dimension Disabled" : "Dimension Enabled";
-						frm.save();
-						frappe.show_alert({message:__(message), indicator:'green'});
-					}
-				});
-			});
-		}
-	},
-
-	document_type: function(frm) {
-
-		frm.set_value('label', frm.doc.document_type);
-		frm.set_value('fieldname', frappe.model.scrub(frm.doc.document_type));
-
-		frappe.db.get_value('Accounting Dimension', {'document_type': frm.doc.document_type}, 'document_type', (r) => {
-			if (r && r.document_type) {
-				frm.set_df_property('document_type', 'description', "Document type is already set as dimension");
-			}
-		});
-	},
-});
-
-frappe.ui.form.on('Accounting Dimension Detail', {
-	dimension_defaults_add: function(frm, cdt, cdn) {
-		let row = locals[cdt][cdn];
-		row.reference_document = frm.doc.document_type;
-	}
-});

erpnext/accounts/doctype/accounting_dimension/accounting_dimension.json

@@ -1,86 +0,0 @@
-{
- "actions": [],
- "autoname": "field:label",
- "creation": "2019-05-04 18:13:37.002352",
- "doctype": "DocType",
- "engine": "InnoDB",
- "field_order": [
-  "document_type",
-  "label",
-  "fieldname",
-  "dimension_defaults",
-  "disabled"
- ],
- "fields": [
-  {
-   "fieldname": "label",
-   "fieldtype": "Data",
-   "in_list_view": 1,
-   "label": "Dimension Name",
-   "unique": 1
-  },
-  {
-   "fieldname": "fieldname",
-   "fieldtype": "Data",
-   "hidden": 1,
-   "label": "Fieldname"
-  },
-  {
-   "fieldname": "document_type",
-   "fieldtype": "Link",
-   "label": "Reference Document Type",
-   "options": "DocType",
-   "read_only_depends_on": "eval:!doc.__islocal",
-   "reqd": 1
-  },
-  {
-   "default": "0",
-   "fieldname": "disabled",
-   "fieldtype": "Check",
-   "hidden": 1,
-   "label": "Disable",
-   "read_only": 1
-  },
-  {
-   "fieldname": "dimension_defaults",
-   "fieldtype": "Table",
-   "label": "Dimension Defaults",
-   "options": "Accounting Dimension Detail"
-  }
- ],
- "links": [],
- "modified": "2021-02-08 16:37:53.936656",
- "modified_by": "Administrator",
- "module": "Accounts",
- "name": "Accounting Dimension",
- "owner": "Administrator",
- "permissions": [
-  {
-   "create": 1,
-   "delete": 1,
-   "email": 1,
-   "export": 1,
-   "print": 1,
-   "read": 1,
-   "report": 1,
-   "role": "System Manager",
-   "share": 1,
-   "write": 1
-  },
-  {
-   "create": 1,
-   "delete": 1,
-   "email": 1,
-   "export": 1,
-   "print": 1,
-   "read": 1,
-   "report": 1,
-   "role": "Accounts Manager",
-   "share": 1,
-   "write": 1
-  }
- ],
- "sort_field": "modified",
- "sort_order": "ASC",
- "track_changes": 1
-}

erpnext/accounts/doctype/accounting_dimension/accounting_dimension.py

@@ -1,243 +0,0 @@
-# -*- coding: utf-8 -*-
-# Copyright (c) 2019, Frappe Technologies Pvt. Ltd. and contributors
-# For license information, please see license.txt
-
-from __future__ import unicode_literals
-import frappe
-from frappe import _
-import json
-from frappe.model.document import Document
-from frappe.custom.doctype.custom_field.custom_field import create_custom_field
-from frappe import scrub
-from frappe.utils import cstr
-from frappe.utils.background_jobs import enqueue
-from frappe.model import core_doctypes_list
-
-class AccountingDimension(Document):
-	def before_insert(self):
-		self.set_fieldname_and_label()
-
-	def validate(self):
-		if self.document_type in core_doctypes_list + ('Accounting Dimension', 'Project',
-				'Cost Center', 'Accounting Dimension Detail', 'Company') :
-
-			msg = _("Not allowed to create accounting dimension for {0}").format(self.document_type)
-			frappe.throw(msg)
-
-		exists = frappe.db.get_value("Accounting Dimension", {'document_type': self.document_type}, ['name'])
-
-		if exists and self.is_new():
-			frappe.throw(_("Document Type already used as a dimension"))
-
-		if not self.is_new():
-			self.validate_document_type_change()
-
-	def validate_document_type_change(self):
-		doctype_before_save = frappe.db.get_value("Accounting Dimension", self.name, "document_type")
-		if doctype_before_save != self.document_type:
-			message = _("Cannot change Reference Document Type.")
-			message += _("Please create a new Accounting Dimension if required.")
-			frappe.throw(message)
-
-	def after_insert(self):
-		if frappe.flags.in_test:
-			make_dimension_in_accounting_doctypes(doc=self)
-		else:
-			frappe.enqueue(make_dimension_in_accounting_doctypes, doc=self, queue='long')
-
-	def on_trash(self):
-		if frappe.flags.in_test:
-			delete_accounting_dimension(doc=self, queue='long')
-		else:
-			frappe.enqueue(delete_accounting_dimension, doc=self)
-
-	def set_fieldname_and_label(self):
-		if not self.label:
-			self.label = cstr(self.document_type)
-
-		if not self.fieldname:
-			self.fieldname = scrub(self.label)
-
-	def on_update(self):
-		frappe.flags.accounting_dimensions = None
-
-def make_dimension_in_accounting_doctypes(doc, doclist=None):
-	if not doclist:
-		doclist = get_doctypes_with_dimensions()
-
-	doc_count = len(get_accounting_dimensions())
-	count = 0
-
-	for doctype in doclist:
-
-		if (doc_count + 1) % 2 == 0:
-			insert_after_field = 'dimension_col_break'
-		else:
-			insert_after_field = 'accounting_dimensions_section'
-
-		df = {
-			"fieldname": doc.fieldname,
-			"label": doc.label,
-			"fieldtype": "Link",
-			"options": doc.document_type,
-			"insert_after": insert_after_field,
-			"owner": "Administrator"
-		}
-
-		meta = frappe.get_meta(doctype, cached=False)
-		fieldnames = [d.fieldname for d in meta.get("fields")]
-
-		if df['fieldname'] not in fieldnames:
-			if doctype == "Budget":
-				add_dimension_to_budget_doctype(df.copy(), doc)
-			else:
-				create_custom_field(doctype, df)
-
-		count += 1
-
-		frappe.publish_progress(count*100/len(doclist), title = _("Creating Dimensions..."))
-		frappe.clear_cache(doctype=doctype)
-
-def add_dimension_to_budget_doctype(df, doc):
-	df.update({
-		"insert_after": "cost_center",
-		"depends_on": "eval:doc.budget_against == '{0}'".format(doc.document_type)
-	})
-
-	create_custom_field("Budget", df)
-
-	property_setter = frappe.db.exists("Property Setter", "Budget-budget_against-options")
-
-	if property_setter:
-		property_setter_doc = frappe.get_doc("Property Setter", "Budget-budget_against-options")
-		property_setter_doc.value = property_setter_doc.value + "\n" + doc.document_type
-		property_setter_doc.save()
-
-		frappe.clear_cache(doctype='Budget')
-	else:
-		frappe.get_doc({
-			"doctype": "Property Setter",
-			"doctype_or_field": "DocField",
-			"doc_type": "Budget",
-			"field_name": "budget_against",
-			"property": "options",
-			"property_type": "Text",
-			"value": "\nCost Center\nProject\n" + doc.document_type
-		}).insert(ignore_permissions=True)
-
-
-def delete_accounting_dimension(doc):
-	doclist = get_doctypes_with_dimensions()
-
-	frappe.db.sql("""
-		DELETE FROM `tabCustom Field`
-		WHERE fieldname = %s
-		AND dt IN (%s)""" %			#nosec
-		('%s', ', '.join(['%s']* len(doclist))), tuple([doc.fieldname] + doclist))
-
-	frappe.db.sql("""
-		DELETE FROM `tabProperty Setter`
-		WHERE field_name = %s
-		AND doc_type IN (%s)""" %		#nosec
-		('%s', ', '.join(['%s']* len(doclist))), tuple([doc.fieldname] + doclist))
-
-	budget_against_property = frappe.get_doc("Property Setter", "Budget-budget_against-options")
-	value_list = budget_against_property.value.split('\n')[3:]
-
-	if doc.document_type in value_list:
-		value_list.remove(doc.document_type)
-
-	budget_against_property.value = "\nCost Center\nProject\n" + "\n".join(value_list)
-	budget_against_property.save()
-
-	for doctype in doclist:
-		frappe.clear_cache(doctype=doctype)
-
-@frappe.whitelist()
-def disable_dimension(doc):
-	if frappe.flags.in_test:
-		toggle_disabling(doc=doc)
-	else:
-		frappe.enqueue(toggle_disabling, doc=doc)
-
-def toggle_disabling(doc):
-	doc = json.loads(doc)
-
-	if doc.get('disabled'):
-		df = {"read_only": 1}
-	else:
-		df = {"read_only": 0}
-
-	doclist = get_doctypes_with_dimensions()
-
-	for doctype in doclist:
-		field = frappe.db.get_value("Custom Field", {"dt": doctype, "fieldname": doc.get('fieldname')})
-		if field:
-			custom_field = frappe.get_doc("Custom Field", field)
-			custom_field.update(df)
-			custom_field.save()
-
-		frappe.clear_cache(doctype=doctype)
-
-def get_doctypes_with_dimensions():
-	return frappe.get_hooks("accounting_dimension_doctypes")
-
-def get_accounting_dimensions(as_list=True):
-	if frappe.flags.accounting_dimensions is None:
-		frappe.flags.accounting_dimensions = frappe.get_all("Accounting Dimension",
-			fields=["label", "fieldname", "disabled", "document_type"])
-
-	if as_list:
-		return [d.fieldname for d in frappe.flags.accounting_dimensions]
-	else:
-		return frappe.flags.accounting_dimensions
-
-def get_checks_for_pl_and_bs_accounts():
-	dimensions = frappe.db.sql("""SELECT p.label, p.disabled, p.fieldname, c.default_dimension, c.company, c.mandatory_for_pl, c.mandatory_for_bs
-		FROM `tabAccounting Dimension`p ,`tabAccounting Dimension Detail` c
-		WHERE p.name = c.parent""", as_dict=1)
-
-	return dimensions
-
-def get_dimension_with_children(doctype, dimension):
-
-	if isinstance(dimension, list):
-		dimension = dimension[0]
-
-	all_dimensions = []
-	lft, rgt = frappe.db.get_value(doctype, dimension, ["lft", "rgt"])
-	children = frappe.get_all(doctype, filters={"lft": [">=", lft], "rgt": ["<=", rgt]}, order_by="lft")
-	all_dimensions += [c.name for c in children]
-
-	return all_dimensions
-
-@frappe.whitelist()
-def get_dimensions(with_cost_center_and_project=False):
-	dimension_filters = frappe.db.sql("""
-		SELECT label, fieldname, document_type
-		FROM `tabAccounting Dimension`
-		WHERE disabled = 0
-	""", as_dict=1)
-
-	default_dimensions = frappe.db.sql("""SELECT p.fieldname, c.company, c.default_dimension
-		FROM `tabAccounting Dimension Detail` c, `tabAccounting Dimension` p
-		WHERE c.parent = p.name""", as_dict=1)
-
-	if with_cost_center_and_project:
-		dimension_filters.extend([
-			{
-				'fieldname': 'cost_center',
-				'document_type': 'Cost Center'
-			},
-			{
-				'fieldname': 'project',
-				'document_type': 'Project'
-			}
-		])
-
-	default_dimensions_map = {}
-	for dimension in default_dimensions:
-		default_dimensions_map.setdefault(dimension.company, {})
-		default_dimensions_map[dimension.company][dimension.fieldname] = dimension.default_dimension
-
-	return dimension_filters, default_dimensions_map

erpnext/accounts/doctype/accounting_dimension/test_accounting_dimension.py

@@ -1,117 +0,0 @@
-# -*- coding: utf-8 -*-
-# Copyright (c) 2019, Frappe Technologies Pvt. Ltd. and Contributors
-# See license.txt
-from __future__ import unicode_literals
-
-import frappe
-import unittest
-from erpnext.accounts.doctype.sales_invoice.test_sales_invoice import create_sales_invoice
-from erpnext.accounts.doctype.journal_entry.test_journal_entry import make_journal_entry
-
-test_dependencies = ['Cost Center', 'Location', 'Warehouse', 'Department']
-
-class TestAccountingDimension(unittest.TestCase):
-	def setUp(self):
-		create_dimension()
-
-	def test_dimension_against_sales_invoice(self):
-		si = create_sales_invoice(do_not_save=1)
-
-		si.location = "Block 1"
-		si.append("items", {
-			"item_code": "_Test Item",
-			"warehouse": "_Test Warehouse - _TC",
-			"qty": 1,
-			"rate": 100,
-			"income_account": "Sales - _TC",
-			"expense_account": "Cost of Goods Sold - _TC",
-			"cost_center": "_Test Cost Center - _TC",
-			"department": "_Test Department - _TC",
-			"location": "Block 1"
-		})
-
-		si.save()
-		si.submit()
-
-		gle = frappe.get_doc("GL Entry", {"voucher_no": si.name, "account": "Sales - _TC"})
-
-		self.assertEqual(gle.get('department'), "_Test Department - _TC")
-
-	def test_dimension_against_journal_entry(self):
-		je = make_journal_entry("Sales - _TC", "Sales Expenses - _TC", 500, save=False)
-		je.accounts[0].update({"department": "_Test Department - _TC"})
-		je.accounts[1].update({"department": "_Test Department - _TC"})
-
-		je.accounts[0].update({"location": "Block 1"})
-		je.accounts[1].update({"location": "Block 1"})
-
-		je.save()
-		je.submit()
-
-		gle = frappe.get_doc("GL Entry", {"voucher_no": je.name, "account": "Sales - _TC"})
-		gle1 = frappe.get_doc("GL Entry", {"voucher_no": je.name, "account": "Sales Expenses - _TC"})
-		self.assertEqual(gle.get('department'), "_Test Department - _TC")
-		self.assertEqual(gle1.get('department'), "_Test Department - _TC")
-
-	def test_mandatory(self):
-		si = create_sales_invoice(do_not_save=1)
-		si.append("items", {
-			"item_code": "_Test Item",
-			"warehouse": "_Test Warehouse - _TC",
-			"qty": 1,
-			"rate": 100,
-			"income_account": "Sales - _TC",
-			"expense_account": "Cost of Goods Sold - _TC",
-			"cost_center": "_Test Cost Center - _TC",
-			"location": ""
-		})
-
-		si.save()
-		self.assertRaises(frappe.ValidationError, si.submit)
-
-	def tearDown(self):
-		disable_dimension()
-
-def create_dimension():
-	frappe.set_user("Administrator")
-
-	if not frappe.db.exists("Accounting Dimension", {"document_type": "Department"}):
-		frappe.get_doc({
-			"doctype": "Accounting Dimension",
-			"document_type": "Department",
-		}).insert()
-	else:
-		dimension = frappe.get_doc("Accounting Dimension", "Department")
-		dimension.disabled = 0
-		dimension.save()
-
-	if not frappe.db.exists("Accounting Dimension", {"document_type": "Location"}):
-		dimension1 = frappe.get_doc({
-			"doctype": "Accounting Dimension",
-			"document_type": "Location",
-		})
-
-		dimension1.append("dimension_defaults", {
-			"company": "_Test Company",
-			"reference_document": "Location",
-			"default_dimension": "Block 1",
-			"mandatory_for_bs": 1
-		})
-
-		dimension1.insert()
-		dimension1.save()
-	else:
-		dimension1 = frappe.get_doc("Accounting Dimension", "Location")
-		dimension1.disabled = 0
-		dimension1.save()
-
-def disable_dimension():
-	dimension1 = frappe.get_doc("Accounting Dimension", "Department")
-	dimension1.disabled = 1
-	dimension1.save()
-
-	dimension2 = frappe.get_doc("Accounting Dimension", "Location")
-	dimension2.disabled = 1
-	dimension2.save()
-
-

erpnext/accounts/doctype/accounting_dimension_detail/accounting_dimension_detail.json

@@ -1,65 +0,0 @@
-{
- "creation": "2019-07-16 17:53:18.718831",
- "doctype": "DocType",
- "editable_grid": 1,
- "engine": "InnoDB",
- "field_order": [
-  "company",
-  "reference_document",
-  "default_dimension",
-  "mandatory_for_bs",
-  "mandatory_for_pl"
- ],
- "fields": [
-  {
-   "columns": 2,
-   "fieldname": "company",
-   "fieldtype": "Link",
-   "in_list_view": 1,
-   "label": "Company",
-   "options": "Company"
-  },
-  {
-   "fieldname": "reference_document",
-   "fieldtype": "Link",
-   "hidden": 1,
-   "label": "Reference Document",
-   "options": "DocType",
-   "read_only": 1
-  },
-  {
-   "columns": 2,
-   "fieldname": "default_dimension",
-   "fieldtype": "Dynamic Link",
-   "in_list_view": 1,
-   "label": "Default Dimension",
-   "options": "reference_document"
-  },
-  {
-   "columns": 3,
-   "default": "0",
-   "fieldname": "mandatory_for_bs",
-   "fieldtype": "Check",
-   "in_list_view": 1,
-   "label": "Mandatory For Balance Sheet"
-  },
-  {
-   "columns": 3,
-   "default": "0",
-   "fieldname": "mandatory_for_pl",
-   "fieldtype": "Check",
-   "in_list_view": 1,
-   "label": "Mandatory For Profit and Loss Account"
-  }
- ],
- "istable": 1,
- "modified": "2019-08-15 11:59:09.389891",
- "modified_by": "Administrator",
- "module": "Accounts",
- "name": "Accounting Dimension Detail",
- "owner": "Administrator",
- "permissions": [],
- "sort_field": "modified",
- "sort_order": "DESC",
- "track_changes": 1
-}

erpnext/accounts/doctype/accounting_dimension_detail/accounting_dimension_detail.py

@@ -1,10 +0,0 @@
-# -*- coding: utf-8 -*-
-# Copyright (c) 2019, Frappe Technologies Pvt. Ltd. and contributors
-# For license information, please see license.txt
-
-from __future__ import unicode_literals
-# import frappe
-from frappe.model.document import Document
-
-class AccountingDimensionDetail(Document):
-	pass

erpnext/accounts/doctype/accounting_dimension_filter/accounting_dimension_filter.js

@@ -1,82 +0,0 @@
-// Copyright (c) 2020, Frappe Technologies Pvt. Ltd. and contributors
-// For license information, please see license.txt
-
-frappe.ui.form.on('Accounting Dimension Filter', {
-	refresh: function(frm, cdt, cdn) {
-		if (frm.doc.accounting_dimension) {
-			frm.set_df_property('dimensions', 'label', frm.doc.accounting_dimension, cdn, 'dimension_value');
-		}
-
-		let help_content =
-			`<table class="table table-bordered" style="background-color: #f9f9f9;">
-				<tr><td>
-					<p>
-						<i class="fa fa-hand-right"></i>
-						{{__('Note: On checking Is Mandatory the accounting dimension will become mandatory against that specific account for all accounting transactions')}}
-					</p>
-				</td></tr>
-			</table>`;
-
-		frm.set_df_property('dimension_filter_help', 'options', help_content);
-	},
-	onload: function(frm) {
-		frm.set_query('applicable_on_account', 'accounts', function() {
-			return {
-				filters: {
-					'company': frm.doc.company
-				}
-			};
-		});
-
-		frappe.db.get_list('Accounting Dimension',
-			{fields: ['document_type']}).then((res) => {
-			let options = ['Cost Center', 'Project'];
-
-			res.forEach((dimension) => {
-				options.push(dimension.document_type);
-			});
-
-			frm.set_df_property('accounting_dimension', 'options', options);
-		});
-
-		frm.trigger('setup_filters');
-	},
-
-	setup_filters: function(frm) {
-		let filters = {};
-
-		if (frm.doc.accounting_dimension) {
-			frappe.model.with_doctype(frm.doc.accounting_dimension, function() {
-				if (frappe.model.is_tree(frm.doc.accounting_dimension)) {
-					filters['is_group'] = 0;
-				}
-
-				if (frappe.meta.has_field(frm.doc.accounting_dimension, 'company')) {
-					filters['company'] = frm.doc.company;
-				}
-
-				frm.set_query('dimension_value', 'dimensions', function() {
-					return {
-						filters: filters
-					};
-				});
-			});
-		}
-	},
-
-	accounting_dimension: function(frm) {
-		frm.clear_table("dimensions");
-		let row = frm.add_child("dimensions");
-		row.accounting_dimension = frm.doc.accounting_dimension;
-		frm.refresh_field("dimensions");
-		frm.trigger('setup_filters');
-	},
-});
-
-frappe.ui.form.on('Allowed Dimension', {
-	dimensions_add: function(frm, cdt, cdn) {
-		let row = locals[cdt][cdn];
-		row.accounting_dimension = frm.doc.accounting_dimension;
-		frm.refresh_field("dimensions");
-	}
-});

erpnext/accounts/doctype/accounting_dimension_filter/accounting_dimension_filter.json

@@ -1,158 +0,0 @@
-{
- "actions": [],
- "autoname": "format:{accounting_dimension}-{#####}",
- "creation": "2020-11-08 18:28:11.906146",
- "doctype": "DocType",
- "editable_grid": 1,
- "engine": "InnoDB",
- "field_order": [
-  "accounting_dimension",
-  "disabled",
-  "column_break_2",
-  "company",
-  "allow_or_restrict",
-  "section_break_4",
-  "accounts",
-  "column_break_6",
-  "dimensions",
-  "section_break_10",
-  "dimension_filter_help"
- ],
- "fields": [
-  {
-   "fieldname": "accounting_dimension",
-   "fieldtype": "Select",
-   "in_list_view": 1,
-   "label": "Accounting Dimension",
-   "reqd": 1,
-   "show_days": 1,
-   "show_seconds": 1
-  },
-  {
-   "fieldname": "column_break_2",
-   "fieldtype": "Column Break",
-   "show_days": 1,
-   "show_seconds": 1
-  },
-  {
-   "fieldname": "section_break_4",
-   "fieldtype": "Section Break",
-   "hide_border": 1,
-   "show_days": 1,
-   "show_seconds": 1
-  },
-  {
-   "fieldname": "column_break_6",
-   "fieldtype": "Column Break",
-   "show_days": 1,
-   "show_seconds": 1
-  },
-  {
-   "fieldname": "allow_or_restrict",
-   "fieldtype": "Select",
-   "label": "Allow Or Restrict Dimension",
-   "options": "Allow\nRestrict",
-   "reqd": 1,
-   "show_days": 1,
-   "show_seconds": 1
-  },
-  {
-   "fieldname": "accounts",
-   "fieldtype": "Table",
-   "label": "Applicable On Account",
-   "options": "Applicable On Account",
-   "reqd": 1,
-   "show_days": 1,
-   "show_seconds": 1
-  },
-  {
-   "depends_on": "eval:doc.accounting_dimension",
-   "fieldname": "dimensions",
-   "fieldtype": "Table",
-   "label": "Applicable Dimension",
-   "options": "Allowed Dimension",
-   "reqd": 1,
-   "show_days": 1,
-   "show_seconds": 1
-  },
-  {
-   "default": "0",
-   "fieldname": "disabled",
-   "fieldtype": "Check",
-   "label": "Disabled",
-   "show_days": 1,
-   "show_seconds": 1
-  },
-  {
-   "fieldname": "company",
-   "fieldtype": "Link",
-   "label": "Company",
-   "options": "Company",
-   "reqd": 1,
-   "show_days": 1,
-   "show_seconds": 1
-  },
-  {
-   "fieldname": "dimension_filter_help",
-   "fieldtype": "HTML",
-   "label": "Dimension Filter Help",
-   "show_days": 1,
-   "show_seconds": 1
-  },
-  {
-   "fieldname": "section_break_10",
-   "fieldtype": "Section Break",
-   "show_days": 1,
-   "show_seconds": 1
-  }
- ],
- "index_web_pages_for_search": 1,
- "links": [],
- "modified": "2021-02-03 12:04:58.678402",
- "modified_by": "Administrator",
- "module": "Accounts",
- "name": "Accounting Dimension Filter",
- "owner": "Administrator",
- "permissions": [
-  {
-   "create": 1,
-   "delete": 1,
-   "email": 1,
-   "export": 1,
-   "print": 1,
-   "read": 1,
-   "report": 1,
-   "role": "System Manager",
-   "share": 1,
-   "write": 1
-  },
-  {
-   "create": 1,
-   "delete": 1,
-   "email": 1,
-   "export": 1,
-   "print": 1,
-   "read": 1,
-   "report": 1,
-   "role": "Accounts User",
-   "share": 1,
-   "write": 1
-  },
-  {
-   "create": 1,
-   "delete": 1,
-   "email": 1,
-   "export": 1,
-   "print": 1,
-   "read": 1,
-   "report": 1,
-   "role": "Accounts Manager",
-   "share": 1,
-   "write": 1
-  }
- ],
- "quick_entry": 1,
- "sort_field": "modified",
- "sort_order": "DESC",
- "track_changes": 1
-}

erpnext/accounts/doctype/accounting_dimension_filter/accounting_dimension_filter.py

@@ -1,61 +0,0 @@
-# -*- coding: utf-8 -*-
-# Copyright, (c) 2020, Frappe Technologies Pvt. Ltd. and contributors
-# For license information, please see license.txt
-
-from __future__ import unicode_literals
-import frappe
-from frappe import _, scrub
-from frappe.model.document import Document
-
-class AccountingDimensionFilter(Document):
-	def validate(self):
-		self.validate_applicable_accounts()
-
-	def validate_applicable_accounts(self):
-		accounts = frappe.db.sql(
-			"""
-				SELECT a.applicable_on_account as account
-				FROM `tabApplicable On Account` a, `tabAccounting Dimension Filter` d
-				WHERE d.name = a.parent
-				and d.name != %s
-				and d.accounting_dimension = %s
-			""", (self.name, self.accounting_dimension), as_dict=1)
-
-		account_list = [d.account for d in accounts]
-
-		for account in self.get('accounts'):
-			if account.applicable_on_account in account_list:
-				frappe.throw(_("Row {0}: {1} account already applied for Accounting Dimension {2}").format(
-					account.idx, frappe.bold(account.applicable_on_account), frappe.bold(self.accounting_dimension)))
-
-def get_dimension_filter_map():
-	filters = frappe.db.sql("""
-		SELECT
-			a.applicable_on_account, d.dimension_value, p.accounting_dimension,
-			p.allow_or_restrict, a.is_mandatory
-		FROM
-			`tabApplicable On Account` a, `tabAllowed Dimension` d,
-			`tabAccounting Dimension Filter` p
-		WHERE
-			p.name = a.parent
-			AND p.disabled = 0
-			AND p.name = d.parent
-	""", as_dict=1)
-
-	dimension_filter_map = {}
-
-	for f in filters:
-		f.fieldname = scrub(f.accounting_dimension)
-
-		build_map(dimension_filter_map, f.fieldname, f.applicable_on_account, f.dimension_value,
-			f.allow_or_restrict, f.is_mandatory)
-
-	return dimension_filter_map
-
-def build_map(map_object, dimension, account, filter_value, allow_or_restrict, is_mandatory):
-	map_object.setdefault((dimension, account), {
-		'allowed_dimensions': [],
-		'is_mandatory': is_mandatory,
-		'allow_or_restrict': allow_or_restrict
-	})
-	map_object[(dimension, account)]['allowed_dimensions'].append(filter_value)

erpnext/accounts/doctype/accounting_dimension_filter/test_accounting_dimension_filter.py

@@ -1,101 +0,0 @@
-# -*- coding: utf-8 -*-
-# Copyright (c) 2020, Frappe Technologies Pvt. Ltd. and Contributors
-# See license.txt
-from __future__ import unicode_literals
-
-import frappe
-import unittest
-from erpnext.accounts.doctype.sales_invoice.test_sales_invoice import create_sales_invoice
-from erpnext.accounts.doctype.accounting_dimension.test_accounting_dimension import create_dimension, disable_dimension
-from erpnext.exceptions import InvalidAccountDimensionError, MandatoryAccountDimensionError
-
-test_dependencies = ['Location', 'Cost Center', 'Department']
-
-class TestAccountingDimensionFilter(unittest.TestCase):
-	def setUp(self):
-		create_dimension()
-		create_accounting_dimension_filter()
-		self.invoice_list = []
-
-	def test_allowed_dimension_validation(self):
-		si = create_sales_invoice(do_not_save=1)
-		si.items[0].cost_center = 'Main - _TC'
-		si.department = 'Accounts - _TC'
-		si.location = 'Block 1'
-		si.save()
-
-		self.assertRaises(InvalidAccountDimensionError, si.submit)
-		self.invoice_list.append(si)
-
-	def test_mandatory_dimension_validation(self):
-		si = create_sales_invoice(do_not_save=1)
-		si.department = ''
-		si.location = 'Block 1'
-
-		# Test with no department for Sales Account
-		si.items[0].department = ''
-		si.items[0].cost_center = '_Test Cost Center 2 - _TC'
-		si.save()
-
-		self.assertRaises(MandatoryAccountDimensionError, si.submit)
-		self.invoice_list.append(si)
-
-	def tearDown(self):
-		disable_dimension_filter()
-		disable_dimension()
-
-		for si in self.invoice_list:
-			si.load_from_db()
-			if si.docstatus == 1:
-				si.cancel()
-
-def create_accounting_dimension_filter():
-	if not frappe.db.get_value('Accounting Dimension Filter',
-		{'accounting_dimension': 'Cost Center'}):
-		frappe.get_doc({
-			'doctype': 'Accounting Dimension Filter',
-			'accounting_dimension': 'Cost Center',
-			'allow_or_restrict': 'Allow',
-			'company': '_Test Company',
-			'accounts': [{
-				'applicable_on_account': 'Sales - _TC',
-			}],
-			'dimensions': [{
-				'accounting_dimension': 'Cost Center',
-				'dimension_value': '_Test Cost Center 2 - _TC'
-			}]
-		}).insert()
-	else:
-		doc = frappe.get_doc('Accounting Dimension Filter', {'accounting_dimension': 'Cost Center'})
-		doc.disabled = 0
-		doc.save()
-
-	if not frappe.db.get_value('Accounting Dimension Filter',
-		{'accounting_dimension': 'Department'}):
-		frappe.get_doc({
-			'doctype': 'Accounting Dimension Filter',
-			'accounting_dimension': 'Department',
-			'allow_or_restrict': 'Allow',
-			'company': '_Test Company',
-			'accounts': [{
-				'applicable_on_account': 'Sales - _TC',
-				'is_mandatory': 1
-			}],
-			'dimensions': [{
-				'accounting_dimension': 'Department',
-				'dimension_value': 'Accounts - _TC'
-			}]
-		}).insert()
-	else:
-		doc = frappe.get_doc('Accounting Dimension Filter', {'accounting_dimension': 'Department'})
-		doc.disabled = 0
-		doc.save()
-
-def disable_dimension_filter():
-	doc = frappe.get_doc('Accounting Dimension Filter', {'accounting_dimension': 'Cost Center'})
-	doc.disabled = 1
-	doc.save()
-
-	doc = frappe.get_doc('Accounting Dimension Filter', {'accounting_dimension': 'Department'})
-	doc.disabled = 1
-	doc.save()

erpnext/accounts/doctype/accounting_period/accounting_period.json

@@ -167,7 +167,39 @@
    "set_only_once": 0, 
    "translatable": 0, 
    "unique": 0
-  },
+  }, 
+  {
+   "allow_bulk_edit": 0, 
+   "allow_on_submit": 0, 
+   "bold": 0, 
+   "collapsible": 0, 
+   "columns": 0, 
+   "fieldname": "status", 
+   "fieldtype": "Select", 
+   "hidden": 0, 
+   "ignore_user_permissions": 0, 
+   "ignore_xss_filter": 0, 
+   "in_filter": 0, 
+   "in_global_search": 0, 
+   "in_list_view": 0, 
+   "in_standard_filter": 0, 
+   "label": "Status", 
+   "length": 0, 
+   "no_copy": 0, 
+   "options": "Open\nClosed", 
+   "permlevel": 0, 
+   "precision": "", 
+   "print_hide": 0, 
+   "print_hide_if_no_value": 0, 
+   "read_only": 0, 
+   "remember_last_selected_value": 0, 
+   "report_hide": 0, 
+   "reqd": 0, 
+   "search_index": 0, 
+   "set_only_once": 0, 
+   "translatable": 0, 
+   "unique": 0
+  }, 
   {
    "allow_bulk_edit": 0, 
    "allow_on_submit": 0, 
@@ -241,7 +273,7 @@
  "issingle": 0, 
  "istable": 0, 
  "max_attachments": 0, 
- "modified": "2019-08-01 19:14:47.593753", 
+ "modified": "2018-04-13 19:14:47.593753", 
  "modified_by": "Administrator", 
  "module": "Accounts", 
  "name": "Accounting Period", 

erpnext/accounts/doctype/accounting_period/accounting_period.py

@@ -5,9 +5,6 @@
 from __future__ import unicode_literals
 import frappe
 from frappe.model.document import Document
-from frappe import _
-
-class OverlapError(frappe.ValidationError): pass
 
 class AccountingPeriod(Document):
 	def validate(self):
@@ -19,7 +16,7 @@ class AccountingPeriod(Document):
 	def autoname(self):
 		company_abbr = frappe.get_cached_value('Company',  self.company,  "abbr")
 		self.name = " - ".join([self.period_name, company_abbr])
-
+	
 	def validate_overlap(self):
 		existing_accounting_period = frappe.db.sql("""select name from `tabAccounting Period`
 			where (
@@ -36,14 +33,12 @@ class AccountingPeriod(Document):
 			}, as_dict=True)
 
 		if len(existing_accounting_period) > 0:
-			frappe.throw(_("Accounting Period overlaps with {0}")
-				.format(existing_accounting_period[0].get("name")), OverlapError)
+			frappe.throw("Accounting Period overlaps with {0}".format(existing_accounting_period[0].get("name")))
 
-	@frappe.whitelist()
 	def get_doctypes_for_closing(self):
 		docs_for_closing = []
-		doctypes = ["Sales Invoice", "Purchase Invoice", "Journal Entry", "Payroll Entry", \
-			"Bank Clearance", "Asset", "Stock Entry"]
+		#if not self.closed_documents or len(self.closed_documents) == 0:
+		doctypes = ["Sales Invoice", "Purchase Invoice", "Journal Entry", "Payroll Entry", "Bank Reconciliation", "Asset", "Purchase Order", "Sales Order", "Leave Application", "Leave Allocation", "Stock Entry"]
 		closed_doctypes = [{"document_type": doctype, "closed": 1} for doctype in doctypes]
 		for closed_doctype in closed_doctypes:
 			docs_for_closing.append(closed_doctype)
@@ -56,4 +51,4 @@ class AccountingPeriod(Document):
 				self.append('closed_documents', {
 					"document_type": doctype_for_closing.document_type,
 					"closed": doctype_for_closing.closed
-				})
+				})

erpnext/accounts/doctype/accounting_period/test_accounting_period.py

@@ -5,44 +5,23 @@ from __future__ import unicode_literals
 
 import frappe
 import unittest
-from frappe.utils import nowdate, add_months
-from erpnext.accounts.general_ledger import ClosedAccountingPeriod
-from erpnext.accounts.doctype.accounting_period.accounting_period import OverlapError
-from erpnext.accounts.doctype.sales_invoice.test_sales_invoice import create_sales_invoice
 
-test_dependencies = ['Item']
-
-class TestAccountingPeriod(unittest.TestCase):
-	def test_overlap(self):
-		ap1 = create_accounting_period(start_date = "2018-04-01",
-			end_date = "2018-06-30", company = "Wind Power LLC")
-		ap1.save()
-
-		ap2 = create_accounting_period(start_date = "2018-06-30",
-			end_date = "2018-07-10", company = "Wind Power LLC", period_name = "Test Accounting Period 1")
-		self.assertRaises(OverlapError, ap2.save)
-
-	def test_accounting_period(self):
-		ap1 = create_accounting_period(period_name = "Test Accounting Period 2")
-		ap1.save()
-
-		doc = create_sales_invoice(do_not_submit=1, cost_center="_Test Company - _TC", warehouse="Stores - _TC")
-		self.assertRaises(ClosedAccountingPeriod, doc.submit)
-
-	def tearDown(self):
-		for d in frappe.get_all("Accounting Period"):
-			frappe.delete_doc("Accounting Period", d.name)
-
-def create_accounting_period(**args):
-	args = frappe._dict(args)
-
-	accounting_period = frappe.new_doc("Accounting Period")
-	accounting_period.start_date = args.start_date or nowdate()
-	accounting_period.end_date = args.end_date or add_months(nowdate(), 1)
-	accounting_period.company = args.company or "_Test Company"
-	accounting_period.period_name = args.period_name or "_Test_Period_Name_1"
-	accounting_period.append("closed_documents", {
-		"document_type": 'Sales Invoice', "closed": 1
-	})
-
-	return accounting_period
+# class TestAccountingPeriod(unittest.TestCase):
+# 	def test_overlap(self):
+# 		ap1 = create_accounting_period({"start_date":"2018-04-01", "end_date":"2018-06-30", "company":"Wind Power LLC"})
+# 		ap1.save()
+# 		ap2 = create_accounting_period({"start_date":"2018-06-30", "end_date":"2018-07-10", "company":"Wind Power LLC"})
+# 		self.assertRaises(frappe.OverlapError, accounting_period_2.save())
+#
+# 	def tearDown(self):
+# 		pass
+#
+#
+# def create_accounting_period(**args):
+# 	accounting_period = frappe.new_doc("Accounting Period")
+# 	accounting_period.start_date = args.start_date or frappe.utils.datetime.date(2018, 4, 1)
+# 	accounting_period.end_date = args.end_date or frappe.utils.datetime.date(2018, 6, 30)
+# 	accounting_period.company = args.company
+# 	accounting_period.period_name = "_Test_Period_Name_1"
+#
+# 	return accounting_period

erpnext/accounts/doctype/accounts_settings/accounts_settings.js

@@ -6,46 +6,3 @@ frappe.ui.form.on('Accounts Settings', {
 
 	}
 });
-
-frappe.tour['Accounts Settings'] = [
-	{
-		fieldname: "acc_frozen_upto",
-		title: "Accounts Frozen Upto",
-		description: __("Freeze accounting transactions up to specified date, nobody can make/modify entry except the specified Role."),
-	},
-	{
-		fieldname: "frozen_accounts_modifier",
-		title: "Role Allowed to Set Frozen Accounts & Edit Frozen Entries",
-		description: __("Users with this Role are allowed to set frozen accounts and create/modify accounting entries against frozen accounts.")
-	},
-	{
-		fieldname: "determine_address_tax_category_from",
-		title: "Determine Address Tax Category From",
-		description: __("Tax category can be set on Addresses. An address can be Shipping or Billing address. Set which addres to select when applying Tax Category.")
-	},
-	{
-		fieldname: "over_billing_allowance",
-		title: "Over Billing Allowance Percentage",
-		description: __("The percentage by which you can overbill transactions. For example, if the order value is $100 for an Item and percentage here is set as 10% then you are allowed to bill for $110.")
-	},
-	{
-		fieldname: "credit_controller",
-		title: "Credit Controller",
-		description: __("Select the role that is allowed to submit transactions that exceed credit limits set. The credit limit can be set in the Customer form.")
-	},
-	{
-		fieldname: "make_payment_via_journal_entry",
-		title: "Make Payment via Journal Entry",
-		description: __("When checked, if user proceeds to make payment from an invoice, the system will open a Journal Entry instead of a Payment Entry.")
-	},
-	{
-		fieldname: "unlink_payment_on_cancellation_of_invoice",
-		title: "Unlink Payment on Cancellation of Invoice",
-		description: __("If checked, system will unlink the payment against the respective invoice.")
-	},
-	{
-		fieldname: "unlink_advance_payment_on_cancelation_of_order",
-		title: "Unlink Advance Payment on Cancellation of Order",
-		description: __("Similar to the previous option, this unlinks any advance payments made against Purchase/Sales Orders.")
-	}
-];

erpnext/accounts/doctype/accounts_settings/accounts_settings.json

@@ -1,298 +1,717 @@
 {
- "actions": [],
- "creation": "2013-06-24 15:49:57",
- "description": "Settings for Accounts",
- "doctype": "DocType",
- "document_type": "Other",
- "editable_grid": 1,
- "engine": "InnoDB",
- "field_order": [
-  "accounts_transactions_settings_section",
-  "over_billing_allowance",
-  "role_allowed_to_over_bill",
-  "make_payment_via_journal_entry",
-  "column_break_11",
-  "check_supplier_invoice_uniqueness",
-  "unlink_payment_on_cancellation_of_invoice",
-  "automatically_fetch_payment_terms",
-  "delete_linked_ledger_entries",
-  "book_asset_depreciation_entry_automatically",
-  "unlink_advance_payment_on_cancelation_of_order",
-  "post_change_gl_entries",
-  "tax_settings_section",
-  "determine_address_tax_category_from",
-  "column_break_19",
-  "add_taxes_from_item_tax_template",
-  "period_closing_settings_section",
-  "acc_frozen_upto",
-  "frozen_accounts_modifier",
-  "column_break_4",
-  "credit_controller",
-  "deferred_accounting_settings_section",
-  "book_deferred_entries_based_on",
-  "column_break_18",
-  "automatically_process_deferred_accounting_entry",
-  "book_deferred_entries_via_journal_entry",
-  "submit_journal_entries",
-  "print_settings",
-  "show_inclusive_tax_in_print",
-  "column_break_12",
-  "show_payment_schedule_in_print",
-  "currency_exchange_section",
-  "allow_stale",
-  "stale_days",
-  "report_settings_sb",
-  "use_custom_cash_flow"
- ],
+ "allow_copy": 0, 
+ "allow_events_in_timeline": 0, 
+ "allow_guest_to_view": 0, 
+ "allow_import": 0, 
+ "allow_rename": 0, 
+ "beta": 0, 
+ "creation": "2013-06-24 15:49:57", 
+ "custom": 0, 
+ "description": "Settings for Accounts", 
+ "docstatus": 0, 
+ "doctype": "DocType", 
+ "document_type": "Other", 
+ "editable_grid": 1, 
+ "engine": "InnoDB", 
  "fields": [
   {
-   "description": "Accounting entries are frozen up to this date. Nobody can create or modify entries except users with the role specified below",
-   "fieldname": "acc_frozen_upto",
-   "fieldtype": "Date",
-   "in_list_view": 1,
-   "label": "Accounts Frozen Till Date"
-  },
+   "allow_bulk_edit": 0, 
+   "allow_in_quick_entry": 0, 
+   "allow_on_submit": 0, 
+   "bold": 0, 
+   "collapsible": 0, 
+   "columns": 0, 
+   "default": "1", 
+   "description": "If enabled, the system will post accounting entries for inventory automatically.", 
+   "fieldname": "auto_accounting_for_stock", 
+   "fieldtype": "Check", 
+   "hidden": 1, 
+   "ignore_user_permissions": 0, 
+   "ignore_xss_filter": 0, 
+   "in_filter": 0, 
+   "in_global_search": 0, 
+   "in_list_view": 1, 
+   "in_standard_filter": 0, 
+   "label": "Make Accounting Entry For Every Stock Movement", 
+   "length": 0, 
+   "no_copy": 0, 
+   "permlevel": 0, 
+   "print_hide": 0, 
+   "print_hide_if_no_value": 0, 
+   "read_only": 0, 
+   "remember_last_selected_value": 0, 
+   "report_hide": 0, 
+   "reqd": 0, 
+   "search_index": 0, 
+   "set_only_once": 0, 
+   "translatable": 0, 
+   "unique": 0
+  }, 
   {
-   "description": "Users with this role are allowed to set frozen accounts and create / modify accounting entries against frozen accounts",
-   "fieldname": "frozen_accounts_modifier",
-   "fieldtype": "Link",
-   "in_list_view": 1,
-   "label": "Role Allowed to Set Frozen Accounts and Edit Frozen Entries",
-   "options": "Role"
-  },
+   "allow_bulk_edit": 0, 
+   "allow_in_quick_entry": 0, 
+   "allow_on_submit": 0, 
+   "bold": 0, 
+   "collapsible": 0, 
+   "columns": 0, 
+   "description": "Accounting entry frozen up to this date, nobody can do / modify entry except role specified below.", 
+   "fieldname": "acc_frozen_upto", 
+   "fieldtype": "Date", 
+   "hidden": 0, 
+   "ignore_user_permissions": 0, 
+   "ignore_xss_filter": 0, 
+   "in_filter": 0, 
+   "in_global_search": 0, 
+   "in_list_view": 1, 
+   "in_standard_filter": 0, 
+   "label": "Accounts Frozen Upto", 
+   "length": 0, 
+   "no_copy": 0, 
+   "permlevel": 0, 
+   "print_hide": 0, 
+   "print_hide_if_no_value": 0, 
+   "read_only": 0, 
+   "remember_last_selected_value": 0, 
+   "report_hide": 0, 
+   "reqd": 0, 
+   "search_index": 0, 
+   "set_only_once": 0, 
+   "translatable": 0, 
+   "unique": 0
+  }, 
   {
-   "default": "Billing Address",
-   "description": "Address used to determine Tax Category in transactions",
-   "fieldname": "determine_address_tax_category_from",
-   "fieldtype": "Select",
-   "label": "Determine Address Tax Category From",
-   "options": "Billing Address\nShipping Address"
-  },
+   "allow_bulk_edit": 0, 
+   "allow_in_quick_entry": 0, 
+   "allow_on_submit": 0, 
+   "bold": 0, 
+   "collapsible": 0, 
+   "columns": 0, 
+   "description": "Users with this role are allowed to set frozen accounts and create / modify accounting entries against frozen accounts", 
+   "fieldname": "frozen_accounts_modifier", 
+   "fieldtype": "Link", 
+   "hidden": 0, 
+   "ignore_user_permissions": 0, 
+   "ignore_xss_filter": 0, 
+   "in_filter": 0, 
+   "in_global_search": 0, 
+   "in_list_view": 1, 
+   "in_standard_filter": 0, 
+   "label": "Role Allowed to Set Frozen Accounts & Edit Frozen Entries", 
+   "length": 0, 
+   "no_copy": 0, 
+   "options": "Role", 
+   "permlevel": 0, 
+   "print_hide": 0, 
+   "print_hide_if_no_value": 0, 
+   "read_only": 0, 
+   "remember_last_selected_value": 0, 
+   "report_hide": 0, 
+   "reqd": 0, 
+   "search_index": 0, 
+   "set_only_once": 0, 
+   "translatable": 0, 
+   "unique": 0
+  }, 
   {
-   "fieldname": "column_break_4",
-   "fieldtype": "Column Break"
-  },
+   "allow_bulk_edit": 0, 
+   "allow_in_quick_entry": 0, 
+   "allow_on_submit": 0, 
+   "bold": 0, 
+   "collapsible": 0, 
+   "columns": 0, 
+   "fieldname": "column_break_4", 
+   "fieldtype": "Column Break", 
+   "hidden": 0, 
+   "ignore_user_permissions": 0, 
+   "ignore_xss_filter": 0, 
+   "in_filter": 0, 
+   "in_global_search": 0, 
+   "in_list_view": 0, 
+   "in_standard_filter": 0, 
+   "length": 0, 
+   "no_copy": 0, 
+   "permlevel": 0, 
+   "precision": "", 
+   "print_hide": 0, 
+   "print_hide_if_no_value": 0, 
+   "read_only": 0, 
+   "remember_last_selected_value": 0, 
+   "report_hide": 0, 
+   "reqd": 0, 
+   "search_index": 0, 
+   "set_only_once": 0, 
+   "translatable": 0, 
+   "unique": 0
+  }, 
   {
-   "description": "This role is allowed to submit transactions that exceed credit limits",
-   "fieldname": "credit_controller",
-   "fieldtype": "Link",
-   "in_list_view": 1,
-   "label": "Credit Controller",
-   "options": "Role"
-  },
+   "allow_bulk_edit": 0, 
+   "allow_in_quick_entry": 0, 
+   "allow_on_submit": 0, 
+   "bold": 0, 
+   "collapsible": 0, 
+   "columns": 0, 
+   "description": "Role that is allowed to submit transactions that exceed credit limits set.", 
+   "fieldname": "credit_controller", 
+   "fieldtype": "Link", 
+   "hidden": 0, 
+   "ignore_user_permissions": 0, 
+   "ignore_xss_filter": 0, 
+   "in_filter": 0, 
+   "in_global_search": 0, 
+   "in_list_view": 1, 
+   "in_standard_filter": 0, 
+   "label": "Credit Controller", 
+   "length": 0, 
+   "no_copy": 0, 
+   "options": "Role", 
+   "permlevel": 0, 
+   "print_hide": 0, 
+   "print_hide_if_no_value": 0, 
+   "read_only": 0, 
+   "remember_last_selected_value": 0, 
+   "report_hide": 0, 
+   "reqd": 0, 
+   "search_index": 0, 
+   "set_only_once": 0, 
+   "translatable": 0, 
+   "unique": 0
+  }, 
   {
-   "default": "0",
-   "fieldname": "check_supplier_invoice_uniqueness",
-   "fieldtype": "Check",
-   "label": "Check Supplier Invoice Number Uniqueness"
-  },
+   "allow_bulk_edit": 0, 
+   "allow_in_quick_entry": 0, 
+   "allow_on_submit": 0, 
+   "bold": 0, 
+   "collapsible": 0, 
+   "columns": 0, 
+   "fieldname": "check_supplier_invoice_uniqueness", 
+   "fieldtype": "Check", 
+   "hidden": 0, 
+   "ignore_user_permissions": 0, 
+   "ignore_xss_filter": 0, 
+   "in_filter": 0, 
+   "in_global_search": 0, 
+   "in_list_view": 0, 
+   "in_standard_filter": 0, 
+   "label": "Check Supplier Invoice Number Uniqueness", 
+   "length": 0, 
+   "no_copy": 0, 
+   "permlevel": 0, 
+   "precision": "", 
+   "print_hide": 0, 
+   "print_hide_if_no_value": 0, 
+   "read_only": 0, 
+   "remember_last_selected_value": 0, 
+   "report_hide": 0, 
+   "reqd": 0, 
+   "search_index": 0, 
+   "set_only_once": 0, 
+   "translatable": 0, 
+   "unique": 0
+  }, 
   {
-   "default": "0",
-   "fieldname": "make_payment_via_journal_entry",
-   "fieldtype": "Check",
-   "hidden": 1,
-   "label": "Make Payment via Journal Entry"
-  },
+   "allow_bulk_edit": 0, 
+   "allow_in_quick_entry": 0, 
+   "allow_on_submit": 0, 
+   "bold": 0, 
+   "collapsible": 0, 
+   "columns": 0, 
+   "fieldname": "make_payment_via_journal_entry", 
+   "fieldtype": "Check", 
+   "hidden": 0, 
+   "ignore_user_permissions": 0, 
+   "ignore_xss_filter": 0, 
+   "in_filter": 0, 
+   "in_global_search": 0, 
+   "in_list_view": 0, 
+   "in_standard_filter": 0, 
+   "label": "Make Payment via Journal Entry", 
+   "length": 0, 
+   "no_copy": 0, 
+   "permlevel": 0, 
+   "precision": "", 
+   "print_hide": 0, 
+   "print_hide_if_no_value": 0, 
+   "read_only": 0, 
+   "remember_last_selected_value": 0, 
+   "report_hide": 0, 
+   "reqd": 0, 
+   "search_index": 0, 
+   "set_only_once": 0, 
+   "translatable": 0, 
+   "unique": 0
+  }, 
   {
-   "default": "1",
-   "fieldname": "unlink_payment_on_cancellation_of_invoice",
-   "fieldtype": "Check",
-   "label": "Unlink Payment on Cancellation of Invoice"
-  },
+   "allow_bulk_edit": 0, 
+   "allow_in_quick_entry": 0, 
+   "allow_on_submit": 0, 
+   "bold": 0, 
+   "collapsible": 0, 
+   "columns": 0, 
+   "default": "1", 
+   "fieldname": "unlink_payment_on_cancellation_of_invoice", 
+   "fieldtype": "Check", 
+   "hidden": 0, 
+   "ignore_user_permissions": 0, 
+   "ignore_xss_filter": 0, 
+   "in_filter": 0, 
+   "in_global_search": 0, 
+   "in_list_view": 0, 
+   "in_standard_filter": 0, 
+   "label": "Unlink Payment on Cancellation of Invoice", 
+   "length": 0, 
+   "no_copy": 0, 
+   "permlevel": 0, 
+   "precision": "", 
+   "print_hide": 0, 
+   "print_hide_if_no_value": 0, 
+   "read_only": 0, 
+   "remember_last_selected_value": 0, 
+   "report_hide": 0, 
+   "reqd": 0, 
+   "search_index": 0, 
+   "set_only_once": 0, 
+   "translatable": 0, 
+   "unique": 0
+  }, 
   {
-   "default": "1",
-   "fieldname": "unlink_advance_payment_on_cancelation_of_order",
-   "fieldtype": "Check",
-   "label": "Unlink Advance Payment on Cancellation of Order"
-  },
+   "allow_bulk_edit": 0, 
+   "allow_in_quick_entry": 0, 
+   "allow_on_submit": 0, 
+   "bold": 0, 
+   "collapsible": 0, 
+   "columns": 0, 
+   "default": "1", 
+   "fieldname": "book_asset_depreciation_entry_automatically", 
+   "fieldtype": "Check", 
+   "hidden": 0, 
+   "ignore_user_permissions": 0, 
+   "ignore_xss_filter": 0, 
+   "in_filter": 0, 
+   "in_global_search": 0, 
+   "in_list_view": 0, 
+   "in_standard_filter": 0, 
+   "label": "Book Asset Depreciation Entry Automatically", 
+   "length": 0, 
+   "no_copy": 0, 
+   "permlevel": 0, 
+   "precision": "", 
+   "print_hide": 0, 
+   "print_hide_if_no_value": 0, 
+   "read_only": 0, 
+   "remember_last_selected_value": 0, 
+   "report_hide": 0, 
+   "reqd": 0, 
+   "search_index": 0, 
+   "set_only_once": 0, 
+   "translatable": 0, 
+   "unique": 0
+  }, 
   {
-   "default": "1",
-   "fieldname": "book_asset_depreciation_entry_automatically",
-   "fieldtype": "Check",
-   "label": "Book Asset Depreciation Entry Automatically"
-  },
+   "allow_bulk_edit": 0, 
+   "allow_in_quick_entry": 0, 
+   "allow_on_submit": 0, 
+   "bold": 0, 
+   "collapsible": 0, 
+   "columns": 0, 
+   "fieldname": "allow_cost_center_in_entry_of_bs_account", 
+   "fieldtype": "Check", 
+   "hidden": 0, 
+   "ignore_user_permissions": 0, 
+   "ignore_xss_filter": 0, 
+   "in_filter": 0, 
+   "in_global_search": 0, 
+   "in_list_view": 0, 
+   "in_standard_filter": 0, 
+   "label": "Allow Cost Center In Entry of Balance Sheet Account", 
+   "length": 0, 
+   "no_copy": 0, 
+   "permlevel": 0, 
+   "precision": "", 
+   "print_hide": 0, 
+   "print_hide_if_no_value": 0, 
+   "read_only": 0, 
+   "remember_last_selected_value": 0, 
+   "report_hide": 0, 
+   "reqd": 0, 
+   "search_index": 0, 
+   "set_only_once": 0, 
+   "translatable": 0, 
+   "unique": 0
+  }, 
   {
-   "default": "1",
-   "fieldname": "add_taxes_from_item_tax_template",
-   "fieldtype": "Check",
-   "label": "Automatically Add Taxes and Charges from Item Tax Template"
-  },
+   "allow_bulk_edit": 0, 
+   "allow_in_quick_entry": 0, 
+   "allow_on_submit": 0, 
+   "bold": 0, 
+   "collapsible": 0, 
+   "columns": 0, 
+   "fieldname": "print_settings", 
+   "fieldtype": "Section Break", 
+   "hidden": 0, 
+   "ignore_user_permissions": 0, 
+   "ignore_xss_filter": 0, 
+   "in_filter": 0, 
+   "in_global_search": 0, 
+   "in_list_view": 0, 
+   "in_standard_filter": 0, 
+   "label": "Print Settings", 
+   "length": 0, 
+   "no_copy": 0, 
+   "permlevel": 0, 
+   "precision": "", 
+   "print_hide": 0, 
+   "print_hide_if_no_value": 0, 
+   "read_only": 0, 
+   "remember_last_selected_value": 0, 
+   "report_hide": 0, 
+   "reqd": 0, 
+   "search_index": 0, 
+   "set_only_once": 0, 
+   "translatable": 0, 
+   "unique": 0
+  }, 
   {
-   "fieldname": "print_settings",
-   "fieldtype": "Section Break",
-   "label": "Print Settings"
-  },
+   "allow_bulk_edit": 0, 
+   "allow_in_quick_entry": 0, 
+   "allow_on_submit": 0, 
+   "bold": 0, 
+   "collapsible": 0, 
+   "columns": 0, 
+   "fieldname": "show_inclusive_tax_in_print", 
+   "fieldtype": "Check", 
+   "hidden": 0, 
+   "ignore_user_permissions": 0, 
+   "ignore_xss_filter": 0, 
+   "in_filter": 0, 
+   "in_global_search": 0, 
+   "in_list_view": 0, 
+   "in_standard_filter": 0, 
+   "label": "Show Inclusive Tax In Print", 
+   "length": 0, 
+   "no_copy": 0, 
+   "permlevel": 0, 
+   "precision": "", 
+   "print_hide": 0, 
+   "print_hide_if_no_value": 0, 
+   "read_only": 0, 
+   "remember_last_selected_value": 0, 
+   "report_hide": 0, 
+   "reqd": 0, 
+   "search_index": 0, 
+   "set_only_once": 0, 
+   "translatable": 0, 
+   "unique": 0
+  }, 
   {
-   "default": "0",
-   "fieldname": "show_inclusive_tax_in_print",
-   "fieldtype": "Check",
-   "label": "Show Inclusive Tax in Print"
-  },
+   "allow_bulk_edit": 0, 
+   "allow_in_quick_entry": 0, 
+   "allow_on_submit": 0, 
+   "bold": 0, 
+   "collapsible": 0, 
+   "columns": 0, 
+   "fieldname": "column_break_12", 
+   "fieldtype": "Column Break", 
+   "hidden": 0, 
+   "ignore_user_permissions": 0, 
+   "ignore_xss_filter": 0, 
+   "in_filter": 0, 
+   "in_global_search": 0, 
+   "in_list_view": 0, 
+   "in_standard_filter": 0, 
+   "length": 0, 
+   "no_copy": 0, 
+   "permlevel": 0, 
+   "precision": "", 
+   "print_hide": 0, 
+   "print_hide_if_no_value": 0, 
+   "read_only": 0, 
+   "remember_last_selected_value": 0, 
+   "report_hide": 0, 
+   "reqd": 0, 
+   "search_index": 0, 
+   "set_only_once": 0, 
+   "translatable": 0, 
+   "unique": 0
+  }, 
   {
-   "fieldname": "column_break_12",
-   "fieldtype": "Column Break"
-  },
+   "allow_bulk_edit": 0, 
+   "allow_in_quick_entry": 0, 
+   "allow_on_submit": 0, 
+   "bold": 0, 
+   "collapsible": 0, 
+   "columns": 0, 
+   "fieldname": "show_payment_schedule_in_print", 
+   "fieldtype": "Check", 
+   "hidden": 0, 
+   "ignore_user_permissions": 0, 
+   "ignore_xss_filter": 0, 
+   "in_filter": 0, 
+   "in_global_search": 0, 
+   "in_list_view": 0, 
+   "in_standard_filter": 0, 
+   "label": "Show Payment Schedule in Print", 
+   "length": 0, 
+   "no_copy": 0, 
+   "permlevel": 0, 
+   "precision": "", 
+   "print_hide": 0, 
+   "print_hide_if_no_value": 0, 
+   "read_only": 0, 
+   "remember_last_selected_value": 0, 
+   "report_hide": 0, 
+   "reqd": 0, 
+   "search_index": 0, 
+   "set_only_once": 0, 
+   "translatable": 0, 
+   "unique": 0
+  }, 
   {
-   "default": "0",
-   "fieldname": "show_payment_schedule_in_print",
-   "fieldtype": "Check",
-   "label": "Show Payment Schedule in Print"
-  },
+   "allow_bulk_edit": 0, 
+   "allow_in_quick_entry": 0, 
+   "allow_on_submit": 0, 
+   "bold": 0, 
+   "collapsible": 0, 
+   "columns": 0, 
+   "fieldname": "currency_exchange_section", 
+   "fieldtype": "Section Break", 
+   "hidden": 0, 
+   "ignore_user_permissions": 0, 
+   "ignore_xss_filter": 0, 
+   "in_filter": 0, 
+   "in_global_search": 0, 
+   "in_list_view": 0, 
+   "in_standard_filter": 0, 
+   "label": "Currency Exchange Settings", 
+   "length": 0, 
+   "no_copy": 0, 
+   "permlevel": 0, 
+   "precision": "", 
+   "print_hide": 0, 
+   "print_hide_if_no_value": 0, 
+   "read_only": 0, 
+   "remember_last_selected_value": 0, 
+   "report_hide": 0, 
+   "reqd": 0, 
+   "search_index": 0, 
+   "set_only_once": 0, 
+   "translatable": 0, 
+   "unique": 0
+  }, 
   {
-   "fieldname": "currency_exchange_section",
-   "fieldtype": "Section Break",
-   "label": "Currency Exchange Settings"
-  },
+   "allow_bulk_edit": 0, 
+   "allow_in_quick_entry": 0, 
+   "allow_on_submit": 0, 
+   "bold": 0, 
+   "collapsible": 0, 
+   "columns": 0, 
+   "default": "1", 
+   "fieldname": "allow_stale", 
+   "fieldtype": "Check", 
+   "hidden": 0, 
+   "ignore_user_permissions": 0, 
+   "ignore_xss_filter": 0, 
+   "in_filter": 0, 
+   "in_global_search": 0, 
+   "in_list_view": 1, 
+   "in_standard_filter": 0, 
+   "label": "Allow Stale Exchange Rates", 
+   "length": 0, 
+   "no_copy": 0, 
+   "permlevel": 0, 
+   "precision": "", 
+   "print_hide": 0, 
+   "print_hide_if_no_value": 0, 
+   "read_only": 0, 
+   "remember_last_selected_value": 0, 
+   "report_hide": 0, 
+   "reqd": 0, 
+   "search_index": 0, 
+   "set_only_once": 0, 
+   "translatable": 0, 
+   "unique": 0
+  }, 
   {
-   "default": "1",
-   "fieldname": "allow_stale",
-   "fieldtype": "Check",
-   "in_list_view": 1,
-   "label": "Allow Stale Exchange Rates"
-  },
+   "allow_bulk_edit": 0, 
+   "allow_in_quick_entry": 0, 
+   "allow_on_submit": 0, 
+   "bold": 0, 
+   "collapsible": 0, 
+   "columns": 0, 
+   "default": "1", 
+   "depends_on": "eval:doc.allow_stale==0", 
+   "fieldname": "stale_days", 
+   "fieldtype": "Int", 
+   "hidden": 0, 
+   "ignore_user_permissions": 0, 
+   "ignore_xss_filter": 0, 
+   "in_filter": 0, 
+   "in_global_search": 0, 
+   "in_list_view": 0, 
+   "in_standard_filter": 0, 
+   "label": "Stale Days", 
+   "length": 0, 
+   "no_copy": 0, 
+   "permlevel": 0, 
+   "precision": "", 
+   "print_hide": 0, 
+   "print_hide_if_no_value": 0, 
+   "read_only": 0, 
+   "remember_last_selected_value": 0, 
+   "report_hide": 0, 
+   "reqd": 0, 
+   "search_index": 0, 
+   "set_only_once": 0, 
+   "translatable": 0, 
+   "unique": 0
+  }, 
   {
-   "default": "1",
-   "depends_on": "eval:doc.allow_stale==0",
-   "fieldname": "stale_days",
-   "fieldtype": "Int",
-   "label": "Stale Days"
-  },
+   "allow_bulk_edit": 0, 
+   "allow_in_quick_entry": 0, 
+   "allow_on_submit": 0, 
+   "bold": 0, 
+   "collapsible": 0, 
+   "columns": 0, 
+   "fieldname": "report_settings_sb", 
+   "fieldtype": "Section Break", 
+   "hidden": 0, 
+   "ignore_user_permissions": 0, 
+   "ignore_xss_filter": 0, 
+   "in_filter": 0, 
+   "in_global_search": 0, 
+   "in_list_view": 0, 
+   "in_standard_filter": 0, 
+   "label": "Report Settings", 
+   "length": 0, 
+   "no_copy": 0, 
+   "permlevel": 0, 
+   "precision": "", 
+   "print_hide": 0, 
+   "print_hide_if_no_value": 0, 
+   "read_only": 0, 
+   "remember_last_selected_value": 0, 
+   "report_hide": 0, 
+   "reqd": 0, 
+   "search_index": 0, 
+   "set_only_once": 0, 
+   "translatable": 0, 
+   "unique": 0
+  }, 
   {
-   "fieldname": "report_settings_sb",
-   "fieldtype": "Section Break",
-   "label": "Report Settings"
-  },
-  {
-   "default": "0",
-   "description": "Only select this if you have set up the Cash Flow Mapper documents",
-   "fieldname": "use_custom_cash_flow",
-   "fieldtype": "Check",
-   "label": "Use Custom Cash Flow Format"
-  },
-  {
-   "default": "0",
-   "fieldname": "automatically_fetch_payment_terms",
-   "fieldtype": "Check",
-   "label": "Automatically Fetch Payment Terms"
-  },
-  {
-   "description": "The percentage you are allowed to bill more against the amount ordered. For example, if the order value is $100 for an item and tolerance is set as 10%, then you are allowed to bill up to $110 ",
-   "fieldname": "over_billing_allowance",
-   "fieldtype": "Currency",
-   "label": "Over Billing Allowance (%)"
-  },
-  {
-   "default": "1",
-   "fieldname": "automatically_process_deferred_accounting_entry",
-   "fieldtype": "Check",
-   "label": "Automatically Process Deferred Accounting Entry"
-  },
-  {
-   "fieldname": "deferred_accounting_settings_section",
-   "fieldtype": "Section Break",
-   "label": "Deferred Accounting Settings"
-  },
-  {
-   "fieldname": "column_break_18",
-   "fieldtype": "Column Break"
-  },
-  {
-   "default": "0",
-   "description": "If this is unchecked, direct GL entries will be created to book deferred revenue or expense",
-   "fieldname": "book_deferred_entries_via_journal_entry",
-   "fieldtype": "Check",
-   "label": "Book Deferred Entries Via Journal Entry"
-  },
-  {
-   "default": "0",
-   "depends_on": "eval:doc.book_deferred_entries_via_journal_entry",
-   "description": "If this is unchecked Journal Entries will be saved in a Draft state and will have to be submitted manually",
-   "fieldname": "submit_journal_entries",
-   "fieldtype": "Check",
-   "label": "Submit Journal Entries"
-  },
-  {
-   "default": "Days",
-   "description": "If \"Months\" is selected, a fixed amount will be booked as deferred revenue or expense for each month irrespective of the number of days in a month. It will be prorated if deferred revenue or expense is not booked for an entire month",
-   "fieldname": "book_deferred_entries_based_on",
-   "fieldtype": "Select",
-   "label": "Book Deferred Entries Based On",
-   "options": "Days\nMonths"
-  },
-  {
-   "default": "0",
-   "fieldname": "delete_linked_ledger_entries",
-   "fieldtype": "Check",
-   "label": "Delete Accounting and Stock Ledger Entries on deletion of Transaction"
-  },
-  {
-   "description": "Users with this role are allowed to over bill above the allowance percentage",
-   "fieldname": "role_allowed_to_over_bill",
-   "fieldtype": "Link",
-   "label": "Role Allowed to Over Bill ",
-   "options": "Role"
-  },
-  {
-   "fieldname": "period_closing_settings_section",
-   "fieldtype": "Section Break",
-   "label": "Period Closing Settings"
-  },
-  {
-   "fieldname": "accounts_transactions_settings_section",
-   "fieldtype": "Section Break",
-   "label": "Transactions Settings"
-  },
-  {
-   "fieldname": "column_break_11",
-   "fieldtype": "Column Break"
-  },
-  {
-   "fieldname": "tax_settings_section",
-   "fieldtype": "Section Break",
-   "label": "Tax Settings"
-  },
-  {
-   "fieldname": "column_break_19",
-   "fieldtype": "Column Break"
-  },
-  {
-   "default": "1",
-   "fieldname": "post_change_gl_entries",
-   "fieldtype": "Check",
-   "label": "Post Ledger Entries for Given Change"
+   "allow_bulk_edit": 0, 
+   "allow_in_quick_entry": 0, 
+   "allow_on_submit": 0, 
+   "bold": 0, 
+   "collapsible": 0, 
+   "columns": 0, 
+   "default": "0", 
+   "description": "Only select if you have setup Cash Flow Mapper documents", 
+   "fieldname": "use_custom_cash_flow", 
+   "fieldtype": "Check", 
+   "hidden": 0, 
+   "ignore_user_permissions": 0, 
+   "ignore_xss_filter": 0, 
+   "in_filter": 0, 
+   "in_global_search": 0, 
+   "in_list_view": 0, 
+   "in_standard_filter": 0, 
+   "label": "Use Custom Cash Flow Format", 
+   "length": 0, 
+   "no_copy": 0, 
+   "permlevel": 0, 
+   "precision": "", 
+   "print_hide": 0, 
+   "print_hide_if_no_value": 0, 
+   "read_only": 0, 
+   "remember_last_selected_value": 0, 
+   "report_hide": 0, 
+   "reqd": 0, 
+   "search_index": 0, 
+   "set_only_once": 0, 
+   "translatable": 0, 
+   "unique": 0
   }
- ],
- "icon": "icon-cog",
- "idx": 1,
- "index_web_pages_for_search": 1,
- "issingle": 1,
- "links": [],
- "modified": "2021-05-25 12:34:05.858669",
- "modified_by": "Administrator",
- "module": "Accounts",
- "name": "Accounts Settings",
- "owner": "Administrator",
+ ], 
+ "has_web_view": 0, 
+ "hide_heading": 0, 
+ "hide_toolbar": 0, 
+ "icon": "icon-cog", 
+ "idx": 1, 
+ "image_view": 0, 
+ "in_create": 0, 
+ "is_submittable": 0, 
+ "issingle": 1, 
+ "istable": 0, 
+ "max_attachments": 0, 
+ "modified": "2019-01-07 16:52:03.869199", 
+ "modified_by": "Administrator", 
+ "module": "Accounts", 
+ "name": "Accounts Settings", 
+ "owner": "Administrator", 
  "permissions": [
   {
-   "create": 1,
-   "email": 1,
-   "print": 1,
-   "read": 1,
-   "role": "Accounts Manager",
-   "share": 1,
+   "amend": 0, 
+   "cancel": 0, 
+   "create": 1, 
+   "delete": 0, 
+   "email": 1, 
+   "export": 0, 
+   "if_owner": 0, 
+   "import": 0, 
+   "permlevel": 0, 
+   "print": 1, 
+   "read": 1, 
+   "report": 0, 
+   "role": "Accounts Manager", 
+   "set_user_permissions": 0, 
+   "share": 1, 
+   "submit": 0, 
    "write": 1
-  },
+  }, 
   {
-   "read": 1,
-   "role": "Sales User"
-  },
+   "amend": 0, 
+   "cancel": 0, 
+   "create": 0, 
+   "delete": 0, 
+   "email": 0, 
+   "export": 0, 
+   "if_owner": 0, 
+   "import": 0, 
+   "permlevel": 0, 
+   "print": 0, 
+   "read": 1, 
+   "report": 0, 
+   "role": "Sales User", 
+   "set_user_permissions": 0, 
+   "share": 0, 
+   "submit": 0, 
+   "write": 0
+  }, 
   {
-   "read": 1,
-   "role": "Purchase User"
+   "amend": 0, 
+   "cancel": 0, 
+   "create": 0, 
+   "delete": 0, 
+   "email": 0, 
+   "export": 0, 
+   "if_owner": 0, 
+   "import": 0, 
+   "permlevel": 0, 
+   "print": 0, 
+   "read": 1, 
+   "report": 0, 
+   "role": "Purchase User", 
+   "set_user_permissions": 0, 
+   "share": 0, 
+   "submit": 0, 
+   "write": 0
   }
- ],
- "quick_entry": 1,
- "sort_field": "modified",
- "sort_order": "ASC",
- "track_changes": 1
+ ], 
+ "quick_entry": 1, 
+ "read_only": 0, 
+ "read_only_onload": 0, 
+ "show_name_in_global_search": 0, 
+ "sort_order": "ASC", 
+ "track_changes": 1, 
+ "track_seen": 0, 
+ "track_views": 0
 }

erpnext/accounts/doctype/accounts_settings/accounts_settings.py

@@ -5,7 +5,6 @@
 
 from __future__ import unicode_literals
 import frappe
-from frappe import _
 from frappe.utils import cint
 from frappe.model.document import Document
 from frappe.custom.doctype.property_setter.property_setter import make_property_setter
@@ -16,20 +15,23 @@ class AccountsSettings(Document):
 		frappe.clear_cache()
 
 	def validate(self):
-		frappe.db.set_default("add_taxes_from_item_tax_template",
-			self.get("add_taxes_from_item_tax_template", 0))
-
 		self.validate_stale_days()
 		self.enable_payment_schedule_in_print()
+		self.enable_fields_for_cost_center_settings()
 
 	def validate_stale_days(self):
 		if not self.allow_stale and cint(self.stale_days) <= 0:
 			frappe.msgprint(
-				_("Stale Days should start from 1."), title='Error', indicator='red',
+				"Stale Days should start from 1.", title='Error', indicator='red',
 				raise_exception=1)
 
 	def enable_payment_schedule_in_print(self):
 		show_in_print = cint(self.show_payment_schedule_in_print)
 		for doctype in ("Sales Order", "Sales Invoice", "Purchase Order", "Purchase Invoice"):
-			make_property_setter(doctype, "due_date", "print_hide", show_in_print, "Check", validate_fields_for_doctype=False)
-			make_property_setter(doctype, "payment_schedule", "print_hide",  0 if show_in_print else 1, "Check", validate_fields_for_doctype=False)
+			make_property_setter(doctype, "due_date", "print_hide", show_in_print, "Check")
+			make_property_setter(doctype, "payment_schedule", "print_hide",  0 if show_in_print else 1, "Check")
+
+	def enable_fields_for_cost_center_settings(self):
+		show_field = 0 if cint(self.allow_cost_center_in_entry_of_bs_account) else 1
+		for doctype in ("Sales Invoice", "Purchase Invoice", "Payment Entry"):
+			make_property_setter(doctype, "cost_center", "hidden", show_field, "Check")

erpnext/accounts/doctype/accounts_settings/regional/united_states.js

@@ -1,8 +0,0 @@
-
-frappe.ui.form.on('Accounts Settings', {
-	refresh: function(frm) {
-		frm.set_df_property("acc_frozen_upto", "label", "Books Closed Through");
-		frm.set_df_property("frozen_accounts_modifier", "label", "Role Allowed to Close Books & Make Changes to Closed Periods");
-		frm.set_df_property("credit_controller", "label", "Credit Manager");
-	}
-});

erpnext/accounts/doctype/advance_taxes_and_charges/advance_taxes_and_charges.json

@@ -1,197 +0,0 @@
-{
- "actions": [],
- "creation": "2020-09-12 22:26:19.594367",
- "doctype": "DocType",
- "document_type": "Setup",
- "editable_grid": 1,
- "engine": "InnoDB",
- "field_order": [
-  "add_deduct_tax",
-  "charge_type",
-  "row_id",
-  "account_head",
-  "col_break_1",
-  "description",
-  "included_in_paid_amount",
-  "accounting_dimensions_section",
-  "cost_center",
-  "dimension_col_break",
-  "section_break_8",
-  "rate",
-  "section_break_9",
-  "currency",
-  "tax_amount",
-  "total",
-  "allocated_amount",
-  "column_break_13",
-  "base_tax_amount",
-  "base_total",
-  "base_allocated_amount"
- ],
- "fields": [
-  {
-   "columns": 2,
-   "fieldname": "charge_type",
-   "fieldtype": "Select",
-   "in_list_view": 1,
-   "label": "Type",
-   "oldfieldname": "charge_type",
-   "oldfieldtype": "Select",
-   "options": "\nActual\nOn Paid Amount\nOn Previous Row Amount\nOn Previous Row Total",
-   "reqd": 1
-  },
-  {
-   "depends_on": "eval:[\"On Previous Row Amount\", \"On Previous Row Total\"].indexOf(doc.charge_type)!==-1",
-   "fieldname": "row_id",
-   "fieldtype": "Data",
-   "label": "Reference Row #",
-   "oldfieldname": "row_id",
-   "oldfieldtype": "Data"
-  },
-  {
-   "columns": 2,
-   "fieldname": "account_head",
-   "fieldtype": "Link",
-   "in_list_view": 1,
-   "label": "Account Head",
-   "oldfieldname": "account_head",
-   "oldfieldtype": "Link",
-   "options": "Account",
-   "reqd": 1,
-   "search_index": 1
-  },
-  {
-   "fieldname": "col_break_1",
-   "fieldtype": "Column Break",
-   "width": "50%"
-  },
-  {
-   "fieldname": "description",
-   "fieldtype": "Small Text",
-   "label": "Description",
-   "oldfieldname": "description",
-   "oldfieldtype": "Small Text",
-   "print_width": "300px",
-   "reqd": 1,
-   "width": "300px"
-  },
-  {
-   "fieldname": "accounting_dimensions_section",
-   "fieldtype": "Section Break",
-   "label": "Accounting Dimensions"
-  },
-  {
-   "default": ":Company",
-   "fieldname": "cost_center",
-   "fieldtype": "Link",
-   "label": "Cost Center",
-   "oldfieldname": "cost_center_other_charges",
-   "oldfieldtype": "Link",
-   "options": "Cost Center"
-  },
-  {
-   "fieldname": "dimension_col_break",
-   "fieldtype": "Column Break"
-  },
-  {
-   "fieldname": "section_break_8",
-   "fieldtype": "Section Break"
-  },
-  {
-   "columns": 2,
-   "fieldname": "rate",
-   "fieldtype": "Float",
-   "in_list_view": 1,
-   "label": "Rate",
-   "oldfieldname": "rate",
-   "oldfieldtype": "Currency"
-  },
-  {
-   "fieldname": "section_break_9",
-   "fieldtype": "Section Break"
-  },
-  {
-   "columns": 2,
-   "fieldname": "tax_amount",
-   "fieldtype": "Currency",
-   "in_list_view": 1,
-   "label": "Amount",
-   "options": "currency"
-  },
-  {
-   "columns": 2,
-   "fieldname": "total",
-   "fieldtype": "Currency",
-   "in_list_view": 1,
-   "label": "Total",
-   "options": "currency",
-   "read_only": 1
-  },
-  {
-   "fieldname": "column_break_13",
-   "fieldtype": "Column Break"
-  },
-  {
-   "fieldname": "base_tax_amount",
-   "fieldtype": "Currency",
-   "label": "Amount (Company Currency)",
-   "oldfieldname": "tax_amount",
-   "oldfieldtype": "Currency",
-   "options": "Company:company:default_currency",
-   "read_only": 1
-  },
-  {
-   "fieldname": "base_total",
-   "fieldtype": "Currency",
-   "label": "Total (Company Currency)",
-   "oldfieldname": "total",
-   "oldfieldtype": "Currency",
-   "options": "Company:company:default_currency",
-   "read_only": 1
-  },
-  {
-   "fieldname": "add_deduct_tax",
-   "fieldtype": "Select",
-   "label": "Add Or Deduct",
-   "options": "Add\nDeduct",
-   "reqd": 1
-  },
-  {
-   "default": "0",
-   "fieldname": "included_in_paid_amount",
-   "fieldtype": "Check",
-   "label": "Considered In Paid Amount"
-  },
-  {
-   "fieldname": "allocated_amount",
-   "fieldtype": "Currency",
-   "label": "Allocated Amount",
-   "options": "currency"
-  },
-  {
-   "fieldname": "base_allocated_amount",
-   "fieldtype": "Currency",
-   "label": "Allocated Amount (Company Currency)",
-   "options": "Company:company:default_currency"
-  },
-  {
-   "fetch_from": "account_head.account_currency",
-   "fieldname": "currency",
-   "fieldtype": "Link",
-   "label": "Account Currency",
-   "options": "Currency",
-   "read_only": 1
-  }
- ],
- "index_web_pages_for_search": 1,
- "istable": 1,
- "links": [],
- "modified": "2021-06-09 11:46:58.373170",
- "modified_by": "Administrator",
- "module": "Accounts",
- "name": "Advance Taxes and Charges",
- "owner": "Administrator",
- "permissions": [],
- "sort_field": "modified",
- "sort_order": "ASC"
-}

erpnext/accounts/doctype/advance_taxes_and_charges/advance_taxes_and_charges.py

@@ -1,10 +0,0 @@
-# -*- coding: utf-8 -*-
-# Copyright (c) 2020, Frappe Technologies Pvt. Ltd. and contributors
-# For license information, please see license.txt
-
-from __future__ import unicode_literals
-# import frappe
-from frappe.model.document import Document
-
-class AdvanceTaxesandCharges(Document):
-	pass

erpnext/accounts/doctype/allowed_dimension/allowed_dimension.json

@@ -1,43 +0,0 @@
-{
- "actions": [],
- "creation": "2020-11-08 18:22:36.001131",
- "doctype": "DocType",
- "editable_grid": 1,
- "engine": "InnoDB",
- "field_order": [
-  "accounting_dimension",
-  "dimension_value"
- ],
- "fields": [
-  {
-   "fieldname": "accounting_dimension",
-   "fieldtype": "Link",
-   "label": "Accounting Dimension",
-   "options": "DocType",
-   "read_only": 1,
-   "show_days": 1,
-   "show_seconds": 1
-  },
-  {
-   "fieldname": "dimension_value",
-   "fieldtype": "Dynamic Link",
-   "in_list_view": 1,
-   "options": "accounting_dimension",
-   "show_days": 1,
-   "show_seconds": 1
-  }
- ],
- "index_web_pages_for_search": 1,
- "istable": 1,
- "links": [],
- "modified": "2020-11-23 09:56:19.744200",
- "modified_by": "Administrator",
- "module": "Accounts",
- "name": "Allowed Dimension",
- "owner": "Administrator",
- "permissions": [],
- "quick_entry": 1,
- "sort_field": "modified",
- "sort_order": "DESC",
- "track_changes": 1
-}