* feat: add provision for process loss in manufac
* feat: add is process loss autoset and validation
* fix: add warehouse and unset is scrap for process loss items
* refactor: shift auto entry of is process loss check, update validations
* test: add bom tests for process loss val, add se test for qty calc
* fix: add more validations, remove source wh req for pl item
* fix: sider
* refactor: polyfill ??
* fix: sider
* refactor: validation error message formatting
* test: check manufacture completion qty in se and wo
* fix: wo tests, sider, account for pl in se validation
* fix: reword error messages, fix test values
* feat: add procss_loss_qty field in work order
* feat: process loss report, fix set pl query condition
* fix: correct value in test
* fix: get filters to work
- reorder and rename columns
- add work order filter
* fix: Shopping cart Exchange rate validation (#27050)
* fix: Shopping cart Exchange rate validation
- Use `get_exchange_rate` to check for price list exchange rate in cart settings
- Move cart exchange rate validation for Price List from hooks to doc event
- Call cart exchange rate validation on PL update only if PL is in cart and currency is changed
* chore: Comment out obsolete test
- Modifying this test means considering extreme edge cases, which seems pointless now
* fix: Remove snippet that got in due to cherry-pick from `develop`
- This snippet is not present in v13-hotfix. Via https://github.com/frappe/erpnext/pull/26520
Co-authored-by: Nabin Hait <nabinhait@gmail.com>
* feat: initialize party link for customer & suppliers
* feat: toggle to enable common party accounting
* feat: auto create advance entry on invoice submission
* test: creation of advance entry on invoice submission
* fix: remove unwanted filter query
* feat: validate multiple links
* fix: party link permissions
* perf: reduce number of queries to get party link
* fix: cost center & naming series
* fix: cost center in test_sales_invoice_against_supplier
* fix: Don't create inward SLE against SI unless is internal customer enabled (#27086)
* fix: Dont create inward SLE against SI unless is internal customer enabled
- Check if is internal customer enabled apart from target warehouse
- Test to check if inward SLE is made if target warehouse is accidentally set but customer is not internal
* test: Use internal customer for delivery of bundle items to target warehouse
- created `create_internal_customer` util
- reused it in delivery note and sales invoice tests
- use internal customer for target warehouse test in delivery note
(cherry picked from commit f4dc9ee2aa)
# Conflicts:
# erpnext/accounts/doctype/sales_invoice/test_sales_invoice.py
* fix: prevent over riding scrap table values, name kwargs, set currency
* fix(regional): minor fixes and test for South Africa VAT report (#26933) (#27162)
* fix: allow to change incoming rate manually in case of stand-alone credit note (#27164)
* fix: allow to change rate manually in case of stand-alone credit note (#27036)
Co-authored-by: Marica <maricadsouza221197@gmail.com>
(cherry picked from commit fe4540d74d)
# Conflicts:
# erpnext/accounts/doctype/sales_invoice_item/sales_invoice_item.json
* fix: resolve conflicts
Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com>
Co-authored-by: Ankush Menat <ankush@iwebnotes.com>
* fix: Fee Validity fixes (#27161)
* fix: Fee Validity fixes (#27156)
* chore: update Fee Validity form labels
* fix: first appointment should not be considered for Fee Validity
* fix: Fee Validity test cases
* fix: appointment test case
(cherry picked from commit 642b4c805c)
* fix: overlapping appointments
Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com>
* fix: Merge conflicts and place internal customer creation util in test_customer.py
* fix: internal customer util returns 'str' not doc object
* fix: negative qty validation on stock reco cancellation (#27170) (#27171)
* test: negative stock validation on SR cancel
* fix: negative stock setting ignored in stock reco
In stock reconcilation cancellation negative stock setting is ignored as
`db.get_value` is returning string `'0'` which is not casted to int/bool
for further logic. This causes negative qty, which evantually gets
caught by reposting but by design this should stop cancellation.
* test: typo and minor refactor
(cherry picked from commit e7109c18db)
Co-authored-by: Ankush Menat <ankush@iwebnotes.com>
Co-authored-by: 18alantom <2.alan.tom@gmail.com>
Co-authored-by: Marica <maricadsouza221197@gmail.com>
Co-authored-by: Nabin Hait <nabinhait@gmail.com>
Co-authored-by: Saqib Ansari <nextchamp.saqib@gmail.com>
Co-authored-by: Frappe PR Bot <frappe.pr.bot@gmail.com>
Co-authored-by: Ankush Menat <ankush@iwebnotes.com>
Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com>
* refactor: update stock onboarding
* refactor: add form tour for stock module onboarding
* refactor: move trailing whitespace out of translate func
* refactor: sider/semgrep
* refactor: remove DN, PR; change wording, add/remove steps in tour
* refactor: add watch video step for stock opening balance
* refactor: reorder steps according to stock settings refactor
* refactor: fix typo, remove target warehouse cause SE Type dependency
* fix: semgrep, remove trailing and leading whitespaces
* refactor: reduce steps, reword cards
* fix: minor changes
- remove Is Group from warehouse
- change stock entry type
- link to stock entry type
- add posting date to stock reco
- change report to Stock Projected Qty
- highlight quality inspection action
- remove allow neg highlight
* refactor: use Form Tour doc instead of controller form tour
note - keeping controller form tours as a fallback, new form tours
seem to work only for Stock Settings
* fix: rename form tours to doctype names, remove tours from js controllers
* fix: re-order tour to circumvent glitchy save highlight
* fix: (tests) get_healthcare_docs and get_medical_department separated, related changes
* feat: Service Unit option to allow overlap, overlap capacity
Appointment to allow overlapping appointments
Co-authored-by: Akash Krishna <akash@earthianslive.com>
* feat: Create multiple service units from tree view
Co-authored-by: Akash Krishna <akash@earthianslive.com>
* feat: patient address and contact
patient dashboard links, customer stats
* fix: sider review
* fix: untranslated message
* fix: enable non-negative check for service unit capacity
- incorrect depends on statement in dialog
* refactor(UX): Available Slots Dialog
* chore: remove unused field from Healthcare Service Unit Type
Co-authored-by: Akash Krishna <akash@earthianslive.com>
Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com>
* feat(india): reduced rate of depreciation as per IT Act
* refactor: check date difference instead of month difference
* feat: add test for regional feature
* fix: GST on freight charge in e-invocing
* fix: Add patch for taxable value field
* fix: Handle discounts on net total
* fix: Handle all types of discounts for e-invoicing
* fix: Absolute taxable values
* fix: Use correct tax amount
GST Invoice numbers should be 16 characters alphanumeric with dash(/) or
slash(-) only. Add check for doc.name before saving and warn about
naming series.
Prior to this change, there was simply a single hardcoded list of doctypes
with accounting dimensions in ERPNext. However, when extending the
capabilities of ERPNext using an add-on app rather than by modifying
ERPNext itself, it may well be necessary to create new doctypes in other
apps that will have accounting dimensions as well.
So, this PR moves the list of doctypes with accounting dimensions into
hooks.py so it can be accumulated from multiple apps. It also allows the
list of doctypes in make_dimension_in_accounting_doctypes be specifiable,
for more convenient use in the after_install hooks of other apps.
* feat: Leave Policy Assignment
* feat: linking with leave allocation and valiations
* style: removed old code from leave period
* feat: Bulk Leave policy Assignment and grant Leaves
* fix: overlap validation
* feat: earned leaves based on joining date
* feat: automatic grant leave based on leave policy
* patch: create leave policy assignment based on employee current leave policy
* fix: dependent test cases
* test: Leave policy assignment
* fix: some enhancement
* style: break large function into small function
* fix:requested Changes
* fix(patch): Handled old Leave allocatioln
* fix:codacy
* fix: travis and sider,codacy
* fix: codacy
* fix: codacy
* fix: requested changes and sider
Co-authored-by: Nabin Hait <nabinhait@gmail.com>
