* fix: operation time auto set to zero (#27188)
(cherry picked from commit e6799d78ef)
# Conflicts:
# erpnext/patches.txt
* fix: conflicts
Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com>
* feat: add provision for process loss in manufac
* feat: add is process loss autoset and validation
* fix: add warehouse and unset is scrap for process loss items
* refactor: shift auto entry of is process loss check, update validations
* test: add bom tests for process loss val, add se test for qty calc
* fix: add more validations, remove source wh req for pl item
* fix: sider
* refactor: polyfill ??
* fix: sider
* refactor: validation error message formatting
* test: check manufacture completion qty in se and wo
* fix: wo tests, sider, account for pl in se validation
* fix: reword error messages, fix test values
* feat: add procss_loss_qty field in work order
* feat: process loss report, fix set pl query condition
* fix: correct value in test
* fix: get filters to work
- reorder and rename columns
- add work order filter
* fix: Shopping cart Exchange rate validation (#27050)
* fix: Shopping cart Exchange rate validation
- Use `get_exchange_rate` to check for price list exchange rate in cart settings
- Move cart exchange rate validation for Price List from hooks to doc event
- Call cart exchange rate validation on PL update only if PL is in cart and currency is changed
* chore: Comment out obsolete test
- Modifying this test means considering extreme edge cases, which seems pointless now
* fix: Remove snippet that got in due to cherry-pick from `develop`
- This snippet is not present in v13-hotfix. Via https://github.com/frappe/erpnext/pull/26520
Co-authored-by: Nabin Hait <nabinhait@gmail.com>
* feat: initialize party link for customer & suppliers
* feat: toggle to enable common party accounting
* feat: auto create advance entry on invoice submission
* test: creation of advance entry on invoice submission
* fix: remove unwanted filter query
* feat: validate multiple links
* fix: party link permissions
* perf: reduce number of queries to get party link
* fix: cost center & naming series
* fix: cost center in test_sales_invoice_against_supplier
* fix: Don't create inward SLE against SI unless is internal customer enabled (#27086)
* fix: Dont create inward SLE against SI unless is internal customer enabled
- Check if is internal customer enabled apart from target warehouse
- Test to check if inward SLE is made if target warehouse is accidentally set but customer is not internal
* test: Use internal customer for delivery of bundle items to target warehouse
- created `create_internal_customer` util
- reused it in delivery note and sales invoice tests
- use internal customer for target warehouse test in delivery note
(cherry picked from commit f4dc9ee2aa)
# Conflicts:
# erpnext/accounts/doctype/sales_invoice/test_sales_invoice.py
* fix: prevent over riding scrap table values, name kwargs, set currency
* fix(regional): minor fixes and test for South Africa VAT report (#26933) (#27162)
* fix: allow to change incoming rate manually in case of stand-alone credit note (#27164)
* fix: allow to change rate manually in case of stand-alone credit note (#27036)
Co-authored-by: Marica <maricadsouza221197@gmail.com>
(cherry picked from commit fe4540d74d)
# Conflicts:
# erpnext/accounts/doctype/sales_invoice_item/sales_invoice_item.json
* fix: resolve conflicts
Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com>
Co-authored-by: Ankush Menat <ankush@iwebnotes.com>
* fix: Fee Validity fixes (#27161)
* fix: Fee Validity fixes (#27156)
* chore: update Fee Validity form labels
* fix: first appointment should not be considered for Fee Validity
* fix: Fee Validity test cases
* fix: appointment test case
(cherry picked from commit 642b4c805c)
* fix: overlapping appointments
Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com>
* fix: Merge conflicts and place internal customer creation util in test_customer.py
* fix: internal customer util returns 'str' not doc object
* fix: negative qty validation on stock reco cancellation (#27170) (#27171)
* test: negative stock validation on SR cancel
* fix: negative stock setting ignored in stock reco
In stock reconcilation cancellation negative stock setting is ignored as
`db.get_value` is returning string `'0'` which is not casted to int/bool
for further logic. This causes negative qty, which evantually gets
caught by reposting but by design this should stop cancellation.
* test: typo and minor refactor
(cherry picked from commit e7109c18db)
Co-authored-by: Ankush Menat <ankush@iwebnotes.com>
Co-authored-by: 18alantom <2.alan.tom@gmail.com>
Co-authored-by: Marica <maricadsouza221197@gmail.com>
Co-authored-by: Nabin Hait <nabinhait@gmail.com>
Co-authored-by: Saqib Ansari <nextchamp.saqib@gmail.com>
Co-authored-by: Frappe PR Bot <frappe.pr.bot@gmail.com>
Co-authored-by: Ankush Menat <ankush@iwebnotes.com>
Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com>
Summary : unable to create manual / auto asset depreciation entry when cost_center is mandatory
Reason: Though we are calculating value for depreciation_cost_center, it is not passed in credit_entry(it is passed in debit_entry) and this prevents creation of manual / auto asset depreciation entry when cost_center is mandatory
Solution : pass already calculated depreciation_cost_center value in credit_entry (in line with, already done as in debit_entry)
(cherry picked from commit b99c011947)
Co-authored-by: Ashish Shah <mr.ashish.shah@gmail.com>
* fix: update test suite to accodomate new currency exchange function
* feat: Increase number of supported currency exchanges
* fix: don't make api call when testing
* remove condition for test(being fixed in another pull request)
Sales Invoice doctype is starting to hit row length limit as many
integrations add custom fields on this doctype. This is just a small
change to remove VARCHAR(140) fields and reduce row size wherever
possible.
(cherry picked from commit 8d116fb9ff)
Co-authored-by: Ankush Menat <ankush@iwebnotes.com>
* refactor: update stock onboarding
* refactor: add form tour for stock module onboarding
* refactor: move trailing whitespace out of translate func
* refactor: sider/semgrep
* refactor: remove DN, PR; change wording, add/remove steps in tour
* refactor: add watch video step for stock opening balance
* refactor: reorder steps according to stock settings refactor
* refactor: fix typo, remove target warehouse cause SE Type dependency
* fix: semgrep, remove trailing and leading whitespaces
* refactor: reduce steps, reword cards
* fix: minor changes
- remove Is Group from warehouse
- change stock entry type
- link to stock entry type
- add posting date to stock reco
- change report to Stock Projected Qty
- highlight quality inspection action
- remove allow neg highlight
* refactor: use Form Tour doc instead of controller form tour
note - keeping controller form tours as a fallback, new form tours
seem to work only for Stock Settings
* fix: rename form tours to doctype names, remove tours from js controllers
* fix: re-order tour to circumvent glitchy save highlight
* fix: broken URL
The quotations are supplier quotations, not sales quotation.
* fix: remove erpnext from path
(cherry picked from commit c7bad657b1)
Co-authored-by: Dany Robert <rtdany10@gmail.com>
* perf: reduce number of queries to validate selling price
* fix: improved flow and formatting
* fix: improve condition and use of `as_dict`
Co-authored-by: Sagar Vora <sagar@resilient.tech>
(cherry picked from commit 7c957d72b3)
Co-authored-by: Pruthvi Patel <pruthvipatel145@gmail.com>
