mergify[bot]
e757970db3
fix(general_ledger): Order by in case Group by Account ( #28093 ) ( #28106 )
...
* Update general_ledger.py
Fix order_by_statement if filter group by: Group by Account
* chore: whitespace
Co-authored-by: Ankush Menat <ankushmenat@gmail.com >
Co-authored-by: Afshan <33727827+AfshanKhan@users.noreply.github.com >
(cherry picked from commit f24ed6723e )
Co-authored-by: hendrik <hendrik.zeta@gmail.com >
2021-10-27 14:45:05 +05:30
Saqib
2a60a65ccd
Merge pull request #28102 from frappe/mergify/bp/version-13-hotfix/pr-27916
...
perf(minor): improve sales invoice submission (backport #27916 )
2021-10-27 14:26:38 +05:30
Afshan
db5593287e
Merge branch 'version-13-hotfix' into mergify/bp/version-13-hotfix/pr-27916
2021-10-27 14:05:51 +05:30
mergify[bot]
e8b46bf3a3
fix(ux): add naming series to ERPNext setting workspace (backport #28090 ) ( #28103 )
...
* fix(ux): add naming series to ERPNext setting workspace (#28090 )
* fix(ux): add naming series to setting workspace
* fix: doctype link to naming series
Co-authored-by: Ankush Menat <ankushmenat@gmail.com >
Co-authored-by: Summayya <frappe@Summayyas-MacBook-Air.local >
Co-authored-by: Ankush Menat <ankushmenat@gmail.com >
(cherry picked from commit 0806e32049 )
# Conflicts:
# erpnext/setup/workspace/erpnext_settings/erpnext_settings.json
* fix: conflicts
Co-authored-by: Summayya Hashmani <58825865+sumaiya2908@users.noreply.github.com >
Co-authored-by: Afshan <33727827+AfshanKhan@users.noreply.github.com >
2021-10-27 14:03:24 +05:30
Marica
67e5e95466
Merge pull request #27931 from marination/optimize-get-attribute-filters-hotfix
...
perf: Optimize get_attribute_filters (#26729 )
2021-10-27 13:31:58 +05:30
mergify[bot]
f1b7bb8878
fix: Update receivable/payable account on company change (backport #28057 ) ( #28087 )
...
* fix: Update receivable/payable account on company change
(cherry picked from commit 65025fb628 )
# Conflicts:
# erpnext/accounts/doctype/sales_invoice/sales_invoice.js
* fix: Update sales_invoice.js
Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com >
Co-authored-by: Deepesh Garg <42651287+deepeshgarg007@users.noreply.github.com >
Co-authored-by: Afshan <33727827+AfshanKhan@users.noreply.github.com >
2021-10-27 13:30:32 +05:30
mergify[bot]
fb742476f8
fix: Payment Terms validation precision ( #28104 )
...
(cherry picked from commit 9c1705205f )
Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com >
Co-authored-by: Afshan <33727827+AfshanKhan@users.noreply.github.com >
2021-10-27 13:26:57 +05:30
mergify[bot]
d4b4bd9d97
fix: update production plan status (backport #27567 )
...
* fix: update production plan status #27567
fix: update production plan status
(cherry picked from commit 05831b18ad )
# Conflicts:
# erpnext/patches.txt
* fix: resolve conflicts
Co-authored-by: Alan <2.alan.tom@gmail.com >
Co-authored-by: Ankush Menat <ankush@frappe.io >
2021-10-27 13:20:51 +05:30
Afshan
accb98ccf4
Merge branch 'version-13-hotfix' into mergify/bp/version-13-hotfix/pr-27916
2021-10-27 12:58:30 +05:30
Deepesh Garg
6acab32934
Merge pull request #28085 from frappe/mergify/bp/version-13-hotfix/pr-28055
...
fix(UX): Add mandatory depends on condition for reference no and date fields (backport #28055 )
2021-10-27 11:57:20 +05:30
Saqib
5d4d6bb52b
fix: sider
...
(cherry picked from commit ac381d21fe )
2021-10-27 06:13:33 +00:00
Ankush Menat
a2a462f2f5
fix: undo changes to allow negative stock flag
...
(cherry picked from commit 7bafa11d57 )
2021-10-27 06:13:32 +00:00
Saqib Ansari
b1efb7f80b
perf: skip insertion of stock ledger entry
...
(cherry picked from commit c7fc609236 )
2021-10-27 06:13:32 +00:00
Saqib Ansari
97fc449222
perf: get total company stock only for purchase order
...
(cherry picked from commit eb3aae870f )
2021-10-27 06:13:32 +00:00
Saqib Ansari
cb0168ae65
perf: fetch mode of payments data in single query
...
(cherry picked from commit 7b691beabb )
2021-10-27 06:13:31 +00:00
Saqib Ansari
de38c70707
perf: skip get_pricing_rules if no pricing rule exists
...
(cherry picked from commit a500252570 )
2021-10-27 06:13:31 +00:00
Saqib
cb97e950e6
feat(e-invoicing): dispatch address ( #28084 )
2021-10-27 11:39:00 +05:30
Ankush Menat
a046da1e61
test: picklist item grouping
...
(cherry picked from commit 479ecb8de0 )
2021-10-27 11:30:30 +05:30
Ankush Menat
28026f7f1c
refactor: use defaultdict and enumeration
...
(cherry picked from commit 6942900555 )
2021-10-27 11:30:30 +05:30
Diksha Jadhav
93a0ea7118
feat(pick list): group items based on item code and warehouse before printing picklist
...
(cherry picked from commit f2d136e574 )
2021-10-27 11:30:30 +05:30
mergify[bot]
a30cfbce42
fix: change modified timestamp to apply changes on migrate #28095 ( #28099 )
...
fix: change modified timestamp to apply changes on migrate
(cherry picked from commit 2920f2f614 )
Co-authored-by: Dany Robert <rtdany10@gmail.com >
2021-10-27 11:20:13 +05:30
mergify[bot]
019c5a338d
fix(ux): overbiling message in SO->SI, PO->PI (bp #28088 )
...
(cherry picked from commit 6ec047cba9 )
Co-authored-by: Ankush Menat <ankush@frappe.io >
2021-10-27 11:08:23 +05:30
gsi-maruiz
8cad23b8fb
fix: add filter to query to avoid send reminder for zero years ( #28092 )
...
Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com >
2021-10-27 11:00:56 +05:30
Deepesh Garg
f63a71e2cc
fix(minor): Add mandatory depends on condition for reference no and date fields
...
(cherry picked from commit a20058a343 )
2021-10-26 14:33:10 +00:00
mergify[bot]
f81c5cd478
fix: POS Closing Entry without linked invoices ( #28077 )
2021-10-26 14:42:44 +05:30
mergify[bot]
a23ef95cd8
refactor: shows opening balance from filtered from_date ( #26877 ) ( #28072 )
...
* refactor: shows opening balance from filtered from_date
* refactor: opening balance considered from filtered from_date in stock ledger
* fix: check if stock reco is opening and misc cleanups
(cherry picked from commit fdaf93f76c )
Co-authored-by: Noah Jacob <noahjacobkurian@gmail.com >
2021-10-25 09:09:44 +05:30
Deepesh Garg
943def5faa
Merge pull request #28014 from deepeshgarg007/tds_computation_summary_fixes
...
fix: Error in TDS computation summary
2021-10-23 13:16:30 +05:30
Ankush Menat
7a08f8aeec
chore: change semgrep rules repo name
...
[skip ci]
2021-10-22 22:40:56 +05:30
mergify[bot]
a082d70553
ci: move semgrep rules out of repo (backport #28067 )
...
* ci: move semgrep rules out of repo (#28067 )
Moving semgrep rules out of repos as it's unnecessary to maintain
same ruleset for different repos and different branches.
(cherry picked from commit cc1baae5eb )
# Conflicts:
# .github/helper/semgrep_rules/frappe_correctness.py
# .github/helper/semgrep_rules/frappe_correctness.yml
# .github/helper/semgrep_rules/report.py
# .github/helper/semgrep_rules/ux.py
# .github/workflows/linters.yml
* fix: resolve conflicts
Co-authored-by: Ankush Menat <ankush@frappe.io >
2021-10-22 21:58:45 +05:30
mergify[bot]
60620fe335
fix: don't reset rates in Timesheet Detail when Activity Type is cleared ( #28056 )
...
* fix: don't reset rates when activity type is cleared
* refactor: suggestions from review
Co-authored-by: Sagar Vora <sagar@resilient.tech >
* refactor: suggestions from review (fix)
* style: fix sider
* fix: sider issue
Co-authored-by: Sagar Vora <sagar@resilient.tech >
(cherry picked from commit 2bdaf7bb23 )
Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com >
2021-10-22 14:06:11 +05:30
mergify[bot]
46567f0fe9
refactor: move process loss report to manufacturing ( #28043 ) ( #28047 )
...
* refactor: move process loss report to manufacturing
* test: fix process loss report test
Co-authored-by: Ankush Menat <ankush@iwebnotes.com >
(cherry picked from commit 2849297471 )
Co-authored-by: Alan <2.alan.tom@gmail.com >
2021-10-21 11:11:53 +05:30
Ankush Menat
5ed32b5995
fix: unused imports
2021-10-21 11:04:40 +05:30
Devin Slauenwhite
152f9b0a43
fix: useless validation message ( #28029 )
...
Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com >
2021-10-21 10:58:35 +05:30
Ankush Menat
71e517f043
test: fix get_attribute_filter test
...
The function returns strings directly instead of objects now.
2021-10-21 10:55:11 +05:30
mergify[bot]
e0f2130731
feat: employee initial work history updated when transfer is performed ( #27768 ) ( #28045 )
...
* feat: employee initial work history updated when transfer is performed
* fix: sider
* fix: remove commit statement
* fix: tests and code formatting
* fix: tests
Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com >
(cherry picked from commit 03bfc77940 )
Co-authored-by: Mohammed Yusuf Shaikh <49878143+mohammedyusufshaikh@users.noreply.github.com >
2021-10-21 10:34:31 +05:30
mergify[bot]
4f5d67883c
fix: consolidated report issue #28035 ( #28039 )
...
fix: consolidated report issue
(cherry picked from commit 871cb1157f )
Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com >
2021-10-20 21:10:45 +05:30
Ankush Menat
5ba315eb96
test: execute manufacturing reports
...
(cherry picked from commit da3635b94f )
2021-10-20 21:00:11 +05:30
Ankush Menat
408c4a6f54
fix: remove debug from query
...
(cherry picked from commit 126ba16740 )
2021-10-20 21:00:11 +05:30
Ankush Menat
e357541509
fix: remove employee_name from job card summary
...
This field doesn't exist and it's moved on individual line level logs.
(cherry picked from commit 8221e7e01f )
2021-10-20 21:00:11 +05:30
mergify[bot]
1fae8f1fcb
Merge pull request #28038 from frappe/mergify/bp/version-13-hotfix/pr-28036
...
fix: incorrect field name (backport #28036 )
2021-10-20 20:55:00 +05:30
Ankush Menat
8fffd1597d
fix: dont recompute item wise taxes from front end
...
(cherry picked from commit 393749a611 )
2021-10-20 19:44:26 +05:30
mergify[bot]
34e92ab229
fix: incorrect status being set in Invoices (backport #28019 ) ( #28031 )
...
* fix: incorrect status being set in Invoices (#28019 )
Co-authored-by: Pruthvi Patel <pruthvipatel145@gmail.com >
(cherry picked from commit 8d9d0987fe )
# Conflicts:
# erpnext/patches.txt
* fix: merge conflict
Co-authored-by: Sagar Vora <sagar@resilient.tech >
2021-10-20 19:31:47 +05:30
mergify[bot]
9ce7ea692d
fix: avoid resetting employee on amending timesheets ( #28025 ) ( #28026 )
...
(cherry picked from commit 261f80c5ca )
Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com >
2021-10-20 17:45:43 +05:30
mergify[bot]
a739bf90c4
feat: Tax for recurring additional salary (backport #27459 ) ( #28024 )
...
* feat: Tax for recurring additional salary (#27459 )
* fix: Logic for tax calculation on recurring additional salary
* fix: Get actual amount always in case of overwritten additional salary even if based on payment days
* feat: Test case added for recurring additional salary
* fix: use query builder to get additional salaries instead of raw SQL
* fix: query formatting and remove trailing spaces
Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com >
(cherry picked from commit 2ef4844a3c )
# Conflicts:
# erpnext/payroll/doctype/salary_slip/salary_slip.py
# erpnext/payroll/doctype/salary_slip/test_salary_slip.py
* fix: conflicts
Co-authored-by: Nabin Hait <nabinhait@gmail.com >
Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com >
2021-10-20 16:20:25 +05:30
Marica
077026a7ae
Merge pull request #28005 from marination/patch-thumbnail-perf
...
fix: Fetch thumbnail from Item master instead of regenerating
2021-10-20 14:40:57 +05:30
marination
348a961b53
fix: Move thumbnail updation to different patch
...
- Thumbnail updation handled via different patch
- create_website_items will only have one purpose
- added progress bar to `create_website_items`
- code cleanup
2021-10-20 14:14:13 +05:30
Jannat Patel
3cf5861a8b
Merge pull request #28015 from frappe/mergify/bp/version-13-hotfix/pr-27728
...
fix: Employee Leave Balance report should only consider ledgers of transaction type Leave Allocation (backport #27728 )
2021-10-20 13:10:58 +05:30
Jannat Patel
8e9db11c69
Merge pull request #28012 from frappe/mergify/bp/version-13-hotfix/pr-27904
...
fix: map missing fields in opportunity (backport #27904 )
2021-10-20 12:36:46 +05:30
Goh Yan Chang
50af32f35c
Update employee_leave_balance.py
...
fix: Employee Leave Balance report showing wrong figures
(cherry picked from commit 632f7848a3 )
2021-10-20 06:57:51 +00:00
Deepesh Garg
944e3d467c
fix: Check for supplier name
2021-10-20 12:17:13 +05:30