mergify[bot]
2a615af00a
fix: contact search in request for quotation (backport #31828 ) ( #31841 )
...
* fix: contact search in request for quotation (#31828 )
(cherry picked from commit e5e88bb9f1 )
# Conflicts:
# erpnext/buying/doctype/request_for_quotation/request_for_quotation.py
* chore: conflicts
Co-authored-by: Sagar Sharma <sagarsharma.s312@gmail.com >
2022-08-17 11:23:24 +05:30
mergify[bot]
ba8dc8925f
fix: check item_code in all rows of po_items (backport #31741 ) ( #31843 )
...
fix: check item_code in all rows of po_items (#31741 )
fix: check item-code in each row of po-items
(cherry picked from commit 0047e18a9b )
Co-authored-by: Sagar Sharma <sagarsharma.s312@gmail.com >
2022-08-17 11:21:47 +05:30
Sagar Vora
14891ccf18
Merge pull request #31792 from frappe/mergify/bp/version-13-hotfix/pr-31733
...
fix: set `billing_address` for purchases in `get_party_details` (backport #31733 )
2022-08-16 05:48:48 +00:00
Sagar Vora
15654aae8b
fix: use old style for _dict.update
2022-08-13 08:00:27 +00:00
Sagar Vora
d1de4b027c
fix: set company_address for purchases in party.js
...
(cherry picked from commit d05082987f )
2022-08-13 08:00:27 +00:00
Sagar Vora
a7d66fa352
fix: set billing_address for purchases in get_party_details
...
(cherry picked from commit a3625b3817 )
2022-08-13 08:00:27 +00:00
Deepesh Garg
0569f8a857
Merge pull request #31736 from maharshivpatel/fix-india-hsn-report
...
fix: (india) HSN wise report
2022-08-09 18:58:25 +05:30
Rucha Mahabal
63715bf229
Merge pull request #31813 from ruchamahabal/fix-claim
2022-08-09 18:52:22 +05:30
Rucha Mahabal
63cd4349a6
fix: consider precision while validating advance amount against sanctioned amount
2022-08-09 18:28:19 +05:30
Maharshi Patel
42b395916d
fix: f-string and where clause
...
Used f-string formatting and added conditions to WHERE clause
2022-08-09 18:22:05 +05:30
Rucha Mahabal
0057c10a7d
fix: update To Date in Employee Work History ( #31811 )
2022-08-09 18:19:09 +05:30
Deepesh Garg
3c8c5d01fb
Merge pull request #31797 from frappe/mergify/bp/version-13-hotfix/pr-31779
...
Bug add accouting dimension in asset repair (backport #31779 )
2022-08-09 18:18:42 +05:30
Rucha Mahabal
d820757359
fix: Payment Entry button is visible even when claim is fully paid
2022-08-09 18:15:41 +05:30
mergify[bot]
14e59c86aa
Tds report (backport #31801 ) ( #31808 )
...
* fix: TDS Computation Summary Report not loading, too many values to unpack
2022-08-09 18:11:13 +05:30
Deepesh Garg
9e16f4e412
chore: resolve conflicts
2022-08-09 17:55:02 +05:30
rohitwaghchaure
6d269a4d89
Merge pull request #31805 from frappe/mergify/bp/version-13-hotfix/pr-31804
...
fix: incorrect incoming rate set for inter transfer purchase receipt (backport #31804 )
2022-08-09 16:26:34 +05:30
Rohit Waghchaure
4e8b39ab3f
fix: incorrect incoming rate set for inter transfer purchase receipt
...
(cherry picked from commit ddd24ea8c8 )
2022-08-09 10:31:14 +00:00
Rucha Mahabal
9925eb9982
Merge pull request #31802 from ruchamahabal/fix-salary-slip-tds-v13
2022-08-09 15:33:54 +05:30
Rucha Mahabal
301d199ece
test: default amount in slip
2022-08-09 14:57:10 +05:30
Maharshi Patel
6c574fbf33
fix: taxable_value and gst_account_heads
...
used taxable_value instead of base_net_amount and only appended required GST accounts
2022-08-09 14:39:13 +05:30
Rucha Mahabal
80981d025f
fix: incorrect tax calculation in case of reduced payment days
2022-08-09 12:40:06 +05:30
ruthra kumar
a420d0242c
chore: patch for creating existing dimensions in asset repair
...
(cherry picked from commit 80f508c4b1 )
# Conflicts:
# erpnext/patches.txt
2022-08-08 11:09:55 +00:00
ruthra kumar
809d5caf80
fix: add asset repair to accounting dimension list
...
(cherry picked from commit 452584c4bd )
2022-08-08 11:09:53 +00:00
Deepesh Garg
6f442d14cf
Merge pull request #31795 from frappe/mergify/bp/version-13-hotfix/pr-31777
...
fix: intercompany SO created from Purchase Order throws exception (backport #31777 )
2022-08-08 16:37:39 +05:30
ruthra kumar
a17acfdaa2
fix: intercompany SO throws exception
...
(cherry picked from commit af0a353b79 )
2022-08-08 10:37:25 +00:00
Deepesh Garg
3673dea03b
Merge pull request #31783 from frappe/mergify/bp/version-13-hotfix/pr-31780
...
Fix: Loan pending principal amount (backport #31780 )
2022-08-08 14:48:06 +05:30
Deepesh Garg
fb3725752f
chore: resolve conflicts
2022-08-08 11:53:49 +05:30
Abhinav Raut
16c94d292c
fix: pending principal- amount
...
(cherry picked from commit a272d73dd9 )
# Conflicts:
# erpnext/loan_management/doctype/loan_repayment/loan_repayment.json
2022-08-05 10:35:05 +00:00
mergify[bot]
0e46b33ee3
fix(ecommerce): remove query to non-existing field (backport #31771 ) ( #31774 )
...
fix(ecommerce): remove query to non-existing field (#31771 )
(cherry picked from commit 17b9bfd249 )
Co-authored-by: Ankush Menat <ankush@frappe.io >
2022-08-03 17:08:46 +05:30
mergify[bot]
df716fbd0c
ci: fix automated release regex (backport #31770 ) ( #31772 )
...
ci: fix automated release regex (#31770 )
[skip ci]
(cherry picked from commit 2defb89962 )
Co-authored-by: Ankush Menat <ankush@frappe.io >
2022-08-03 16:37:39 +05:30
mergify[bot]
0dbfb1589e
fix: specify allowed doctype in queries ( #31765 )
...
Co-authored-by: Sagar Vora <sagar@resilient.tech >
2022-08-03 12:03:53 +05:30
mergify[bot]
473a43b6b1
fix: getting error to show sales invoice group or print rep… (backport #31756 ) ( #31768 )
...
fix: getting error to show sales invoice group or print rep… (#31756 )
fix: formatter getting error to show sales invoice group or print report.
1 - When I view the Gross Profit report in Sales Invoice mode, the table is all broken.
Error on browser console:
TypeError: Cannot read properties of undefined (reading 'indent')
2 - When I try to print, no matter the Group (Sales Invoice, Item Code, Item Group...) nothing happens. in browser log console I have the following error:
TypeError: Cannot read properties of undefined (reading 'content')
i fixed both errors and all working perfectly.
(cherry picked from commit ea88451875 )
Co-authored-by: HarryPaulo <paulo_fabris@hotmail.com >
2022-08-03 11:23:10 +05:30
rohitwaghchaure
1a3b3b96c2
Merge pull request #31751 from frappe/mergify/bp/version-13-hotfix/pr-31750
...
fix: minor URL link (backport #31750 )
2022-08-01 14:34:12 +05:30
Rohit Waghchaure
e9e53a74c9
fix: minor changed link
...
(cherry picked from commit 0e7c4314b4 )
2022-08-01 09:02:07 +00:00
Rucha Mahabal
26aef4fb1c
fix: statistical component showing up in salary slip ( #31746 )
...
* fix: statistical component showing up in salary slip
* fix(test): payment days effect on timesheet salary slio
2022-08-01 12:54:25 +05:30
mergify[bot]
b145fe3b3e
fix(pos): validate product bundles while submitting pos invoice (backport #31615 ) ( #31657 )
2022-07-31 19:12:14 +05:30
Marica
d83c869d73
Merge pull request #31717 from frappe/mergify/bp/version-13-hotfix/pr-31601
...
perf: reduce db calls for warehouse wise stock value chart (backport #31601 )
2022-07-31 18:26:27 +05:30
Maharshi Patel
08c69c7a76
fix: (india) HSN wise report
...
Problem:
The previous approach for calculating tax_rate was incorrect.
```
['tax_rate'] * ['number of unique rows']
```
Joining `tabSales Taxes and Charges` was adding unnecessary rows & complexity.
Solution:
Instead of trying to get tax_rate from the main query itself, I used the get_tax_accounts's data to calculate the correct tax_rate.
Todo:
Union Territory
2022-07-29 14:22:31 +05:30
Deepesh Garg
25da4d28ff
Merge pull request #31727 from frappe/mergify/bp/version-13-hotfix/pr-31656
...
fix: use current pos profile on sales return (backport #31656 )
2022-07-28 16:32:36 +05:30
Deepesh Garg
f57d2fadbc
Merge pull request #31728 from frappe/mergify/bp/version-13-hotfix/pr-31676
...
fix: enable tax withholding checkbox in PI with supplier_tds (backport #31676 )
2022-07-28 16:32:17 +05:30
Deepesh Garg
9e7edd677a
Merge pull request #31726 from frappe/mergify/bp/version-13-hotfix/pr-31576
...
fix: credite note for returned delivery note updates SO's billed percentage (backport #31576 )
2022-07-28 16:32:05 +05:30
ruthra kumar
bc7494278d
fix: enable tax withholding checkbox in PI with supplier_tds
...
(cherry picked from commit b461724416 )
2022-07-28 10:42:58 +00:00
ruthra kumar
c442b4aef1
fix: use current pos profile on sales return
...
(cherry picked from commit 5b85af5f1a )
2022-07-28 10:36:23 +00:00
ruthra kumar
ef9b25cf08
test: SO percentage billed when cr_note made against delivery return
...
(cherry picked from commit 243f66fcd3 )
2022-07-28 10:21:19 +00:00
ruthra kumar
2f2d3de306
fix: update SO's percentage billed on credit note
...
Credit Note created from Sales Return will update precentage billed in
Sales Order accordingly
(cherry picked from commit 04c1019242 )
2022-07-28 10:21:18 +00:00
Rucha Mahabal
13639682ce
Merge pull request #31724 from ruchamahabal/expense-claim-adv
2022-07-28 14:51:15 +05:30
Rucha Mahabal
c01adae8a5
test: advance amount allocation against expense claim with taxes
2022-07-28 14:27:09 +05:30
Deepesh Garg
8ae691d9dc
Merge branch 'version-13' into version-13-hotfix
2022-07-28 13:59:25 +05:30
Alaa Alsalehi
a95c011a93
fix: Reload loan Table in Salary Slip when change Employee ( #31525 )
...
Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com >
Co-authored-by: bahaaabed <bahaa.9999.sh@gmail.com >
Co-authored-by: newhr1 <104132586+newhr1@users.noreply.github.com >
2022-07-28 13:22:07 +05:30
Rucha Mahabal
42f3592e95
fix: Allow allocating advance amount against Expense Claim taxes
2022-07-28 13:21:29 +05:30