fix:Add shipping charges to taxes only if applicable

2022-01-24 15:59:38 +05:30
parent f75d36dcb4
commit e8bc4f12a7
1 changed files with 2 additions and 1 deletions
--- a/erpnext/accounts/doctype/shipping_rule/shipping_rule.py
+++ b/erpnext/accounts/doctype/shipping_rule/shipping_rule.py
@@ -71,7 +71,8 @@ class ShippingRule(Document):
 		if doc.currency != doc.company_currency:
 			shipping_amount = flt(shipping_amount / doc.conversion_rate, 2)

-		self.add_shipping_rule_to_tax_table(doc, shipping_amount)
+		if shipping_amount:
+			self.add_shipping_rule_to_tax_table(doc, shipping_amount)

 	def get_shipping_amount_from_rules(self, value):
 		for condition in self.get("conditions"):