schuetz3/schuetz3-erpnext
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(Employee): remove User Permissions if create_user_permission is unchecked

Browse Source
This commit is contained in:
Patrick Eissler
2025-02-14 15:14:03 +01:00
parent a81867bc43
commit dee46c6954
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
erpnext/setup/doctype/employee/employee.py
View File

@@ -5,6 +5,7 @@ from frappe import _, scrub, throw
from frappe.model.naming import set_name_by_naming_series
from frappe.permissions import (
add_user_permission,
delete_user_permission,
get_doc_permissions,
has_permission,
remove_user_permission,
@@ -84,8 +85,6 @@ class Employee(NestedSet):
self.reset_employee_emails_cache()
def update_user_permissions(self):
if not self.create_user_permission:
return
if not has_permission("User Permission", ptype="write", print_logs=False):
return
@@ -93,11 +92,12 @@ class Employee(NestedSet):
"User Permission", {"allow": "Employee", "for_value": self.name, "user": self.user_id}
)
if employee_user_permission_exists:
return
add_user_permission("Employee", self.name, self.user_id)
add_user_permission("Company", self.company, self.user_id)
if employee_user_permission_exists and not self.create_user_permission:
delete_user_permission("Employee", self.name, self.user_id)
delete_user_permission("Company", self.company, self.user_id)
elif not employee_user_permission_exists and self.create_user_permission:
add_user_permission("Employee", self.name, self.user_id)
add_user_permission("Company", self.company, self.user_id)
def update_user(self):
# add employee role if missing