schuetz3/schuetz3-erpnext
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #40744 from frappe/mergify/bp/version-14-hotfix/pr-40739

Browse Source 
refactor: use sql to clear comments (backport #40739)
This commit is contained in:
ruthra kumar
2024-03-28 19:42:02 +05:30
committed by GitHub
parent b1105fb0ab 4d6fad26f3
commit bb35c334c0
1 changed files with 5 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
erpnext/setup/doctype/transaction_deletion_record/transaction_deletion_record.py
View File

@@ -388,17 +388,11 @@ class TransactionDeletionRecord(Document):
frappe.delete_doc("Communication", batch, ignore_permissions=True)
def delete_comments(self, doctype, reference_doc_names):
comments = frappe.get_all(
"Comment",
filters={"reference_doctype": doctype, "reference_name": ["in", reference_doc_names]},
)
comment_names = [c.name for c in comments]
if not comment_names:
return
for batch in create_batch(comment_names, self.batch_size):
frappe.delete_doc("Comment", batch, ignore_permissions=True)
if reference_doc_names:
comment = qb.DocType("Comment")
qb.from_(comment).delete().where(
(comment.reference_doctype == doctype) & (comment.reference_name.isin(reference_doc_names))
).run()
def unlink_attachments(self, doctype, reference_doc_names):
files = frappe.get_all(