schuetz3/schuetz3-erpnext
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #34653 from frappe/mergify/bp/version-13-hotfix/pr-34648

Browse Source 
fix: serial no with zero quantity issue in stock reco (backport #34648)
This commit is contained in:
rohitwaghchaure
2023-03-30 13:39:28 +05:30
committed by GitHub
parent 60046feac3 46638b19db
commit a872a7a9eb
1 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
erpnext/stock/doctype/stock_reconciliation/stock_reconciliation.py
View File

@@ -3,7 +3,7 @@
import frappe
from frappe import _, msgprint
from frappe import _, bold, msgprint
from frappe.utils import cint, cstr, flt
import erpnext
@@ -88,7 +88,7 @@ class StockReconciliation(StockController):
if item_dict.get("serial_nos"):
item.current_serial_no = item_dict.get("serial_nos")
if self.purpose == "Stock Reconciliation" and not item.serial_no:
if self.purpose == "Stock Reconciliation" and not item.serial_no and item.qty:
item.serial_no = item.current_serial_no
item.current_qty = item_dict.get("qty")
@@ -139,6 +139,14 @@ class StockReconciliation(StockController):
self.validate_item(row.item_code, row)
if row.serial_no and not row.qty:
self.validation_messages.append(
_get_msg(
row_num,
f"Quantity should not be zero for the {bold(row.item_code)} since serial nos are specified",
)
)
# validate warehouse
if not frappe.db.get_value("Warehouse", row.warehouse):
self.validation_messages.append(_get_msg(row_num, _("Warehouse not found in the system")))