schuetz3/schuetz3-erpnext
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: consider empty iban

Browse Source
This commit is contained in:
Raffael Meyer
2019-04-22 12:27:12 +02:00
parent 49f919a4fc
commit 70f89462a8
2 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
erpnext/accounts/doctype/bank_account/bank_account.py
View File

@@ -21,7 +21,8 @@ class BankAccount(Document):
def validate(self): def validate(self):
self.validate_company() self.validate_company()
self.validate_iban() if self.validate_iban:
self.validate_iban()
def validate_company(self): def validate_company(self):
if self.is_company_account and not self.company: if self.is_company_account and not self.company:

6
erpnext/accounts/doctype/bank_account/test_bank_account.py
View File

@@ -28,6 +28,12 @@ class TestBankAccount(unittest.TestCase):
bank_account = frappe.get_doc({'doctype':'Bank Account'}) bank_account = frappe.get_doc({'doctype':'Bank Account'})
try:
bank_account.validate_iban()
except AttributeError:
msg = _('BankAccount.validate_iban() failed for empty IBAN')
self.fail(msg=msg)
for iban in valid_ibans: for iban in valid_ibans:
bank_account.iban = iban bank_account.iban = iban
try: try: