fix: consider empty iban
This commit is contained in:
@@ -21,7 +21,8 @@ class BankAccount(Document):
|
||||
|
||||
def validate(self):
|
||||
self.validate_company()
|
||||
self.validate_iban()
|
||||
if self.validate_iban:
|
||||
self.validate_iban()
|
||||
|
||||
def validate_company(self):
|
||||
if self.is_company_account and not self.company:
|
||||
|
||||
@@ -28,6 +28,12 @@ class TestBankAccount(unittest.TestCase):
|
||||
|
||||
bank_account = frappe.get_doc({'doctype':'Bank Account'})
|
||||
|
||||
try:
|
||||
bank_account.validate_iban()
|
||||
except AttributeError:
|
||||
msg = _('BankAccount.validate_iban() failed for empty IBAN')
|
||||
self.fail(msg=msg)
|
||||
|
||||
for iban in valid_ibans:
|
||||
bank_account.iban = iban
|
||||
try:
|
||||
|
||||
Reference in New Issue
Block a user