chore: code cleanup

(cherry picked from commit eea260b9f9)
This commit is contained in:
ruthra kumar
2024-03-19 11:18:11 +05:30
committed by Mergify
parent 3de53999ce
commit 3f45f63ff8

View File

@@ -132,7 +132,6 @@ class TransactionDeletionRecord(Document):
job_names = self.generate_job_name_for_next_tasks(task=task)
self.validate_running_task_for_doc(job_names=job_names)
# method = self.task_to_internal_method_map[task]
# Generate Job Id to uniquely identify each task for this document
job_id = self.generate_job_name_for_task(task)
@@ -149,7 +148,6 @@ class TransactionDeletionRecord(Document):
def execute_task(self, task_to_execute: str | None = None):
if task_to_execute:
pass
method = self.task_to_internal_method_map[task_to_execute]
if task := getattr(self, method, None):
task()
@@ -309,7 +307,9 @@ class TransactionDeletionRecord(Document):
frappe.db.set_value(docfield.doctype, docfield.name, "done", 1)
pending_doctypes = frappe.db.get_all(
docfield.doctype, filters={"parent": self.name, "done": 0}, pluck="doctype_name"
"Transaction Deletion Record Details",
filters={"parent": self.name, "done": 0},
pluck="doctype_name",
)
if pending_doctypes:
# as method is enqueued after commit, calling itself will not make validate_doc_status to throw