Merge branch 'develop' into fix-get_single_value

erpnext/accounts/doctype/purchase_invoice/test_purchase_invoice.py

@@ -1238,10 +1238,10 @@ class TestPurchaseInvoice(FrappeTestCase, StockTestMixin):
 	@change_settings("Accounts Settings", {"unlink_payment_on_cancellation_of_invoice": 1})
 	def test_gain_loss_with_advance_entry(self):
 		unlink_enabled = frappe.db.get_single_value(
-			"Accounts Settings", "unlink_payment_on_cancel_of_invoice"
+			"Accounts Settings", "unlink_payment_on_cancellation_of_invoice"
 		)
 
-		frappe.db.set_single_value("Accounts Settings", "unlink_payment_on_cancel_of_invoice", 1)
+		frappe.db.set_single_value("Accounts Settings", "unlink_payment_on_cancellation_of_invoice", 1)
 
 		original_account = frappe.db.get_value("Company", "_Test Company", "exchange_gain_loss_account")
 		frappe.db.set_value(
@@ -1432,7 +1432,7 @@ class TestPurchaseInvoice(FrappeTestCase, StockTestMixin):
 		pay.cancel()
 
 		frappe.db.set_single_value(
-			"Accounts Settings", "unlink_payment_on_cancel_of_invoice", unlink_enabled
+			"Accounts Settings", "unlink_payment_on_cancellation_of_invoice", unlink_enabled
 		)
 		frappe.db.set_value("Company", "_Test Company", "exchange_gain_loss_account", original_account)
 

erpnext/patches/v14_0/migrate_crm_settings.py

@@ -2,11 +2,7 @@ import frappe
 
 
 def execute():
-	settings = frappe.db.get_single_value(
+	settings = frappe.db.get_singles_dict("Selling Settings", cast=True)
-		"Selling Settings",
-		["campaign_naming_by", "close_opportunity_after_days", "default_valid_till"],
-		as_dict=True,
-	)
 
 	frappe.reload_doc("crm", "doctype", "crm_settings")
 	if settings:

erpnext/utilities/doctype/video/video.py

@@ -78,13 +78,11 @@ def get_frequency(value):
 
 def update_youtube_data():
 	# Called every 30 minutes via hooks
-	enable_youtube_tracking = frappe.db.get_single_value("Video Settings", "enable_youtube_tracking")
+	video_settings = frappe.get_cached_doc("Video Settings")
-	frequency = frappe.db.get_single_value("Video Settings", "frequency")
+	if not video_settings.enable_youtube_tracking:
-
-	if not cint(enable_youtube_tracking):
 		return
 
-	frequency = get_frequency(frequency)
+	frequency = get_frequency(video_settings.frequency)
 	time = datetime.now()
 	timezone = pytz.timezone(get_system_timezone())
 	site_time = time.astimezone(timezone)