Nihantra C. Patel
aee8a23626
fix: removed single quotes from deferred revenue ( #43985 )
...
(cherry picked from commit 834d18840c )
2024-11-06 06:37:02 +00:00
Corentin Forler
3d082c93bc
fix(deferred_revenue): Escape account in query
...
(cherry picked from commit c7b3ae41d4 )
2024-10-22 10:42:08 +00:00
Dany Robert
7cd6debd0e
fix: missing def expense if no exp in first month
...
(cherry picked from commit 5c9ce575f6 )
2024-08-06 11:01:41 +00:00
Akhil Narang
4d34b1ead7
refactor(treewide): formatting and ruff fixes, + manually enabled F401
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev >
2024-04-10 17:13:31 +05:30
ruthra kumar
8f72a6814b
fix: incorrect usage get_cached_value on single doctypes
...
(cherry picked from commit ba15810639 )
2023-08-01 10:12:55 +05:30
mergify[bot]
573183cff5
fix: deferred accounting entries on accounts frozen ( #35978 )
...
* fix: deferred accounting entries on accounts frozen (#35978 )
* fix: accounts frozen entries in deferred accounting
* test: accounts frozen date in deferred accounting
* fix: reset account settings after running test
* fix: resolve conflicts
* fix: modify expected gle when deferred accounting is disabled through JE
* fix: change posting date when accounts not frozen
(cherry picked from commit 674af15696 )
# Conflicts:
# erpnext/accounts/doctype/process_deferred_accounting/test_process_deferred_accounting.py
* chore: resolve conflicts
* fix: test for deferred accounting
* chore: Linting Issues
---------
Co-authored-by: Gursheen Kaur Anand <40693548+GursheenK@users.noreply.github.com >
Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com >
2023-07-10 17:31:17 +05:30
mergify[bot]
027510b629
fix: Deferred revenue date comparison ( #33515 )
...
fix: Deferred revenue date comparison (#33515 )
(cherry picked from commit a3ab8f973a )
Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com >
2023-01-03 18:39:19 +05:30
Rushabh Mehta
548afba8bb
fix(minor): update frappe.error_log to new API ( #30864 )
...
* fix(minor): update frappe.error_log to new API
* refactor: changes for updated log_error api
Co-authored-by: Ankush Menat <ankush@frappe.io >
2022-05-02 15:04:26 +05:30
Deepesh Garg
9bf5f76ac8
fix: Deferred Revenue/Expense Account validation
2022-04-06 17:33:46 +05:30
Ankush Menat
494bd9ef78
style: format code with black
2022-03-28 18:52:46 +05:30
Deepesh Garg
366120ffee
fix: Deferred revenue booking
2022-03-01 11:57:34 +05:30
Deepesh Garg
30a647ff80
fix: Handle frozen books while handling
2022-01-07 19:52:38 +05:30
Deepesh Garg
094158f287
fix: Add test case for multicurrency invoice
2022-01-04 14:04:18 +05:30
Deepesh Garg
98f294a8ae
fix: Deferred revenue booking for multi currency invoices via JV
2022-01-03 19:40:47 +05:30
Deepesh Garg
3c64e201cc
fix: Log error before throwing exception
2021-12-04 20:05:37 +05:30
Deepesh Garg
0ba4fcee2a
fix: Commit joural entries
2021-12-04 19:25:44 +05:30
Deepesh Garg
67a001d876
fix: Better Error logging fordeferred revenue/expense booking
2021-12-04 19:19:03 +05:30
Ankush Menat
8fe5feb6a4
chore: remove all six compat code
2021-11-05 11:16:29 +05:30
Ankush Menat
6098e92ba9
chore: remove utf-8 compat code
2021-11-05 11:16:29 +05:30
Deepesh Garg
f1a669c2f7
fix: Test case
...
(cherry picked from commit 23863c7663 )
2021-09-30 03:06:02 +00:00
Chillar Anand
915b34391c
chore: Clean up imports ( #27302 )
...
* chore: Added isort to pre-commit config
* chore: Sort imports with isort
* chore: Clean up imports with pycln
* chore: Sort imports with isort
* chore: Fix import issues
* chore: Clean up sider issues
* chore: Remove import errors from flake8 ignore list
* chore: Clean up lint issues
2021-09-02 16:44:59 +05:30
Ankush Menat
694ae81618
fix: remove bare excepts
2021-09-01 15:02:28 +05:30
Ankush Menat
4551d7d602
chore: mass trailing whitespace and EOF fixes
2021-08-19 13:43:28 +05:30
Deepesh Garg
5069095984
fix: Auto process deferred accounting for multi-company setup
2021-07-04 20:31:37 +05:30
Deepesh Garg
f79a72dbf3
fix: Error while booking deferred revenue
2021-06-24 14:49:09 +05:30
Ankush Menat
b6783b158f
chore: translation fixes
2021-05-17 17:06:41 +05:30
Ankush Menat
f3b3d81e0b
fix: escape company name in deferred_revenue
2021-05-17 17:06:41 +05:30
Deepesh Garg
7cc1cf36ca
feat: More controlled deferred revenue booking ( #21671 )
...
* feat: More controller deferred revenue booking
* fix: Query for last gl entry
* fix: Accounting Dimension for Deferred entries
* fix: Deferred revenue booking against paid invoices
* fix: Don not update outstanding on Deferred Entry submission
* fix: Naming fixes
* feat: Deferred revenue/expense booking based on months
* fix: Test case for fix monthly deferred revenue booking
* fix: Typo
* fix: Patch to update settings
* fix: Test case to book deferred expense via journal entry
* fix: Update field for better UX
* fix: Codacy
* fix: Change select field to checkbox
2020-06-23 09:57:56 +05:30
Chinmay D. Pai
0d147b011e
fix: set default posting_date value to None
...
using mutable python defaults, and especially function calls, inside
function definitions causes bugs that can be really hard to debug
sometimes. please refrain from using such defaults.
instead, using None is almost always a sane default. the values can
then be manipulated inside the function instead.
Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com >
2020-05-24 00:54:04 +05:30
Deepesh Garg
7d61c03af4
fix: Add missing dimensions in GL entries ( #21689 )
...
* fix: Add misssing dimensions in GL entries
* fix: Add project filter in trial balance report
* fix: Use current dimensions instead of dimensions from asset
2020-05-15 12:58:48 +05:30
Mangesh-Khairnar
2f7861a9b8
feat: Process deferred accounting entry ( #19658 )
...
* feat: process deferred accounting
* feat: maintain entry for deferred accounting
* feat: add check for automatic deferred accounting entry
* feat: add build conditions for company and account
* fix: create record for automatic processing of deferred accounting
* feat: add custom naming series
* fix: change the deferred revenue creation via hooks
* fix: add client side validations
* test: creation of gl entries on submission of process deferred accounting
* fix: add multiple validations
* patch(accounts-settings): set automatically process deferred accounting entry
* fix: On cancel function for deferred entry
* fix: Send email per process instead of per invoice
* fix: Test cases
* fix: Label
* fix: Process deferred accounting fixes
* fix: Error flag
Co-authored-by: Nabin Hait <nabinhait@gmail.com >
Co-authored-by: deepeshgarg007 <deepeshgarg6@gmail.com >
Co-authored-by: Deepesh Garg <42651287+deepeshgarg007@users.noreply.github.com >
2020-05-02 20:09:33 +05:30
Suraj Shetty
48e9bc3fc9
fix: Incorrect translation syntax
2020-01-29 15:06:18 +05:30
rohitwaghchaure
e123ec6b45
fix: incorrect number of entries while making deferred revenue entry ( #19473 )
2019-11-06 15:25:00 +05:30
Nabin Hait
7b2c52b6f2
Merge branch 'hotfix' of https://github.com/frappe/erpnext into develop
2019-03-29 13:26:46 +05:30
Nabin Hait
66d07c2700
fix(accounts): Indentation
2019-03-29 13:25:11 +05:30
Nabin Hait
d4e038b6ca
Merge branch 'hotfix' of https://github.com/frappe/erpnext into develop
2019-03-29 12:41:48 +05:30
Nabin Hait
86fb523ea7
fix(accounts): codacy fixes
2019-03-28 20:06:57 +05:30
Nabin Hait
0a90ce5cf6
Refactored deferred revenue booking logic
2019-03-28 19:43:02 +05:30
Frappe Bot
74fd5daeb2
Merge branch 'master' into develop
2019-02-15 10:22:33 +00:00
Nabin Hait
c3698e458f
Merge pull request #16666 from nabinhait/deferred-revenue-fix
...
fix: errors in deferred revenue booking
2019-02-14 18:49:01 +05:30
Nabin Hait
29fcb14c42
fix: errors in deferred revenue booking
2019-02-13 17:18:12 +05:30
Sagar Vora
551f52fd25
Merge branch 'master' into develop
2019-02-12 16:41:24 +05:30
Nabin Hait
27af6b377f
fix: defered accounting fixes
2019-02-08 16:56:26 +05:30
Nabin Hait
3476a457ad
fix: minor
2019-01-25 16:22:36 +05:30
Zlash65
58a080a1b1
add voucher detail no while creating gl entry
2018-10-06 16:34:58 +05:30
Zarrar
bc7a2c5cb3
Merge pull request #15602 from Zlash65/fix-mod
...
[Minor] Deferred Expense
2018-10-06 16:21:06 +05:30
Zlash65
b4aeee776a
add voucher detail no while creating gl entry
2018-10-06 16:17:12 +05:30
Ameya Shenoy
da10f6ebd8
Merge branch 'staging' into develop
2018-10-04 11:51:30 +00:00
rohitwaghchaure
90f9f9d3d8
Code optimization for deferred revenue ( #15527 )
2018-09-30 21:12:50 +05:30
Rohit Waghchaure
c699b2a98a
[Fix] Key error while saving sales invoice
2018-09-24 11:57:48 +05:30