ruthra kumar
bcae2810b9
Merge pull request #44892 from Sanket322/payment_schedule_in_is_paid
...
fix: clear payment schedule in purchase invoice for is_paid
2024-12-27 13:23:07 +05:30
ruthra kumar
0589fa7f3e
refactor: early return is always better
...
validate_advance_entries() has a heavy IO bound operation. Early
return on unwanted cases is always better.
2024-12-27 12:48:25 +05:30
rohitwaghchaure
1319ce4bc1
fix: material request status ( #44917 )
2024-12-26 15:58:39 +05:30
Sanket322
e1fc239f3d
fix: clear payment schedule in purchase invoice for is_paid
2024-12-24 16:38:51 +05:30
rohitwaghchaure
021d077808
fix: set project in GL from the SLE ( #44879 )
2024-12-24 14:49:41 +05:30
Diptanil Saha
948556def5
Merge pull request #44856 from diptanilsaha/fix-pos-invoice-advanced-received
...
fix: fetch advance payment entries on pos invoice
2024-12-23 20:59:00 +05:30
rohitwaghchaure
c9b143b509
fix: stock entry not fetching expired batches ( #44863 )
2024-12-23 20:28:06 +05:30
Diptanil Saha
a7078e5702
fix: fetch advance payment entries on pos invoice
2024-12-23 15:54:16 +05:30
rohitwaghchaure
a2c2b8b5ad
fix: do not validate qc for scrap item ( #44844 )
2024-12-23 15:39:04 +05:30
ruthra kumar
ab91abb144
refacto(test): remove hardcoded names
2024-12-23 14:54:15 +05:30
ruthra kumar
fad00fedaa
Merge pull request #44808 from aerele/difference_posting_date_in_si_pi
...
feat: Added difference_posting_date field in Sales Invoice Advance and Purchase Invoice Advance
2024-12-23 14:09:07 +05:30
Mihir Kandoi
b7699012b2
feat: Create subcontracted PO from Material Request ( #44745 )
...
* feat: Create subcontracted PO from Material Request
* fix: Made minor changes in logic to pass all test cases
* refactor: Made changes suggested by mentor and simplified logic
* test: Made changes to tests
2024-12-23 13:11:44 +05:30
ruthra kumar
cf57cb73f0
Merge pull request #44786 from ljain112/fic-adv-pv
...
fix: correct args for get_advance_payment_entries_for_regional
2024-12-23 12:57:42 +05:30
rs-rethik
854e37c05c
fix: update query
2024-12-20 14:00:54 +05:30
rs-rethik
2d58e845e6
refactor: convert sql query to query builder
2024-12-20 12:42:47 +05:30
rs-rethik
c14a2d73bf
test: add unit test to validate journal entry posting date
2024-12-20 12:13:35 +05:30
rs-rethik
ff1d040a6e
feat: use difference_posting_date for journal entry posting_date
2024-12-20 12:10:08 +05:30
rohitwaghchaure
90baa38f64
perf: SABB ( #44764 )
2024-12-19 13:00:31 +05:30
ljain112
df13a4cc2f
fix: correct args for get_advance_payment_entries_for_regional
2024-12-19 12:04:04 +05:30
Mihir Kandoi
3eba6bf3dd
feat(subcontracting): Added provision to create multiple Subcontracting Orders against a single Purchase Order ( #44711 )
...
* feat(subcontracting): Added provision to create multiple Subcontracting Orders from a single Subcontracted Purchase Order
* refactor(new_sc_flow_2): Fixed error thrown by semgrep
2024-12-18 20:38:21 +05:30
rohitwaghchaure
1f5d7072e7
fix: purchase return entry issue ( #44721 )
2024-12-17 12:29:20 +05:30
barredterra
11644241fa
feat: validate discount date in payment schedule
2024-12-10 17:23:00 +01:00
ruthra kumar
267d9606f8
refactor(test): disable unwanted dimensions
2024-12-10 17:48:13 +05:30
ruthra kumar
22c1608745
test: assert all reqd are set
2024-12-10 17:48:13 +05:30
ruthra kumar
c97e058bc6
chore: rename and move test file
2024-12-10 17:48:13 +05:30
ruthra kumar
6e02e29e4e
Merge pull request #44545 from ljain112/fix-pr-adv
...
fix: only show advance payment entries where "book_advance_payments_in_separate_party_account" is true
2024-12-09 16:25:47 +05:30
ruthra kumar
d847f75ade
chore: remove 'debug' param and linter fix
2024-12-09 15:59:40 +05:30
Deepesh Garg
1ac292285e
chore: Ignore stock validation for non stock invoices ( #44549 )
...
* chore: Ignore stock validation for non stock invoices
* chore: Ignore stock validation for non stock invoices
2024-12-05 18:14:23 +05:30
ljain112
ffd6a8424b
fix: only show advance payment entries where "book_advance_payments_in_separate_party_account" is true
2024-12-05 15:18:44 +05:30
ruthra kumar
9bbb953e26
Merge pull request #44373 from Ninad1306/valuation_rate_fix
...
fix: Always Calculate `sales_incoming_rate` for Internal Transfers
2024-12-03 14:17:04 +05:30
ruthra kumar
810a2c8fc1
Merge pull request #44412 from ljain112/fix-common-party
...
fix: handle multi currency in common party journal entry
2024-12-02 12:38:34 +05:30
Sagar Vora
279dcabf38
Merge pull request #44443 from sagarvora/minor-perfs
...
perf: reduce queries during transaction save
2024-11-30 00:45:46 +05:30
Sagar Vora
b6b8a06fda
perf: reduce queries during transaction save
2024-11-30 00:20:18 +05:30
Sagar Vora
6de7320ef4
perf: cache product bundle items at document level ( #44440 )
2024-11-29 17:21:32 +00:00
rohitwaghchaure
5266f236b7
fix: SABB print for packed items ( #44413 )
2024-11-29 15:49:00 +05:30
ljain112
e371f68d66
fix: handle multi currency in common party journal entry
2024-11-28 19:50:01 +05:30
vimalraj27
21049bae91
chore: Fix typo "Purchase Reecipt"
2024-11-27 18:03:39 +05:30
Ninad1306
94d3fc9fde
test: validate buying workflow
2024-11-27 12:06:11 +05:30
Ninad1306
d049c97884
fix: always set sales incoming rate for internal transfers
2024-11-27 12:05:39 +05:30
ruthra kumar
1baed9f46e
Merge pull request #44304 from ernestoruiz89/patch-2
...
chore: Add translations to QI validations in Update stock_controller.py
2024-11-26 11:36:05 +05:30
rohitwaghchaure
52f0d67bae
Merge pull request #44260 from rohitwaghchaure/fixed-github-40144
...
feat: available qty at company in sales transactions
2024-11-25 19:58:54 +05:30
Rohit Waghchaure
d8b9aef14f
feat: available qty at company in sales transactions
2024-11-25 16:27:46 +05:30
David Arnold
f1bd6e492a
chore: use local deprecation ( #44306 )
2024-11-23 22:25:12 +00:00
David Arnold
2e04eeb661
fix: net_amount calculation ( #44231 )
...
fix: tax_item_rate calculation
2024-11-23 22:10:33 +00:00
Ernesto Ruiz
6754f15487
chore: Add translations to QI validations in Update stock_controller.py
...
chore: Add translations to QI validations in Update stock_controller.py
2024-11-23 09:07:18 -06:00
ruthra kumar
a971417f25
Merge pull request #44207 from ljain112/validate-sales_person
...
fix: validate sales team to ensure all sales person are enabled
2024-11-20 10:40:34 +05:30
David Arnold
9673bf85ec
refactor: pass typed arguments to get_item_details methods ( #44230 )
...
* refactor: pass proper types to get_item_details methods
* chore: excempt previous commit from git blame
2024-11-20 02:31:03 +01:00
David Arnold
af2a622afb
fix: partial fix for #44291 ( #44229 )
...
This is only a partial fix and improves the situaton.
A proper fix will need to have items _always_ track their tax-related
account head, namely for item-wise tax templates as well as default
document taxes that are applied "On Net Total", in order to achive
proper assignment of the net_amount.
Currently there is no way to always identify the orignating account head per item.
2024-11-19 23:15:22 +00:00
David Arnold
daabe847b0
refactor: cleanup args structure akin to some typing ( #44226 )
...
* refactor: cleanup args structure akin to some typing
this clarification is a human precondition to being able to fix https://github.com/frappe/erpnext/issues/44219
* chore: excempt previous commit from git blame
* fix: adapt signature
2024-11-19 22:27:57 +00:00
ljain112
548dbb33eb
fix: validate sales team to ensure all sales person are enabled
2024-11-19 14:32:43 +05:30
