Subin Tom
c494ed087a
fix: Coupon code item pricing dynamic updation issue
...
(cherry picked from commit ccf63124d6 )
2022-02-08 06:20:51 +00:00
marination
6e7f1a300c
fix: Linter and minor code refactor
...
- Create an indexed map of stale packed items table to avoid loops to check if packed item row exists
- Reset packed items if row deletion takes place
- Renamed functions to self-explain them
- Split long function
- Reduce function calls inside function (makes it harder to follow through)
(cherry picked from commit 4c677eafe9 )
2022-02-03 16:40:44 +00:00
Deepesh Garg
d85aef5b2a
Merge pull request #29188 from frappe/mergify/bp/version-13-hotfix/pr-29176
...
fix: Inconsistency in calculating outstanding amount (backport #29176 )
2022-01-07 20:21:02 +05:30
Saqib Ansari
4ef9d289e8
fix(sales-invoice): cannot create debit note with zero qty
...
(cherry picked from commit 04ea42ce52 )
2022-01-07 13:06:00 +00:00
Deepesh Garg
9b6c2fdfb7
fix: Conflicts
2022-01-07 15:03:55 +05:30
Deepesh Garg
b561c18502
fix: Inconsistency in calculating outstanding amount
...
(cherry picked from commit 9d3a5c3184 )
# Conflicts:
# erpnext/public/js/controllers/taxes_and_totals.js
2022-01-07 07:59:28 +00:00
Deepesh Garg
b60fbf5ba9
fix: Add round floats for price list rate
2021-12-22 12:01:39 +05:30
Deepesh Garg
233f79bf96
fix: Recalculate taxes irrespective of price list rate changed or not
2021-12-22 11:26:19 +05:30
Deepesh Garg
0980c2f981
fix: Linting issues
2021-12-20 13:26:16 +05:30
Deepesh Garg
6087d5a603
fix(UX): Optimize rate updation of changing price list
2021-12-20 12:16:14 +05:30
Deepesh Garg
b09274bd49
Merge pull request #28641 from frappe/mergify/bp/version-13-hotfix/pr-28302
...
fix: Shipping Rule picking up old net_rate (backport #28302 )
2021-12-03 15:20:09 +05:30
mergify[bot]
b6d752201a
fix: actual tax conversion in case of multicurrency invoices ( #28686 )
2021-12-02 12:13:34 +05:30
Subin Tom
f591596615
fix: merge conflicts
2021-11-30 16:06:55 +05:30
Subin Tom
facaa9cc39
fix: sider issues
...
(cherry picked from commit e7b4204c35 )
# Conflicts:
# erpnext/public/js/controllers/taxes_and_totals.js
2021-11-30 09:08:17 +00:00
Subin Tom
9e1fd09a64
fix: fixed tests, separated a method for shipping charges
...
(cherry picked from commit a8e2c02e14 )
2021-11-30 09:08:16 +00:00
Subin Tom
e65a720810
fix: Shipping Rule picking up old net_rate
...
(cherry picked from commit c78b8b7897 )
# Conflicts:
# erpnext/public/js/controllers/taxes_and_totals.js
# erpnext/public/js/controllers/transaction.js
2021-11-30 09:08:15 +00:00
marination
af430bb590
fix: Merge conflicts
2021-11-16 18:58:36 +05:30
marination
4441f4d93a
refactor: (ux) Accepted/Rejected/Received Qty UX
...
(cherry picked from commit 5fb5a757cf )
# Conflicts:
# erpnext/public/js/controllers/buying.js
2021-11-16 12:43:29 +00:00
Ankush Menat
8fffd1597d
fix: dont recompute item wise taxes from front end
...
(cherry picked from commit 393749a611 )
2021-10-20 19:44:26 +05:30
mergify[bot]
15c9c08261
Merge pull request #27715 from frappe/mergify/bp/version-13-hotfix/pr-27668
...
fix: Batch scans get overwritten on the same row (backport #27668 )
2021-09-30 16:34:11 +05:30
Frappe PR Bot
fbae3c7fd6
fix: apply price list after batch or serial no insertion ( #27566 ) ( #27683 )
...
(cherry picked from commit 72c081fd8f )
Co-authored-by: Alan <2.alan.tom@gmail.com >
2021-09-28 12:59:45 +05:30
vama
666eaae6ce
fix: PO/PINV - Check if doctype has company_address field before setting the value ( #27441 )
...
Co-authored-by: Vama Mehta <vama.mehta@inqubit.in >
2021-09-18 13:21:45 +05:30
Frappe PR Bot
e9da4ed34d
fix: manually added weight per unit reset to zero after save ( #27330 ) ( #27338 )
...
(cherry picked from commit 7b4a65484a )
Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com >
2021-09-03 22:54:49 +05:30
Frappe PR Bot
1063d85569
fix: Correct company address not getting copied from Purchase Order to Invoice ( #27217 ) ( #27235 )
...
* fix: Correct company adderess not getting copied from Purchase Order to Invoice
* fix: Linting issues
(cherry picked from commit fd467e6d32 )
Co-authored-by: Deepesh Garg <42651287+deepeshgarg007@users.noreply.github.com >
Co-authored-by: Afshan <33727827+AfshanKhan@users.noreply.github.com >
2021-08-31 20:11:21 +05:30
Frappe PR Bot
a7cdba24bc
feat: coupon code discount in pos invoice ( #27103 )
2021-08-24 19:47:40 +05:30
Saqib
dbca11071e
refactor: scan barcode field scanning ( #26990 ) ( #27076 )
2021-08-23 11:23:46 +05:30
Ankush Menat
9bb69e711a
chore: whitespace cleanup from codebase
2021-08-19 14:33:03 +05:30
Frappe PR Bot
1167a9bf94
fix: unsetting of payment if no pos profile found ( #26891 )
...
* fix: unseting of payment if no pos profile found (#26884 )
(cherry picked from commit b614834efe )
# Conflicts:
# erpnext/public/js/controllers/taxes_and_totals.js
* fix: conflicts
* fix: conflicts
* fix: conflicts
* fix: conflicts
Co-authored-by: Afshan <33727827+AfshanKhan@users.noreply.github.com >
Co-authored-by: Afshan <afshan13k@gmail.com >
2021-08-10 23:18:23 +05:30
Frappe PR Bot
1a39d1a311
fix: cost center & account validation in Sales/Purchase Taxes and Charges ( #26881 )
2021-08-10 19:38:39 +05:30
Subin Tom
793063bf4e
fix: pos return payment mode issue ( #26875 )
2021-08-10 15:57:30 +05:30
marination
f22b858253
fix: Clean Serial No input on Server Side
2021-08-10 14:35:41 +05:30
Deepesh Garg
8d52a22709
fix: Additional discount calculations in Invoices ( #26553 )
...
* fix: Additional discount calculations in Invoices
* revert: Client side handling for Dynamic GST Rates
* fix: Add update item tax template method back
* fix: Revert refresh field
* fix: add company change trigger
2021-07-26 19:00:57 +05:30
Deepesh Garg
991d3cdd76
fix: Incorrect discount amount on amended document
2021-07-01 21:17:17 +05:30
Deepesh Garg
b4b76b75cd
Merge pull request #26176 from deepeshgarg007/item_tax_fetch_fix
...
fix: User is not able to change item tax template
2021-06-24 19:55:49 +05:30
Deepesh Garg
1658107a92
fix: Linting fixes
2021-06-24 19:18:50 +05:30
Deepesh Garg
e21e435a0d
fix: Add python 3 compatible string types
2021-06-24 19:17:58 +05:30
Deepesh Garg
03b629c851
Merge pull request #26100 from deepeshgarg007/pi_billing_address
...
fix: Billing address not fetched in Purchase Invoice
2021-06-24 10:29:01 +05:30
Deepesh Garg
1f7b95f390
fix: User is not able to change item tax template
2021-06-23 20:56:27 +05:30
Saqib
fb89008a13
fix(pos): unsupported operand type -=: for 'float' and 'NoneType' ( #26097 )
2021-06-21 10:49:09 +05:30
Rohit Waghchaure
5cc3f14506
fix: purchase invoice qty change not recalculate the consumed qty and added test cases for purchase invoice
2021-06-19 23:16:23 +05:30
Rohit Waghchaure
ddb0ec261a
fix: code cleanup and convert public method to private for subcontracting class
2021-06-19 23:16:23 +05:30
Deepesh Garg
a58b571ccb
fix: Billing address not fetched in Purchase Invoice
2021-06-18 10:45:35 +05:30
Nabin Hait
d17217c4e2
Merge pull request #25831 from deepeshgarg007/tds_advance_payment_v13
...
feat: Tax deduction against advance payments
2021-06-10 20:25:30 +05:30
Deepesh Garg
5434dd048b
Merge branch 'version-13-hotfix' of https://github.com/frappe/erpnext into dynamic_gst_rates
2021-06-10 18:56:39 +05:30
Deepesh Garg
6f2dacc60c
Merge branch 'version-13-hotfix' of https://github.com/frappe/erpnext into tds_advance_payment_v13
2021-06-06 19:31:50 +05:30
Deepesh Garg
3646c301ed
fix: Linting issues
2021-06-05 13:21:03 +05:30
Deepesh Garg
8a7e283926
feat: Item Taxes based on net rate
2021-06-04 22:53:26 +05:30
Rohan Bansal
a06ec03efc
test: add test for new QI function
2021-06-02 14:55:31 +05:30
Deepesh Garg
2f5885627d
fix: Labeling and other fixes
2021-06-01 11:07:18 +05:30
Rohan Bansal
1cdf5a0dba
fix: add requested changes
2021-05-26 14:42:15 +05:30