Rohit Waghchaure
2f0c0c2b59
fix: test case
2025-06-19 16:55:22 +05:30
Diptanil Saha
8f4a6d248f
fix: fetch correct item tax template on item rate update ( #47955 )
2025-06-11 10:58:18 +05:30
Ankush Menat
765c7c2bcc
refactor: rename get_settings -> get_single_value ( #47961 )
2025-06-09 04:40:02 +00:00
Ankush Menat
ea5c2c454b
perf: use cached stock settings ( #47945 )
2025-06-06 18:54:49 +05:30
Ankush Menat
a38ed286bd
perf: cache item metadata retrieval ( #47929 )
...
* perf(get_item_details): use cached doc, avoid full get_doc
* perf: short-circuit common usecase of same UOM
* perf: use cached doc for inspection
* perf: use cached valuation method and other item props
It rarely if ever changes after initial configuration
2025-06-06 11:39:27 +00:00
Sagar Vora
3ebde4526a
feat!: configure which rate is used to auto-update price list
2025-05-06 13:01:13 +05:30
ruthra kumar
0a2193e458
chore: linter fix
2025-03-03 14:05:41 +05:30
Nirmalrajaa K
1a56b83054
fix: Batch Price gets updated only if it is a billed item
2025-03-03 14:05:40 +05:30
Nirmalrajaa K
9597b1a69e
fix: Batch Price gets updated only if it is a billed item
2025-03-03 14:05:26 +05:30
Mihir Kandoi
7c9c0c7776
fix: error
2025-03-02 12:07:31 +05:30
Mihir Kandoi
a3596f717b
fix: dont update rate of free item when batch is updated
2025-03-02 11:29:39 +05:30
rohitwaghchaure
03290ef45f
Merge pull request #45774 from DaizyModi/fix-attribute-error
...
fix: AttributeError in `get_item_details` when selecting/scanning batch in Delivery Note
2025-02-10 15:47:19 +05:30
Rohit Waghchaure
35388e7a04
fix: not able to select the item in the sales invoice
2025-02-10 09:27:36 +05:30
DaizyModi
820b32eb8a
fix: Attibute error selling_price_list
2025-02-06 21:54:57 +05:30
Mihir Kandoi
1e4b9fbdf0
fix: fetch rate from item price list when document is saved
2025-02-04 10:54:57 +05:30
Rohit Waghchaure
88ab9be79c
fix: auto fetch batch and serial no for draft stock transactions
2025-01-13 17:17:03 +05:30
ljain112
976e35d547
fix: get item tax template based on posting date
2024-12-26 17:18:39 +05:30
Raffael Meyer
657c85638c
fix: get value from dict ( #44492 )
...
`doc.taxes` is not always a `frappe._dict`, it can also be a regular `dict`. Resolves #44328
2024-12-03 19:03:57 +00:00
David Arnold
2e04eeb661
fix: net_amount calculation ( #44231 )
...
fix: tax_item_rate calculation
2024-11-23 22:10:33 +00:00
Raffael Meyer
4b53075f84
refactor: use frappe._dict() instead of {} ( #44255 )
...
* refactor: use `frappe._dict()` instead of `{}`
A downstream function (`_get_item_tax_template`) expects this to be a frappe._dict and fails otherwise.
* refactor: use `ItemDetails()`
2024-11-21 00:36:20 +01:00
Raffael Meyer
8d8070e8eb
fix: use of ctx ( #44253 )
...
* fix: rename args to ctx in caller
* fix: use `.get("items")` to avoid conflict with `.items()` method
2024-11-20 19:03:26 +01:00
David Arnold
4ec23b5525
refactor: make stem utility for normalizing ctx args from dict json-str or Document ( #44228 )
2024-11-20 00:40:16 +01:00
David Arnold
daabe847b0
refactor: cleanup args structure akin to some typing ( #44226 )
...
* refactor: cleanup args structure akin to some typing
this clarification is a human precondition to being able to fix https://github.com/frappe/erpnext/issues/44219
* chore: excempt previous commit from git blame
* fix: adapt signature
2024-11-19 22:27:57 +00:00
rohitwaghchaure
d9e4ed13cb
fix: batch based item price not working ( #43172 )
2024-09-13 12:03:36 +05:30
Lakshit Jain
38f925b376
fix: adjust price insertion logic for internal suppliers/customers ( #42988 )
...
* fix: adjust price insertion logic for internal suppliers/customers
* refactor: correct indentation, specify conditions within function
* fix: typo
---------
Co-authored-by: Smit Vora <smitvora203@gmail.com >
2024-09-04 12:56:04 +05:30
rohitwaghchaure
c8af544ef3
fix: do not update item price and last purchase rate for inter transf… ( #42616 )
...
fix: do not update item price and last purchase rate for inter transfer transaction
2024-08-05 20:20:36 +05:30
rohitwaghchaure
0e817f42ef
fix: dynamic condition in the pricing rule not working ( #42467 )
2024-07-25 10:15:05 +05:30
Nabin Hait
92673d706c
Merge pull request #41024 from khushi8112/expense-account-based-on-asset-category
...
fix: expense account should be fetched from related asset category
2024-05-09 01:30:45 +05:30
Khushi Rawat
272ce24016
style: code changes for better readability
...
Co-authored-by: Nabin Hait <nabinhait@gmail.com >
2024-05-08 19:17:09 +05:30
“Khushi
651e4696fd
fix: expense account should be fetched from related asset category
2024-05-08 19:14:51 +05:30
Raffael Meyer
e4db0562ac
fix: search for item price in stock UOM ( #41075 )
2024-05-03 10:06:52 +05:30
Rohit Waghchaure
b0730293e2
fix: barcode not fetched on selection of item
2024-04-02 10:39:48 +05:30
Akhil Narang
3effaf21ef
refactor(treewide): formatting and ruff fixes, + manually enabled F401
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev >
2024-03-27 16:06:04 +05:30
Deepesh Garg
7d7d10e422
Merge pull request #40577 from barredterra/one-item-price
...
perf: query one item price only
2024-03-25 17:22:49 +05:30
Deepesh Garg
12945341ce
Merge pull request #40589 from barredterra/get_prices_as_dict
...
refactor: get prices as dict
2024-03-25 17:18:31 +05:30
Rohit Waghchaure
6821baa850
fix: rate reset to zero
2024-03-22 15:03:38 +05:30
Rohit Waghchaure
d893a465d7
fix: rate not fetching from the item price
2024-03-21 21:04:03 +05:30
barredterra
58b3ce6a19
refactor: get prices as dict
2024-03-21 13:48:05 +01:00
barredterra
be9fe7331a
perf: query one item price only
2024-03-20 19:37:34 +01:00
Nabin Hait
5691cc6323
Merge pull request #40456 from nabinhait/pi-optimization-dev
...
perf: Performance optimization for Purchase Invoice submission
2024-03-19 16:09:17 +05:30
rohitwaghchaure
09ea7edb86
fix: Update Existing Price List Rate not working ( #40333 )
2024-03-19 12:10:24 +05:30
Nabin Hait
26202d90cb
Merge pull request #40263 from nabinhait/pi-optimization
...
perf: Performance optmization for Purchase Invoice submission
2024-03-14 14:19:24 +05:30
rohitwaghchaure
675a0b810f
Merge pull request #39659 from rohitwaghchaure/fixed-timeout-error-while-making-auto-mr
...
perf: timeout for auto material request through reorder level
2024-02-05 11:38:11 +05:30
Divyam Mistry
e9fe10c6f1
fix: fetch/change tax template on basis of base_net_rate instead of net_rate ( #39448 )
...
fix: change tax template on basis of base_net_rate instead of net_rate
Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com >
2024-02-01 16:15:43 +05:30
Rohit Waghchaure
951023f434
perf: timeout for auto material request through reorder level
2024-01-31 17:27:32 +05:30
Deepesh Garg
f52d7c7665
fix: Pricing rule application/removal on qty change
2024-01-02 13:37:39 +05:30
rohitwaghchaure
db24e24882
fix: supplier removed on selection of item ( #38712 )
2023-12-13 14:06:45 +05:30
barredterra
0465c9aabb
fix: attribute error
2023-12-08 14:15:26 +01:00
Deepesh Garg
2989e36b1d
Merge pull request #38284 from vorasmit/fetch-item-tax-values
...
fix: fetch item_tax_template values if fields with fetch_from exisit
2023-11-26 17:54:35 +05:30
Smit Vora
b206b0583b
fix: fetch item_tax_template values if fields with fetch_from exisit
2023-11-23 15:10:47 +05:30
