barredterra
8deaba8def
fix(Issue): create communication
...
Ignore permisions and mandatory. Required, for example, when Issue is created by Customer via portal.
(cherry picked from commit 3f1d008741 )
2024-02-16 19:15:29 +00:00
mergify[bot]
942f34a734
fix: Reset SLA on issue doesn't work (backport #38789 ) ( #38790 )
...
fix: Reset SLA on issue doesn't work (#38789 )
This was broken since last refactor where it was spun off to work with
all types of doctypes but client side code was never adapted.
(cherry picked from commit fa1c7b663c )
Co-authored-by: Ankush Menat <ankush@frappe.io >
2023-12-15 22:02:29 +05:30
mergify[bot]
49296cd5cb
fix: OperationalError while selecting Serial No in Warranty Claim (backport #38394 ) ( #38413 )
...
* refactor: use arrow function
(cherry picked from commit 1763824e5f )
* refactor: use DocType `Fetch From` instead of `frm.add_fetch`
(cherry picked from commit 01044ca8e9 )
# Conflicts:
# erpnext/support/doctype/warranty_claim/warranty_claim.json
* refactor: use `frm.set_query` to add filters
(cherry picked from commit 640dfab827 )
* refactor: don't use `cur_frm`
(cherry picked from commit 9fadf5f426 )
* chore: `conflicts`
---------
Co-authored-by: s-aga-r <sagarsharma.s312@gmail.com >
2023-11-29 12:27:03 +05:30
mergify[bot]
b605b08ec1
refactor: remove extraneous disabled filters (backport #37732 ) ( #37748 )
...
* refactor: remove extraneous disabled filters
(cherry picked from commit f276fbba4f )
# Conflicts:
# erpnext/accounts/report/profitability_analysis/profitability_analysis.js
# erpnext/public/js/controllers/accounts.js
* chore: `conflicts`
---------
Co-authored-by: Bernd Oliver Sünderhauf <46800703+bosue@users.noreply.github.com >
Co-authored-by: s-aga-r <sagarsharma.s312@gmail.com >
2023-10-30 10:10:16 +05:30
Ankush Menat
adb6918834
perf: send SLA doctypes in boot
...
This request is fired on every load, data rarely if ever changes though.
(cherry picked from commit bd9ef74ef7 )
2023-07-16 07:01:32 +00:00
mergify[bot]
841d2e4b2c
refactor: Workspace cleanup (backport #35409 ) ( #35505 )
...
* refactor: Workspace cleanup
(cherry picked from commit 243c49c550 )
# Conflicts:
# erpnext/accounts/workspace/accounting/accounting.json
# erpnext/assets/workspace/assets/assets.json
* fix: Delete Retail and Utilities worspaces amd hide default Settings and Integration workspaces
(cherry picked from commit 0b28f641ad )
* fix: Added pos links in Selling workspace
(cherry picked from commit 86f88817a9 )
* fix: removed duplicate links of manufacturing workspace
(cherry picked from commit 5cf4c8c8b7 )
* fix: Rearranged accounting module links
(cherry picked from commit e78a7de1e5 )
# Conflicts:
# erpnext/accounts/workspace/accounting/accounting.json
* chore: typo
(cherry picked from commit bb67cc03df )
* chore: conflicts
---------
Co-authored-by: Nabin Hait <nabinhait@gmail.com >
Co-authored-by: Ankush Menat <ankushmenat@gmail.com >
Co-authored-by: Ankush Menat <ankush@frappe.io >
2023-05-31 16:51:54 +05:30
Shadrak Gurupnor
38e27a68d5
fix: validate for active sla ( #32132 )
...
(cherry picked from commit f2b7c9ee66 )
2023-05-11 12:18:49 +00:00
mergify[bot]
83a1b836f9
fix: SLA permissions (backport #34981 ) ( #34986 )
...
fix: SLA permissions (#34981 )
(cherry picked from commit ac871797b2 )
Co-authored-by: Ankush Menat <ankush@frappe.io >
2023-04-21 21:13:38 +05:30
Deepesh Garg
a2e001a2da
Revert "refactor: use renamed timezone utils ( #34301 )"
...
Revert "refactor: use renamed timezone utils (#34301 )"
This reverts commit 164933aae8 .
2023-03-07 17:56:57 +05:30
mergify[bot]
164933aae8
refactor: use renamed timezone utils ( #34301 )
...
refactor: use renamed timezone utils
https://github.com/frappe/frappe/pull/20253
(cherry picked from commit 502a37a864 )
Co-authored-by: barredterra <14891507+barredterra@users.noreply.github.com >
Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com >
2023-03-07 16:52:56 +05:30
mergify[bot]
f8b7cfa6dd
refactor: Remove usage of deprecated methods (backport #32914 ) ( #32915 )
...
* refactor: Remove usage of deprecated methods (#32914 )
Warn: Just used regex to replace all usage.
```regex
s/frappe.db.set(\(.*\),\(.*\),\(.*\))/\1.db_set(\2, \3)/g
```
Required after: https://github.com/frappe/frappe/pull/18815
(cherry picked from commit 7e1742956c )
# Conflicts:
# erpnext/accounts/doctype/sales_invoice/sales_invoice.py
* chore: conflicts
* style: black
Co-authored-by: Ankush Menat <ankush@frappe.io >
2022-11-10 11:09:13 +05:30
ruthra kumar
98e7b2dd25
test: lead creation and deletion restricted to dummy company
...
(cherry picked from commit ced8d2a537 )
2022-10-17 11:42:33 +00:00
Ankush Menat
755a060ba7
refactor: dont force issue list options ( #31613 )
...
Setting route option forces the filters, only default filters should be
set and not forced for each visit.
2022-07-18 11:12:07 +05:30
Conor
b8f728a40a
refactor: use CURRENT_DATE instead of CURDATE() ( #31356 )
...
* refactor: use CURRENT_DATE instead of CURDATE()
* style: reformat to black spec
* refactor: use QB for auto_close queries
Co-authored-by: Ankush Menat <ankush@frappe.io >
2022-06-15 12:07:33 +05:30
Ankush Menat
a896895a9e
fix: bulk fix (~330) missing translations
2022-04-04 13:59:51 +05:30
Ankush Menat
494bd9ef78
style: format code with black
2022-03-28 18:52:46 +05:30
Rushabh Mehta
fcf12c4054
fix(minor): allow SLA update without permission check
2022-01-18 18:07:11 +05:30
Ankush Menat
3db8d908dc
Merge pull request #29278 from shariquerik/update-workspace-json
...
fix: Updating public workspace json based on new design
2022-01-17 13:25:16 +05:30
Saqib Ansari
cc88b31f1f
test: remove sla if no active sla found
2022-01-14 18:17:40 +05:30
Saqib Ansari
b31679b6ef
fix: customer filter while fetching active sla
2022-01-14 16:31:48 +05:30
Saqib Ansari
0bfbfa3719
fix: reset sla if no active sla found
2022-01-14 16:13:17 +05:30
Saqib Ansari
a68fc546e7
refactor: do not allow submittable doctypes for SLA
2022-01-14 15:35:40 +05:30
Saqib Ansari
a9ab157198
fix: remove dashboard showing only issue count
2022-01-14 11:42:34 +05:30
Shariq Ansari
bc187c121a
fix: updated standard workspace json files
2022-01-13 19:24:11 +05:30
Rucha Mahabal
2b33e63d2c
fix: use get_all instead of get_list while fetching SLA doctypes ( #29216 )
...
Co-authored-by: Ankush Menat <ankush@frappe.io >
2022-01-11 14:40:08 +05:30
Saqib Ansari
fcc5fa14c8
fix: failing tests of first response time ( #29153 )
2022-01-05 20:44:06 +05:30
Saqib
f6d5534627
fix: set resolution by only if not on hold ( #28995 )
2021-12-22 19:05:18 +05:30
Saqib Ansari
0add80b02f
fix: failing tests
2021-12-14 20:24:29 +05:30
Saqib Ansari
c5fcbeff7a
fix: reset_expected_response_and_resolution on hold
2021-12-14 18:45:27 +05:30
Saqib Ansari
2f7d8ac29e
fix: indentation
2021-12-06 19:19:34 +05:30
Saqib Ansari
3446f7545f
fix: remove 'ongoing' status from issue summary report
2021-12-06 19:17:38 +05:30
Saqib Ansari
91aa78707c
fix: remove missed 'ongoing' references
2021-12-06 19:13:31 +05:30
Saqib Ansari
1a76b3801a
fix: test
2021-12-06 17:06:20 +05:30
Saqib Ansari
32c81818f6
fix: transalations
2021-12-06 15:38:01 +05:30
Saqib Ansari
812572d250
feat: record assignment on first response failure
2021-12-06 14:46:51 +05:30
Saqib Ansari
c1d8877a83
refactor: handle special cases on communication creation
2021-12-06 14:34:59 +05:30
Saqib Ansari
defa01edac
fix: undo removing of resolution_time fields
2021-12-03 16:22:10 +05:30
Saqib Ansari
1e550d3e46
fix: failing tests
2021-12-03 11:36:53 +05:30
Saqib Ansari
6736a89b4e
fix: failing tests
2021-12-02 15:54:02 +05:30
Saqib Ansari
a1cedc3ea0
fix: failing tests
2021-12-02 14:48:24 +05:30
Saqib Ansari
6f67bbca69
refactor(SLA): remove response_by_variance & resolution_by_variance
2021-12-02 13:39:05 +05:30
Saqib Ansari
79f8159ab9
test: issue closing after being on hold
2021-11-27 17:14:58 +05:30
Saqib Ansari
267cc35850
fix: failing tests
2021-11-27 16:47:45 +05:30
Saqib Ansari
214d0e367f
fix: remove leading whitespace
2021-11-26 20:20:38 +05:30
Saqib Ansari
a8c75b6862
refactor: application of SLA and its metrics
2021-11-26 20:16:21 +05:30
Saqib Ansari
210f593a49
refactor: SLA form fields
2021-11-26 15:49:17 +05:30
Saqib Ansari
c46c8dd6c5
feat: do not change variance if response or resolution is set
2021-11-24 19:23:31 +05:30
Saqib Ansari
1f060c0b0a
feat: find SLA based on customer group's ancestors
2021-11-24 14:00:18 +05:30
Saqib Ansari
9047e2b9dd
refactor: do not set default priority in isssues
2021-11-24 13:52:20 +05:30
Wolfram Schmidt
6907ad8adb
fix: add Email option to contact email field ( #28296 )
...
* Update warranty_claim.json
Added the Email in option field of Contact Email so you are able to create a notification mapping to this field as reciever.
* Update warranty_claim.json
2021-11-09 17:32:57 +05:30