ruthra kumar
753223da78
chore: resolve merge conflict
2024-03-02 16:00:29 +05:30
ruthra kumar
46063518d7
test: gain/loss on Journals against Journals
...
(cherry picked from commit 8a5078b826 )
# Conflicts:
# erpnext/controllers/tests/test_accounts_controller.py
2024-03-02 10:07:33 +00:00
ruthra kumar
c1a0ac655e
fix: make use of 'flt' to prevent really low precision exc gain/loss
...
(cherry picked from commit 0aa72f841d )
2024-03-02 10:07:31 +00:00
ljain112
30315aba37
fix: default taxable value for item not found in item list
...
(cherry picked from commit 5885978fc2 )
2024-02-27 16:39:03 +00:00
Gursheen Kaur Anand
317738dc36
Merge pull request #40063 from frappe/mergify/bp/version-14-hotfix/pr-40035
...
fix: delete PLE containing invoice in against (backport #40035 )
2024-02-27 12:41:42 +05:30
Gursheen Anand
8c7d0d4b85
fix: skip max discount validation for rate adjustment
...
(cherry picked from commit 5a3b133d65 )
2024-02-23 07:28:17 +00:00
Gursheen Anand
3d243a7fa5
fix: only check for delinked PLEs
...
(cherry picked from commit 146c5b3e16 )
2024-02-23 07:10:03 +00:00
Gursheen Anand
08459cef4a
fix: delete PLE containing invoice in against
...
(cherry picked from commit c1e1fd8829 )
2024-02-23 07:10:02 +00:00
ruthra kumar
9e9486d5ab
refactor: skip popup for POS invoices
...
(cherry picked from commit 3634c4c284 )
2024-02-23 00:33:09 +00:00
Nabin Hait
11bddc14bb
fix: Delete linked asset movement record on cancellation of purchase receipt/invoice
2024-02-20 12:23:16 +05:30
ruthra kumar
5894bb3bbe
refactor: use popup to inform on additional reconciliation step
...
(cherry picked from commit 0d260faa00 )
2024-02-19 07:32:19 +05:30
mergify[bot]
d0b9c568d3
fix: landed cost voucher not submitting because of incorrect reference (backport #39898 ) ( #39899 )
...
fix: landed cost voucher not submitting because of incorrect reference (#39898 )
(cherry picked from commit 6239fd704b )
Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com >
2024-02-14 15:57:48 +05:30
mergify[bot]
08e02710cd
perf: cached get_last_purchase_details to fix performance issue (backport #39854 ) ( #39855 )
...
perf: cached get_last_purchase_details to fix performance issue (#39854 )
(cherry picked from commit b966c06a4f )
Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com >
2024-02-12 15:54:03 +05:30
ruthra kumar
8d9b5764dd
refactor(test): Forex Credit Note cancellation against Invoice
...
(cherry picked from commit 2f676ced5c )
2024-02-07 15:00:47 +00:00
ruthra kumar
33777a4d4c
refactor: cancel Cr/Dr JE's on Sales/Purchase return cancel
...
(cherry picked from commit 0549535603 )
2024-02-07 15:00:44 +00:00
mergify[bot]
a6067c6239
fix: show warehouse title field in sales docs (backport #39746 ) ( #39754 )
...
fix: show warehouse title field in sales docs
(cherry picked from commit ee14faaa39 )
Co-authored-by: s-aga-r <sagarsharma.s312@gmail.com >
2024-02-06 12:45:43 +05:30
mergify[bot]
46ac4f4714
fix: remove applied pricing rule on qty change (backport #39688 ) ( #39736 )
...
fix: remove pricing rule
(cherry picked from commit 7c6a5a0f23 )
Co-authored-by: s-aga-r <sagarsharma.s312@gmail.com >
2024-02-05 16:09:09 +05:30
Rohit Waghchaure
85e6b39e23
perf: timeout for auto material request through reorder level
...
(cherry picked from commit 951023f434 )
# Conflicts:
# erpnext/stock/doctype/stock_entry/test_stock_entry.py
2024-02-05 06:09:53 +00:00
ruthra kumar
0884c5ed83
chore: resolve conflicts
2024-01-30 11:05:24 +05:30
ruthra kumar
c5ce4db315
refactor: prevent '{debit/credit}_to' account mismatch
...
(cherry picked from commit 6f2fae1b61 )
# Conflicts:
# erpnext/controllers/accounts_controller.py
2024-01-30 05:31:43 +00:00
ruthra kumar
844db3b8d6
Merge pull request #39509 from frappe/mergify/bp/version-14-hotfix/pr-39054
...
refactor: provision to filter on dimensions in reconciliation tool (backport #39054 )
2024-01-30 08:20:51 +05:30
ruthra kumar
d0c810accd
refactor(test): disable dimensions post test
2024-01-30 06:29:59 +05:30
ruthra kumar
1966ea15ba
refactor: pass orders name in a separate criterion
2024-01-30 05:58:26 +05:30
ruthra kumar
c054316127
chore: fix typo and initialize a list
2024-01-29 17:41:56 +05:30
ruthra kumar
ff0daedd52
refactor: convert sql to query builder on Payments query
2024-01-29 17:09:59 +05:30
mergify[bot]
bf61030dab
fix: prevent extra transfer against inter transfer transaction (backport #39213 ) ( #39595 )
...
* fix: prevent extra transfer against inter transfer transaction (#39213 )
* fix: prevent extra transfer against inter transfer transaction
* fix: internal transfer dashboard
(cherry picked from commit 8fdc244e16 )
# Conflicts:
# erpnext/controllers/stock_controller.py
* chore: fix conflicts
---------
Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com >
2024-01-27 23:25:04 +05:30
s-aga-r
9fd1692db2
fix: RM valuation rate in SCR ( #39541 )
2024-01-25 19:08:39 +05:30
Rohit Waghchaure
9a5995a3e5
fix: do not delete batches implicitly
2024-01-25 11:58:07 +05:30
ruthra kumar
2c431f394e
chore: resolve conflicts
2024-01-24 16:11:14 +05:30
ruthra kumar
15db7b8ae4
test: dimension inheritance on adv allocation
...
(cherry picked from commit fcf4687c52 )
2024-01-23 11:59:30 +00:00
ruthra kumar
d4828f3cf5
refactor: pass dimensions on advance allocation
...
(cherry picked from commit cbd443a78a )
2024-01-23 11:59:30 +00:00
ruthra kumar
ec58c309d2
test: dimension inheritance in PE reconciliation
...
(cherry picked from commit 6148fb024b )
2024-01-23 11:59:30 +00:00
ruthra kumar
a919702319
refactor: pass dimension values to Gain/Loss journal
...
(cherry picked from commit c44eb432a5 )
# Conflicts:
# erpnext/accounts/utils.py
2024-01-23 11:59:29 +00:00
ruthra kumar
de948f23c1
test: dimension inheritance for cr note reconciliation
...
(cherry picked from commit ba5a7c8cd8 )
2024-01-23 11:59:29 +00:00
ruthra kumar
c1591ec8e1
chore: test dimension filter output
...
(cherry picked from commit e3c44231ab )
2024-01-23 11:59:29 +00:00
ruthra kumar
dac422a0e1
refactor: pass dimension details to query
...
(cherry picked from commit 5dc22e1811 )
# Conflicts:
# erpnext/accounts/utils.py
2024-01-23 11:59:27 +00:00
ruthra kumar
3d62bce885
refactor: pass dimension filters to query
...
(cherry picked from commit ff60ec85b8 )
# Conflicts:
# erpnext/controllers/accounts_controller.py
2024-01-23 11:59:27 +00:00
ruthra kumar
42c1de640c
chore: resolve conflict
2024-01-17 10:36:29 +05:30
ruthra kumar
b35a83ee47
refactor: better ordering of query result
...
(cherry picked from commit bfe42fdccb )
# Conflicts:
# erpnext/controllers/queries.py
2024-01-16 10:55:31 +00:00
ruthra kumar
98967ed584
fix(test): test case for project query
...
(cherry picked from commit 3349dde5e2 )
2024-01-16 10:55:30 +00:00
ruthra kumar
f2e577bec7
fix: project query controller logic
...
(cherry picked from commit 4eefb445a7 )
# Conflicts:
# erpnext/controllers/queries.py
2024-01-16 10:55:30 +00:00
barredterra
755576bd78
fix: unreconcile Bank Transaction on cancel of payment voucher
...
(cherry picked from commit 0a95b38166 )
# Conflicts:
# erpnext/accounts/doctype/bank_transaction/bank_transaction.py
# erpnext/accounts/doctype/journal_entry/journal_entry.js
2024-01-11 13:37:32 +00:00
Nabin Hait
41e384326e
fix: Set asset purchase amount based on qty and valuation_rate
...
(cherry picked from commit 135e19d0aa )
2024-01-10 06:03:03 +00:00
mergify[bot]
f42e93bf6c
fix: skip rate validation for return DN Items with Moving Average valuation (backport #39242 ) ( #39265 )
...
* fix: skip rate validation for return `DN Items` with `Moving Average` valuation
(cherry picked from commit e0ad52b500 )
# Conflicts:
# erpnext/controllers/sales_and_purchase_return.py
* chore: `conflicts`
---------
Co-authored-by: s-aga-r <sagarsharma.s312@gmail.com >
2024-01-10 10:53:09 +05:30
mergify[bot]
06d193ad87
fix: don't set rate for non-stock item in Internal Transfer (backport #39140 ) ( #39168 )
...
* fix: don't set rate for non-stock item in Internal Transfer
(cherry picked from commit e1b0fffd0c )
* test: internal transfer for non-stock item
(cherry picked from commit 57b6a98703 )
# Conflicts:
# erpnext/stock/doctype/delivery_note/test_delivery_note.py
* chore: `conflicts`
---------
Co-authored-by: s-aga-r <sagarsharma.s312@gmail.com >
2024-01-08 11:44:52 +05:30
mergify[bot]
c0b598074c
fix: Validate account in Sales/Purchase Taxes and Charges Template ( #39013 )
...
fix: Validate account in Sales/Purchase Taxes and Charges Template (#39013 )
(cherry picked from commit cd37fd790b )
Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com >
2023-12-29 16:15:45 +05:30
s-aga-r
2eac618bba
Merge pull request #38892 from s-aga-r/FIX-6565
...
fix: remove rows with zero consumed qty
2023-12-22 15:58:09 +05:30
rohitwaghchaure
3a668bbe96
fix: reposting not fixing valuation rate for sales return using movin… ( #38895 )
...
fix: reposting not fixing valuation rate for sales return using moving average method
2023-12-21 14:13:34 +05:30
s-aga-r
f2f410093a
fix: remove rows with zero consumed qty
2023-12-21 11:03:18 +05:30
rohitwaghchaure
7fdac62393
fix: incoming rate for sales return with Moving Average valuation method ( #38849 )
2023-12-19 18:01:50 +05:30