Commit Graph

892 Commits

Author SHA1 Message Date
ruthra kumar
b2c3da135e refactor: only apply configuration on normal payments
patch to update default value
2025-01-23 14:12:24 +05:30
Rohit Waghchaure
88ab9be79c fix: auto fetch batch and serial no for draft stock transactions 2025-01-13 17:17:03 +05:30
Ejaaz Khan
81d8f257aa refactor: validate due date code and message according to doctype (#45126)
* refactor: change message of date comparision and refactor code

* refactor: commonify function call for sales and purchase invoice

* refactor: remove redundant mandatory error validation
2025-01-08 12:49:02 +05:30
ruthra kumar
0589fa7f3e refactor: early return is always better
validate_advance_entries() has a heavy IO bound operation. Early
return on unwanted cases is always better.
2024-12-27 12:48:25 +05:30
Sanket322
e1fc239f3d fix: clear payment schedule in purchase invoice for is_paid 2024-12-24 16:38:51 +05:30
Diptanil Saha
a7078e5702 fix: fetch advance payment entries on pos invoice 2024-12-23 15:54:16 +05:30
ruthra kumar
fad00fedaa Merge pull request #44808 from aerele/difference_posting_date_in_si_pi
feat: Added difference_posting_date field in Sales Invoice Advance and Purchase Invoice Advance
2024-12-23 14:09:07 +05:30
rs-rethik
854e37c05c fix: update query 2024-12-20 14:00:54 +05:30
rs-rethik
2d58e845e6 refactor: convert sql query to query builder 2024-12-20 12:42:47 +05:30
rs-rethik
ff1d040a6e feat: use difference_posting_date for journal entry posting_date 2024-12-20 12:10:08 +05:30
ljain112
df13a4cc2f fix: correct args for get_advance_payment_entries_for_regional 2024-12-19 12:04:04 +05:30
barredterra
11644241fa feat: validate discount date in payment schedule 2024-12-10 17:23:00 +01:00
ruthra kumar
d847f75ade chore: remove 'debug' param and linter fix 2024-12-09 15:59:40 +05:30
ljain112
ffd6a8424b fix: only show advance payment entries where "book_advance_payments_in_separate_party_account" is true 2024-12-05 15:18:44 +05:30
ljain112
e371f68d66 fix: handle multi currency in common party journal entry 2024-11-28 19:50:01 +05:30
David Arnold
2e04eeb661 fix: net_amount calculation (#44231)
fix: tax_item_rate calculation
2024-11-23 22:10:33 +00:00
David Arnold
9673bf85ec refactor: pass typed arguments to get_item_details methods (#44230)
* refactor: pass proper types to get_item_details methods

* chore: excempt previous commit from git blame
2024-11-20 02:31:03 +01:00
David Arnold
daabe847b0 refactor: cleanup args structure akin to some typing (#44226)
* refactor: cleanup args structure akin to some typing

this clarification is a human precondition to being able to fix https://github.com/frappe/erpnext/issues/44219

* chore: excempt previous commit from git blame

* fix: adapt signature
2024-11-19 22:27:57 +00:00
Smit Vora
f9dc9bdc0f Merge branch 'develop' into fix-voucher-types 2024-11-07 13:11:55 +05:30
ruthra kumar
c832d9fb9a refactor: avoid permission issue for non-admin 2024-11-05 10:25:32 +05:30
ruthra kumar
9c1a4e284c refactor: use dr / cr account currency field for journals 2024-10-31 10:36:22 +05:30
ruthra kumar
ae6a81cd07 refactor: handle currency on advance payment ledger 2024-10-31 10:36:22 +05:30
ruthra kumar
ad88bde448 refactor: move creation logic to controller 2024-10-31 10:36:22 +05:30
ruthra kumar
14357bccba fix: deleting SO/PO will remove its advance payment ledger entry 2024-10-31 10:36:22 +05:30
ruthra kumar
3c53b92f05 refactor: remove advance payment ledgers on document deletion 2024-10-31 10:36:22 +05:30
ruthra kumar
2b2360bf7b refactor: calculate advance from advance ledger 2024-10-31 10:36:22 +05:30
ruthra kumar
7e45d1555a Merge pull request #43685 from ljain112/fix-arap-report
fix: do not check for payment terms details for return invoices.
2024-10-28 11:22:36 +05:30
ljain112
8b700eadc7 fix: do not set payment terms for return invoices 2024-10-25 18:09:01 +05:30
Raffael Meyer
345d32432b fix: use correct variable in error message (#43790) 2024-10-22 17:24:40 +02:00
Raffael Meyer
c4faa0e101 refactor: validate_return_against_account (#43778) 2024-10-22 13:44:28 +02:00
rohitwaghchaure
4fd4a37dc9 fix: added validation for UOM must be whole number (#43710) 2024-10-17 15:07:34 +05:30
Deepesh Garg
ca8820b566 chore: Allow apps to extend voucher subtypes 2024-10-07 23:32:50 +05:30
Deepesh Garg
8a1e38a43b chore: Allow apps to extend voucher subtypes 2024-10-07 22:14:10 +05:30
Deepesh Garg
a1525d9b8e chore: Allow apps to extend voucher subtypes 2024-10-07 21:43:49 +05:30
Raffael Meyer
4912288433 fix: translate display text passed to validate_expense_account (#43057) 2024-10-03 20:18:51 +00:00
Sagar Vora
7d4b73eacc Merge pull request #43475 from sagarvora/set-margin-values
fix: set margin fields for purchase documents when updating items
2024-10-02 15:20:58 +05:30
Sagar Vora
7be4d56be2 fix: set margin fields for purchase documents when updating items 2024-10-02 13:14:30 +05:30
David Arnold
6f61d88472 Merge pull request #43282 from blaggacao/feat/email-to-empty-pi
feat: allow to create empty pi via email append to
2024-09-30 14:05:56 +02:00
ruthra kumar
3fb4d8fbf1 Merge pull request #43331 from ruthra-kumar/incorrect_transaction_currency_val_in_gl_entry
fix: transaction exchange rate on GL's for Multi currency Journals
2024-09-23 17:32:00 +05:30
ruthra kumar
8cd9ad5361 fix: transaction exchange rate on GL's for Multi currency Journals 2024-09-23 17:02:00 +05:30
Abdeali Chharchhodawala
93f867570f fix: multiple issues in Payment Request (#42427)
* fix: multiple issues in Payment Request

* chore: minor changes

* fix: remove  bug

* fix: replace `round` with `flt`

* fix: update `set_advance_payment_status()` logic

* fix: removed bug of `set_advance_payment_status`

* fix: changes as per review

* refactor: replace sql query of `matched_payment_requests` to query builder

* fix: replace `locals` with `get_doc` in set_query

* fix: changes during review

* fix: minor review changes

* fix: remove unnecessary code for setting payment entry received amount

* fix: logic for ser payment_request if PE made from transaction

* fix: Use rounded total to make Payment Request from `Sales Invoice` or `Purchase Invoice`

* refactor: enhance logic of `set_open_payment_requests_to_references`

* fix: added one optional arg `created_from_payment_request`

* fix: handle multiple allocation of PR at PE's reference

* fix: logic for PR if outstanding docs fetch

* fix: formatted Link field for `Payment Request` for PE's references

* fix: replace `get_all()` with `get_list()` for getting Payment Request for Link field

* fix: replace `get_all()` with `get_list()` for getting Payment Request for Link field

* chore: format `payment_entry.js` file

* style: Show preview popup of `Payment Request`

* fix: remove minor bug

* fix: add virtual field for Payment Term and Request `outstanding_amount` in PE's reference

* fix: get outstanding amount in PE's reference on realtime

* fix: move allocation of allocated_amount to server side (no change)

* fix: some minor changes to allocation

* fix: Split `Payment Request` if PE is created from PR and there are `Payment Terms`

* fix: minor logic changes

* fix: Allocation of allocated_amount if `paid_amount` is changes

* fix: improve logic of allocation

* fix: set matched payment request if unset

* fix: minor changes

* fix: Allocate single Payment Request if PE created from PR

* fix: improve code logic

* fix: Removed duplication code

* fix: proper message title

* refactor: Rename method of Allocation Amount to References

* refactor: Changing `grand_total` description based on `party_type`

* refactor: update Payment Request

* fix: Remove virtual property of payment_term_oustanding from references

* fix: fetch party account currency for creating payment request

* fix: use transaction currency as base in payment request

* fix: party amount for creating payment entry

* fix: allow for proportional amount paid by bank

* fix: Changed field order in Payment Request

* fix: Minor refactor in Payment Entry Reference table data

* test: Added test cases for allow Payment at `Partially Paid` status for PR

* test: Update partial paid status test case

* test: Update test case for same currency PR

* refactor: Wider the `msgprint` dialog for after save PE

* test: Update PR test cases

* chore: Remove dirty lines

* test: Checking `Advance Payment Status`

* fix: formatting update

* fix: Use `flt` where doing subtraction

* test: PR test case with Payment Term for same currency

* fix: remove redundant `flt`

* test: Add test cases for PR

---------

Co-authored-by: Sagar Vora <sagar@resilient.tech>
2024-09-21 07:04:46 +05:30
David
0cab2ae644 feat: allow to create empty pi via email append to 2024-09-18 19:35:28 +02:00
ljain112
00eee16190 fix: improved the conditions for determining voucher subtypes 2024-09-18 19:38:14 +05:30
Navin-S-R
9886cf0d46 fix: delete exchange gain loss journal entry while deleting payment entry 2024-09-12 15:25:54 +05:30
ruthra kumar
d8b988dd9c Merge pull request #43095 from aerele/common_party_on_foreign_currency
fix: check multi-currency on jv for common party accounting with foreign currency
2024-09-09 10:34:47 +05:30
ruthra kumar
f9136c5d87 Merge pull request #43077 from aerele/common_party_jv
fix: cancel common party advance jv while canceling the invoice
2024-09-06 20:18:55 +05:30
venkat102
00938bfd4d fix: check multi-currency on jv for common party accounting with foreign currency 2024-09-06 19:53:40 +05:30
ruthra kumar
75cf3e245f Merge pull request #42588 from ruthra-kumar/round_off_account_for_opening
refactor: separate round off account for opening
2024-09-06 10:10:23 +05:30
venkat102
6a928b92df fix: cancel common party advance jv while canceling the invoice 2024-09-05 19:13:31 +05:30
David
0bab6f34c1 fix: distributed discounts on si 2024-09-05 11:49:24 +02:00