barredterra
af0ae930ca
fix: translatability of boldened text
2024-08-16 21:38:56 +02:00
rohitwaghchaure
f620ef20ae
fix: inter transfer delivery note issue with batch ( #42552 )
2024-07-31 14:17:22 +05:30
Ninad Parikh
723ac0ffc4
fix: Update Rate as per Valuation Rate for Internal Transfers only if Setting is Enabled ( #42050 )
...
* fix: update rate for internal transfers only if settings enabled
* fix: better naming
* fix: create field for storing incoming rate in purchase doctypes
* fix: use qty instead of qty_in_stock_uom
* fix: add description, refactor for readablility
* test: test case to validate internal transfers at arm's length price
* fix: minor fix
* fix: deletion of code not required
---------
Co-authored-by: Smit Vora <smitvora203@gmail.com >
2024-07-26 18:22:40 +05:30
rohitwaghchaure
6d42cd0f4c
fix: not able to cancel the inter transfer DN ( #42333 )
2024-07-15 16:21:07 +05:30
ljain112
db807d433b
fix: removed max discount validation for sales return
2024-07-01 16:07:38 +05:30
Rohit Waghchaure
f9e230e758
fix: zero division error
2024-04-11 17:35:06 +05:30
Deepesh Garg
4f8990602e
Merge pull request #40770 from deepeshgarg007/so_commission_update
...
fix: Recalculate sales commission on item update
2024-04-01 20:37:57 +05:30
Rohit Waghchaure
d73b1f3e6a
fix: button to select serial / batch bundle in the subcontracting receipt
2024-03-30 10:46:56 +05:30
Deepesh Garg
2a8a404c69
Merge branch 'develop' of https://github.com/frappe/erpnext into so_commission_update
2024-03-29 18:02:53 +05:30
Deepesh Garg
f76da50b7e
fix: Recalculate sales commission on item update
2024-03-29 17:57:58 +05:30
Akhil Narang
3effaf21ef
refactor(treewide): formatting and ruff fixes, + manually enabled F401
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev >
2024-03-27 16:06:04 +05:30
rohitwaghchaure
59222813af
fix: serial and batch for internal transfer ( #40467 )
...
* fix: serial and batch for internal transfer
* chore: fix test cases
2024-03-15 17:55:41 +05:30
rohitwaghchaure
bc9c480246
fix: use serial batch fields for packed items ( #40140 )
2024-02-26 23:57:52 +05:30
Gursheen Anand
5a3b133d65
fix: skip max discount validation for rate adjustment
2024-02-22 16:09:29 +05:30
Rohit Waghchaure
951023f434
perf: timeout for auto material request through reorder level
2024-01-31 17:27:32 +05:30
Nabin Hait
ec07b42ea2
Merge pull request #38530 from bosue/duplicate_zero_quantity_check2
...
refactor: Consolidate duplicate zero-quantity Items checks for transactions.
2024-01-09 13:12:25 +05:30
s-aga-r
e1b0fffd0c
fix: don't set rate for non-stock item in Internal Transfer
2024-01-04 11:43:02 +05:30
mergify[bot]
07175367d8
fix: reposting not fixing valuation rate for sales return using movin… (backport #38895 ) ( #38897 )
...
* fix: reposting not fixing valuation rate for sales return using movin… (#38895 )
fix: reposting not fixing valuation rate for sales return using moving average method
(cherry picked from commit 3a668bbe96 )
# Conflicts:
# erpnext/stock/stock_ledger.py
* chore: fix conflicts
---------
Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com >
2023-12-21 14:40:52 +05:30
mergify[bot]
4057682c87
fix: incoming rate for sales return with Moving Average valuation method (backport #38849 ) ( #38863 )
...
* fix: incoming rate for sales return with Moving Average valuation method (#38849 )
(cherry picked from commit 7fdac62393 )
# Conflicts:
# erpnext/stock/doctype/delivery_note/test_delivery_note.py
* chore: fix conflicts
---------
Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com >
2023-12-19 18:29:56 +05:30
rohitwaghchaure
0743289925
fix: serial and batch bundle return not working ( #38754 )
...
* fix: serial and batch bundle return not working
* test: added test case for delivery note return against denormalized serial no
2023-12-17 12:42:07 +05:30
Bernd Oliver Sünderhauf
4918aeb4c6
refactor: Consolidate duplicate zero-quantity transaction Items checks.
2023-12-03 19:57:32 +01:00
Bernd Oliver Sünderhauf
b2d8a44199
test: Add, expand and refine test-cases for zero-quantity transactions.
2023-12-03 16:33:29 +01:00
rohitwaghchaure
5e9016ffab
fix: validation error has not throw for the batch ( #38494 )
...
* fix: validation error has not throw for the batch
* chore: fix test cases
2023-12-01 21:42:22 +05:30
Gursheen Anand
1657337887
chore: linting issues
2023-11-22 16:45:14 +05:30
Gursheen Anand
3543f86c63
fix: has_product_bundle util to only check for enabled bundles
2023-11-22 16:04:05 +05:30
Ankush Menat
f4d74990fe
fix: E-commerce permissions
2023-10-17 22:28:04 +05:30
Ankush Menat
7b9cedebf6
fix: Ignore addr permission in internal code
2023-10-17 19:00:52 +05:30
mergify[bot]
d2aa4d5d6b
fix: validation message for valuation rate (backport #37301 ) ( #37351 )
...
fix: validation message for valuation rate (#37301 )
(cherry picked from commit 643bb0511c )
Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com >
2023-10-05 18:13:23 +05:30
rohitwaghchaure
dd4769ecf1
feat: allow to edit Stock Quantity in the Sales and Purchase Transactions ( #36600 )
...
feat: allow to edit Stock Quantity in the Sales and Purchase transactions
2023-09-20 18:09:03 +05:30
mergify[bot]
35f72a17db
Allow to make return against sales invoice which has closed sales order. ( #36676 )
...
fix: Allow to make return against sales invoice which has closed sales order
fix: Allow to make return against sales invoice which has closed sales order
(cherry picked from commit 0f98cc85e9 )
Co-authored-by: Gourav Saini <63018500+gouravsaini021@users.noreply.github.com >
2023-08-26 19:29:33 +05:30
Nabin Hait
5a0aacc0b6
fix: get party details
2023-06-06 15:39:22 +05:30
Rohit Waghchaure
d3ceb07936
fix: travis
2023-06-02 17:14:17 +05:30
Rohit Waghchaure
86da306cca
feat: added negative inventory validation and restrict to make backdated entry for serial nos
2023-06-02 17:14:15 +05:30
Rohit Waghchaure
674bd3e2e5
feat: serial and batch bundle for Packing Items
2023-06-02 17:14:15 +05:30
Rohit Waghchaure
e6143abb8a
refactor: added new file serial batch bundle
2023-06-02 17:14:14 +05:30
Rohit Waghchaure
6c9b212dd1
fix: removed sales and purchase fields from serial nos
2023-06-02 17:14:14 +05:30
Indrajith.vs
0c8276ec82
fix: sales person allocated amount calculation error nonetype and float ( #35293 )
...
fix: sales person allocated amount calculation error nontype and float
2023-05-14 11:47:46 +05:30
Deepesh Garg
9a8f8e8b7d
Revert "fix: Default sales team not getting set" ( #34376 )
...
Revert "fix: Default sales team not getting set (#34284 )"
This reverts commit 7d0199d743 .
2023-03-09 15:36:52 +05:30
Deepesh Garg
10632d75b0
fix: Do not calculate commission post submit ( #34267 )
...
* fix: Do not calculate commision post submit
* chore: Update condition to match server side logic
Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com >
---------
Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com >
2023-03-07 11:44:09 +05:30
Deepesh Garg
7d0199d743
fix: Default sales team not getting set ( #34284 )
2023-03-07 11:41:26 +05:30
Rohit Waghchaure
02566a02a8
fix: incorrect actual qty for the packed item
2023-01-20 22:38:56 +05:30
s-aga-r
c716dcc01e
fix: consider child nodes while getting bin details
2022-12-29 14:01:42 +05:30
Ankush Menat
915e0347b0
chore!: remove activity log feeds ( #33294 )
...
- This contains little to no information and practically no one uses this.
- Also causes a lot of problem by adding way too many feeds in activity
log to the point where activity page doesn't even load.
2022-12-12 15:14:30 +05:30
Deepesh Garg
ef9d126254
fix: Allow item rate udpates for non-stock invoices
2022-12-05 10:17:19 +05:30
Deepesh Garg
8287fb5104
Merge pull request #33143 from deepeshgarg007/auto_repeat_dates
...
fix: Auto repeat date validations
2022-11-29 09:28:19 +05:30
Deepesh Garg
fa15221455
fix: Auto repeat date validations
2022-11-28 19:22:35 +05:30
Deepesh Garg
104fdcb9f9
fix: Dispatch address display
2022-11-24 16:41:40 +05:30
Deepesh Garg
083309c056
fix: Incoming rate precision fixes for intra company transfer
2022-09-19 15:06:06 +05:30
Rohit Waghchaure
237299948a
fix: fetch from parent not working for custom field
2022-09-03 17:27:00 +05:30
mergify[bot]
89f516c32b
fix: assign duplicate_items_msg outside conditional (backport #31639 ) ( #31650 )
...
fix: assign duplicate_items_msg outside conditional (#31639 )
duplicate_items_msg was defined inside if the statement of stock_item so when duplicate was found in non_stock_item it raised referenced before assignment
(cherry picked from commit 8e23c6ad69 )
Co-authored-by: Maharshi Patel <39730881+maharshivpatel@users.noreply.github.com >
2022-07-21 13:57:03 +05:30