venkat102
9bd3d7a020
fix: cancel common party advance jv while canceling the invoice
...
(cherry picked from commit 6a928b92df )
2024-09-06 14:50:07 +00:00
mergify[bot]
56dad7d365
fix: disabled batches showing in the list (backport #43024 ) ( #43069 )
...
fix: disabled batches showing in the list (#43024 )
(cherry picked from commit c13a147df1 )
Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com >
2024-09-05 16:00:33 +05:30
Khushi Rawat
1121c6663f
fix: link Purchase Invoice and Receipt Items to Asset
2024-09-05 14:31:05 +05:30
ljain112
caa6ca1d0b
fix: update dimesions in exchange_gain_loss jv based on base document
...
(cherry picked from commit 96df19149d )
2024-08-26 12:01:28 +00:00
mergify[bot]
2203ea9301
fix: last purchase rate not updated from purchase invoice (backport #42847 ) ( #42853 )
...
fix: last purchase rate not updated from purchase invoice (#42847 )
(cherry picked from commit 5b9309cf34 )
Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com >
2024-08-21 15:20:50 +05:30
barredterra
dbd466b6b2
chore: resolve conflicts
2024-08-17 02:24:58 +02:00
barredterra
4914481105
fix: translatability of boldened text
...
(cherry picked from commit af0ae930ca )
# Conflicts:
# erpnext/controllers/accounts_controller.py
2024-08-17 00:21:05 +00:00
Smit Vora
91a5c562d8
Merge pull request #42489 from frappe/mergify/bp/version-15-hotfix/pr-42050
...
fix: Update Rate as per Valuation Rate for Internal Transfers only if Setting is Enabled (backport #42050 )
2024-08-13 11:25:09 +05:30
ljain112
fd4143e686
fix: dimensions in common party journal entry
...
(cherry picked from commit ac629ede79 )
2024-08-07 10:34:09 +00:00
mergify[bot]
9321408154
fix: Discount and taxes in return document should follow the reference document (backport #41911 ) ( #42574 )
...
fix: Discount and taxes in return document should follow the reference document (#41911 )
* fix: Discount and taxes in return document should follow the reference document
* fix: Ignore Pricing rule on debit/credit note if created against PI/SI with test cases
* fix: linter issue
(cherry picked from commit 281198456d )
Co-authored-by: Nabin Hait <nabinhait@gmail.com >
2024-08-01 15:45:18 +05:30
mergify[bot]
97cc3082e1
fix: inter transfer delivery note issue with batch (backport #42552 ) ( #42556 )
...
fix: inter transfer delivery note issue with batch (#42552 )
(cherry picked from commit f620ef20ae )
Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com >
2024-08-01 13:22:33 +05:30
mergify[bot]
b7d70ac928
fix: purchase return from rejected warehouse (backport #42531 ) ( #42535 )
...
fix: purchase return from rejected warehouse (#42531 )
(cherry picked from commit c5d68333c9 )
Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com >
2024-07-30 14:53:42 +05:30
Ninad Parikh
6e833cce6a
fix: Update Rate as per Valuation Rate for Internal Transfers only if Setting is Enabled ( #42050 )
...
* fix: update rate for internal transfers only if settings enabled
* fix: better naming
* fix: create field for storing incoming rate in purchase doctypes
* fix: use qty instead of qty_in_stock_uom
* fix: add description, refactor for readablility
* test: test case to validate internal transfers at arm's length price
* fix: minor fix
* fix: deletion of code not required
---------
Co-authored-by: Smit Vora <smitvora203@gmail.com >
(cherry picked from commit 723ac0ffc4 )
2024-07-26 12:58:12 +00:00
ruthra kumar
949d7f4b53
refactor: repost without checking on flag
...
(cherry picked from commit 09f429ffba )
2024-07-24 07:29:11 +00:00
mergify[bot]
5f1d6ede31
feat: create variant with/without image (backport #41317 ) ( #42343 )
...
feat: create variant with/without image (#41317 )
* feat: create variant with/without image
* feat: create variant with/without image
* feat: create variant with/without image
* feat: create variant with/without image
* feat: create variant with/without image
* feat: create variant with/without image
* fix: change the variable name use_same_image to use_template_image
(cherry picked from commit 66b35ec9fb )
Co-authored-by: Nihantra C. Patel <141945075+Nihantra-Patel@users.noreply.github.com >
2024-07-15 22:58:30 +05:30
mergify[bot]
cf2651dd85
fix: not able to cancel the inter transfer DN (backport #42333 ) ( #42340 )
...
fix: not able to cancel the inter transfer DN (#42333 )
(cherry picked from commit 6d42cd0f4c )
Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com >
2024-07-15 16:52:28 +05:30
mergify[bot]
076bf17439
fix: incoming rate zero for supplied items in returned SCR (backport #42314 ) ( #42315 )
...
fix: incoming rate zero for supplied items in returned SCR (#42314 )
(cherry picked from commit 61daa318fe )
Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com >
2024-07-15 13:28:06 +05:30
ljain112
ab987e9a86
fix: removed max discount validation for sales return
...
(cherry picked from commit db807d433b )
2024-07-10 07:02:02 +00:00
mergify[bot]
e1b50efeea
fix: corrected mismatch in the Purchase Receipt Status #15620 (backport #42138 ) ( #42252 )
...
* fix: corrected mismatch in the Purchase Receipt Status #15620 (#42138 )
(cherry picked from commit 623b4c21cd )
# Conflicts:
# erpnext/stock/doctype/purchase_receipt/test_purchase_receipt.py
* chore: fix conflicts
---------
Co-authored-by: Poorvi-R-Bhat <poorvi.r.bhat@gmail.com >
Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com >
2024-07-09 16:17:35 +05:30
mergify[bot]
7916d6436f
fix: auto serial and batch bundle not creating for Asset Capitalization (backport #42231 ) ( #42242 )
...
fix: auto serial and batch bundle not creating for Asset Capitalization (#42231 )
(cherry picked from commit 5f53ad3117 )
Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com >
2024-07-09 12:13:19 +05:30
mergify[bot]
d396c18689
perf: Performance optmization for Purchase Invoice submission (backport #40263 ) ( #41946 )
...
* perf: Optimization for providional gl entries
(cherry picked from commit d7b738ff61 )
# Conflicts:
# erpnext/accounts/doctype/purchase_invoice/purchase_invoice.py
* perf: Performance optimization for validating budget
(cherry picked from commit f204d810bb )
# Conflicts:
# erpnext/accounts/doctype/budget/budget.py
* perf: Cached accounting dimensions details
(cherry picked from commit 8cd8b8f885 )
* perf: Optimzed code for merging similar gl entries
(cherry picked from commit aa75a60142 )
* fix: linter issues
(cherry picked from commit acc0b2faf8 )
* perf: Cache accounting dimension filter map
(cherry picked from commit e4bd173875 )
# Conflicts:
# erpnext/accounts/doctype/accounting_dimension_filter/accounting_dimension_filter.py
* fix: minor fixes
(cherry picked from commit 5cd9bf3bda )
* perf: skip unnecessary validation while transaction cancellation
(cherry picked from commit 05385e4acb )
* perf: refactored handling provisional gl entries for non-stock items
(cherry picked from commit 49c74369a5 )
# Conflicts:
# erpnext/accounts/doctype/purchase_invoice/purchase_invoice.py
* perf: validate expense against budget only if budget exists
(cherry picked from commit c15b2d5490 )
* perf: Get bin details only for stock items
(cherry picked from commit 6ff9e6ee84 )
# Conflicts:
# erpnext/stock/get_item_details.py
* fix: added index for price_list column in Item Price
(cherry picked from commit d279e23623 )
# Conflicts:
# erpnext/stock/doctype/item_price/item_price.json
* perf: Caching in checking allowance for qty and amount
(cherry picked from commit 8d682fa884 )
* perf: Caching in gl entry
(cherry picked from commit b07769d8d7 )
# Conflicts:
# erpnext/accounts/doctype/gl_entry/gl_entry.py
* chore: resolve conflicts
* chore: resolve conflict in purchase_invoice.py
---------
Co-authored-by: Nabin Hait <nabinhait@gmail.com >
Co-authored-by: ruthra kumar <ruthra@erpnext.com >
2024-06-27 17:32:43 +05:30
mergify[bot]
8a91bf3154
fix: not able to make purchase return (backport #42053 ) ( #42055 )
...
fix: not able to make purchase return (#42053 )
(cherry picked from commit 9738c04ef0 )
Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com >
2024-06-27 16:31:06 +05:30
mergify[bot]
c27f272f06
perf: code optimization to handle large asset creation (backport #42018 ) ( #42025 )
...
perf: code optimization to handle large asset creation (#42018 )
(cherry picked from commit 5738d93f95 )
Co-authored-by: Khushi Rawat <142375893+khushi8112@users.noreply.github.com >
2024-06-26 16:51:07 +05:30
ruthra kumar
6dbe820416
refactor(test): enfore use of customer/supplier master
...
While using advance accounts in foreign currency, always use
Customer/Supplier master to maintain them
(cherry picked from commit 64e63887be )
2024-06-22 23:58:11 +00:00
ruthra kumar
88e1c28e7d
test: advance against purchase invoice
...
(cherry picked from commit 90c84822d0 )
2024-06-22 23:58:09 +00:00
ruthra kumar
259d7cde39
test: exc gain/loss booking on advances under asset/liability
...
(cherry picked from commit 827d67d02f )
2024-06-22 23:58:09 +00:00
ruthra kumar
6ebd4ba2cc
refactor(test): simpler create_account helper method
...
(cherry picked from commit 475e0ddeee )
2024-06-22 23:58:09 +00:00
ruthra kumar
47071cec5d
refactor: for advances uses the party account in references table
...
(cherry picked from commit 7dce6e03c7 )
2024-06-22 23:58:09 +00:00
Sagar Vora
b59c91a341
perf: dont run queries unnecessarily, improved filters ( #41993 )
...
* perf: dont run queries unnecessarily, improved filters
* perf: dont run query if `in` filter is empty
(cherry picked from commit ac6d85aed6 )
2024-06-22 15:58:00 +00:00
ruthra kumar
e3539ac2de
Merge pull request #41913 from frappe/mergify/bp/version-15-hotfix/pr-40187
...
fix: valuation tax entries on LCV after billing PR (backport #40187 )
2024-06-17 13:53:17 +05:30
Rohit Waghchaure
b64b4330a3
fix: incorrect batch return from sales return
...
(cherry picked from commit 317047c808 )
2024-06-17 05:47:25 +00:00
Gursheen Anand
c7c9d33954
test: LCV entries after billing
...
(cherry picked from commit 53642e7417 )
# Conflicts:
# erpnext/stock/doctype/purchase_receipt/test_purchase_receipt.py
2024-06-15 15:12:22 +00:00
Gursheen Anand
83ccb32be6
fix: add LCV flag to determine negative expenses
...
(cherry picked from commit baa3fee1bf )
# Conflicts:
# erpnext/stock/doctype/landed_cost_voucher/landed_cost_voucher.py
2024-06-15 15:12:21 +00:00
ljain112
5ea2cdcaad
fix: regional overide for updating item valution
...
(cherry picked from commit 1a10f0bcbd )
2024-06-13 08:09:51 +00:00
Rohit Waghchaure
6c57971abc
fix: return from accepted and rejected warehouse at a same time not working
...
(cherry picked from commit 17731f09ef )
2024-06-12 10:17:33 +00:00
Rohit Waghchaure
67d1709ef8
fix: batch qty in the dropdown field
...
(cherry picked from commit eb426c69fe )
2024-06-12 07:32:03 +00:00
mergify[bot]
3e4c568ddc
fix: valuation rate for serial and batch bundle for current bundle (backport #41850 ) ( #41860 )
...
fix: valuation rate for serial and batch bundle for current bundle (#41850 )
(cherry picked from commit 7249a691b3 )
Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com >
2024-06-11 18:29:54 +05:30
mergify[bot]
24775db97e
fix: batch selection issue (backport #41692 ) ( #41693 )
...
fix: batch selection issue (#41692 )
(cherry picked from commit 968120d0eb )
Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com >
2024-05-30 18:49:12 +05:30
mergify[bot]
dc0bb220ed
fix: multiple issues related to serial and batch bundle (backport #41662 ) ( #41668 )
...
* fix: multiple issues related to serial and batch bundle (#41662 )
(cherry picked from commit ce834f5dba )
# Conflicts:
# erpnext/stock/doctype/purchase_receipt_item/purchase_receipt_item.json
# erpnext/subcontracting/doctype/subcontracting_receipt/subcontracting_receipt.json
* chore: fix conflicts
* chore: fix conflicts
---------
Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com >
2024-05-28 21:57:13 +05:30
mergify[bot]
17ea958170
fix: SCR batch qty issue (backport #41595 ) ( #41599 )
...
fix: SCR batch qty issue (#41595 )
(cherry picked from commit 418439b58f )
Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com >
2024-05-23 16:30:30 +05:30
mergify[bot]
0a36139ef4
fix: convert invoice_portion value from str to float (backport #41485 ) ( #41555 )
...
fix: convert invoice_portion value from str to float (#41485 )
(cherry picked from commit a1d489195d )
Co-authored-by: Nabin Hait <nabinhait@gmail.com >
2024-05-20 18:36:48 +05:30
mergify[bot]
a070ad786d
fix: not able to submit landed cost voucher (backport #41481 ) ( #41486 )
...
fix: not able to submit landed cost voucher (#41481 )
(cherry picked from commit 81a9521f04 )
Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com >
2024-05-15 18:05:39 +05:30
“Khushi
9b3f309598
refactor: renamed purchase receipt amount field to purchase amount
...
(cherry picked from commit 31841b4ab2 )
# Conflicts:
# erpnext/assets/doctype/asset/asset.json
# erpnext/assets/doctype/asset/asset.py
# erpnext/patches.txt
2024-05-14 12:47:53 +00:00
Nihantra C. Patel
5c1043fe88
fix: correct ordered qty on SO when removing PO item - v15 ( #41342 )
2024-05-06 21:36:27 +05:30
Nikhil Kothari
ee9822fd42
fix: party and party type label on accounting preview
...
(cherry picked from commit f7f3b22786 )
2024-04-29 13:24:48 +00:00
Rohit Waghchaure
4555f8a9a6
feat: allow to do reposting for all transactions (audit)
...
(cherry picked from commit aefbe21b46 )
# Conflicts:
# erpnext/stock/doctype/stock_reposting_settings/stock_reposting_settings.json
2024-04-26 08:15:11 +00:00
mergify[bot]
93242ca883
fix: validate uom is integer for PR item (backport #41074 ) ( #41077 )
...
fix: validate uom is integer for PR item
(cherry picked from commit 9a290fdfc9 )
Co-authored-by: s-aga-r <sagarsharma.s312@gmail.com >
2024-04-18 07:53:20 +05:30
mergify[bot]
1ae447e4fc
fix: do not add qty to supplied items (backport #41061 ) ( #41066 )
...
fix: do not add qty to supplied items
(cherry picked from commit 8233c392fb )
Co-authored-by: s-aga-r <sagarsharma.s312@gmail.com >
2024-04-17 17:30:43 +05:30
ruthra kumar
59950290a2
test: exc gain/loss journals booking in Payable accounts
...
(cherry picked from commit 8821c98625 )
2024-04-16 05:29:53 +00:00
ruthra kumar
361d7f1ba5
fix: incorrect exc gain/loss for PE against JE for payable accounts
...
(cherry picked from commit 81b574053f )
2024-04-16 05:29:52 +00:00