Rohit Waghchaure
f976115a2b
fix: validation to prevent submission if the SABB is not linked to a stock transaction
2025-01-31 14:04:27 +05:30
rohitwaghchaure
968e235a3f
Merge pull request #45486 from rohitwaghchaure/fixed-SABB-performance-issue
...
perf: stock entry with batch
2025-01-29 20:49:09 +05:30
ruthra kumar
9ae8e94e6c
Merge pull request #45585 from ruthra-kumar/auto_add_taxes
...
refactor: auto add taxes from template
2025-01-29 15:28:12 +05:30
ruthra kumar
d1086722bf
refactor: auto add taxes from template
2025-01-29 14:38:50 +05:30
Rohit Waghchaure
0b1b964b77
perf: stock entry with batch
2025-01-28 09:49:37 +05:30
Dany Robert
3078578692
fix: return qty error due to precision
2025-01-27 09:54:06 +00:00
ruthra kumar
49570a5544
Merge pull request #45302 from aerele/validate-dimensions-company
...
feat: add company level validation for accounting dimension
2025-01-27 14:53:49 +05:30
ruthra kumar
e55d4030ec
Merge pull request #45284 from aerele/pos-return-currency
...
fix: set party_account_currency for pos_invoice returns
2025-01-27 14:27:41 +05:30
Sanket Shah
d862e9b771
fix: validate items against selling settings ( #45288 )
...
fix: validate_for_duplicate_items
Co-authored-by: Sanket322 <shahsanket322003.com>
2025-01-24 15:10:43 +05:30
Diptanil Saha
54d234e05d
fix: resolved pos return setting to default mode of payment instead of user selection ( #45377 )
...
* fix: resolved pos return setting to default mode of payment instead of user selection
* refactor: removed console log statement
* refactor: moved get_payment_data to sales_and_purchase_return.py
2025-01-24 12:41:01 +05:30
ruthra kumar
766b5fa5ed
Merge pull request #44790 from ruthra-kumar/configurable_posting_date_for_exc_gain_loss
...
refactor: configurable posting date for Exc Gain / Loss journal
2025-01-23 16:28:21 +05:30
ruthra kumar
2f3281579a
test: exc gain/loss posting date based on configuration
2025-01-23 14:44:40 +05:30
ruthra kumar
b2c3da135e
refactor: only apply configuration on normal payments
...
patch to update default value
2025-01-23 14:12:24 +05:30
Sanket Shah
2a400dd3f8
perf: optimize DB calls with frappe.get_all ( #45289 )
...
* perf: reduce multiple db queries
* fix: use frappe._dict instread of extra iteration
---------
Co-authored-by: Sanket322 <shahsanket322003.com>
2025-01-23 11:29:41 +05:30
Diógenes Souza
b26f0b6633
fix: System was allowing to save payment schedule amount less than grand total ( #45322 )
...
* fix: System was allowing to save payment schedule amount less than grand_total
* style: After run pre-commit
2025-01-22 17:52:26 +05:30
Sugesh393
36bae55299
chore: update variable names for improved readability
2025-01-21 17:38:24 +05:30
ruthra kumar
d73c17aa98
Merge pull request #45242 from aerele/pos-invoice-item
...
fix: include pos invoice in modifing key for returned item validation
2025-01-21 16:34:59 +05:30
Nabin Hait
ec487c14d9
fix: Ambiguous column error while creating Sales Return ( #45275 )
2025-01-17 16:51:07 +05:30
Lakshit Jain
ada272a29b
fix: round off tax withholding amount ( #45271 )
2025-01-17 16:50:15 +05:30
rohitwaghchaure
9163f60191
fix: sales return for multi-uom ( #45303 )
2025-01-17 16:35:59 +05:30
Sugesh393
c94091d68f
test: add new unit test for company validation in accounting dimension
2025-01-17 11:45:51 +05:30
Sugesh393
60efd3e219
feat: add company level validation for accounting dimension
2025-01-17 11:41:52 +05:30
Sugesh393
2af6fca7fa
fix: set party_account_currency for pos_invoice returns
2025-01-15 18:20:20 +05:30
rohitwaghchaure
9bb7d4e428
Merge pull request #45241 from rohitwaghchaure/fixed-support-28979
...
fix: auto fetch batch and serial no for draft stock transactions
2025-01-14 12:35:17 +05:30
Rohit Waghchaure
88ab9be79c
fix: auto fetch batch and serial no for draft stock transactions
2025-01-13 17:17:03 +05:30
venkat102
2936139c79
fix: include pos invoice in modifing key for returned item validation
2025-01-13 16:51:25 +05:30
rohitwaghchaure
1f1c01d88e
Merge pull request #44988 from frappe/35225
...
feat: Validate sub assembly and material request items in Production …
2025-01-09 16:28:29 +05:30
Ejaaz Khan
81d8f257aa
refactor: validate due date code and message according to doctype ( #45126 )
...
* refactor: change message of date comparision and refactor code
* refactor: commonify function call for sales and purchase invoice
* refactor: remove redundant mandatory error validation
2025-01-08 12:49:02 +05:30
Rohit Waghchaure
729ce1dc50
fix: issue in returning components against the SCO
2025-01-07 18:11:56 +05:30
Mihir Kandoi
87f1f6e15c
fix: Attempt to fix status updater 1
2025-01-06 19:47:44 +05:30
ruthra kumar
e609a6a038
Merge pull request #45040 from ruthra-kumar/use_idx_for_identifying
...
refactor: use `idx` for identifying row
2025-01-02 12:16:40 +05:30
ruthra kumar
51354c894a
refactor: use idx for identifying row
2025-01-02 11:54:55 +05:30
rohitwaghchaure
5e977cf5a7
Merge pull request #44999 from frappe/fix_multiple_sco_pr
...
fix: Added patch and fallback code to prevent future issues similar …
2025-01-01 16:35:41 +05:30
Mihir Kandoi
575fb43f9c
fix: Fixed logic in if condition causing tests to fail
2024-12-31 20:33:05 +05:30
ruthra kumar
ebc0ed8a31
Merge pull request #44884 from ljain112/fix-item-tax-template
...
fix: update item_tax_rate in backend
2024-12-31 15:50:39 +05:30
Mihir Kandoi
65dc3505c4
fix: Added patch and fallback code to prevent future issues similiar to helpdesk ticket 28246
2024-12-31 12:53:30 +05:30
Khushi Rawat
079ec864de
fix: copy accounting dimensions to asset and sales invoice ( #44964 )
...
* fix: copy accounting dimensions to asset and sales invoice
* fix: replace sql query with query builder
* refactor: reuse function for accounting dimensions
* fix: loop handling
* fix: use explicit param
2024-12-31 07:05:51 +00:00
Mihir Kandoi
22d38c2af4
feat: Validate sub assembly and material request items in Production Plan and fix Production Plan summary reports not showing correct received quantity from subcontracted POs
2024-12-30 20:12:14 +05:30
ruthra kumar
7926bf066a
Merge pull request #44975 from aerele/filter-project
...
fix: add company filter to project
2024-12-30 15:27:37 +05:30
venkat102
b92f8bc514
fix: include company in filter condition
2024-12-30 14:18:55 +05:30
ruthra kumar
bcae2810b9
Merge pull request #44892 from Sanket322/payment_schedule_in_is_paid
...
fix: clear payment schedule in purchase invoice for is_paid
2024-12-27 13:23:07 +05:30
ruthra kumar
0589fa7f3e
refactor: early return is always better
...
validate_advance_entries() has a heavy IO bound operation. Early
return on unwanted cases is always better.
2024-12-27 12:48:25 +05:30
rohitwaghchaure
1319ce4bc1
fix: material request status ( #44917 )
2024-12-26 15:58:39 +05:30
Sanket322
e1fc239f3d
fix: clear payment schedule in purchase invoice for is_paid
2024-12-24 16:38:51 +05:30
ljain112
de54c0b41f
fix: update item_tax_rate in backend
2024-12-24 15:15:30 +05:30
rohitwaghchaure
021d077808
fix: set project in GL from the SLE ( #44879 )
2024-12-24 14:49:41 +05:30
Diptanil Saha
948556def5
Merge pull request #44856 from diptanilsaha/fix-pos-invoice-advanced-received
...
fix: fetch advance payment entries on pos invoice
2024-12-23 20:59:00 +05:30
rohitwaghchaure
c9b143b509
fix: stock entry not fetching expired batches ( #44863 )
2024-12-23 20:28:06 +05:30
Diptanil Saha
a7078e5702
fix: fetch advance payment entries on pos invoice
2024-12-23 15:54:16 +05:30
rohitwaghchaure
a2c2b8b5ad
fix: do not validate qc for scrap item ( #44844 )
2024-12-23 15:39:04 +05:30
