Akhil Narang
4d34b1ead7
refactor(treewide): formatting and ruff fixes, + manually enabled F401
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev >
2024-04-10 17:13:31 +05:30
Nabin Hait
11bddc14bb
fix: Delete linked asset movement record on cancellation of purchase receipt/invoice
2024-02-20 12:23:16 +05:30
mergify[bot]
d0b9c568d3
fix: landed cost voucher not submitting because of incorrect reference (backport #39898 ) ( #39899 )
...
fix: landed cost voucher not submitting because of incorrect reference (#39898 )
(cherry picked from commit 6239fd704b )
Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com >
2024-02-14 15:57:48 +05:30
Nabin Hait
41e384326e
fix: Set asset purchase amount based on qty and valuation_rate
...
(cherry picked from commit 135e19d0aa )
2024-01-10 06:03:03 +00:00
rohitwaghchaure
23042dfc3c
fix: not able to make inter-company po from so ( #38826 )
2023-12-18 17:44:17 +05:30
Anand Baburajan
3daf6f822a
fix: set default asset quantity as 1 [v14] ( #38224 )
...
fix: set default asset quantity as 1
2023-11-20 22:27:25 +05:30
s-aga-r
9a34518e54
fix: incorrect incoming rate for serial and batch items in standalone debit note ( #38121 )
2023-11-18 18:48:25 +05:30
mergify[bot]
8446e87cc2
chore: delete comments and unlink attachments on company transactions deletion (backport #38077 ) ( #38078 )
...
* chore: delete comments and unlink attachments on company transactions deletion
(cherry picked from commit 2f9e96e324 )
* fix: unrelated transation date typo
(cherry picked from commit b097bb20d9 )
---------
Co-authored-by: anandbaburajan <anandbaburajan@gmail.com >
2023-11-13 19:20:52 +05:30
mergify[bot]
64658fc790
fix: don't reset rate if greater than zero in standalone debit note (backport #37935 ) ( #37940 )
...
* fix: don't reset rate if greater than zero in standalone debit note
(cherry picked from commit 5cce522ecd )
* fix(test): `test_gl_entries_for_standalone_debit_note`
(cherry picked from commit f9fc6c9c9d )
---------
Co-authored-by: s-aga-r <sagarsharma.s312@gmail.com >
2023-11-06 19:27:28 +05:30
mergify[bot]
1a3dae0f9a
fix: permission error while creating Supplier Quotation from Portal (backport #37864 ) ( #37870 )
...
* fix: permission error while creating Supplier Quotation from Portal
(cherry picked from commit e019d43d0b )
# Conflicts:
# erpnext/controllers/buying_controller.py
* chore: `conflicts`
---------
Co-authored-by: s-aga-r <sagarsharma.s312@gmail.com >
2023-11-03 16:24:36 +05:30
s-aga-r
26ad688584
fix: negative valuation rate in PR return ( #37424 )
...
* fix: negative valuation rate in PR return
* test: add test case for PR return
2023-10-11 18:44:32 +05:30
ruthra kumar
b33db6c79a
fix: asset validation misfire on debit notes
...
(cherry picked from commit 097b9892dc )
2023-09-15 14:32:41 +00:00
rohitwaghchaure
c1819a4b21
fix: serial no not able to reject for the internal transfer ( #36467 )
2023-08-03 12:19:25 +05:30
Rohit Waghchaure
5d77e3ce05
fix: accepted warehouse and rejected warehouse can't be same
...
(cherry picked from commit d618aaef32 )
# Conflicts:
# erpnext/accounts/doctype/purchase_invoice/purchase_invoice.json
# erpnext/stock/doctype/purchase_receipt/purchase_receipt.json
# erpnext/subcontracting/doctype/subcontracting_receipt/subcontracting_receipt.json
# erpnext/subcontracting/doctype/subcontracting_receipt_item/subcontracting_receipt_item.json
2023-07-10 08:26:13 +00:00
saeedkola
4a7d75b5cc
fix: Set Asset cost center default as PR or PI Item Cost Center while auto creating ( #35844 )
...
* fix: Set Asset cost center default as PR or PI Item Cost Center while auto creating
* chore: Linting Issues
---------
Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com >
2023-06-24 19:58:31 +05:30
rohitwaghchaure
7339e447bb
Merge pull request #35718 from frappe/mergify/bp/version-14-hotfix/pr-35711
...
fix: incorrect gl entries for standalone debit note (backport #35711 )
2023-06-16 13:46:16 +05:30
Sagar Sharma
3f62e854e5
fix: consider field precision while setting sle actual_qty ( #35717 )
2023-06-15 19:26:38 +05:30
rohitwaghchaure
697fcef98b
fix: conflicts
2023-06-15 19:14:41 +05:30
Rohit Waghchaure
e2c4e16d72
test: added test case
...
(cherry picked from commit f9f662679f )
2023-06-15 13:43:20 +00:00
Rohit Waghchaure
3355dc2a41
fix: incorrect gl entries for standalone debit note with update stock
...
(cherry picked from commit 6e198188ff )
# Conflicts:
# erpnext/controllers/buying_controller.py
2023-06-15 13:43:20 +00:00
mergify[bot]
33e8d05718
fix: Billing Address display in buying transactions ( #35451 )
...
fix: Billing Address display in buying transactions (#35451 )
(cherry picked from commit bb21c044f6 )
Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com >
2023-05-31 11:03:49 +05:30
Rohit Waghchaure
5e9f1dfbb3
fix: labels name
...
(cherry picked from commit a8445da02a )
2023-02-28 12:05:58 +00:00
Rohit Waghchaure
db033c6862
feat: adjust purchase receipt valuation rate as per purchase invoice rate
...
(cherry picked from commit eab775ef32 )
2023-02-28 12:05:56 +00:00
anandbaburajan
68df9ad83c
chore: use continue, not break
...
(cherry picked from commit 3380dc5dea )
2023-02-05 10:37:40 +00:00
anandbaburajan
c98b2b5918
fix: allow PI cancel if linked asset is cancelled
...
(cherry picked from commit b961321de5 )
2023-02-05 10:37:40 +00:00
mergify[bot]
d2e3701b1a
fix: Timeout error while saving the purchase invoice ( #33577 )
...
* fix: timeout error in the Purchase Invoice
(cherry picked from commit 7249657d15 )
* feat: provision to disable get last purchase rate
fix: set_incoming_rate condition
(cherry picked from commit d1d4671320 )
* fix: linters issue
(cherry picked from commit 05df8579cd )
* test: test case to check disable last purchase rate
(cherry picked from commit ec171fc7c1 )
Co-authored-by: Rohit Waghchaure <rohitw1991@gmail.com >
2023-01-10 09:02:15 +05:30
Deepesh Garg
030765618b
fix: Allow item rate udpates for non-stock invoices
...
(cherry picked from commit ef9d126254 )
2022-12-06 03:43:16 +00:00
Deepesh Garg
2aada1a0d9
fix: Auto repeat date validations
...
(cherry picked from commit fa15221455 )
2022-11-29 03:59:09 +00:00
ruthra kumar
7554ac9569
fix: get amount in words for debit note
...
(cherry picked from commit 70f6484d9d )
2022-09-20 12:44:03 +00:00
Rohit Waghchaure
f370c7b50b
fix: consider posting time for internal transfer PO
...
(cherry picked from commit cb763938dc )
2022-09-16 04:08:04 +00:00
Deepesh Garg
dda057d257
chore: Resolve conflicts
2022-09-13 13:40:36 +05:30
Deepesh Garg
c06e241fbc
fix: Rate for internal PI have non stock UOM items
...
(cherry picked from commit 0f655e4430 )
# Conflicts:
# erpnext/controllers/buying_controller.py
2022-09-12 03:40:43 +00:00
Sagar Vora
5a28ba8537
fix: set billing_address for purchases in get_party_details
...
(cherry picked from commit a3625b3817 )
2022-08-08 07:31:44 +00:00
Sagar Sharma
f9885746a8
Merge branch 'develop' into subcontracting
2022-07-07 09:56:23 +05:30
marination
aa043fe961
fix: Use fallback conversion factor while setting incoming rate for petty purchase
...
- PIs for petty items (that do not need an Item record) are allowed using Item Name field
- If a different UOM is used in this case, conversion factor stays 0 and causes an error
- Fallback to 1 in `set_incoming_rate` for buying
- Selling will need a proper item, so this change is not needed there
2022-07-05 19:43:02 +05:30
Sagar Sharma
fd162f9b14
fix: supplier warehouse in PR
2022-07-01 16:51:19 +05:30
s-aga-r
6d89b2fa28
refactor: backport old subcontracting code
2022-06-20 23:10:02 +05:30
Sagar Sharma
213113bc00
Merge branch 'develop' into subcontracting
2022-05-20 12:13:13 +05:30
Sagar Sharma
34bda14b5b
refactor!: Buying Controller
2022-05-20 10:45:33 +05:30
Sagar Sharma
409df263e8
refactor!: change "is_subcontracted" field type from "Select" to "Check"
2022-05-20 10:45:33 +05:30
Sagar Sharma
77db843692
refactor!: Make required changes to create SCO from PO
2022-05-20 10:45:30 +05:30
Ankush Menat
ee0a277540
fix: prevent bypassing forced valuation rate
...
if you edit "margin_rate_or_amount" after saving DN then based on
selected margin the rate gets updated which isn't valuation rate.
2022-05-12 19:01:26 +05:30
Nabin Hait
993c6c0de9
feat: Ignore permlevel for specific fields
2022-04-12 12:24:47 +05:30
Rohit Waghchaure
ac5df1abbe
test: test case to validate rejected qty without accepted warehouse
2022-04-04 17:57:57 +05:30
Rohit Waghchaure
0a71cabab1
fix: if accepted warehouse not selected during rejection then stock ledger not created
2022-04-04 15:42:59 +05:30
Sagar Sharma
01c64915c8
chore: remove unwanted validation
2022-04-01 15:51:48 +05:30
Sagar Sharma
d074c93ac7
refactor!: change "is_subcontracted" field type from "Select" to "Check"
2022-04-01 13:22:44 +05:30
Ankush Menat
494bd9ef78
style: format code with black
2022-03-28 18:52:46 +05:30
Ankush Menat
5718777a2b
fix: consider batch_no when getting incoming rate
2022-02-21 18:02:40 +05:30
Ankush Menat
342d09a671
feat: get_valuation_rate batch wise
...
This function is used to show valuation rate on frontend and also as
fallback in case values aren't available. Add "batch_no" param to get
batch specific valuation rates.
Co-Authored-By: Alan Tom <2.alan.tom@gmail.com >
2022-02-21 18:02:40 +05:30