mahsem
92b1f314ef
fix: Hold_to_On_Hold
2024-12-29 14:15:52 +01:00
Akhil Narang
af3743f09e
refactor: drop pytz
...
Follow up to https://github.com/frappe/frappe/pull/28093 so I can drop the pytz dependency
Signed-off-by: Akhil Narang <me@akhilnarang.dev >
2024-12-09 11:37:09 +05:30
David
895143a847
fix(testing): setup class must invoke super
2024-10-16 18:56:18 +02:00
David
a2d22c3f42
chore: remove redundant declarations of test_records
2024-10-11 05:00:20 +02:00
David
58c49dc9d2
refactor: Use IntegrationTestCase in multiple files
...
Signed-off-by: David <dgx.arnold@gmail.com >
2024-10-08 02:13:00 +02:00
David
96a6673510
feat(analytics): comply erpnext with utm methodology
2024-09-12 04:47:51 +02:00
Raffael Meyer
f6371f4a0d
Merge branch 'develop' into pseudo-translate-in-setup-wizard
2024-08-22 16:01:17 +02:00
barredterra
97c2853497
feat: enable "Translate Link Fields" for fixture doctypes
2024-08-17 02:02:20 +02:00
barredterra
af0ae930ca
fix: translatability of boldened text
2024-08-16 21:38:56 +02:00
rohitwaghchaure
4d41516abb
Merge pull request #40713 from rohitwaghchaure/fixed-12091
...
fix: enable list view for the issues on the portal
2024-03-28 11:07:07 +05:30
Rohit Waghchaure
bddc1e3974
fix: enable list view for the issues on the portal
2024-03-27 16:17:22 +05:30
Akhil Narang
3effaf21ef
refactor(treewide): formatting and ruff fixes, + manually enabled F401
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev >
2024-03-27 16:06:04 +05:30
Ankush Menat
dfde490c02
refactor!: switch to creation sort ( #40699 )
2024-03-27 13:45:34 +05:30
Ankush Menat
e055147849
fix: address_display, text -> text editor ( #40621 )
...
* fix: address_display, text -> text editor
* fix: text -> text editor for shipping and dispatch_address
2024-03-25 05:46:16 +00:00
Ankush Menat
ec74a5e566
style: format js files
2024-03-10 19:45:40 +05:30
barredterra
3f1d008741
fix(Issue): create communication
...
Ignore permisions and mandatory. Required, for example, when Issue is created by Customer via portal.
2024-02-16 19:58:58 +01:00
Ankush Menat
bb18ae82cf
refactor: use db.get_single_value
2024-01-09 21:57:50 +05:30
Ankush Menat
fa1c7b663c
fix: Reset SLA on issue doesn't work ( #38789 )
...
This was broken since last refactor where it was spun off to work with
all types of doctypes but client side code was never adapted.
2023-12-15 22:00:01 +05:30
barredterra
eb9ee3f79b
refactor: simplify conditional logic
...
Command: `sourcery review --fix --enable de-morgan .`
2023-12-05 11:22:55 +01:00
Ankush Menat
63313eef6f
feat: enable automatic type annotations ( #38452 )
2023-11-30 08:23:48 +00:00
s-aga-r
9fadf5f426
refactor: don't use cur_frm
2023-11-28 21:34:07 +05:30
s-aga-r
640dfab827
refactor: use frm.set_query to add filters
2023-11-28 17:45:17 +05:30
s-aga-r
01044ca8e9
refactor: use DocType Fetch From instead of frm.add_fetch
2023-11-28 17:33:27 +05:30
s-aga-r
1763824e5f
refactor: use arrow function
2023-11-28 17:20:05 +05:30
Bernd Oliver Sünderhauf
f276fbba4f
refactor: remove extraneous disabled filters
2023-10-28 02:10:28 +02:00
Ankush Menat
0d22fe02be
refactor!: Lower all perm to Desk User
2023-08-28 22:42:14 +05:30
Deepesh Garg
3f81e15672
Merge pull request #36147 from deepeshgarg007/eslint
...
refactor(ci): add eslint and update linting confs
2023-07-24 20:55:07 +05:30
Ankush Menat
bd9ef74ef7
perf: send SLA doctypes in boot
...
This request is fired on every load, data rarely if ever changes though.
2023-07-16 11:38:54 +05:30
Deepesh Garg
924cdef6d9
ci: add eslint and update linting confs
2023-07-14 18:53:02 +05:30
Ankush Menat
a3ea985348
refactor: Use db.set_single_value ( #35668 )
...
I just applied semgrep autofix. Untested completed, review before merging.
```yaml
- id: frappe-set-value-semantics
patterns:
- pattern-either:
- pattern: frappe.db.set_value($DOCTYPE, None, $...AFTER)
- pattern: frappe.db.set_value($DOCTYPE, $DOCTYPE, $...AFTER)
fix: frappe.db.set_single_value($DOCTYPE, $...AFTER)
message: |
If $DOCTYPE is a single doctype then using `frappe.db.set_value` is discouraged for setting values in DB. Use db.set_single_value for single doctype instead.
languages: [python]
severity: ERROR
```
2023-06-13 17:30:38 +05:30
David Arnold
c1b42b858d
fix: set Phone and Email option in doctypes ( #35549 )
2023-06-11 19:34:41 +05:30
Nabin Hait
243c49c550
refactor: Workspace cleanup
2023-05-30 13:17:59 +05:30
Ankush Menat
ac871797b2
fix: SLA permissions ( #34981 )
2023-04-21 18:05:29 +05:30
barredterra
502a37a864
refactor: use renamed timezone utils
...
https://github.com/frappe/frappe/pull/20253
2023-03-04 19:31:40 +01:00
Ankush Menat
915e0347b0
chore!: remove activity log feeds ( #33294 )
...
- This contains little to no information and practically no one uses this.
- Also causes a lot of problem by adding way too many feeds in activity
log to the point where activity page doesn't even load.
2022-12-12 15:14:30 +05:30
Ankush Menat
7e1742956c
refactor: Remove usage of deprecated methods ( #32914 )
...
Warn: Just used regex to replace all usage.
```regex
s/frappe.db.set(\(.*\),\(.*\),\(.*\))/\1.db_set(\2, \3)/g
```
Required after: https://github.com/frappe/frappe/pull/18815
2022-11-09 20:09:06 +05:30
ruthra kumar
ced8d2a537
test: lead creation and deletion restricted to dummy company
2022-10-17 16:26:07 +05:30
Shadrak Gurupnor
f2b7c9ee66
fix: validate for active sla ( #32132 )
2022-09-13 13:42:45 +05:30
Ankush Menat
755a060ba7
refactor: dont force issue list options ( #31613 )
...
Setting route option forces the filters, only default filters should be
set and not forced for each visit.
2022-07-18 11:12:07 +05:30
Conor
b8f728a40a
refactor: use CURRENT_DATE instead of CURDATE() ( #31356 )
...
* refactor: use CURRENT_DATE instead of CURDATE()
* style: reformat to black spec
* refactor: use QB for auto_close queries
Co-authored-by: Ankush Menat <ankush@frappe.io >
2022-06-15 12:07:33 +05:30
Ankush Menat
a896895a9e
fix: bulk fix (~330) missing translations
2022-04-04 13:59:51 +05:30
Ankush Menat
494bd9ef78
style: format code with black
2022-03-28 18:52:46 +05:30
Rushabh Mehta
fcf12c4054
fix(minor): allow SLA update without permission check
2022-01-18 18:07:11 +05:30
Ankush Menat
3db8d908dc
Merge pull request #29278 from shariquerik/update-workspace-json
...
fix: Updating public workspace json based on new design
2022-01-17 13:25:16 +05:30
Saqib Ansari
cc88b31f1f
test: remove sla if no active sla found
2022-01-14 18:17:40 +05:30
Saqib Ansari
b31679b6ef
fix: customer filter while fetching active sla
2022-01-14 16:31:48 +05:30
Saqib Ansari
0bfbfa3719
fix: reset sla if no active sla found
2022-01-14 16:13:17 +05:30
Saqib Ansari
a68fc546e7
refactor: do not allow submittable doctypes for SLA
2022-01-14 15:35:40 +05:30
Saqib Ansari
a9ab157198
fix: remove dashboard showing only issue count
2022-01-14 11:42:34 +05:30
Shariq Ansari
bc187c121a
fix: updated standard workspace json files
2022-01-13 19:24:11 +05:30