From fb2d4884b38132fc0071f5c8e92f90ecc791d3a6 Mon Sep 17 00:00:00 2001 From: RJPvT <48353029+RJPvT@users.noreply.github.com> Date: Thu, 14 Nov 2019 05:40:02 +0100 Subject: [PATCH] fix: allow pending within review date (#19577) * fix: allow pending within review date referenced - fix: allow Pending on review date #19497 explanation for closing not valid * fix: codacy --- erpnext/projects/doctype/task/task.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/erpnext/projects/doctype/task/task.py b/erpnext/projects/doctype/task/task.py index 8a469cd269b..97d15130eb0 100755 --- a/erpnext/projects/doctype/task/task.py +++ b/erpnext/projects/doctype/task/task.py @@ -7,7 +7,7 @@ import json import frappe from frappe import _, throw -from frappe.utils import add_days, cstr, date_diff, get_link_to_form, getdate +from frappe.utils import add_days, cstr, date_diff, get_link_to_form, getdate, today from frappe.utils.nestedset import NestedSet @@ -201,6 +201,9 @@ def set_multiple_status(names, status): def set_tasks_as_overdue(): tasks = frappe.get_all("Task", filters={'status':['not in',['Cancelled', 'Closed']]}) for task in tasks: + if frappe.db.get_value("Task", task.name, "status") in 'Pending Review': + if getdate(frappe.db.get_value("Task", task.name, "review_date")) < getdate(today()): + continue frappe.get_doc("Task", task.name).update_status() @frappe.whitelist()