From f8c659d8d517b8faefce71a0d5a0cc521f257019 Mon Sep 17 00:00:00 2001 From: Sugesh G <73237300+Sugesh393@users.noreply.github.com> Date: Wed, 12 Mar 2025 16:27:48 +0530 Subject: [PATCH] fix: pricing rule not ignored in Sales Order (#46248) * fix: pricing rule not ignored in Sales Order * test: update parameter do_not_submit to do_not_save --- erpnext/accounts/doctype/coupon_code/test_coupon_code.py | 2 +- erpnext/accounts/doctype/pricing_rule/pricing_rule.py | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/erpnext/accounts/doctype/coupon_code/test_coupon_code.py b/erpnext/accounts/doctype/coupon_code/test_coupon_code.py index 0eb4045567c..ce57a27a536 100644 --- a/erpnext/accounts/doctype/coupon_code/test_coupon_code.py +++ b/erpnext/accounts/doctype/coupon_code/test_coupon_code.py @@ -128,7 +128,7 @@ class TestCouponCode(IntegrationTestCase): item_code="_Test Tesla Car", rate=5000, qty=1, - do_not_submit=True, + do_not_save=True, ) self.assertEqual(so.items[0].rate, 5000) diff --git a/erpnext/accounts/doctype/pricing_rule/pricing_rule.py b/erpnext/accounts/doctype/pricing_rule/pricing_rule.py index 9f1e16661d5..a45f6276ff8 100644 --- a/erpnext/accounts/doctype/pricing_rule/pricing_rule.py +++ b/erpnext/accounts/doctype/pricing_rule/pricing_rule.py @@ -454,8 +454,7 @@ def get_pricing_rule_for_item(args, doc=None, for_validate=False): if pricing_rule.coupon_code_based == 1: if not args.coupon_code: - return item_details - + continue coupon_code = frappe.db.get_value( doctype="Coupon Code", filters={"pricing_rule": pricing_rule.name}, fieldname="name" )