schuetz3/schuetz3-erpnext
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: Gracefully handle duplicate bank account name to make setup faster

Browse Source
This commit is contained in:
Deepesh Garg
2021-05-02 12:23:11 +05:30
parent a66184fe3c
commit f6610c96dd
3 changed files with 6 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
erpnext/public/js/setup_wizard.js
View File

@@ -139,36 +139,10 @@ erpnext.setup.slides_settings = [
},
validate: function () {
let me = this;
let exist;
if (!this.validate_fy_dates()) {
return false;
}
// Validate bank name
if(me.values.bank_account){
frappe.call({
async: false,
method: "erpnext.accounts.doctype.account.chart_of_accounts.chart_of_accounts.validate_bank_account",
args: {
"coa": me.values.chart_of_accounts,
"bank_account": me.values.bank_account
},
callback: function (r) {
if(r.message){
exist = r.message;
me.get_field("bank_account").set_value("");
let message = __('Account {0} already exists. Please enter a different name for your bank account.',
[me.values.bank_account]
);
frappe.msgprint(message);
}
}
});
return !exist; // Return False if exist = true
}
return true;
},