schuetz3/schuetz3-erpnext
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: LCV updates wrong future qty/Bin qty

Browse Source 
- As -ve LCV SLE case is returned from `repost_current_voucher`, future qty is not updated
- This just doubly shifts all future qty which is then fixed by a repost
- Until the repost balance values are wrong
- Bin continues to show wrong projected qty even after repost, this is fixed by next SLE that recalculates Bin

(cherry picked from commit 7a5fd71a6c)
This commit is contained in:
marination
2022-07-04 17:46:54 +05:30
committed by Mergify
parent 31930a16fa
commit f0ecdbef5a
1 changed files with 18 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
erpnext/stock/stock_ledger.py
View File

@@ -94,9 +94,7 @@ def repost_current_voucher(args, allow_negative_stock=False, via_landed_cost_vou
if not args.get("posting_date"): if not args.get("posting_date"):
args["posting_date"] = nowdate() args["posting_date"] = nowdate()
if args.get("is_cancelled") and via_landed_cost_voucher: if not (args.get("is_cancelled") and via_landed_cost_voucher):
return
# Reposts only current voucher SL Entries # Reposts only current voucher SL Entries
# Updates valuation rate, stock value, stock queue for current transaction # Updates valuation rate, stock value, stock queue for current transaction
update_entries_after( update_entries_after(
@@ -115,6 +113,7 @@ def repost_current_voucher(args, allow_negative_stock=False, via_landed_cost_vou
) )
# update qty in future sle and Validate negative qty # update qty in future sle and Validate negative qty
# For LCV: update future balances with -ve LCV SLE, which will be balanced by +ve LCV SLE
update_qty_in_future_sle(args, allow_negative_stock) update_qty_in_future_sle(args, allow_negative_stock)