schuetz3/schuetz3-erpnext
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: precision check for salvage value

Browse Source
This commit is contained in:
Khushi Rawat
2024-12-10 12:54:02 +05:30
parent 5cd39941ee
commit ef5a5643dc
1 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
erpnext/assets/doctype/asset/asset.py
View File

@@ -410,6 +410,9 @@ class Asset(AccountsController):
) )
def validate_asset_finance_books(self, row): def validate_asset_finance_books(self, row):
row.expected_value_after_useful_life = flt(
row.expected_value_after_useful_life, self.precision("gross_purchase_amount")
)
if flt(row.expected_value_after_useful_life) >= flt(self.gross_purchase_amount): if flt(row.expected_value_after_useful_life) >= flt(self.gross_purchase_amount):
frappe.throw( frappe.throw(
_("Row {0}: Expected Value After Useful Life must be less than Gross Purchase Amount").format( _("Row {0}: Expected Value After Useful Life must be less than Gross Purchase Amount").format(
@@ -430,7 +433,10 @@ class Asset(AccountsController):
self.opening_accumulated_depreciation = 0 self.opening_accumulated_depreciation = 0
self.opening_number_of_booked_depreciations = 0 self.opening_number_of_booked_depreciations = 0
else: else:
depreciable_amount = flt(self.gross_purchase_amount) - flt(row.expected_value_after_useful_life) depreciable_amount = flt(
flt(self.gross_purchase_amount) - flt(row.expected_value_after_useful_life),
self.precision("gross_purchase_amount"),
)
if flt(self.opening_accumulated_depreciation) > depreciable_amount: if flt(self.opening_accumulated_depreciation) > depreciable_amount:
frappe.throw( frappe.throw(
_("Opening Accumulated Depreciation must be less than or equal to {0}").format( _("Opening Accumulated Depreciation must be less than or equal to {0}").format(