From 1b8bd0e1f3b496682ce3bb3c1716889a5b805ade Mon Sep 17 00:00:00 2001
From: ruthra kumar <ruthra@erpnext.com>
Date: Tue, 5 Nov 2024 10:25:32 +0530
Subject: [PATCH 1/2] refactor: avoid permission issue for non-admin

(cherry picked from commit c832d9fb9a7378a7a7186bf9bd9661e92dcfdf9b)
---
 erpnext/controllers/accounts_controller.py | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/erpnext/controllers/accounts_controller.py b/erpnext/controllers/accounts_controller.py
index 1ae6b5256a5..e47e9917149 100644
--- a/erpnext/controllers/accounts_controller.py
+++ b/erpnext/controllers/accounts_controller.py
@@ -2588,6 +2588,7 @@ class AccountsController(TransactionBase):
 				doc.amount = amount if self.docstatus == 1 else -1 * amount
 				doc.event = "Submit" if self.docstatus == 1 else "Cancel"
 				doc.currency = x.account_currency
+				doc.flags.ignore_permissions = 1
 				doc.save()
 
 	def make_advance_payment_ledger_for_payment(self):
@@ -2610,6 +2611,7 @@ class AccountsController(TransactionBase):
 			doc.amount = x.allocated_amount if self.docstatus == 1 else -1 * x.allocated_amount
 			doc.currency = currency
 			doc.event = "Submit" if self.docstatus == 1 else "Cancel"
+			doc.flags.ignore_permissions = 1
 			doc.save()
 
 	def make_advance_payment_ledger_entries(self):

From eaf6d0d7d88c930fdb7cf42ac938f93a80b6e7db Mon Sep 17 00:00:00 2001
From: ruthra kumar <ruthra@erpnext.com>
Date: Tue, 5 Nov 2024 10:31:45 +0530
Subject: [PATCH 2/2] refactor: update advance ledger role requirement

(cherry picked from commit e41560d30ba0fe72b53cf41cf5fd34bc3a8a541b)
---
 .../advance_payment_ledger_entry.json         | 28 +++++++++++++++----
 1 file changed, 22 insertions(+), 6 deletions(-)

diff --git a/erpnext/accounts/doctype/advance_payment_ledger_entry/advance_payment_ledger_entry.json b/erpnext/accounts/doctype/advance_payment_ledger_entry/advance_payment_ledger_entry.json
index 1d0a5b42a31..290ed11c98e 100644
--- a/erpnext/accounts/doctype/advance_payment_ledger_entry/advance_payment_ledger_entry.json
+++ b/erpnext/accounts/doctype/advance_payment_ledger_entry/advance_payment_ledger_entry.json
@@ -70,25 +70,41 @@
    "read_only": 1
   }
  ],
+ "in_create": 1,
  "index_web_pages_for_search": 1,
  "links": [],
- "modified": "2024-10-16 17:11:28.143979",
+ "modified": "2024-11-05 10:31:28.736671",
  "modified_by": "Administrator",
  "module": "Accounts",
  "name": "Advance Payment Ledger Entry",
  "owner": "Administrator",
  "permissions": [
   {
-   "create": 1,
-   "delete": 1,
    "email": 1,
    "export": 1,
    "print": 1,
    "read": 1,
    "report": 1,
-   "role": "System Manager",
-   "share": 1,
-   "write": 1
+   "role": "Accounts User",
+   "share": 1
+  },
+  {
+   "email": 1,
+   "export": 1,
+   "print": 1,
+   "read": 1,
+   "report": 1,
+   "role": "Accounts Manager",
+   "share": 1
+  },
+  {
+   "email": 1,
+   "export": 1,
+   "print": 1,
+   "read": 1,
+   "report": 1,
+   "role": "Auditor",
+   "share": 1
   }
  ],
  "sort_field": "creation",