From e43cfdf460e7cde01ca2bd0e1ac21e36c06cc018 Mon Sep 17 00:00:00 2001 From: Afshan Date: Wed, 27 Oct 2021 17:24:30 +0530 Subject: [PATCH] fix: linting issues --- .../doctype/sales_commission/sales_commission.py | 15 +++++++-------- .../sales_commission/sales_commission_list.js | 6 +++--- 2 files changed, 10 insertions(+), 11 deletions(-) diff --git a/erpnext/payroll/doctype/sales_commission/sales_commission.py b/erpnext/payroll/doctype/sales_commission/sales_commission.py index 9aa5d6d7dc2..dd1772f2e53 100644 --- a/erpnext/payroll/doctype/sales_commission/sales_commission.py +++ b/erpnext/payroll/doctype/sales_commission/sales_commission.py @@ -22,8 +22,7 @@ class SalesCommission(Document): frappe.throw(_("Total Commission Amount should be greater than 0")) def validate_salary_component(self): - if self.pay_via_salary and not frappe.db.get_single_value( - "Payroll Settings", "salary_component_for_sales_commission"): + if self.pay_via_salary and not frappe.db.get_single_value("Payroll Settings", "salary_component_for_sales_commission"): frappe.throw(_("Please set {0} in {1}").format(frappe.bold("Salary Component for Sales Commission"), get_link_to_form("Payroll Settings", "Payroll Settings"))) def on_submit(self): @@ -121,12 +120,12 @@ class SalesCommission(Document): def add_references(self, doc): reference = { - 'reference_doctype': 'Sales Commission', - 'reference_name': self.name, - 'due_date': self.to_date, - 'total_amount': self.total_commission_amount, - 'outstanding_amount': self.total_commission_amount, - 'allocated_amount': self.total_commission_amount, + 'reference_doctype': 'Sales Commission', + 'reference_name': self.name, + 'due_date': self.to_date, + 'total_amount': self.total_commission_amount, + 'outstanding_amount': self.total_commission_amount, + 'allocated_amount': self.total_commission_amount, } doc.append("references", reference) diff --git a/erpnext/payroll/doctype/sales_commission/sales_commission_list.js b/erpnext/payroll/doctype/sales_commission/sales_commission_list.js index 67f5eaf5a61..2fc7a730f3d 100644 --- a/erpnext/payroll/doctype/sales_commission/sales_commission_list.js +++ b/erpnext/payroll/doctype/sales_commission/sales_commission_list.js @@ -1,10 +1,10 @@ frappe.listview_settings['Sales Commission'] = { - add_fields: ["total_commission_amount", "status"], - get_indicator: function (doc) { + add_fields: ["total_commission_amount", "status"], + get_indicator: function (doc) { if (doc.status == "Paid") { return [__(doc.status), "green", "status,=," + doc.status]; } else { return [__(doc.status), "red", "status,=," + doc.status]; } } -} \ No newline at end of file +}; \ No newline at end of file