schuetz3/schuetz3-erpnext
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #28203 from frappe/mergify/bp/version-13-hotfix/pr-28202

Browse Source 
fix: Serial Nos not set in the row after scanning in popup (backport #28202)
This commit is contained in:
Marica
2021-11-02 20:25:59 +05:30
committed by GitHub
parent 4bdde5f706 4262682080
commit df6465d715
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
erpnext/selling/sales_common.js
View File

@@ -202,8 +202,10 @@ erpnext.selling.SellingController = erpnext.TransactionController.extend({
var me = this; var me = this;
var item = frappe.get_doc(cdt, cdn); var item = frappe.get_doc(cdt, cdn);
if (item.serial_no && item.qty === item.serial_no.split(`\n`).length) { // check if serial nos entered are as much as qty in row
return; if (item.serial_no) {
let serial_nos = item.serial_no.split(`\n`).filter(sn => sn.trim()); // filter out whitespaces
if (item.qty === serial_nos.length) return;
} }
if (item.serial_no && !item.batch_no) { if (item.serial_no && !item.batch_no) {