refactor: remove references in repost doctypes upon parent doc delet
(cherry picked from commit ed7f67b1a8)
This commit is contained in:
@@ -242,13 +242,38 @@ class AccountsController(TransactionBase):
|
||||
_doc.cancel()
|
||||
_doc.delete()
|
||||
|
||||
def on_trash(self):
|
||||
# delete references in 'Repost Payment Ledger'
|
||||
rpi = frappe.qb.DocType("Repost Payment Ledger Items")
|
||||
frappe.qb.from_(rpi).delete().where(
|
||||
(rpi.voucher_type == self.doctype) & (rpi.voucher_no == self.name)
|
||||
).run()
|
||||
def _remove_references_in_repost_doctypes(self):
|
||||
repost_doctypes = ["Repost Payment Ledger Items", "Repost Accounting Ledger Items"]
|
||||
|
||||
for _doctype in repost_doctypes:
|
||||
dt = frappe.qb.DocType(_doctype)
|
||||
rows = (
|
||||
frappe.qb.from_(dt)
|
||||
.select(dt.name, dt.parent, dt.parenttype)
|
||||
.where((dt.voucher_type == self.doctype) & (dt.voucher_no == self.name))
|
||||
.run(as_dict=True)
|
||||
)
|
||||
|
||||
if rows:
|
||||
references_map = frappe._dict()
|
||||
for x in rows:
|
||||
references_map.setdefault((x.parenttype, x.parent), []).append(x.name)
|
||||
|
||||
for doc, rows in references_map.items():
|
||||
repost_doc = frappe.get_doc(doc[0], doc[1])
|
||||
|
||||
for row in rows:
|
||||
if _doctype == "Repost Payment Ledger Items":
|
||||
repost_doc.remove(repost_doc.get("repost_vouchers", {"name": row})[0])
|
||||
else:
|
||||
repost_doc.remove(repost_doc.get("vouchers", {"name": row})[0])
|
||||
|
||||
repost_doc.flags.ignore_validate_update_after_submit = True
|
||||
repost_doc.flags.ignore_links = True
|
||||
repost_doc.save(ignore_permissions=True)
|
||||
|
||||
def on_trash(self):
|
||||
self._remove_references_in_repost_doctypes()
|
||||
self._remove_references_in_unreconcile()
|
||||
|
||||
# delete sl and gl entries on deletion of transaction
|
||||
|
||||
Reference in New Issue
Block a user