schuetz3/schuetz3-erpnext
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: validate hmac unconditionally (#28372) (#28374)

Browse Source 
(cherry picked from commit c0f06bc8e3)

Co-authored-by: Ankush Menat <ankush@frappe.io>
This commit is contained in:
mergify[bot]
2021-11-12 14:53:27 +05:30
committed by GitHub
parent 68ff68a357
commit d44cab3926
1 changed files with 0 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
erpnext/erpnext_integrations/utils.py
View File

@@ -25,7 +25,6 @@ def validate_webhooks_request(doctype, hmac_key, secret_key='secret'):
) )
if frappe.request.data and \ if frappe.request.data and \
frappe.get_request_header(hmac_key) and \
not sig == bytes(frappe.get_request_header(hmac_key).encode()): not sig == bytes(frappe.get_request_header(hmac_key).encode()):
frappe.throw(_("Unverified Webhook Data")) frappe.throw(_("Unverified Webhook Data"))
frappe.set_user(settings.modified_by) frappe.set_user(settings.modified_by)