schuetz3/schuetz3-erpnext
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(HR): Ignore invalid fields when updating employee details (#27456) (#27474)

Browse Source 
(cherry picked from commit 95460d9818)

Co-authored-by: Chillar Anand <chillar@avilpage.com>
This commit is contained in:
Frappe PR Bot
2021-09-14 12:48:31 +05:30
committed by GitHub
parent 8fd1aec76c
commit c9e7e72a29
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
erpnext/hr/utils.py
View File

@@ -148,7 +148,10 @@ def set_employee_name(doc):
def update_employee(employee, details, date=None, cancel=False): def update_employee(employee, details, date=None, cancel=False):
internal_work_history = {} internal_work_history = {}
for item in details: for item in details:
fieldtype = frappe.get_meta("Employee").get_field(item.fieldname).fieldtype field = frappe.get_meta("Employee").get_field(item.fieldname)
if not field:
continue
fieldtype = field.fieldtype
new_data = item.new if not cancel else item.current new_data = item.new if not cancel else item.current
if fieldtype == "Date" and new_data: if fieldtype == "Date" and new_data:
new_data = getdate(new_data) new_data = getdate(new_data)