HR - Leave Approver and Expense Approver fields changed to Link Fields, better default permissions

This commit is contained in:
Anand Doshi
2014-08-27 16:57:13 +05:30
parent f680626f53
commit bb370f3b6a
15 changed files with 285 additions and 306 deletions

View File

@@ -5,24 +5,6 @@ from __future__ import unicode_literals
import frappe
from frappe import _
@frappe.whitelist()
def get_leave_approver_list():
roles = [r[0] for r in frappe.db.sql("""select distinct parent from `tabUserRole`
where role='Leave Approver'""")]
if not roles:
frappe.msgprint(_("No Leave Approvers. Please assign 'Leave Approver' Role to atleast one user"))
return roles
@frappe.whitelist()
def get_expense_approver_list():
roles = [r[0] for r in frappe.db.sql("""select distinct parent from `tabUserRole`
where role='Expense Approver'""")]
if not roles:
frappe.msgprint(_("No Expense Approvers. Please assign 'Expense Approver' Role to atleast one user"))
return roles
def set_employee_name(doc):
if doc.employee and not doc.employee_name:
doc.employee_name = frappe.db.get_value("Employee", doc.employee, "employee_name")