HR - Leave Approver and Expense Approver fields changed to Link Fields, better default permissions
This commit is contained in:
@@ -5,24 +5,6 @@ from __future__ import unicode_literals
|
||||
import frappe
|
||||
from frappe import _
|
||||
|
||||
@frappe.whitelist()
|
||||
def get_leave_approver_list():
|
||||
roles = [r[0] for r in frappe.db.sql("""select distinct parent from `tabUserRole`
|
||||
where role='Leave Approver'""")]
|
||||
if not roles:
|
||||
frappe.msgprint(_("No Leave Approvers. Please assign 'Leave Approver' Role to atleast one user"))
|
||||
|
||||
return roles
|
||||
|
||||
|
||||
@frappe.whitelist()
|
||||
def get_expense_approver_list():
|
||||
roles = [r[0] for r in frappe.db.sql("""select distinct parent from `tabUserRole`
|
||||
where role='Expense Approver'""")]
|
||||
if not roles:
|
||||
frappe.msgprint(_("No Expense Approvers. Please assign 'Expense Approver' Role to atleast one user"))
|
||||
return roles
|
||||
|
||||
def set_employee_name(doc):
|
||||
if doc.employee and not doc.employee_name:
|
||||
doc.employee_name = frappe.db.get_value("Employee", doc.employee, "employee_name")
|
||||
|
||||
Reference in New Issue
Block a user