fix: don't update reference to SI / PI on advances

This commit is contained in:
ruthra kumar
2024-10-12 14:52:35 +05:30
parent 043bfdffbf
commit b409f74620
2 changed files with 23 additions and 4 deletions

View File

@@ -488,8 +488,12 @@ def reconcile_against_document(
# For payments with `Advance` in separate account feature enabled, only new ledger entries are posted for each reference.
# No need to cancel/delete payment ledger entries
repost_whole_ledger = any([x.voucher_detail_no for x in entries])
if voucher_type == "Payment Entry" and doc.book_advance_payments_in_separate_party_account:
doc.make_advance_gl_entries(cancel=1)
if repost_whole_ledger:
doc.make_gl_entries(cancel=1)
else:
doc.make_advance_gl_entries(cancel=1)
else:
_delete_pl_entries(voucher_type, voucher_no)
@@ -525,7 +529,10 @@ def reconcile_against_document(
if voucher_type == "Payment Entry" and doc.book_advance_payments_in_separate_party_account:
# both ledgers must be posted to for `Advance` in separate account feature
# TODO: find a more efficient way post only for the new linked vouchers
doc.make_advance_gl_entries()
if repost_whole_ledger:
doc.make_gl_entries()
else:
doc.make_advance_gl_entries()
else:
gl_map = doc.build_gl_map()
# Make sure there is no overallocation