schuetz3/schuetz3-erpnext
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: handle empty FBs properly in TB and GL [v14] (backport #35189) (backport #35192) (#35195)

Browse Source 
fix: handle empty FBs properly in TB and GL [v14] (backport #35189) (#35192)

fix: handle empty FBs properly in TB and GL [v14] (#35189)

fix: handle empty FBs properly in TB and GL
(cherry picked from commit ed5f39c2c2)

Co-authored-by: Anand Baburajan <anandbaburajan@gmail.com>
(cherry picked from commit e2af66c7be)

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
This commit is contained in:
mergify[bot]
2023-05-06 23:41:57 +05:30
committed by GitHub
parent ef2d4febdd
commit af8142cf85
3 changed files with 18 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
erpnext/accounts/report/financial_statements.py
View File

@@ -532,14 +532,18 @@ def get_additional_conditions(from_date, ignore_closing_entries, filters):
_("To use a different finance book, please uncheck 'Include Default Book Entries'") _("To use a different finance book, please uncheck 'Include Default Book Entries'")
) )
else: else:
additional_conditions.append("(finance_book in (%(finance_book)s) OR finance_book IS NULL)") additional_conditions.append(
"(finance_book in (%(finance_book)s, '') OR finance_book IS NULL)"
)
else: else:
additional_conditions.append("(finance_book in (%(company_fb)s) OR finance_book IS NULL)") additional_conditions.append("(finance_book in (%(company_fb)s, '') OR finance_book IS NULL)")
else: else:
if filters.get("finance_book"): if filters.get("finance_book"):
additional_conditions.append("(finance_book in (%(finance_book)s) OR finance_book IS NULL)") additional_conditions.append(
"(finance_book in (%(finance_book)s, '') OR finance_book IS NULL)"
)
else: else:
additional_conditions.append("(finance_book IS NULL)") additional_conditions.append("(finance_book in ('') OR finance_book IS NULL)")
if accounting_dimensions: if accounting_dimensions:
for dimension in accounting_dimensions: for dimension in accounting_dimensions:

8
erpnext/accounts/report/general_ledger/general_ledger.py
View File

@@ -296,14 +296,14 @@ def get_conditions(filters):
_("To use a different finance book, please uncheck 'Include Default Book Entries'") _("To use a different finance book, please uncheck 'Include Default Book Entries'")
) )
else: else:
conditions.append("(finance_book in (%(finance_book)s) OR finance_book IS NULL)") conditions.append("(finance_book in (%(finance_book)s, '') OR finance_book IS NULL)")
else: else:
conditions.append("(finance_book in (%(company_fb)s) OR finance_book IS NULL)") conditions.append("(finance_book in (%(company_fb)s, '') OR finance_book IS NULL)")
else: else:
if filters.get("finance_book"): if filters.get("finance_book"):
conditions.append("(finance_book in (%(finance_book)s) OR finance_book IS NULL)") conditions.append("(finance_book in (%(finance_book)s, '') OR finance_book IS NULL)")
else: else:
conditions.append("(finance_book IS NULL)") conditions.append("(finance_book in ('') OR finance_book IS NULL)")
if not filters.get("show_cancelled_entries"): if not filters.get("show_cancelled_entries"):
conditions.append("is_cancelled = 0") conditions.append("is_cancelled = 0")

10
erpnext/accounts/report/trial_balance/trial_balance.py
View File

@@ -166,14 +166,16 @@ def get_rootwise_opening_balances(filters, report_type):
_("To use a different finance book, please uncheck 'Include Default Book Entries'") _("To use a different finance book, please uncheck 'Include Default Book Entries'")
) )
else: else:
additional_conditions += " AND (finance_book in (%(finance_book)s) OR finance_book IS NULL)" additional_conditions += (
" AND (finance_book in (%(finance_book)s, '') OR finance_book IS NULL)"
)
else: else:
additional_conditions += " AND (finance_book in (%(company_fb)s) OR finance_book IS NULL)" additional_conditions += " AND (finance_book in (%(company_fb)s, '') OR finance_book IS NULL)"
else: else:
if filters.get("finance_book"): if filters.get("finance_book"):
additional_conditions += " AND (finance_book in (%(finance_book)s) OR finance_book IS NULL)" additional_conditions += " AND (finance_book in (%(finance_book)s, '') OR finance_book IS NULL)"
else: else:
additional_conditions += " AND (finance_book IS NULL)" additional_conditions += " AND (finance_book in ('') OR finance_book IS NULL)"
accounting_dimensions = get_accounting_dimensions(as_list=False) accounting_dimensions = get_accounting_dimensions(as_list=False)