schuetz3/schuetz3-erpnext
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

chore: fix logic for purchase invoice and some typos

Browse Source 
(cherry picked from commit 34b5e849a2)
This commit is contained in:
ruthra kumar
2023-06-16 14:07:44 +05:30
committed by Mergify
parent 72005bdb39
commit a9da619903
2 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
erpnext/controllers/accounts_controller.py
View File

@@ -966,7 +966,7 @@ class AccountsController(TransactionBase):
"""
Make Exchange Gain/Loss journal for Invoices and Payments
"""
# Cancelling is existing exchange gain/loss journals is handled in on_cancel event
# Cancelling existing exchange gain/loss journals is handled in on_cancel event in accounts/utils.py
if self.docstatus == 1:
if self.get("doctype") == "Payment Entry":
gain_loss_to_book = [x for x in self.references if x.exchange_gain_loss != 0]
@@ -1021,6 +1021,10 @@ class AccountsController(TransactionBase):
"Account", party_account, "account_currency"
)
dr_or_cr = "debit" if d.exchange_gain_loss > 0 else "credit"
if d.reference_doctype == "Purchase Invoice":
dr_or_cr = "debit" if dr_or_cr == "credit" else "credit"
reverse_dr_or_cr = "debit" if dr_or_cr == "credit" else "credit"
gain_loss_account = frappe.get_cached_value(
@@ -1074,7 +1078,6 @@ class AccountsController(TransactionBase):
journal_entry.save()
journal_entry.submit()
# frappe.throw("stopping...")
def make_precision_loss_gl_entry(self, gl_entries):
round_off_account, round_off_cost_center = get_round_off_account_and_cost_center(