fix(image): New Image component to consistently handle broken images

- psuedo element hack didn't work cross browser
This commit is contained in:
Faris Ansari
2018-09-07 23:17:29 +05:30
parent 399f3ddf82
commit 9fb5e1c61b
6 changed files with 64 additions and 14 deletions

View File

@@ -7,6 +7,7 @@ import SearchInput from './components/SearchInput.vue';
import DetailView from './components/DetailView.vue';
import DetailHeaderItem from './components/DetailHeaderItem.vue';
import EmptyState from './components/EmptyState.vue';
import Image from './components/Image.vue';
Vue.prototype.__ = window.__;
Vue.prototype.frappe = window.frappe;
@@ -17,6 +18,7 @@ Vue.component('search-input', SearchInput);
Vue.component('detail-view', DetailView);
Vue.component('detail-header-item', DetailHeaderItem);
Vue.component('empty-state', EmptyState);
Vue.component('base-image', Image);
Vue.directive('route', {
bind(el, binding) {
@@ -51,16 +53,6 @@ const handleImage = (el, src) => {
img.src = src;
}
Vue.directive('img-src', {
bind(el, binding) {
handleImage(el, binding.value);
},
update(el, binding) {
if (binding.value === binding.oldValue) return;
handleImage(el, binding.value);
}
});
Vue.filter('striphtml', function (text) {
return strip_html(text || '');
});