schuetz3/schuetz3-erpnext
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #35354 from frappe/mergify/bp/version-13-hotfix/pr-35335

Browse Source 
fix: tds incorrectly calculated for invoice that are below threshold (backport #35335)
This commit is contained in:
ruthra kumar
2023-05-18 14:36:28 +05:30
committed by GitHub
parent 6191cfee4c 06deecbd92
commit 9af4e117d4
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
erpnext/accounts/doctype/tax_withholding_category/tax_withholding_category.py
View File

@@ -274,7 +274,7 @@ def get_invoice_vouchers(parties, tax_details, company, party_type="Supplier"):
"docstatus": 1, "docstatus": 1,
} }
if not tax_details.get("consider_party_ledger_amount") and doctype != "Sales Invoice": if doctype != "Sales Invoice":
filters.update( filters.update(
{"apply_tds": 1, "tax_withholding_category": tax_details.get("tax_withholding_category")} {"apply_tds": 1, "tax_withholding_category": tax_details.get("tax_withholding_category")}
) )

6
erpnext/accounts/doctype/tax_withholding_category/test_tax_withholding_category.py
View File

@@ -110,9 +110,9 @@ class TestTaxWithholdingCategory(unittest.TestCase):
invoices.append(pi1) invoices.append(pi1)
# Cumulative threshold is 30000 # Cumulative threshold is 30000
# Threshold calculation should be on both the invoices # Threshold calculation should be only on the Second invoice
# TDS should be applied only on 1000 # Second didn't breach, no TDS should be applied
self.assertEqual(pi1.taxes[0].tax_amount, 1000) self.assertEqual(pi1.taxes, [])
for d in reversed(invoices): for d in reversed(invoices):
d.cancel() d.cancel()