refactor: update dimensions, only if provided

(cherry picked from commit ec0f17ca8b)
2024-01-22 11:59:20 +05:30
parent 51bc225fe5
commit 9a3bde9350
1 changed files with 4 additions and 2 deletions
--- a/erpnext/accounts/utils.py
+++ b/erpnext/accounts/utils.py
@@ -2054,6 +2054,7 @@ def create_gain_loss_journal(
 			dr_or_cr + "_in_account_currency": 0,
 		}
 	)
+	if dimensions:
 		journal_account.update(dimensions)
 	journal_entry.append("accounts", journal_account)

@@ -2070,6 +2071,7 @@ def create_gain_loss_journal(
 			reverse_dr_or_cr: abs(exc_gain_loss),
 		}
 	)
+	if dimensions:
 		journal_account.update(dimensions)
 	journal_entry.append("accounts", journal_account)