schuetz3/schuetz3-erpnext
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #43335 from frappe/mergify/bp/version-14-hotfix/pr-43316

Browse Source 
fix: incorrect outstanding on non-pos invoice with write_off_account (backport #43316)
This commit is contained in:
ruthra kumar
2024-09-23 18:22:39 +05:30
committed by GitHub
parent 5434d4bb1c 79235cd688
commit 8f81fdba4f
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
erpnext/accounts/doctype/sales_invoice/sales_invoice.py
View File

@@ -170,6 +170,7 @@ class SalesInvoice(SellingController):
): ):
validate_loyalty_points(self, self.loyalty_points) validate_loyalty_points(self, self.loyalty_points)
self.allow_write_off_only_on_pos()
self.reset_default_field_value("set_warehouse", "items", "warehouse") self.reset_default_field_value("set_warehouse", "items", "warehouse")
def validate_accounts(self): def validate_accounts(self):
@@ -850,6 +851,10 @@ class SalesInvoice(SellingController):
raise_exception=1, raise_exception=1,
) )
def allow_write_off_only_on_pos(self):
if not self.is_pos and self.write_off_account:
self.write_off_account = None
def validate_write_off_account(self): def validate_write_off_account(self):
if flt(self.write_off_amount) and not self.write_off_account: if flt(self.write_off_amount) and not self.write_off_account:
self.write_off_account = frappe.get_cached_value("Company", self.company, "write_off_account") self.write_off_account = frappe.get_cached_value("Company", self.company, "write_off_account")