schuetz3/schuetz3-erpnext
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: assign duplicate_items_msg outside conditional (#31639)

Browse Source 
duplicate_items_msg was defined inside if the statement  of stock_item so when duplicate was found in non_stock_item it raised referenced before assignment
This commit is contained in:
Maharshi Patel
2022-07-20 21:25:36 +05:30
committed by GitHub
parent 50fbfd9839
commit 8e23c6ad69
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
erpnext/controllers/selling_controller.py
View File

@@ -614,13 +614,13 @@ class SellingController(StockController):
stock_items = [d.item_code, d.description, d.warehouse, ""] stock_items = [d.item_code, d.description, d.warehouse, ""]
non_stock_items = [d.item_code, d.description] non_stock_items = [d.item_code, d.description]
if frappe.db.get_value("Item", d.item_code, "is_stock_item") == 1:
duplicate_items_msg = _("Item {0} entered multiple times.").format(frappe.bold(d.item_code)) duplicate_items_msg = _("Item {0} entered multiple times.").format(frappe.bold(d.item_code))
duplicate_items_msg += "<br><br>" duplicate_items_msg += "<br><br>"
duplicate_items_msg += _("Please enable {} in {} to allow same item in multiple rows").format( duplicate_items_msg += _("Please enable {} in {} to allow same item in multiple rows").format(
frappe.bold("Allow Item to Be Added Multiple Times in a Transaction"), frappe.bold("Allow Item to Be Added Multiple Times in a Transaction"),
get_link_to_form("Selling Settings", "Selling Settings"), get_link_to_form("Selling Settings", "Selling Settings"),
) )
if frappe.db.get_value("Item", d.item_code, "is_stock_item") == 1:
if stock_items in check_list: if stock_items in check_list:
frappe.throw(duplicate_items_msg) frappe.throw(duplicate_items_msg)
else: else: