schuetz3/schuetz3-erpnext
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

perf: Caching in checking allowance for qty and amount

Browse Source
This commit is contained in:
Nabin Hait
2024-03-13 13:00:10 +05:30
parent d279e23623
commit 8d682fa884
2 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
erpnext/controllers/accounts_controller.py
View File

@@ -1605,8 +1605,8 @@ class AccountsController(TransactionBase):
item_allowance = {} item_allowance = {}
global_qty_allowance, global_amount_allowance = None, None global_qty_allowance, global_amount_allowance = None, None
role_allowed_to_over_bill = frappe.db.get_single_value( role_allowed_to_over_bill = frappe.get_cached_value(
"Accounts Settings", "role_allowed_to_over_bill" "Accounts Settings", None, "role_allowed_to_over_bill"
) )
user_roles = frappe.get_roles() user_roles = frappe.get_roles()

7
erpnext/controllers/status_updater.py
View File

@@ -573,6 +573,7 @@ class StatusUpdater(Document):
ref_doc.set_status(update=True) ref_doc.set_status(update=True)
@frappe.request_cache
def get_allowance_for( def get_allowance_for(
item_code, item_code,
item_allowance=None, item_allowance=None,
@@ -602,20 +603,20 @@ def get_allowance_for(
global_amount_allowance, global_amount_allowance,
) )
qty_allowance, over_billing_allowance = frappe.db.get_value( qty_allowance, over_billing_allowance = frappe.get_cached_value(
"Item", item_code, ["over_delivery_receipt_allowance", "over_billing_allowance"] "Item", item_code, ["over_delivery_receipt_allowance", "over_billing_allowance"]
) )
if qty_or_amount == "qty" and not qty_allowance: if qty_or_amount == "qty" and not qty_allowance:
if global_qty_allowance == None: if global_qty_allowance == None:
global_qty_allowance = flt( global_qty_allowance = flt(
frappe.db.get_single_value("Stock Settings", "over_delivery_receipt_allowance") frappe.get_cached_value("Stock Settings", None, "over_delivery_receipt_allowance")
) )
qty_allowance = global_qty_allowance qty_allowance = global_qty_allowance
elif qty_or_amount == "amount" and not over_billing_allowance: elif qty_or_amount == "amount" and not over_billing_allowance:
if global_amount_allowance == None: if global_amount_allowance == None:
global_amount_allowance = flt( global_amount_allowance = flt(
frappe.db.get_single_value("Accounts Settings", "over_billing_allowance") frappe.get_cached_value("Accounts Settings", None, "over_billing_allowance")
) )
over_billing_allowance = global_amount_allowance over_billing_allowance = global_amount_allowance