schuetz3/schuetz3-erpnext
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #17180 from netchampfaris/duplicate-variant-check

Browse Source 
fix: Validate variant attributes only if is_new
This commit is contained in:
Nabin Hait
2019-04-15 10:09:12 +05:30
committed by GitHub
parent 30bca30f20 697f1186c0
commit 870410c9d5
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
erpnext/stock/doctype/item/item.py
View File

@@ -767,7 +767,7 @@ class Item(WebsiteGenerator):
attributes.append(d.attribute) attributes.append(d.attribute)
def validate_variant_attributes(self): def validate_variant_attributes(self):
if self.variant_of and self.variant_based_on == 'Item Attribute': if self.is_new() and self.variant_of and self.variant_based_on == 'Item Attribute':
args = {} args = {}
for d in self.attributes: for d in self.attributes:
if cstr(d.attribute_value).strip() == '': if cstr(d.attribute_value).strip() == '':