schuetz3/schuetz3-erpnext
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: (india) (e-invoice) CN / DN with 0 qty

Browse Source 
Qty 0 is allowed when creating Credit or Debit Note this caused ZeroDivisionError during unit_rate calculation.
fixed the issue by adding required conditionals.
This commit is contained in:
Maharshi Patel
2022-07-13 01:39:36 +05:30
parent 28e4e4320e
commit 84f260e1d8
1 changed files with 13 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
erpnext/regional/india/e_invoice/utils.py
View File

@@ -276,7 +276,19 @@ def get_item_list(invoice):
if invoice.get("apply_discount_on"): if invoice.get("apply_discount_on"):
item.discount_amount = item.base_amount - item.base_net_amount item.discount_amount = item.base_amount - item.base_net_amount
item.unit_rate = abs(item.taxable_value - item.discount_amount) / item.qty if invoice.get("is_return") or invoice.get("is_debit_note"):
item.unit_rate = abs(item.taxable_value - item.discount_amount) / (
1 if (item.qty == 0) else item.qty
)
else:
try:
item.unit_rate = abs(item.taxable_value - item.discount_amount) / item.qty
except ZeroDivisionError:
# This will never run but added as safety measure
frappe.throw(
title="Error: Qty is Zero",
msg="Quantity can't be zero unless it's Credit/Debit Note.",
)
item.gross_amount = abs(item.taxable_value) + item.discount_amount item.gross_amount = abs(item.taxable_value) + item.discount_amount
item.taxable_value = abs(item.taxable_value) item.taxable_value = abs(item.taxable_value)