fix: Document Name link validation in Bank Reconciliation Tool (#36495)
fix: format_row broke Document Name link validation
#35540 broke Voucher Matching, leading to an invalid link exception on submission. This is because the format_row() function overwrites the row data instead of just providing a formatter on the DataTable column, and therefore passes through the formatted (linked) column data instead of the Document Name only.
This patch moves the appropriate frappe.form.formatters.Link function to a dedicated format hook on the DataTable columns definition, both fixing the error and retaining the functionality of #35540.
(cherry picked from commit 7ab55b1bb2)
# Conflicts:
# erpnext/public/js/bank_reconciliation_tool/dialog_manager.js
This commit is contained in:
@@ -117,6 +117,9 @@ erpnext.accounts.bank_reconciliation.DialogManager = class DialogManager {
|
|||||||
name: __("Document Name"),
|
name: __("Document Name"),
|
||||||
editable: false,
|
editable: false,
|
||||||
width: 1,
|
width: 1,
|
||||||
|
format: (value, row) => {
|
||||||
|
return frappe.form.formatters.Link(value, {options: row[2].content});
|
||||||
|
},
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
name: __("Reference Date"),
|
name: __("Reference Date"),
|
||||||
@@ -141,6 +144,20 @@ erpnext.accounts.bank_reconciliation.DialogManager = class DialogManager {
|
|||||||
];
|
];
|
||||||
}
|
}
|
||||||
|
|
||||||
|
<<<<<<< HEAD
|
||||||
|
=======
|
||||||
|
format_row(row) {
|
||||||
|
return [
|
||||||
|
row[1], // Document Type
|
||||||
|
row[2], // Document Name
|
||||||
|
row[5] || row[8], // Reference Date
|
||||||
|
format_currency(row[3], row[9]), // Remaining
|
||||||
|
row[4], // Reference Number
|
||||||
|
row[6], // Party
|
||||||
|
];
|
||||||
|
}
|
||||||
|
|
||||||
|
>>>>>>> 7ab55b1bb2 (fix: Document Name link validation in Bank Reconciliation Tool (#36495))
|
||||||
get_datatable(proposals_wrapper) {
|
get_datatable(proposals_wrapper) {
|
||||||
if (!this.datatable) {
|
if (!this.datatable) {
|
||||||
const datatable_options = {
|
const datatable_options = {
|
||||||
|
|||||||
Reference in New Issue
Block a user