schuetz3/schuetz3-erpnext
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #43679 from frappe/mergify/bp/version-14-hotfix/pr-43602

Browse Source 
fix: added parentheses for correct query formation for logical OR condition (backport #43602)
This commit is contained in:
ruthra kumar
2024-10-15 17:07:17 +05:30
committed by GitHub
parent 8701cb73ef 0f738de5e5
commit 7c549e60d6
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
erpnext/accounts/doctype/period_closing_voucher/period_closing_voucher.py
View File

@@ -323,9 +323,10 @@ class PeriodClosingVoucher(AccountsController):
if get_opening_entries: if get_opening_entries:
query = query.where( query = query.where(
gl_entry.posting_date.between(self.get("year_start_date"), self.posting_date) ( # noqa: UP034
| gl_entry.is_opening (gl_entry.posting_date.between(self.get("year_start_date"), self.posting_date))
== "Yes" | (gl_entry.is_opening == "Yes")
)
) )
else: else:
query = query.where( query = query.where(